air18n 0.0.2 → 0.0.3

data/lib/air18n/version.rb

@@ -1,3 +1,3 @@
 module Air18n
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/air18n/xss_detector.rb

@@ -5,12 +5,12 @@ module Air18n
     def safe?(text_a, text_b)
       text_a = text_a.to_s
       text_b = text_b.to_s
-      tags_a = extract_tags(text_a)
-      tags_b = extract_tags(text_b)
+      tags_a = normalize_tags(extract_tags(text_a))
+      tags_b = normalize_tags(extract_tags(text_b))
       if has_dubious_escape_characters?(text_a) || has_dubious_escape_characters?(text_b)
         { :safe => false, :reason => 'Backslashes are not allowed' }
       elsif tags_a != tags_b
-        { :safe => false, :reason => "HTML tags don't match: #{tags_a.inspect} vs #{tags_b.inspect}" }
+        { :safe => false, :reason => "HTML tags don't match: #{tags_a.inspect} vs. #{tags_b.inspect}" }
       else
         { :safe => true }
       end
@@ -43,5 +43,13 @@ module Air18n
       end
       tags
     end
+
+    def normalize_tags(tags)
+      tags.map do |tag|
+        # Normalize double-quotes to single-quotes to allow differences in type
+        # of quotation mark.
+        tag.gsub('"', "'")
+      end
+    end
   end
 end

data/spec/lib/air18n/xss_detector_spec.rb

@@ -23,8 +23,12 @@ describe Air18n::XssDetector do
     end
 
     it "should detect tag mismatches" do
-      Air18n::XssDetector::safe?("<tag>", "safe").should == { :safe => false, :reason => "HTML tags don't match: #{['<tag>'].inspect} vs #{[].inspect}" }
-      Air18n::XssDetector::safe?("safe", "<tag>").should == { :safe => false, :reason => "HTML tags don't match: #{[].inspect} vs #{['<tag>'].inspect}" }
+      Air18n::XssDetector::safe?("<tag>", "safe").should == { :safe => false, :reason => "HTML tags don't match: #{['<tag>'].inspect} vs. #{[].inspect}" }
+      Air18n::XssDetector::safe?("safe", "<tag>").should == { :safe => false, :reason => "HTML tags don't match: #{[].inspect} vs. #{['<tag>'].inspect}" }
+    end
+
+    it "should allow quote mismatches in tags" do
+      Air18n::XssDetector::safe?("<tag href='hi'>", "<tag href=\"hi\">").should == { :safe => true }
     end
   end
 
@@ -39,9 +43,4 @@ describe Air18n::XssDetector do
       test('Success! You\'ve invited %{number} friends. <a href="/referrals">Invite <b>more</b>.</a>', ['<a href="/referrals">', '<b>', '</b>', '</a>'])
     end
   end
-
-  describe 'Robustness to various input formats' do
-    it 'should not barf on arrays' do
-    end
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: air18n
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-09 00:00:00.000000000 Z
+date: 2012-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n