agouti 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2d220334119fa85a7b2ddc377869b628032dc0e6
-  data.tar.gz: f8237d926836a2490b283c9074fc75233c64c6cd
+  metadata.gz: 01b7db6614008d1aff38366c1a91557afb6fd75e
+  data.tar.gz: 0ccc48a55e09512ccddad67e3d74800dbeb971a7
 SHA512:
-  metadata.gz: 2119a404d3ff535dd01354e9abde09a4eda59bf485574929a53d3985d287d9ea2a8c7f41230166207608505fcb0718450ca61ff7b9fe08e1b144a36d9060e506
-  data.tar.gz: 144a9805e7ad6eec204a70691d63e23f1ddece6ea4dbda038965e7a277ee113a5378768d3fcd33715e1fb2723a2a532fa926ce96f9dcc648402823d7dcb3f7e5
+  metadata.gz: 864cb988390b4f297e19c9ef0fe694c6d887323e7f582e33ac92e9a257408f2c8bc12690224823968e925271c82e359ce5429488e418bfc68cd4fcc000c79c5e
+  data.tar.gz: de652806d32533f7dfdc32e4416214d6eb4bea9aaa6ba5a965e328c653a1910210c2a1c1dc16dc311556432f2d1e9aa1161b89fc241e7a0caf8a604e47dffdf4

data/CHANGELOG.md

@@ -7,3 +7,7 @@
 ## 0.0.2
 
 * Refactoring, add tests and code documentation.
+
+## 0.0.3
+
+* Fix issues

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    agouti (0.0.2)
+    agouti (0.0.3)
       rack (~> 1.5)
 
 GEM

data/lib/agouti/rack/package_limiter.rb

@@ -48,7 +48,7 @@ module Agouti
         set_limit(env)
 
         if enabled?(env)
-          unless headers['Content-Type'] == 'text/html'
+          unless headers['Content-Type'] && headers['Content-Type'].include?('text/html')
             return [204, {}, []]
           end
 
@@ -71,27 +71,34 @@ module Agouti
       end
 
       def enabled? env
-        get_http_header(env, ENABLE_HEADER) && get_http_header(env, ENABLE_HEADER) == 1
+        get_http_header(env, ENABLE_HEADER).to_i == 1
       end
 
       def set_limit env
         @limit = (get_http_header(env, LIMIT_HEADER)) ? get_http_header(env, LIMIT_HEADER).to_i : DEFAULT_LIMIT
       end
 
-      def valid_enable_header? env
-        header = get_http_header(env, ENABLE_HEADER)
+      def valid? env
+        valid_enable_header?(env) && valid_limit_header?(env)
+      end
 
-        (0..1).include?(header) || header.nil?
+      def parseable?(header)
+        (header =~ /^[0-9]+$/) == 0
       end
 
-      def valid_limit_header? env
-        header = get_http_header(env, LIMIT_HEADER)
+      # Defines two methods: valid_enable_header? and valid_limit_header?
+      ['enable', 'limit'].each do |action|
+        define_method("valid_#{action}_header?") do |env|
+          header = get_http_header(env, self.class.const_get("#{action.upcase}_HEADER"))
 
-        (header.kind_of?(Integer) && header > 0) || header.nil?
-      end
+          return true if header.nil?
 
-      def valid? env
-        valid_enable_header?(env) && valid_limit_header?(env)
+          if parseable?(header)
+            header.to_i >= 0
+          else
+            false
+          end
+        end
       end
 
       # Public: class responsible for truncating the gzip stream to a given number of bytes.

data/lib/agouti/version.rb

@@ -1,3 +1,3 @@
 module Agouti
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/rack/package_limiter_spec.rb

@@ -11,8 +11,8 @@ describe Agouti::Rack::PackageLimiter do
     context 'when header X-Agouti-Enable is set' do
 
       context 'when header X-Agouti-Enable is set with 1' do
-        let(:headers) { { 'X-Agouti-Enable' => 1 } }
-        let(:env) { { 'HTTP_X_AGOUTI_ENABLE' => 1 } }
+        let(:headers) { { 'X-Agouti-Enable' => '1' } }
+        let(:env) { { 'HTTP_X_AGOUTI_ENABLE' => '1' } }
 
         context 'when the request response is not an html' do
           it 'returns status code 204' do
@@ -37,8 +37,8 @@ describe Agouti::Rack::PackageLimiter do
 
           context 'when header X-Agouti-Limit is set with a valid number of bytes' do
             it 'returns gzipped data with given number of bytes' do
-              headers.merge!('X-Agouti-Limit' => 10, 'Content-Type' => 'text/html')
-              env.merge!('HTTP_X_AGOUTI_LIMIT' => 10)
+              headers.merge!('X-Agouti-Limit' => '10', 'Content-Type' => 'text/html')
+              env.merge!('HTTP_X_AGOUTI_LIMIT' => '10')
 
               response_status, response_headers, response_body = subject
 
@@ -61,8 +61,8 @@ describe Agouti::Rack::PackageLimiter do
       end
 
       context 'when header X-Agouti-Enable is set with 0' do
-        let(:headers) { { 'X-Agouti-Enable' => 0 } }
-        let(:env) { { 'HTTP_X_AGOUTI_ENABLE' => 0 } }
+        let(:headers) { { 'X-Agouti-Enable' => '0' } }
+        let(:env) { { 'HTTP_X_AGOUTI_ENABLE' => '0' } }
 
         it 'does nothing' do
           expect(subject). to match_array([200, headers, []])

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: agouti
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - dwayhs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-02 00:00:00.000000000 Z
+date: 2014-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack