RubyGems - agoo - Versions diffs - 2.8.3 → 2.8.4 - Mend

agoo 2.8.3 → 2.8.4

Potentially problematic release.

This version of agoo might be problematic. Click here for more details.

Files changed (9) hide show

checksums.yaml CHANGED

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22bc32c1d37458aeb10fd5c92f9bbc6f29821eeb42ca53398eccf75da6b584cb
-  data.tar.gz: e2ee1b75f02b87221ea27074dfe6e2dc009fdd316757e5bbf420d7b5389ae1b5
+  metadata.gz: 4a08f7cfbaf708e9ae15b2c14c67b7ad06279ffefc55d3f8cdf02bf79d23ec2a
+  data.tar.gz: cdad36a0a5599a9114509b6eff0e219b2f128851f3d95bee344140cfa9f74ba0
 SHA512:
-  metadata.gz: 40a3f34e490c9f401e7abdb51c9a75f30c111e58b5cae79793887fa328586554c38c69a542e1258076d50ed53e7557090bbe688b0e5cea3cbaaea0576daf3b93
-  data.tar.gz: 254adaa0c7d04151be7d950421c911ec9f603f47db11cf875aa028e37754fc56e82c8ca0649de5f06f2d07ace3162adc9409a8345a8108d7e9627df0c6655331
+  metadata.gz: 923b3465e9b1c30e20bf627c2ef6b300574a9e475b9bef28d754845ccc5bf407fec7c48b68553189b55a26ee98a55671f9e2a571b7ba86ff2831c1fe16fb2cc5
+  data.tar.gz: 7b401ec9acc4373d18815266d312b3b30bbd2ab7d523b8be003f3a680ea57bbe4c791c6ab63bf77d2401ee01ac37a596aa785b06b26261547f38c0fe5bf4f248

data/CHANGELOG.md CHANGED

@@ -1,256 +1,293 @@
-# CHANGELOG
+# Changelog
-### 2.8.3 - 2019-04-04
+All changes to the Agoo gem are documented here. Releases follow semantic versioning.
+## [Unreleased]
+## [2.8.4] - 2019-06-14
+GraphQL with Rack
+### Fixed
+- Fixed an issue with using GraphQL with Rack. Added a Rack GraphQL example in
+  example/graphql/config.ru.
+## [2.8.3] - 2019-04-04
 Description parsing fix.
+### Fixed
 - Fixed a description parse bug that would fail to ignore whitespace after a description on some quoted descriptions.
-### 2.8.2 - 2019-03-08
+## [2.8.2] - 2019-03-08
 Rack compatibility improvement.
-- Add miss `close` method to `Agoo::ErrorStream`.
+### Added
 - Rack builder wrapper added.
-### 2.8.1 - 2019-03-01
+### Fixed
+- Add miss `close` method to `Agoo::ErrorStream`.
+## [2.8.1] - 2019-03-01
 Add missing options.
+### Added
 - Add missing options to `bin/agoo`.
 - Add missing options to `rack::Handler::Agoo`.
 - `bin/agoo` now picks up `config.ru` or `config.rb` if no other files are specified.
-### 2.8.0 - 2019-02-19
+## [2.8.0] - 2019-02-19
 Extend GraphQL
+### Added
 - Add support for the Graphql `extend` functionality.
 - Add the ID base scalar type.
+### Fixed
 - Use `schema` SDL element instead of `type schema`.
-### 2.7.0 - 2019-01-29
+## [2.7.0] - 2019-01-29
 Static asset header rules functionality added.
+### Added
 - `Agoo::Server.header_rule()` added.
+### Fixed
 - Assorted code cleanup.
-### 2.6.1 - 2019-01-20
+## [2.6.1] - 2019-01-20
 Ruby 2.6.0 compatibility release.
+### Added
 - Registering the GraphQL root object fixed for 2.6.0.
-### 2.6.0 - 2019-01-20
+## [2.6.0] - 2019-01-20
 GraphQL supported with a simple, easy to use API. Existing API remain the same but a new Agoo::GraphQL module has been added along with supporting examples.
+### Fixed
 - Replaced the use of `gmtime` with an included function to assure support for dates before 1970.
-### 2.5.7 - 2018-12-03
+## [2.5.7] - 2018-12-03
 Bad release fix along with upload example.
+### Fixed
 - Additional return value checking on `strdup`, `strndup`, and `fstat`.
 - Fix double free when a connection times out.
-### 2.5.6 - 2018-11-26
+## [2.5.6] - 2018-11-26
 Even more cleanup and minor performance tweak.
-- Changed the use of __ and _X in C code.
+### Added
+- Compile option to use epoll instead of poll. (its slower)
+### Fixed
+- Changed the use of __ and _X in C code.
 - Resuse of some memory for responses.
-- Compile option to use epoll instead of poll. (its slower)
-### 2.5.5 - 2018-11-12
+## [2.5.5] - 2018-11-12
 More optimizations and some cleanup.
+### Added
 - New optional hint to the server that allows responses to `#call` to be cached.
+### Fixed
 - Change C header file guards. No change in behavior. Just code cleanup.
 - Fixed change that slowed down the server.
-### 2.5.4 - 2018-11-10
+## [2.5.4] - 2018-11-10
 Third times a charm.
+### Fixed
 - Make sure response are sent when the request includes a close indicator.
-### 2.5.3 - 2018-11-10
+## [2.5.3] - 2018-11-10
 Bug fix.
+### Fixed
 - The latest changes introduced a bug where requests were lost. Fixed in this release.
-### 2.5.2 - 2018-11-09
+## [2.5.2] - 2018-11-09
 Latency improvements.
+### Changed
 - Allow empty pages to be returned.
 - Included multiple read/write threads.
-### 2.5.1 - 2018-08-30
+## [2.5.1] - 2018-08-30
 Bug fix.
+### Fixed
 - Sending a POST request that was not handled and caused a segfault. Fixed.
-### 2.5.0 - 2018-08-10
+## [2.5.0] - 2018-08-10
 The binding release with multiple options for connecting to the server.
+### Added
 - Multiple connection bindings now supported
 - Binding to Unix named sockets support added.
 - IPv6 now supported.
 - Connection address now supported to restrict connection requests.
-### 2.4.0 - 2018-07-04
+## [2.4.0] - 2018-07-04
+### Added
 - Rack hijack now supported.
 - Upgraded handler `on_error` now supported and called on Websocket or SSE errors.
-### 2.3.0 - 2018-06-29
+## [2.3.0] - 2018-06-29
+### Added
 - Added an `env` method to the upgrade (Websocket and SSE) client.
+### Fixed
 - Fixed Websocket bug where a pong caused a hang on the socket.
-### 2.2.2 - 2018-06-05
-- Fixed `bin/agoo` which had become out of date.
+## [2.2.2] - 2018-06-05
+### Added
 - Added optimization description in `misc/optimize.md`.
+### Fixed
+- Fixed `bin/agoo` which had become out of date.
 - Fixed static file asset page caching bug.
-### 2.2.1 - 2018-05-31
+## [2.2.1] - 2018-05-31
+### Fixed
 - Corrected header bug where a `:` in the value would cause an incorrect header key and value.
 - Improved idle CPU use.
-### 2.2.0 - 2018-05-30
+## [2.2.0] - 2018-05-30
+### Added
 - Clustering now supported with forked workers making Agoo even faster.
 - Changed addition header keys to be all uppercase and also replace `-` with `_` to match Rack unit tests instead of the spec.
-### 2.1.3 - 2018-05-16
+## [2.1.3] - 2018-05-16
+### Added
 - Optimized `rackup` to look for files in the root directory before calling rackup as the default. The root is now set to `./public` instead of `.`. The `:rmux` (rack multiplex) turns that off.
-### 2.1.2 - 2018-05-15
+## [2.1.2] - 2018-05-15
+### Added
 - Added `#open?` method to the Upgraded (connection client) class.
 - Slight improvement performcance serving static assets for Rails.
-### 2.1.1 - 2018-05-11
+## [2.1.1] - 2018-05-11
+### Added
 - Subject can now be Symbols or any other object that responds top `#to_s`.
-- Fixed bug where publishes from the `#on_open` callback broke the connection.
 - Super fast asset loading for Rails and Rack using `Agoo::Server.path_group`
-### 2.1.0 - 2018-05-10
+### Fixed
+- Fixed bug where publishes from the `#on_open` callback broke the connection.
-- This is a minor release even though the API has changed. The changed API is the one for Rack based WebSocket and SSE connection upgrades. The PR for the spec addition is currently stalled but some suggestions for a stateless API are implemented in this release. The proposed Rack SPEC is [here](misc/SPEC). The PR is [here](https://github.com/rack/rack/pull/1272)
+## [2.1.0] - 2018-05-10
+### Added
 - Publish and subscribe to WebSocket and SSE connections now available. An example in the push subdirectory demonstrates how it works.
 - Slight performance boost.
-### 2.0.5 - 2018-05-06
+### Changed
+- This is a minor release even though the API has changed. The changed API is the one for Rack based WebSocket and SSE connection upgrades. The PR for the spec addition is currently stalled but some suggestions for a stateless API are implemented in this release. The proposed Rack SPEC is [here](misc/SPEC). The PR is [here](https://github.com/rack/rack/pull/1272)
-- Changed to putting all the path on the `REQUEST_PATH` variable instead of the `SCRIPT_NAME` to accomodate Rails which only uses the `REQUEST_PATH`.
+## [2.0.5] - 2018-05-06
+### Changed
+- Changed to putting all the path on the `REQUEST_PATH` variable instead of the `SCRIPT_NAME` to accomodate Rails which only uses the `REQUEST_PATH`.
 - Duplicated all `HTTP_` variables to use an all upper case key in addition to the Rack spec simple concatenation to make Rails middleware work. There seems to be an undocumented agreement that all keys will be uppercase.
-### 2.0.4 - 2018-05-06
+## [2.0.4] - 2018-05-06
+### Fixed
 - Fix allocation bug.
-### 2.0.3 - 2018-05-05
+## [2.0.3] - 2018-05-05
+### Added
 - Allow X-XSS-Protection and only check headers in pendantic mode.
-### 2.0.2 - 2018-05-04
+## [2.0.2] - 2018-05-04
+### Fixed
 - Fixed compiler issues for different OSs and compilers.
 - More tolerant of `SERVER_NAME` capture from HTTP headers.
-### 2.0.1 - 2018-05-01
+## [2.0.1] - 2018-05-01
+### Fixed
 - Allow compilation on older macOS compilers.
-### 2.0.0 - 2018-04-30
+## [2.0.0] - 2018-04-30
+### Added
 - WebSocket and SSE support added.
 - The API moved to a global server approach to support extended
   handlers for WebSocket and SSE connections.
-### 1.2.2 - 2018-03-26
+## [1.2.2] - 2018-03-26
+### Added
 - rackup option -s now works with 'agoo' as well as with 'Agoo'.
+### Fixed
 - Fixed a memory leak.
-### 1.2.1 - 2018-03-16
+## [1.2.1] - 2018-03-16
+### Fixed
 - Improved Rack handling. Rack version is an array as it was
   supposed to be. Hacked around Rack's handling of HEAD requests so
   that the content length can be returned more easily by the app.
-### 1.2.0 - 2018-03-01
+## [1.2.0] - 2018-03-01
+### Added
 - Added Rack::Handler::Agoo for a rackup like use of Agoo.
 - Examples provided.
 - Default thread count set to zero.
-### 1.1.2 - 2018-02-25
+## [1.1.2] - 2018-02-25
+### Fixed
 - Fixed pipelining to handle extreme rates.
-### 1.1.1 - 2018-02-23
+## [1.1.1] - 2018-02-23
+### Added
 - An `agoo` binary was added to run an Agoo server from the command line.
-### 1.1.0 - 2018-02-11
+## [1.1.0] - 2018-02-11
+### Added
 - New mime types can now be added
 - Added support for rack.logger
-### 1.0.0 - 2018-02-06
+## [1.0.0] - 2018-02-06
+### Added
 - Add not found handler support.
 - Fixed segfault due to GC of handlers.
-### 0.9.1 - 2018-01-28
+## [0.9.1] - 2018-01-28
 Updated to get travis working correctly.
-### 0.9.0 - 2018-01-28
+## [0.9.0] - 2018-01-28
 Initial release.

data/ext/agoo/dtime.c CHANGED

@@ -7,15 +7,17 @@
 #include "dtime.h"
 #define MIN_SLEEP	(1.0 / (double)CLOCKS_PER_SEC)
+#ifndef CLOCK_REALTIME_COURSE
+#define CLOCK_REALTIME_COURSE	CLOCK_REALTIME
+#endif
 double
 dtime() {
-    struct timeval	tv;
-    struct timezone	tz;
+    struct timespec	ts;
-    gettimeofday(&tv, &tz);
+    clock_gettime(CLOCK_REALTIME_COURSE, &ts);
-    return (double)tv.tv_sec + (double)tv.tv_usec / 1000000.0;
+    return (double)ts.tv_sec + (double)ts.tv_nsec / 1000000000.0;
 }
 double
@@ -36,7 +38,7 @@ dsleep(double t) {
 double
 dwait(double t) {
     double	end = dtime() + t;
     if (MIN_SLEEP < t) {
 	struct timespec	req, rem;

data/ext/agoo/gqlintro.c CHANGED

@@ -369,8 +369,8 @@ gql_intro_init(agooErr err) {
 static struct _gqlCclass	type_class;
-static gqlValue
-extract_arg(agooErr err, gqlField field, gqlSel sel, const char *key) {
+gqlValue
+gql_extract_arg(agooErr err, gqlField field, gqlSel sel, const char *key) {
     if (NULL != sel->args) {
 	gqlSelArg	sa;
 	gqlValue	v = NULL;
@@ -892,7 +892,7 @@ type_fields(agooErr err, gqlDoc doc, gqlCobj obj, gqlField field, gqlSel sel, gq
     struct _gqlField	cf;
     struct _gqlCobj	child = { .clas = &field_class };
     int			d2 = depth + 1;
-    gqlValue		a = extract_arg(err, field, sel, "includeDeprecated");
+    gqlValue		a = gql_extract_arg(err, field, sel, "includeDeprecated");
     bool		inc_dep = false;
     if (GQL_OBJECT != type->kind && GQL_SCHEMA != type->kind && GQL_INTERFACE != type->kind) {
@@ -1086,7 +1086,7 @@ type_enum_values(agooErr err, gqlDoc doc, gqlCobj obj, gqlField field, gqlSel se
     struct _gqlField	cf;
     struct _gqlCobj	child = { .clas = &enum_value_class };
     int			d2 = depth + 1;
-    gqlValue		a = extract_arg(err, field, sel, "includeDeprecated");
+    gqlValue		a = gql_extract_arg(err, field, sel, "includeDeprecated");
     bool		inc_dep = false;
     if (GQL_ENUM != type->kind) {
@@ -1376,7 +1376,7 @@ root_schema(agooErr err, gqlDoc doc, gqlCobj obj, gqlField field, gqlSel sel, gq
 static int
 root_type(agooErr err, gqlDoc doc, gqlCobj obj, gqlField field, gqlSel sel, gqlValue result, int depth) {
-    gqlValue		na = extract_arg(err, field, sel, "name");
+    gqlValue		na = gql_extract_arg(err, field, sel, "name");
     const char		*name = NULL;
     const char		*key = sel->name;
     int			d2 = depth + 1;

data/ext/agoo/gqlintro.h CHANGED

@@ -11,8 +11,9 @@ struct _gqlSel;
 struct _gqlType;
 struct _gqlValue;
-extern int	gql_intro_init(agooErr err);
+extern int			gql_intro_init(agooErr err);
-extern int	gql_intro_eval(agooErr err, struct _gqlDoc *doc, struct _gqlSel *sel, struct _gqlValue *result, int depth);
+extern int			gql_intro_eval(agooErr err, struct _gqlDoc *doc, struct _gqlSel *sel, struct _gqlValue *result, int depth);
+extern struct _gqlValue*	gql_extract_arg(agooErr err, struct _gqlField *field, struct _gqlSel *sel, const char *key);
 #endif // AGOO_GQLINTRO_H

data/ext/agoo/queue.c CHANGED

@@ -24,7 +24,7 @@
 // head and tail both increment and wrap.
 // tail points to next open space.
 // When head == tail the queue is full. This happens when tail catches up with head.
-//
+//
 int
 agoo_queue_init(agooErr err, agooQueue q, size_t qsize) {
@@ -109,7 +109,7 @@ agoo_queue_pop(agooQueue q, double timeout) {
     agooQItem	item;
     agooQItem	*next;
     int cnt;
     if (q->multi_pop) {
 	while (atomic_flag_test_and_set(&q->pop_lock)) {
 	    dsleep(RETRY_SECS);
@@ -183,7 +183,7 @@ agoo_queue_listen(agooQueue q) {
 	}
     }
     atomic_store(&q->wait_state, WAITING);
     return q->rsock;
 }
@@ -200,7 +200,6 @@ agoo_queue_release(agooQueue q) {
 int
 agoo_queue_count(agooQueue q) {
     int	size = (int)(q->end - q->q);
     return ((agooQItem*)atomic_load(&q->tail) - (agooQItem*)atomic_load(&q->head) + size) % size;
 }

data/ext/agoo/rgraphql.c CHANGED

@@ -88,6 +88,9 @@ protect_eval(void *x) {
     return NULL;
 }
+// Hidden ruby function.
+extern int ruby_thread_has_gvl_p();
 static gqlValue
 eval_wrap(agooErr err, gqlDoc doc) {
     struct _eval	eval = {
@@ -95,9 +98,11 @@ eval_wrap(agooErr err, gqlDoc doc) {
 	.err = err,
 	.value = NULL,
     };
-    rb_thread_call_with_gvl(protect_eval, &eval);
+    if (ruby_thread_has_gvl_p()) {
+	protect_eval(&eval);
+    } else {
+	rb_thread_call_with_gvl(protect_eval, &eval);
+    }
     return eval.value;
 }

data/lib/agoo/version.rb CHANGED

@@ -1,5 +1,5 @@
 module Agoo
   # Agoo version.
-  VERSION = '2.8.3'
+  VERSION = '2.8.4'
 end

metadata CHANGED

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: agoo
 version: !ruby/object:Gem::Version
-  version: 2.8.3
+  version: 2.8.4
 platform: ruby
 authors:
 - Peter Ohler
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-04-04 00:00:00.000000000 Z
+date: 2019-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oj
@@ -177,10 +177,10 @@ signing_key:
 specification_version: 4
 summary: An HTTP server
 test_files:
+- test/base_handler_test.rb
+- test/bind_test.rb
 - test/graphql_test.rb
 - test/hijack_test.rb
-- test/rack_handler_test.rb
-- test/base_handler_test.rb
 - test/log_test.rb
-- test/bind_test.rb
+- test/rack_handler_test.rb
 - test/static_test.rb