agms 0.1.2 → 0.1.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZmFmZWIwODMwYjBjOTQ5MzFlOGI0ZmIwMzBiOGQ3YmZjN2M2YjYxNA==
+    ZjU0NzZkYTY1YzA1ZTgyNGViMTRmZTA2YmFlMWM0N2ZkYmRkZjg2YQ==
   data.tar.gz: !binary |-
-    ZTgxYzkyZWExZDU2Y2U1NDI0OTA1Njg0OTcyYTEyOWViMjNmOTk0OA==
+    NTFiODVhZWI3NmYyNDUxODljZmM0YWM2YjRkNmRmM2IyMTk1NWU3Nw==
 SHA512:
   metadata.gz: !binary |-
-    OGNmMWRlNTU1MmZmYjFhOTQ3YjIzM2M1M2RiNDYxN2I4MTFlZjI0NGMxMTdj
-    MWQ2NGNlYzUwNDc5OTZjNmUyMzA4ODYyYWE2Mjc3Zjg1NWFkM2FjYmZiOTI3
-    YmFkNzE5MDMwZGIzZWQ4MmRhYjc0NzIzNThkMmVhOTQyMDdjMGE=
+    OWNiMzZiNGI2OWY2MTIxOGFhMmI5MmU3NzA0OTA3ZWNlZTRjOGNjM2FiY2Rl
+    YjEyZDQ3YjA0ODc0YTgzMjNjYTJmMTk3ODRlZTJhYzY1ZTg3M2M0OTk0ZGVk
+    YzUxYTU2ZjcwNGJmZDAwZTU0Njk1N2YyN2ZmNTIzMmJkZjM3NzA=
   data.tar.gz: !binary |-
-    MjU2NWYxMmYwYjEyZDBhYzE1YjNlNWJhNmY1YjVmZDIzNjE4MzllNTExOTlj
-    M2RiZDE4MzgwNTU3MzZhZGU0YWQ0ZmMzMDY4MGY0YTc3YWExNTdiZDZlNWMw
-    MGViMmQxNGYyNTY0ZTk0ODFhZDczYTJjMjMxMzE1OGRhMTg0MGY=
+    MzdlNDA3MjI1YjdhZjAyN2MwN2ZmNDQwMjk4MzNjMGYxMzQ3YjVmZjQzMmYy
+    NjYzZDk4Zjg0NTQzZDUzZjQxYzc5OTQ5OWRjMzA5OGI1Yjk4Nzc0MDVmMDc5
+    YzIyMTVkMTQyZmRmN2RkZjVkYjE1M2JlYjQ1M2ZkOTliNzY1YzU=

data/README.md

@@ -32,7 +32,7 @@ Support for Invoicing and Recurring are not yet completed.
 ## Documentation
 
 * [Official documentation](https://www.onlinepaymentprocessing.com/docs/ruby)
-* [Bug Tracker](http://github.com/agms/agms_ruby/issues)
+* [Bug Tracker](http://github.com/agmscode/agms_ruby/issues)
 
 Examples can be found as part of this package in example /hpp.rb, example/invoicing.rb, example/recurring.rb, example_report.py, example/safe.rb, example/transaction.rb.
 
@@ -41,6 +41,9 @@ Examples can be found as part of this package in example /hpp.rb, example/invoic
 
 See the LICENSE file.
 
+## Development
+
+Test cases can be run with: `bundle exec rake test`
 
 ## Contributing
 

data/lib/agms/configuration.rb

@@ -52,10 +52,10 @@ module Agms
 
     def self.instantiate()
       return Configuration.new(
-        gateway_username = Configuration.gateway_username,
-        gateway_password = Configuration.gateway_password,
-        gateway_account = Configuration.gateway_account,
-        gateway_api_key = Configuration.gateway_api_key,
+        Configuration.gateway_username,
+        Configuration.gateway_password,
+        Configuration.gateway_account,
+        Configuration.gateway_api_key,
       )
     end
 

data/lib/agms/connect.rb

@@ -1,15 +1,17 @@
 module Agms
-	class Connect
-		
-		def self.is_exception_status(status)
-			if [200, 201, 422].include?(status)
+  class Connect
+
+    # @param integer status
+    # @return boolean
+    def self.is_exception_status(status)
+      if [200, 201, 422].include?(status)
         return true
       else
-      	return false
+        return false
       end
     end
 
-		def self.raise_exception_for_status(status, message=nil)
+    def self.raise_exception_for_status(status, message=nil)
       case status.to_i
         when 401
           raise AuthenticationError
@@ -33,36 +35,36 @@ module Agms
     end
 
     def connect(url, request, request_method, response_object)
-    	headers = _buildHeaders(request_method)
+      headers = _buildHeaders(request_method)
       request_body = _buildRequest(request, request_method)
       response_body = post(url, headers, request_body)
       return _parseResponse(response_body, request_method)
-		end
+    end
 
-		def post(url, headers = nil, body = nil)
+    def post(url, headers = nil, body = nil)
       return _http_do(Net::HTTP::Post, url, headers, body)
     end
 
-		def delete(url, headers = nil, body = nil)
-			return _http_do(Net::HTTP::Delete, url, headers, body)
+    def delete(url, headers = nil, body = nil)
+      return _http_do(Net::HTTP::Delete, url, headers, body)
     end
 
     def get(url, headers = nil, body = nil)
-    	return _http_do Net::HTTP::Get, url, headers, body
+      return _http_do Net::HTTP::Get, url, headers, body
     end
 
     def put(url, headers = nil, body = nil)
-    	return _http_do Net::HTTP::Put, url, headers, body
+      return _http_do Net::HTTP::Put, url, headers, body
     end
 
     def _http_do(http_verb, url, headers = nil, body = nil)
       connection = Net::HTTP.new(Configuration.server, Configuration.port)
       connection.open_timeout = 60
       connection.read_timeout = 60
-      
-     	connection.use_ssl = true
+
+      connection.use_ssl = true
       connection.verify_mode = OpenSSL::SSL::VERIFY_PEER
-      
+
       # connection.ca_file = @config.ca_file
       connection.verify_callback = proc { |preverify_ok, ssl_context| _verify_ssl_certificate(preverify_ok, ssl_context) }
 
@@ -72,12 +74,12 @@ module Agms
       end
 
       connection.start do |http|
-      	request = http_verb.new(url)
-        
-      	if headers
-      		headers.each do |key, value|
-      			request[key] = value
-      		end
+        request = http_verb.new(url)
+
+        if headers
+          headers.each do |key, value|
+            request[key] = value
+          end
         end
         if body
           request.body = body
@@ -85,40 +87,40 @@ module Agms
 
         response = http.request(request)
         if response.code.to_i == 200 || response.code.to_i == 201 || response.code.to_i == 422
-        	return response.body
-      	else
-	        Connect.raise_exception_for_status(response.code)
-	      end
+          return response.body
+        else
+          Connect.raise_exception_for_status(response.code)
+        end
       end
     rescue OpenSSL::SSL::SSLError
       raise SSLCertificateError
     end
 
-		# Build Header
-		def _buildHeaders(request_method)
-			return {
-	            'Accept' => 'application/xml',
-	            'Content-type' => 'text/xml; charset=utf-8',
-	            'User-Agent' => '(Agms Ruby ' + Agms.getLibraryVersion() + ')',
-	            'X-ApiVersion' => Agms.getAPIVersion(),
-	            'SOAPAction' => 'https://gateway.agms.com/roxapi/' + request_method
-	        }
-		end
-
-		# Build Request
-		def _buildRequest(request, request_method)
-			header = '<soap:Envelope 
+    # Build Header
+    def _buildHeaders(request_method)
+      return {
+          'Accept' => 'application/xml',
+          'Content-type' => 'text/xml; charset=utf-8',
+          'User-Agent' => '(Agms Ruby ' + Agms.getLibraryVersion() + ')',
+          'X-ApiVersion' => Agms.getAPIVersion(),
+          'SOAPAction' => 'https://gateway.agms.com/roxapi/' + request_method
+      }
+    end
+
+    # Build Request
+    def _buildRequest(request, request_method)
+      header = '<soap:Envelope
 				xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
 				xmlns:xsd="http://www.w3.org/2001/XMLSchema" 
 				xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
             	<soap:Body>'
-            
-        	header_line = '<' + request_method + ' xmlns="https://gateway.agms.com/roxapi/">'
-        	body = _hashToXml(request)
-          footer_line = '</' + request_method + '>'
-        	footer = '</soap:Body></soap:Envelope>'
-        	return header + header_line + body + footer_line + footer		
-		end
+
+      header_line = '<' + request_method + ' xmlns="https://gateway.agms.com/roxapi/">'
+      body = _hashToXml(request)
+      footer_line = '</' + request_method + '>'
+      footer = '</soap:Body></soap:Envelope>'
+      return header + header_line + body + footer_line + footer
+    end
 
     # Build xml from Hash
     def _hashToXml(request)
@@ -140,7 +142,7 @@ module Agms
       return data
     end
 
-		def _verify_ssl_certificate(preverify_ok, ssl_context)
+    def _verify_ssl_certificate(preverify_ok, ssl_context)
       if preverify_ok != true || ssl_context.error != 0
         err_msg = "SSL Verification failed -- Preverify: #{preverify_ok}, Error: #{ssl_context.error_string} (#{ssl_context.error})"
         @config.logger.error err_msg
@@ -150,8 +152,8 @@ module Agms
       end
     end
 
-		# Parse the response received from gateway
-		def _parseResponse(xml, request_method)
+    # Parse the response received from gateway
+    def _parseResponse(xml, request_method)
       # Parse the response body
       doc = Nokogiri::XML(xml)
       # Remove the namespaces
@@ -167,10 +169,8 @@ module Agms
           response = node.children.text
         end
       end
-
       return response
-	  end
+    end
 
-	    
-	end
+  end
 end

data/lib/agms/error/agms_error.rb

@@ -1,9 +1,10 @@
 module Agms
-    class AgmsError < StandardError
-        attr_accessor :object
-        def initialize(message = nil, object = nil)
-          super(message)
-          self.object = object
-        end
+  class AgmsError < StandardError
+    attr_accessor :object
+
+    def initialize(message = nil, object = nil)
+      super(message)
+      self.object = object
     end
+  end
 end

data/lib/agms/error/authentication_error.rb

@@ -1,7 +1,7 @@
 module Agms
-    class AuthenticationError < AgmsError
-      def initialize(message, object)
-        super(message, object)
-      end
+  class AuthenticationError < AgmsError
+    def initialize(message, object)
+      super(message, object)
     end
+  end
 end

data/lib/agms/error/authorization_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class AuthorizationError < AgmsError
+  class AuthorizationError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/client_error_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class ClientErrorError < AgmsError
+  class ClientErrorError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/configuation_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class ConfigurationError < AgmsError
+  class ConfigurationError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/down_for_maintenance_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class DownForMaintenanceError < AgmsError
+  class DownForMaintenanceError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/forged_query_String_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class ForgedQueryStringError < AgmsError
+  class ForgedQueryStringError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/invalid_parameter_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class InvalidParameterError < AgmsError
+  class InvalidParameterError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/invalid_request_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class InvalidRequestError < AgmsError
+  class InvalidRequestError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/invalid_signature_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class InvalidSignatureError < AgmsError
+  class InvalidSignatureError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/not_found_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class NotFoundError < AgmsError
+  class NotFoundError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/request_validation_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class RequestValidationError < AgmsError
+  class RequestValidationError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/response_error.rb

@@ -1,7 +1,7 @@
 module Agms
-	class ResponseError < AgmsError
-        def initialize(message, object)
-        	super(message, object)
-        end
+  class ResponseError < AgmsError
+    def initialize(message, object)
+      super(message, object)
     end
+  end
 end

data/lib/agms/error/server_error_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class ServerErrorError < AgmsError
+  class ServerErrorError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/ssl_certificate_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class SSLCertificateError < AgmsError
+  class SSLCertificateError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/unexpected_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class UnexpectedError < AgmsError
+  class UnexpectedError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/error/upgrade_required_error.rb

@@ -1,5 +1,5 @@
 module Agms
-	class UpgradeRequiredError < AgmsError
+  class UpgradeRequiredError < AgmsError
     def initialize(message, object)
       super(message, object)
     end

data/lib/agms/request/hpp_request.rb

@@ -106,10 +106,10 @@ module Agms
       @required = Array.new
 
       # All sales and auth require an amount unless donation
-      if ( ( @fields[:Donation][:value] != '' or
-            @fields[:Donation][:value] != false ) and
+      if ((@fields[:Donation][:value] != '' or
+          @fields[:Donation][:value] != false) and
           (@fields[:TransactionType][:value] == 'sale' or
-            @fields[:TransactionType][:value] == 'auth') )
+              @fields[:TransactionType][:value] == 'auth'))
         @required.push(:Amount)
       end
 
@@ -119,25 +119,25 @@ module Agms
       messages = error_array['messages'];
 
       # ExpDate MMYY
-      if (  @fields.has_key?(:CCExpDate) and
+      if (@fields.has_key?(:CCExpDate) and
           @fields[:CCExpDate][:value] != '' and
-          ( @fields[:CCExpDate][:value].length != 4 or
-              not /(0[1-9]|1[0-2])([0-9][0-9])/.match(@fields[:CCExpDate][:value]) )  )
+          (@fields[:CCExpDate][:value].length != 4 or
+              not /(0[1-9]|1[0-2])([0-9][0-9])/.match(@fields[:CCExpDate][:value])))
         errors += 1
         messages.push('CCExpDate (credit card expiration date) must be MMYY.')
       end
 
       # CCNumber length
-      if (  @fields.has_key?(:CCNumber) and
-          @fields[:CCNumber][:value] != ''  and
+      if (@fields.has_key?(:CCNumber) and
+          @fields[:CCNumber][:value] != '' and
           @fields[:CCNumber][:value].length != 16 and
-          @fields[:CCNumber][:value].length != 15 )
+          @fields[:CCNumber][:value].length != 15)
         errors += 1
         messages.push('CCNumber (credit card number) must be 15-16 digits long.')
       end
 
       # ABA length
-      if  ( @fields.has_key?(:CheckABA) and
+      if (@fields.has_key?(:CheckABA) and
           @fields[:CheckABA][:value] != '' and
           @fields[:CheckABA][:value].length != 9)
         errors += 1
@@ -156,7 +156,7 @@ module Agms
     end
 
     def getFields
-      fields =  getFieldArray
+      fields = getFieldArray
       if fields.has_key?(:AutoSAFE)
         if fields[:AutoSAFE] == true
           fields[:AutoSAFE] = 1

data/lib/agms/request/invoicing_request.rb

@@ -1,8 +1,8 @@
 module Agms
-	class InvoicingRequest < Request
+  class InvoicingRequest < Request
 
     def initialize(op)
       super(op)
     end
-	end
+  end
 end

data/lib/agms/request/request.rb

@@ -1,26 +1,26 @@
 module Agms
-	class Request
-		def initialize(op)
-			@op = op
-			@validateErrors = 0
-			@validateMessages = nil
-			@fields = nil
-			@required = nil
-			@numeric = nil
-			@optionable = nil
-			@enums = nil
-			@date = nil
-			@time = nil
-			@boolean = nil
-			@digit_2 = nil
-			@amount = nil
-
-			@needs_account = nil
-			@needs_key = nil
-
-			@mapping_alias = nil
-
-			@mapping = {
+  class Request
+    def initialize(op)
+      @op = op
+      @validateErrors = 0
+      @validateMessages = nil
+      @fields = nil
+      @required = nil
+      @numeric = nil
+      @optionable = nil
+      @enums = nil
+      @date = nil
+      @time = nil
+      @boolean = nil
+      @digit_2 = nil
+      @amount = nil
+
+      @needs_account = nil
+      @needs_key = nil
+
+      @mapping_alias = nil
+
+      @mapping = {
           :gateway_username => :GatewayUserName,
           :gateway_password => :GatewayPassword,
           :gateway_account => :AccountNumber,
@@ -128,17 +128,17 @@ module Agms
           :start_time => :StartTime,
           :end_time => :EndTime,
           :suppress_safe_option => :SupressAutoSAFE
-			}
+      }
 
-			@states = %w(AL AK AS AZ AR CA CO CT DE DC FM FL GA GU HI ID IL IN IA KS KY LA ME MH MD MA MI MN MS MO MT NE NV NH NJ NM NY NC ND MP OH OK OR PW PA PR RI SC SD TN TX UT VT VI VA WA WV WI WY AE AA AP)
-		end
+      @states = %w(AL AK AS AZ AR CA CO CT DE DC FM FL GA GU HI ID IL IN IA KS KY LA ME MH MD MA MI MN MS MO MT NE NV NH NJ NM NY NC ND MP OH OK OR PW PA PR RI SC SD TN TX UT VT VI VA WA WV WI WY AE AA AP)
+    end
 
-		def get(username, password, account, api_key)
-			request_body = getFields()
-			request_body[:GatewayUserName] = username
-			request_body[:GatewayPassword] = password
+    def get(username, password, account, api_key)
+      request_body = getFields()
+      request_body[:GatewayUserName] = username
+      request_body[:GatewayPassword] = password
 
-			# Adjust for a field name variation in the Reporting API
+      # Adjust for a field name variation in the Reporting API
       if @op == 'TransactionAPI' or @op == 'QuerySAFE'
         request_body.delete(:GatewayUserName)
         request_body[:GatewayUsername] = username
@@ -179,13 +179,13 @@ module Agms
       end
 
       # Check that it is a valid setting
-      if ( parameter == :setting and
+      if (parameter == :setting and
           value != '' and
           value != 'required' and
           value != 'disabled' and
           value != 'visible' and
           value != 'excluded' and
-          value != 'hidden' )
+          value != 'hidden')
         raise InvalidParameterError, "Invalid parameter #{parameter} for #{name}."
       end
 
@@ -220,7 +220,7 @@ module Agms
       messages = Array.new
 
       if @required
-        @required.each do | field_name |
+        @required.each do |field_name|
           if @fields[field_name][:value] == ''
             errors +=1
             messages.push("Missing required field #{field_name}.")
@@ -230,11 +230,11 @@ module Agms
 
       # Validate enumerated types
       if @enums
-        @enums.each do | field_name, valid_values |
+        @enums.each do |field_name, valid_values|
 
           if @fields.has_key?(field_name) and
               @fields[field_name][:value] != '' and
-              not valid_values.include?@fields[field_name][:value]
+              not valid_values.include? @fields[field_name][:value]
             errors += 1
             messages.push("Invalid #{field_name}, value " + @fields[field_name][:value] + ', must be one of ' + valid_values.join(' ') + '.')
           end
@@ -243,7 +243,7 @@ module Agms
 
       # Validate numeric fields
       if @numeric
-        @numeric.each do | field_name |
+        @numeric.each do |field_name|
           if @fields.has_key?(field_name) and
               @fields[field_name][:value] != '' and
               not isNumber(@fields[field_name][:value])
@@ -255,14 +255,14 @@ module Agms
 
       # Validate optionable fields
       if @optionable
-        @optionable.each do | field_name |
-          if ( @fields.has_key?(field_name) and
+        @optionable.each do |field_name|
+          if (@fields.has_key?(field_name) and
               @fields[field_name][:setting] != '' and
               @fields[field_name][:setting] != :required and
               @fields[field_name][:setting] != :disabled and
               @fields[field_name][:setting] != :visible and
               @fields[field_name][:setting] != :excluded and
-              @fields[field_name][:setting] != :hidden )
+              @fields[field_name][:setting] != :hidden)
             errors += 1
             messages.push("Field #{field_name} has setting " + @fields[field_name][:value] + ', must be required, disabled, visible, hidden, or empty.')
           end
@@ -271,7 +271,7 @@ module Agms
 
       # Validate date fields
       if @date
-        @date.each do | field_name |
+        @date.each do |field_name|
 
           if @fields.has_key?(field_name) and
               @fields[field_name][:value] != '' and
@@ -285,7 +285,7 @@ module Agms
 
       # Validate time fields
       if @time
-        @time.each do | field_name |
+        @time.each do |field_name|
           if not @fields[field_name][:value] != '' and
               not /([01][0-9]|2[0-3]):[0-5][0-9](:[0-5][0-9])/.match(@fields[field_name][:value])
             errors += 1
@@ -297,8 +297,8 @@ module Agms
 
       # Validate boolean fields
       if @boolean
-        @boolean.each do | field_name |
-          if ( @fields.has_key?(field_name) and
+        @boolean.each do |field_name|
+          if (@fields.has_key?(field_name) and
               not @fields[field_name][:value] != '' and
               not @fields[field_name][:value] != true and
               @fields[field_name][:value] != false and
@@ -313,10 +313,10 @@ module Agms
 
       # Validate state code fields
       if @digit_2
-        @digit_2.each do | field_name |
+        @digit_2.each do |field_name|
           if @fields.has_key?(field_name) and
               @fields[field_name][:value] != '' and
-              not @digit_2.has_key?@fields[field_name][:value]
+              not @digit_2.has_key? @fields[field_name][:value]
             errors += 1
             messages.push("Field #{field_name} has setting " + @fields[field_name][:value] + ', must be valid 2 digit US State code.')
           end
@@ -325,7 +325,7 @@ module Agms
 
       # Validate amount fields
       if @amount
-        @amount.each do | field_name |
+        @amount.each do |field_name|
           if @fields.key?(field_name) and
               @fields[field_name][:value] != '' and
               @fields[field_name][:value] > Configuration.max_amount
@@ -352,10 +352,10 @@ module Agms
       validate()
 
       if @validateErrors > 0
-        raise RequestValidationError , 'Request validation failed with ' + '  '.join(@validateMessages) + '.'
+        raise RequestValidationError, 'Request validation failed with ' + '  '.join(@validateMessages) + '.'
       end
 
-      @fields.each do | field_name, settings |
+      @fields.each do |field_name, settings|
         if settings[:setting] == :required
           request[field_name] = ''
           request[field_name + '_Visible'] = true

data/lib/agms/request/safe_request.rb

@@ -107,16 +107,16 @@ module Agms
       end
 
       # All sales and auths require an amount
-      if (   @fields[:TransactionType][:value] == 'sale'  or
-          @fields[:TransactionType][:value] == 'auth'    )
+      if (@fields[:TransactionType][:value] == 'sale' or
+          @fields[:TransactionType][:value] == 'auth')
         @required.push(:Amount)
       end
 
       # Captures, refunds, voids, updates, adjustments need a Transaction ID
-      if (   @fields[:TransactionType][:value] == 'capture' or
+      if (@fields[:TransactionType][:value] == 'capture' or
           @fields[:TransactionType][:value] == 'refund' or
           @fields[:TransactionType][:value] == 'void' or
-          @fields[:TransactionType][:value] == 'adjustment'  )
+          @fields[:TransactionType][:value] == 'adjustment')
         @required.push(:TransactionID)
       end
 
@@ -126,8 +126,8 @@ module Agms
       end
 
       # All safe updates and deletes require a safe id
-      if (   @fields[:SAFE_Action][:value] == 'update' or
-          @fields[:SAFE_Action][:value] == 'delete'  )
+      if (@fields[:SAFE_Action][:value] == 'update' or
+          @fields[:SAFE_Action][:value] == 'delete')
         @required.push(:SAFE_ID)
       end
 
@@ -139,17 +139,17 @@ module Agms
           @required.push(:CheckName)
           @required.push(:CheckABA)
           @required.push(:CheckAccount)
-          if (   @fields[:TransactionType][:value] == 'sale' or
-              @fields[:TransactionType][:value] == 'auth'    )
+          if (@fields[:TransactionType][:value] == 'sale' or
+              @fields[:TransactionType][:value] == 'auth')
             @required.push(:SecCode)
           end
         end
       else
         # Credit card transaction
         # If no SAFE ID and its a sale or auth
-        if (  @fields[:SAFE_ID][:value] == '' and
-            ( @fields[:TransactionType][:value] == 'sale' or
-                @fields[:TransactionType][:value] == 'auth' )  )
+        if (@fields[:SAFE_ID][:value] == '' and
+            (@fields[:TransactionType][:value] == 'sale' or
+                @fields[:TransactionType][:value] == 'auth'))
           # If no Safe ID we need the card info
           # If no MagData then we need keyed info
           if @fields[:MagData][:value] == ''
@@ -167,23 +167,23 @@ module Agms
       messages = error_array['messages'];
 
       # ExpDate MMYY
-      if (    @fields[:CCExpDate][:value] != '' and
-          ( @fields[:CCExpDate][:value].length != 4 or
-              not /(0[1-9]|1[0-2])([0-9][0-9])/.match(@fields[:CCExpDate][:value]) )  )
+      if (@fields[:CCExpDate][:value] != '' and
+          (@fields[:CCExpDate][:value].length != 4 or
+              not /(0[1-9]|1[0-2])([0-9][0-9])/.match(@fields[:CCExpDate][:value])))
         errors += 1
         messages.push('CCExpDate (credit card expiration date) must be MMYY.')
       end
 
       # CCNumber length
-      if ( @fields[:CCNumber][:value] != ''  and
+      if (@fields[:CCNumber][:value] != '' and
           @fields[:CCNumber][:value].length != 16 and
-          @fields[:CCNumber][:value].length != 15 )
+          @fields[:CCNumber][:value].length != 15)
         errors += 1
         messages.push('CCNumber (credit card number) must be 15-16 digits long.')
       end
 
       # ABA length
-      if  ( @fields[:CheckABA][:value] != '' and
+      if (@fields[:CheckABA][:value] != '' and
           @fields[:CheckABA][:value].length != 9)
         errors += 1
         messages.push('CheckABA (routing number) must be 9 digits long.')

data/lib/agms/request/transaction_request.rb

@@ -1,12 +1,12 @@
 module Agms
-	class TransactionRequest < Request
-		# A class representing AGMS Transaction Request objects.
+  class TransactionRequest < Request
+    # A class representing AGMS Transaction Request objects.
 
     alias AgmsAutoValidate autoValidate
 
     def initialize(op)
-			super(op)
-			@fields = {
+      super(op)
+      @fields = {
           :TransactionType => {:setting => '', :value => ''},
           :PaymentType => {:setting => '', :value => 'creditcard'},
           :Amount => {:setting => '', :value => ''}, # Required for sale or auth
@@ -79,14 +79,14 @@ module Agms
       @numeric = %w(Amount Tax Shipping ProcessorID TransactionID CheckABA CheckAccount CCNumber CCExpDate)
 
       @enums = {
-        :TransactionType => %w(sale auth safe\ only capture void refund update adjustment),
-        :SAFE_Action => %w(add_safe update_safe delete_safe),
-        :PaymentType => %w(creditcard check),
-        :SecCode => %w(PPD WEB TEL CCD),
-        :AccountHolderType => %w(business personal),
-        :AccountType => %w(checking savings),
-        :MagHardware => %w(MAGTEK IDTECH),
-        :Shipping_Carrier => %w(ups fedex dhl usps UPS Fedex DHL USPS),
+          :TransactionType => %w(sale auth safe\ only capture void refund update adjustment),
+          :SAFE_Action => %w(add_safe update_safe delete_safe),
+          :PaymentType => %w(creditcard check),
+          :SecCode => %w(PPD WEB TEL CCD),
+          :AccountHolderType => %w(business personal),
+          :AccountType => %w(checking savings),
+          :MagHardware => %w(MAGTEK IDTECH),
+          :Shipping_Carrier => %w(ups fedex dhl usps UPS Fedex DHL USPS),
       }
 
       @digit_2 = %w(State ShippingState)
@@ -97,74 +97,74 @@ module Agms
       @mapping[:shipping_tracking_number] = :Tracking_Number
       @mapping[:shipping_carrier] = :Shipping_Carrier
 
-		end
+    end
 
-		def validate
-			@required = Array.new
+    def validate
+      @required = Array.new
 
       # Unless this is a safe action only request, require a transaction type
       if @fields[:SAFE_Action][:value] == ''
-          @required.push(:TransactionType)
+        @required.push(:TransactionType)
       end
 
       # If no transaction type, require a Safe Action
       if @fields[:TransactionType][:value] == ''
-          @required.push(:SAFE_Action)
+        @required.push(:SAFE_Action)
       end
 
       # All sales and auths require an amount
-      if (   @fields[:TransactionType][:value] == 'sale'  or
-          @fields[:TransactionType][:value] == 'auth'    )
-          @required.push(:Amount)
+      if (@fields[:TransactionType][:value] == 'sale' or
+          @fields[:TransactionType][:value] == 'auth')
+        @required.push(:Amount)
       end
 
       # Captures, refunds, voids, updates, adjustments need a Transaction ID
-      if (   @fields[:TransactionType][:value] == 'capture' or
+      if (@fields[:TransactionType][:value] == 'capture' or
           @fields[:TransactionType][:value] == 'refund' or
           @fields[:TransactionType][:value] == 'void' or
-          @fields[:TransactionType][:value] == 'adjustment'  )
-          @required.push(:TransactionID)
+          @fields[:TransactionType][:value] == 'adjustment')
+        @required.push(:TransactionID)
       end
 
       # Require TipAmount for Tip Adjustment transactions
       if @fields[:TransactionType][:value] == 'adjustment'
-          @required.push(:TipAmount)
+        @required.push(:TipAmount)
       end
 
       # All safe updates and deletes require a safe id
-      if (   @fields[:SAFE_Action][:value] == 'update' or
-          @fields[:SAFE_Action][:value] == 'delete'  )
-          @required.push(:SAFE_ID)
+      if (@fields[:SAFE_Action][:value] == 'update' or
+          @fields[:SAFE_Action][:value] == 'delete')
+        @required.push(:SAFE_ID)
       end
 
 
       if @fields[:PaymentType][:value] == 'check'
-          # Cheque transaction
-          if @fields[:SAFE_ID][:value] == ''
-              # If no Safe ID we need all the check info
-              @required.push(:CheckName)
-              @required.push(:CheckABA)
-              @required.push(:CheckAccount)
-              if (   @fields[:TransactionType][:value] == 'sale' or
-                 @fields[:TransactionType][:value] == 'auth'    )
-                  @required.push(:SecCode)
-              end
+        # Cheque transaction
+        if @fields[:SAFE_ID][:value] == ''
+          # If no Safe ID we need all the check info
+          @required.push(:CheckName)
+          @required.push(:CheckABA)
+          @required.push(:CheckAccount)
+          if (@fields[:TransactionType][:value] == 'sale' or
+              @fields[:TransactionType][:value] == 'auth')
+            @required.push(:SecCode)
           end
+        end
       else
-          # Credit card transaction
-          # If no SAFE ID and its a sale or auth
-          if (  @fields[:SAFE_ID][:value] == '' and
-              ( @fields[:TransactionType][:value] == 'sale' or
-              @fields[:TransactionType][:value] == 'auth' )  )
-              # If no Safe ID we need the card info
-              # If no MagData then we need keyed info
-              if @fields[:MagData][:value] == ''
-                  @required.push(:CCNumber)
-                  @required.push(:CCExpDate)
-              else
-                  @required.push(:MagHardware)
-              end
+        # Credit card transaction
+        # If no SAFE ID and its a sale or auth
+        if (@fields[:SAFE_ID][:value] == '' and
+            (@fields[:TransactionType][:value] == 'sale' or
+                @fields[:TransactionType][:value] == 'auth'))
+          # If no Safe ID we need the card info
+          # If no MagData then we need keyed info
+          if @fields[:MagData][:value] == ''
+            @required.push(:CCNumber)
+            @required.push(:CCExpDate)
+          else
+            @required.push(:MagHardware)
           end
+        end
       end
 
       error_array = AgmsAutoValidate();
@@ -172,23 +172,23 @@ module Agms
       messages = error_array['messages'];
 
       # ExpDate MMYY
-      if (    @fields[:CCExpDate][:value] != '' and
-          ( @fields[:CCExpDate][:value].length != 4 or
-          not /(0[1-9]|1[0-2])([0-9][0-9])/.match(@fields[:CCExpDate][:value]) )  )
-          errors += 1
-          messages.push('CCExpDate (credit card expiration date) must be MMYY.')
+      if (@fields[:CCExpDate][:value] != '' and
+          (@fields[:CCExpDate][:value].length != 4 or
+              not /(0[1-9]|1[0-2])([0-9][0-9])/.match(@fields[:CCExpDate][:value])))
+        errors += 1
+        messages.push('CCExpDate (credit card expiration date) must be MMYY.')
       end
 
       # CCNumber length
-      if ( @fields[:CCNumber][:value] != ''  and
+      if (@fields[:CCNumber][:value] != '' and
           @fields[:CCNumber][:value].length != 16 and
-          @fields[:CCNumber][:value].length != 15 )
-          errors += 1
-          messages.push('CCNumber (credit card number) must be 15-16 digits long.')
+          @fields[:CCNumber][:value].length != 15)
+        errors += 1
+        messages.push('CCNumber (credit card number) must be 15-16 digits long.')
       end
 
       # ABA length
-      if  ( @fields[:CheckABA][:value] != '' and
+      if (@fields[:CheckABA][:value] != '' and
           @fields[:CheckABA][:value].length != 9)
         errors += 1
         messages.push('CheckABA (routing number) must be 9 digits long.')
@@ -203,15 +203,15 @@ module Agms
         print "Request validation failed with #{messages.join(' ')}"
         raise RequestValidationError, "Request validation failed with #{messages.join(' ')}."
       end
-        
-		end
 
-		def getFields
-        	return getFieldArray
-        end
+    end
 
-    	def getParams(request)
-        	return {:objparameters => request}
-        end
-	end
+    def getFields
+      return getFieldArray
+    end
+
+    def getParams(request)
+      return {:objparameters => request}
+    end
+  end
 end

data/lib/agms/transaction.rb

@@ -1,29 +1,29 @@
 module Agms
   class Transaction < Agms
-		# A class representing AGMS Transaction objects.
-		
-		alias AgmsResetParameters resetParameters
-		alias AgmsSetParameter setParameter
-		alias AgmsDoConnect doConnect
+    # A class representing AGMS Transaction objects.
 
-		def initialize
-			super()
+    alias AgmsResetParameters resetParameters
+    alias AgmsSetParameter setParameter
+    alias AgmsDoConnect doConnect
+
+    def initialize
+      super()
       @api_url = 'https://gateway.agms.com/roxapi/agms.asmx'
       @requestObject = 'TransactionRequest'
       @responseObject = 'TransactionResponse'
-		end
+    end
 
     def process(params)
       @op = 'ProcessTransaction'
       AgmsResetParameters()
       params.each do |param, config|
-				AgmsSetParameter(param, config)
-			end
-			self.execute()
-			return @response.toArray()
-		end
+        AgmsSetParameter(param, config)
+      end
+      self.execute()
+      return @response.toArray()
+    end
 
-		protected
+    protected
     def execute
       if @op == 'ProcessTransaction'
         AgmsDoConnect('ProcessTransaction', @responseObject)
@@ -32,5 +32,5 @@ module Agms
       end
     end
 
-	end
+  end
 end

data/lib/agms/version.rb

@@ -1,3 +1,3 @@
 module Agms
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: agms
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Maanas Royy