agentf 0.4.6 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a6b455ea4e8d08419665c731414589a39173932f0bdf70788b76cfbcc7c0380
-  data.tar.gz: 4552007bea3fbb27e4940f09542f76e557bdac18f06391dfcb7db6914adc9017
+  metadata.gz: 2cf35c1c3dd0c0b331de754c2805b3bbd27e9175a339ecb264509ab3ff5e843b
+  data.tar.gz: 1c552174bd8cfdfb0770f8a4c7ae19dd732c7c8e2d440f9197a5c210a0e55b1c
 SHA512:
-  metadata.gz: 37efe8cb9847156d5d0e93ee981c108fddab0940eab62fe60bb609e6fc68f799c14fd84f08214263ec4e98d05b617b5be7cd8d035d8a9352d7c639b4737947bb
-  data.tar.gz: c26f29b7059e1997f62b1a9b25c628c6ff25832309e8766ba2d076ebdf8333ca7ac3206145ae4e05f623c84aa6771c316970b5377e0b48de2980dff3e5c077df
+  metadata.gz: e60ee2faa826fe20c6845ab4250153838519456109893adcbba592e3a389a85520c00e3302a4bfb279e3b53b2c79c74afbe32a621a044837e904ca73dee37c54
+  data.tar.gz: d246b77664af5a645dc00afd17d0ea2799cf786d8c51f910212c7d24516e0f53a00bbeab81ec84b23a466d3a2185058bdbc89318aca932f20b7ef7c16be7e668

data/lib/agentf/agents/debugger.rb

@@ -45,8 +45,8 @@ module Agentf
 
       def self.policy_boundaries
         {
-          "always" => ["Return analysis with root causes and suggested fix", "Persist debugging lesson"],
-          "ask_first" => ["Applying speculative fixes without reproducible error"],
+          "always" => ["Return analysis with root causes and suggested fix"],
+          "ask_first" => ["Applying speculative fixes without reproducible error", "Persisting debugging lessons to memory"],
           "never" => ["Discard stack trace context when available"],
           "required_inputs" => ["error_text"],
           "required_outputs" => ["analysis", "success"]

data/lib/agentf/agents/designer.rb

@@ -46,7 +46,7 @@ module Agentf
       def self.policy_boundaries
         {
           "always" => ["Return generated component details", "Persist successful implementation pattern"],
-          "ask_first" => ["Changing primary UI framework"],
+          "ask_first" => ["Changing primary UI framework", "Persisting successful implementation patterns to memory"],
           "never" => ["Return empty generated code for successful design task"],
           "required_inputs" => ["design_spec"],
           "required_outputs" => ["component", "generated_code", "success"]

data/lib/agentf/agents/explorer.rb

@@ -45,8 +45,8 @@ module Agentf
 
       def self.policy_boundaries
         {
-          "always" => ["Return concrete file evidence", "Persist exploration breadcrumbs"],
-          "ask_first" => ["Scanning outside configured base path"],
+          "always" => ["Return concrete file evidence"],
+          "ask_first" => ["Scanning outside configured base path", "Persisting exploration breadcrumbs to memory"],
           "never" => ["Mutate project files during exploration"],
           "required_inputs" => [],
           "required_outputs" => ["files", "context_gathered"]

data/lib/agentf/agents/security.rb

@@ -45,8 +45,8 @@ module Agentf
 
       def self.policy_boundaries
         {
-          "always" => ["Return issue list and best practices", "Persist outcome as success or pitfall"],
-          "ask_first" => ["Allowing known secret patterns in context"],
+          "always" => ["Return issue list and best practices"],
+          "ask_first" => ["Allowing known secret patterns in context", "Persisting security scan findings to memory"],
           "never" => ["Echo raw secrets in output"],
           "required_inputs" => ["task"],
           "required_outputs" => ["issues", "best_practices"]

data/lib/agentf/agents/specialist.rb

@@ -45,7 +45,7 @@ module Agentf
       def self.policy_boundaries
         {
           "always" => ["Persist execution outcome", "Return deterministic success boolean"],
-          "ask_first" => ["Applying architecture style changes across unrelated modules"],
+          "ask_first" => ["Applying architecture style changes across unrelated modules", "Persisting execution outcomes to memory (success/pitfall)"] ,
           "never" => ["Claim implementation complete without execution result"],
           "required_inputs" => ["description"],
           "required_outputs" => ["subtask_id", "success"]

data/lib/agentf/agents/tester.rb

@@ -46,7 +46,7 @@ module Agentf
       def self.policy_boundaries
         {
           "always" => ["Produce framework-aware tests", "Verify red/green state when TDD enabled"],
-          "ask_first" => ["Changing test framework conventions"],
+          "ask_first" => ["Changing test framework conventions", "Persisting test-generation outcomes to memory"],
           "never" => ["Mark passing when command output is uncertain"],
           "required_inputs" => [],
           "required_outputs" => ["test_file"]

data/lib/agentf/memory.rb

@@ -45,7 +45,39 @@ module Agentf
       end
 
       def store_episode(type:, title:, description:, context: "", code_snippet: "", tags: [], agent: Agentf::AgentRoles::ENGINEER,
-                        related_task_id: nil, metadata: {}, entity_ids: [], relationships: [], parent_episode_id: nil, causal_from: nil)
+                        related_task_id: nil, metadata: {}, entity_ids: [], relationships: [], parent_episode_id: nil, causal_from: nil, confirm: nil)
+        # Determine persistence preference from the agent's policy boundaries.
+        # Precedence: never > always > ask_first > none.
+        auto_confirm = ENV['AGENTF_AUTO_CONFIRM_MEMORIES'] == 'true'
+        pref = persistence_preference_for(agent)
+
+        case pref
+        when :never
+          begin
+            puts "[MEMORY] Skipping persistence for #{agent}: policy forbids persisting memories"
+          rescue StandardError
+          end
+          return nil
+        when :always
+          # proceed without requiring explicit confirm
+        when :ask_first
+          unless agent == Agentf::AgentRoles::ORCHESTRATOR || confirm == true || auto_confirm
+            begin
+              puts "[MEMORY] Skipping persistence for #{agent}: confirmation required by policy"
+            rescue StandardError
+            end
+            return nil
+          end
+        else
+          # default conservative behavior: require explicit confirm (or env opt-in)
+          unless agent == Agentf::AgentRoles::ORCHESTRATOR || confirm == true || auto_confirm
+            begin
+              puts "[MEMORY] Skipping persistence for #{agent}: confirmation required"
+            rescue StandardError
+            end
+            return nil
+          end
+        end
         episode_id = "episode_#{SecureRandom.hex(4)}"
         normalized_metadata = enrich_metadata(
           metadata: metadata,
@@ -107,52 +139,56 @@ module Agentf
         episode_id
       end
 
-      def store_success(title:, description:, context: "", code_snippet: "", tags: [], agent: Agentf::AgentRoles::ENGINEER)
-        store_episode(
+      def store_success(title:, description:, context: "", code_snippet: "", tags: [], agent: Agentf::AgentRoles::ENGINEER, confirm: nil)
+         store_episode(
           type: "success",
           title: title,
           description: description,
           context: context,
           code_snippet: code_snippet,
           tags: tags,
-          agent: agent
+           agent: agent,
+           confirm: confirm
         )
       end
 
-      def store_pitfall(title:, description:, context: "", code_snippet: "", tags: [], agent: Agentf::AgentRoles::ENGINEER)
-        store_episode(
+      def store_pitfall(title:, description:, context: "", code_snippet: "", tags: [], agent: Agentf::AgentRoles::ENGINEER, confirm: nil)
+         store_episode(
           type: "pitfall",
           title: title,
           description: description,
           context: context,
           code_snippet: code_snippet,
           tags: tags,
-          agent: agent
+           agent: agent,
+           confirm: confirm
         )
       end
 
-      def store_lesson(title:, description:, context: "", code_snippet: "", tags: [], agent: Agentf::AgentRoles::ENGINEER)
-        store_episode(
+      def store_lesson(title:, description:, context: "", code_snippet: "", tags: [], agent: Agentf::AgentRoles::ENGINEER, confirm: nil)
+         store_episode(
           type: "lesson",
           title: title,
           description: description,
           context: context,
           code_snippet: code_snippet,
           tags: tags,
-          agent: agent
+           agent: agent,
+           confirm: confirm
         )
       end
 
-      def store_business_intent(title:, description:, constraints: [], tags: [], agent: Agentf::AgentRoles::ORCHESTRATOR, priority: 1)
+      def store_business_intent(title:, description:, constraints: [], tags: [], agent: Agentf::AgentRoles::ORCHESTRATOR, priority: 1, confirm: nil)
         context = constraints.any? ? "Constraints: #{constraints.join('; ')}" : ""
 
-        store_episode(
+         store_episode(
           type: "business_intent",
           title: title,
           description: description,
           context: context,
           tags: tags,
-          agent: agent,
+           agent: agent,
+           confirm: confirm,
           metadata: {
             "intent_kind" => "business",
             "constraints" => constraints,
@@ -162,18 +198,19 @@ module Agentf
       end
 
       def store_feature_intent(title:, description:, acceptance_criteria: [], non_goals: [], tags: [], agent: Agentf::AgentRoles::PLANNER,
-                               related_task_id: nil)
+                                related_task_id: nil, confirm: nil)
         context_parts = []
         context_parts << "Acceptance: #{acceptance_criteria.join('; ')}" if acceptance_criteria.any?
         context_parts << "Non-goals: #{non_goals.join('; ')}" if non_goals.any?
 
-        store_episode(
+         store_episode(
           type: "feature_intent",
           title: title,
           description: description,
           context: context_parts.join(" | "),
           tags: tags,
           agent: agent,
+           confirm: confirm,
           related_task_id: related_task_id,
           metadata: {
             "intent_kind" => "feature",
@@ -858,6 +895,54 @@ module Agentf
         base
       end
 
+      # Determine whether writes from the given agent should require explicit
+      # confirmation. We consider agents that declare "ask_first" policy
+      # boundaries to be conservative and require confirmation before persisting
+      # memories. Agent classes register policy boundaries on their class
+      # definitions (see agents/*). When agent is provided as a role string
+      # (eg. "ENGINEER") we try to match against known agent classes.
+      def agent_requires_confirmation?(agent)
+        begin
+          # If a developer passed an agent class-like string, try to map it to
+          # the loaded agent class and inspect its policy_boundaries.
+          candidate = Agentf::Agents.constants
+                      .map { |c| Agentf::Agents.const_get(c) }
+                      .find do |klass|
+                        klass.is_a?(Class) && klass.respond_to?(:policy_boundaries) && klass.typed_name == agent
+                      end
+
+          return false unless candidate
+
+          boundaries = candidate.policy_boundaries
+          ask_first = Array(boundaries["ask_first"]) rescue []
+          !ask_first.empty?
+        rescue StandardError
+          false
+        end
+      end
+
+      # Inspect loaded agent classes for explicit persistence preference.
+      # Returns one of: :always, :ask_first, :never, or nil when unknown.
+      def persistence_preference_for(agent)
+        begin
+          candidate = Agentf::Agents.constants
+                      .map { |c| Agentf::Agents.const_get(c) }
+                      .find do |klass|
+                        klass.is_a?(Class) && klass.respond_to?(:policy_boundaries) && klass.typed_name == agent
+                      end
+
+          return nil unless candidate
+
+          boundaries = candidate.policy_boundaries
+          return :never if Array(boundaries["never"]).any?
+          return :always if Array(boundaries["always"]).any? && Array(boundaries["ask_first"]).empty?
+          return :ask_first if Array(boundaries["ask_first"]).any?
+          nil
+        rescue StandardError
+          nil
+        end
+      end
+
       def infer_division(agent)
         case agent
         when Agentf::AgentRoles::PLANNER, Agentf::AgentRoles::ORCHESTRATOR, Agentf::AgentRoles::KNOWLEDGE_MANAGER

data/lib/agentf/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Agentf
-  VERSION = "0.4.6"
+  VERSION = "0.4.7"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: agentf
 version: !ruby/object:Gem::Version
-  version: 0.4.6
+  version: 0.4.7
 platform: ruby
 authors:
 - Neal Deters
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-03-10 00:00:00.000000000 Z
+date: 2026-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis