age_calculator 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7308d45111a9fa22ef7e2b79c19aadd8e9d94832
-  data.tar.gz: 17e90eff2afa3da30ee7216f1ea552229460ccb7
+  metadata.gz: bada8221cdeadfc09ed63a8f275efcc302b3084e
+  data.tar.gz: 9c3fb7c34164a261153b64723a2ce4e713842bd2
 SHA512:
-  metadata.gz: 30881c149b2ded17a805de66e48a684a039aa9c5114340643f2a80b4c70ad3434eb33ade2254776e4ece14702fe76ad6e42309fa8dabd686d8cc0f38afccc285
-  data.tar.gz: d5f82b72296c4f199a30fea1d8776e0e8e8e833893c36a59dedad1f15f49b7fecd3ff213539f089d5218ae783e9cff753916413bf9d91161624663eed4ca22c8
+  metadata.gz: a2ffd2f24b305147d379716ab71e216f8ba0d0910b9054ca83d95759499f51518f456d437a2e65d5959fd1808bedf71b9789f52be03f8ca3a65c553eedd4f8eb
+  data.tar.gz: a3ad1f02314fdc79975b2a059c171e818e4b29a1cda9ff5380e27661cc75371d322e12fc59a7b39201c00bc0ba68948ffff3a843b30a196495b91735de8074f7

data/README.md

@@ -4,7 +4,7 @@ A simple age calculator for Ruby. Comes with age validator for ActiveModel.
 
 # Background
 
-You might think calculating age from a birthday is easy, but you'd be wrong - there is [so much confusion](http://stackoverflow.com/questions/10463400/age-calculation-in-ruby) on the topic, and sadly, many people are doing it wrong. Even right ways can look really complicated.
+You might think calculating age from a birthday is easy, but you'd be wrong - there is [so](https://www.ruby-forum.com/topic/49265) [much](http://stackoverflow.com/questions/10463400/age-calculation-in-ruby) [confusion](http://stackoverflow.com/questions/819263/get-persons-age-in-ruby) on the topic, and sadly, many people are doing it wrong. Even right ways can look really complicated.
 
 Here's the simplest, cleanest way:
 
@@ -46,7 +46,10 @@ $ gem install age_calculator
 For a basic usage:
 
 ```ruby
+birthday = Date.new(1987,12,31)
+
 AgeCalculator.new(birthday).age
+ => 26
 ```
 
 For a model with a validation on the age:
@@ -55,9 +58,6 @@ For a model with a validation on the age:
 class Adult < ActiveRecord::Base
   validates :birthday, age: { over: 18 }
 
-  def age
-    AgeCalculator.new(birthday).age
-  end
 end
 ```
 

data/config/locales/en.yml

@@ -1,6 +1,6 @@
 en:
   errors:
     messages:
-      not_date: "is not a date"
+      not_date: "is not a valid date"
       age_over: "must be over %{age}"
       age_under: "must be under %{age}"

data/lib/age_calculator/validator.rb

@@ -2,9 +2,8 @@ class AgeValidator < ActiveModel::EachValidator
   COMPARATORS = { :over => :>=, :under => :<= }.freeze
 
   def validate_each(record, attribute, value)
-    unless value.is_a?(Date)
-      return record.errors.add(attribute, :not_date, options)
-    end
+    return record.errors.add(attribute, :blank, options) if value.blank?
+    return record.errors.add(attribute, :not_date, options) unless value.is_a?(Date)
 
     age = AgeCalculator.new(value).age
 

data/lib/age_calculator/version.rb

@@ -1,3 +1,3 @@
 class AgeCalculator
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

data/test/age_validator_test.rb

@@ -22,11 +22,28 @@ describe AgeValidator do
     end
   end
 
-  it 'rejects invalid values' do
+  it 'validates presence' do
     travel_to Date.new(2014,1,2) do
       @adult.birthday = nil
       @adult.valid?.must_equal false
-      @adult.errors.full_messages.first.must_equal 'Birthday is not a date'
+      @adult.errors.full_messages.first.must_equal "Birthday can't be blank"
+    end
+  end
+
+  it 'validates date' do
+    travel_to Date.new(2014,1,2) do
+      @adult.birthday = 'invalid'
+      @adult.valid?.must_equal false
+      @adult.errors.full_messages.first.must_equal 'Birthday is not a valid date'
+    end
+  end
+
+  it 'allows blank' do
+    adult = AdultAllowBlank.new
+
+    travel_to Date.new(2014,1,2) do
+      adult.birthday = nil
+      adult.valid?.must_equal true
     end
   end
 end

data/test/test_helper.rb

@@ -25,3 +25,13 @@ class Adult
     AgeCalculator.new(birthday).age
   end
 end
+
+class AdultAllowBlank
+  include ActiveModel::Validations
+  attr_accessor :birthday
+  validates :birthday, age: { over: 18 }, allow_blank: true
+
+  def age
+    AgeCalculator.new(birthday).age
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: age_calculator
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Kenn Ejima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-17 00:00:00.000000000 Z
+date: 2014-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake