after_transaction_commit 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5d37205f04fd9dab8a6f219b2ff9ab0760b953d2
-  data.tar.gz: '058120cf8588254d3ce383837752aaf0d575d5cc'
+  metadata.gz: f1c7c34764bd9e999d94e171a49d5c30770ec7a3
+  data.tar.gz: 45fd10cf2ad53b268774ce368fc52131a3161ab6
 SHA512:
-  metadata.gz: 692045eb18c6ec174083466cb7d5e02b84a8eeca2c03ddb023238dad14ee4067b70946e5870899f86718577d3efbce1a0801986c2c8d57ce2b991a4db958df3f
-  data.tar.gz: cb79f79c415901f0b4b2fec1875795fae2f515fe08aed3d015f0e31b277b4b21e57ccccd5f889985c5e9a67e21f1470ed2293c175e2b24500a2a152304b5b960
+  metadata.gz: d42d9aa4f572b0883d1093076ca9b806671263b5e6ae4b66e02f6d37b7c9d608b1376da7759b1bdc85601b8cc92e545ef29aa93cd42c0a315651ef92923e8220
+  data.tar.gz: 7df1363b174f0848d9b2d40234ec580c6172fa2ae66db672980f81a7d2965994c89cc0190818761a42437f0eac7a9bce153d9e4c64aed80c330ada6f5dacbec2

data/after_transaction_commit.gemspec

@@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bump"
   spec.add_development_dependency "bundler", "~> 1.11"
+  spec.add_development_dependency "byebug"
   spec.add_development_dependency "rake", "~> 11.0"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "sqlite3"

data/lib/after_transaction_commit/database_statements.rb

@@ -20,8 +20,6 @@ ActiveRecord::ConnectionAdapters::DatabaseStatements.class_eval do
       @after_transaction_commit = []
       callbacks.each { |cb| cb.call() }
     end
-  ensure
-    @after_transaction_commit = [] if @after_transaction_commit
   end
 
   def _remove_after_transaction_commit_callbacks

data/lib/after_transaction_commit/version.rb

@@ -1,3 +1,3 @@
 module AfterTransactionCommit
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/spec/after_transaction_commit_spec.rb

@@ -84,4 +84,16 @@ describe AfterTransactionCommit do
     end
     expect(a).to eql 1
   end
+
+  it "doesn't lose a callback inside a callback inside a nested non-joinable transaction" do
+    a = 0
+    User.connection.transaction do
+      User.connection.transaction(:requires_new => true) do
+        User.connection.after_transaction_commit do
+          User.connection.after_transaction_commit { puts "inner callback"; a += 1 }
+        end
+      end
+    end
+    expect(a).to eql 1
+  end
 end

data/spec/gemfiles/42.gemfile.lock

@@ -9,49 +9,48 @@ GIT
 PATH
   remote: ../..
   specs:
-    after_transaction_commit (1.1.0)
+    after_transaction_commit (1.1.1)
       activerecord (>= 4.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (4.2.7.1)
-      activesupport (= 4.2.7.1)
+    activemodel (4.2.8)
+      activesupport (= 4.2.8)
       builder (~> 3.1)
-    activerecord (4.2.7.1)
-      activemodel (= 4.2.7.1)
-      activesupport (= 4.2.7.1)
+    activerecord (4.2.8)
+      activemodel (= 4.2.8)
+      activesupport (= 4.2.8)
       arel (~> 6.0)
-    activesupport (4.2.7.1)
+    activesupport (4.2.8)
       i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
       thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    arel (6.0.3)
-    builder (3.2.2)
+    arel (6.0.4)
+    builder (3.2.3)
     bump (0.5.3)
-    diff-lcs (1.2.5)
-    i18n (0.7.0)
-    json (1.8.3)
-    minitest (5.9.1)
+    byebug (9.0.6)
+    diff-lcs (1.3)
+    i18n (0.8.1)
+    minitest (5.10.2)
     rake (11.3.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    rspec (3.6.0)
+      rspec-core (~> 3.6.0)
+      rspec-expectations (~> 3.6.0)
+      rspec-mocks (~> 3.6.0)
+    rspec-core (3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-expectations (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.6.0)
+    rspec-mocks (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    sqlite3 (1.3.11)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
+      rspec-support (~> 3.6.0)
+    rspec-support (3.6.0)
+    sqlite3 (1.3.13)
+    thread_safe (0.3.6)
+    tzinfo (1.2.3)
       thread_safe (~> 0.1)
     wwtd (1.3.0)
 
@@ -63,6 +62,7 @@ DEPENDENCIES
   after_transaction_commit!
   bump
   bundler (~> 1.11)
+  byebug
   rake (~> 11.0)
   rspec
   sqlite3
@@ -70,4 +70,4 @@ DEPENDENCIES
   wwtd
 
 BUNDLED WITH
-   1.14.3
+   1.14.6

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: after_transaction_commit
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Brian Palmer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-17 00:00:00.000000000 Z
+date: 2017-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.11'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -159,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: ActiveRecord::Base.connection.after_transaction_commit { ... }