after_do 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 246d1c1ca42b79e8fedf494f8b9ef5620a88e998
-  data.tar.gz: 591190d78158bb4a97db932ac0481bad656cb35c
+  metadata.gz: 53c375dcc4890f556937b57e4c425fe504bc5774
+  data.tar.gz: 66f9df14bb68c11f643e36d267b80eb435c7ea6a
 SHA512:
-  metadata.gz: b3b639f1aa8bc684b30b8c1b16026bf2406c98872563ff10aadad02177f47715c8f9eec270409fdbbd9213087323cebd5b38b566308cb12e5b02c9fbf0585321
-  data.tar.gz: b05353aee06b2b7ad93347ad7fdf5284b46529b984ddc58411a10b374437a2e91907d91cd925cda6aba614671bbdaf55fbb42e20e796f26320d4e22a335749cc
+  metadata.gz: 9848d290fe04c511fe23f0ce298033626ee2ae75f4720c5118aaf9f553703fb1d2c095853d312ee2275bb77c11abc0be46a72ac8a2983bdc295d723064fa20e7
+  data.tar.gz: 21ea282c3a6c143c1efd2491df07cd53e66b8967006143c0b63d68e9608b79c705f4ff8d7b7e9ca54e9a55ac77a28a802b1b48317c0360008c6ad1e5e95ef381

data/lib/after_do.rb

@@ -53,7 +53,7 @@ module AfterDo
     end
 
     def _after_do_make_after_do_version_of_method(method)
-      _after_do_raise_no_method_error(method) unless method_defined? method
+      _after_do_raise_no_method_error(method) unless _after_do_defined?(method)
       @_after_do_callbacks[:before][method] = []
       @_after_do_callbacks[:after][method] = []
       alias_name = _after_do_aliased_name method
@@ -61,6 +61,10 @@ module AfterDo
       _after_do_redefine_method_with_callback(method, alias_name)
     end
 
+    def _after_do_defined?(method)
+      method_defined?(method) || private_method_defined?(method)
+    end
+
     def _after_do_raise_no_method_error(method)
       raise NonExistingMethodError, "There is no method #{method} on #{self} to attach a block to with AfterDo"
     end

data/lib/after_do/version.rb

@@ -1,3 +1,3 @@
 module AfterDo
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/after_do_spec.rb

@@ -31,12 +31,21 @@ describe AfterDo do
       @dummy_class.should respond_to callback_adder
     end
 
-    it 'calls a method on the injected mockie' do
+    def simple_callback_called_test(callback_adder)
       @dummy_class.send callback_adder, :zero do mockie.call_method end
       mockie.should_receive :call_method
       dummy_instance.zero
     end
 
+    it 'calls a method on the injected mockie' do
+      simple_callback_called_test callback_adder
+    end
+
+    it 'calls a method on the injected mockie even if that method is private' do
+      @dummy_class.send(:private, :zero)
+      simple_callback_called_test callback_adder
+    end
+
     it 'does not change the return value' do
       before_return_value = dummy_instance.zero
       @dummy_class.send callback_adder, :zero do 42 end
@@ -70,10 +79,19 @@ describe AfterDo do
     end
 
     describe 'errors' do
-      it 'throws an error when you try to add a hook to a non existing method' do
-        expect do
-          @dummy_class.send callback_adder,  :non_existing_method do ; end
-        end.to raise_error(AfterDo::NonExistingMethodError)
+      describe 'NonExistingMethodError' do
+        it 'throws an error when you try to add a hook to a non existing method' do
+          expect do
+            @dummy_class.send callback_adder,  :non_existing_method do ; end
+          end.to raise_error(AfterDo::NonExistingMethodError)
+        end
+
+        it 'does not throw the error for private methods (see #9)' do
+          @dummy_class.send(:private, :zero)
+          expect do
+            @dummy_class.send callback_adder,  :zero do ; end
+          end.to_not raise_error
+        end
       end
 
       describe 'errors in callbacks' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: after_do
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Tobias Pfeiffer