after_commit_action 0.1.4 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b4e82136b05236fe081e5cf4aa74c36b3d095dc6
-  data.tar.gz: 179b0cfdf191f0f7cc14a49288f3adba33c57431
+  metadata.gz: 7098526c08593ab256447fbe799f786c877e4831
+  data.tar.gz: c090670e06e2edc562ffea54df197ffd9f947abb
 SHA512:
-  metadata.gz: ad4a8e477a9b1292649c862aea39cbd44726fd820613543a58bbd4ccf3be64a82956d676bbcf9816e7c97ed576e4063c9b6ef8d08ff72953d5f55bc7abdf0040
-  data.tar.gz: b2bff1637b7b6e60d63bda7e2d7c713611c36dcceda44fa1579ec64a8bf889974b9f26a78ec789bf86bb1c068a120e3cb07c52953c6c08bd6bb60a99258dddc0
+  metadata.gz: a89dfaec4db205f167749d6d8b49c9a419352c9ef70f7f2fb4c89c118e55c50a7539dd391ea25147ff2c3982b067860160ac6e7de97f1503336a01f0a41f8688
+  data.tar.gz: 2505e04c3e9dc9e18263180925be6d8617d1b936adc8066e698a05e9eb6113e814fc93c62bb84ebfceca3294390a99d9dc42f749b3f9a0280da5ec4b9b0d242c

data/Gemfile

@@ -1,10 +1,7 @@
 source "http://rubygems.org"
 
-# Add dependencies to develop your gem here.
-# Include everything needed to run rake, tests, features, etc.
-group :development, :test do
-  gem "rails"
-end
+gem "activerecord", ">= 3.0.0"
+gem "activesupport", ">= 3.0.0"
 
 group :development do
   gem "rdoc", "~> 3.12"

data/Gemfile.lock

@@ -1,28 +1,6 @@
 GEM
   remote: http://rubygems.org/
   specs:
-    actionmailer (4.2.0)
-      actionpack (= 4.2.0)
-      actionview (= 4.2.0)
-      activejob (= 4.2.0)
-      mail (~> 2.5, >= 2.5.4)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-    actionpack (4.2.0)
-      actionview (= 4.2.0)
-      activesupport (= 4.2.0)
-      rack (~> 1.6.0)
-      rack-test (~> 0.6.2)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-      rails-html-sanitizer (~> 1.0, >= 1.0.1)
-    actionview (4.2.0)
-      activesupport (= 4.2.0)
-      builder (~> 3.1)
-      erubis (~> 2.7.0)
-      rails-dom-testing (~> 1.0, >= 1.0.5)
-      rails-html-sanitizer (~> 1.0, >= 1.0.1)
-    activejob (4.2.0)
-      activesupport (= 4.2.0)
-      globalid (>= 0.3.0)
     activemodel (4.2.0)
       activesupport (= 4.2.0)
       builder (~> 3.1)
@@ -42,7 +20,6 @@ GEM
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.1.3)
-    erubis (2.7.0)
     faraday (0.9.0)
       multipart-post (>= 1.2, < 3)
     git (1.2.8)
@@ -54,11 +31,8 @@ GEM
       multi_json (>= 1.7.5, < 2.0)
       nokogiri (~> 1.6.3)
       oauth2
-    globalid (0.3.0)
-      activesupport (>= 4.1.0)
     hashie (3.3.2)
     highline (1.6.21)
-    hike (1.2.3)
     i18n (0.7.0)
     jeweler (2.0.1)
       builder
@@ -71,11 +45,6 @@ GEM
       rdoc
     json (1.8.1)
     jwt (1.2.0)
-    loofah (2.0.1)
-      nokogiri (>= 1.5.9)
-    mail (2.6.3)
-      mime-types (>= 1.16, < 3)
-    mime-types (2.4.3)
     mini_portile (0.6.1)
     minitest (5.5.0)
     multi_json (1.10.1)
@@ -90,32 +59,6 @@ GEM
       multi_xml (~> 0.5)
       rack (~> 1.2)
     rack (1.6.0)
-    rack-test (0.6.2)
-      rack (>= 1.0)
-    rails (4.2.0)
-      actionmailer (= 4.2.0)
-      actionpack (= 4.2.0)
-      actionview (= 4.2.0)
-      activejob (= 4.2.0)
-      activemodel (= 4.2.0)
-      activerecord (= 4.2.0)
-      activesupport (= 4.2.0)
-      bundler (>= 1.3.0, < 2.0)
-      railties (= 4.2.0)
-      sprockets-rails
-    rails-deprecated_sanitizer (1.0.3)
-      activesupport (>= 4.2.0.alpha)
-    rails-dom-testing (1.0.5)
-      activesupport (>= 4.2.0.beta, < 5.0)
-      nokogiri (~> 1.6.0)
-      rails-deprecated_sanitizer (>= 1.0.1)
-    rails-html-sanitizer (1.0.1)
-      loofah (~> 2.0)
-    railties (4.2.0)
-      actionpack (= 4.2.0)
-      activesupport (= 4.2.0)
-      rake (>= 0.8.7)
-      thor (>= 0.18.1, < 2.0)
     rake (10.4.2)
     rdoc (3.12.2)
       json (~> 1.4)
@@ -128,19 +71,8 @@ GEM
       diff-lcs (~> 1.1.2)
     rspec-extra-formatters (1.0.0)
     rspec-mocks (2.8.0)
-    sprockets (2.12.3)
-      hike (~> 1.2)
-      multi_json (~> 1.0)
-      rack (~> 1.0)
-      tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.2.2)
-      actionpack (>= 3.0)
-      activesupport (>= 3.0)
-      sprockets (>= 2.8, < 4.0)
     sqlite3 (1.3.10)
-    thor (0.19.1)
     thread_safe (0.3.4)
-    tilt (1.4.1)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
 
@@ -148,9 +80,10 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  activerecord (>= 3.0.0)
+  activesupport (>= 3.0.0)
   bundler (>= 1.1.3)
   jeweler (~> 2.0.1)
-  rails
   rdoc (~> 3.12)
   rspec (~> 2.8.0)
   rspec-extra-formatters

data/README.md

@@ -5,6 +5,7 @@ Use this module to defer actions to the after-commit hook. This is useful if you
 ## Usage
 
 ```ruby
+include AfterCommitAction
 after_create :my_hook
 def my_hook
   execute_after_commit { puts "This is called after committing the transaction. "}

data/Rakefile

@@ -21,8 +21,6 @@ Jeweler::Tasks.new do |gem|
   gem.description = %Q{Use this module to defer actions to the after-commit hook. This is useful if you want to trigger actions in after_create, after_destroy and after_update callbacks but want to execute them outside of the transaction (for example, to avoid deadlocks).}
   gem.email = "magnus@bestvendor.com"
   gem.authors = ["BestVendor"]
-  
-  gem.add_dependency 'activerecord', '>= 3.0.0'
 end
 Jeweler::RubygemsDotOrgTasks.new
 

data/VERSION

@@ -1 +1 @@
-0.1.4
+1.0.0

data/after_commit_action.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: after_commit_action 0.1.4 ruby lib
+# stub: after_commit_action 1.0.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "after_commit_action"
-  s.version = "0.1.4"
+  s.version = "1.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["BestVendor"]
-  s.date = "2014-12-25"
+  s.date = "2015-03-07"
   s.description = "Use this module to defer actions to the after-commit hook. This is useful if you want to trigger actions in after_create, after_destroy and after_update callbacks but want to execute them outside of the transaction (for example, to avoid deadlocks)."
   s.email = "magnus@bestvendor.com"
   s.extra_rdoc_files = [
@@ -87,31 +87,31 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/magnusvk/after_commit_action"
   s.licenses = ["MIT"]
-  s.rubygems_version = "2.2.2"
+  s.rubygems_version = "2.4.3"
   s.summary = "Easily defer blocks of code to the after-commit action of an ActiveRecord model."
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<rails>, [">= 0"])
+      s.add_runtime_dependency(%q<activerecord>, [">= 3.0.0"])
+      s.add_runtime_dependency(%q<activesupport>, [">= 3.0.0"])
       s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
       s.add_development_dependency(%q<bundler>, [">= 1.1.3"])
       s.add_development_dependency(%q<jeweler>, ["~> 2.0.1"])
-      s.add_runtime_dependency(%q<activerecord>, [">= 3.0.0"])
     else
-      s.add_dependency(%q<rails>, [">= 0"])
+      s.add_dependency(%q<activerecord>, [">= 3.0.0"])
+      s.add_dependency(%q<activesupport>, [">= 3.0.0"])
       s.add_dependency(%q<rdoc>, ["~> 3.12"])
       s.add_dependency(%q<bundler>, [">= 1.1.3"])
       s.add_dependency(%q<jeweler>, ["~> 2.0.1"])
-      s.add_dependency(%q<activerecord>, [">= 3.0.0"])
     end
   else
-    s.add_dependency(%q<rails>, [">= 0"])
+    s.add_dependency(%q<activerecord>, [">= 3.0.0"])
+    s.add_dependency(%q<activesupport>, [">= 3.0.0"])
     s.add_dependency(%q<rdoc>, ["~> 3.12"])
     s.add_dependency(%q<bundler>, [">= 1.1.3"])
     s.add_dependency(%q<jeweler>, ["~> 2.0.1"])
-    s.add_dependency(%q<activerecord>, [">= 3.0.0"])
   end
 end
 

data/lib/after_commit_action.rb

@@ -7,49 +7,36 @@
 # def my_hook
 #   execute_after_commit { puts "This is called after committing the transaction. "}
 # end
+require 'active_support/concern'
 
 module AfterCommitAction
+  extend ActiveSupport::Concern
 
-  module ActiveRecord
-
-    def self.included(base)
-      base.after_commit :_after_commit_hook
-    end
-
-    def execute_after_commit(&block)
-      @_execute_after_commit ||= []
-      @_execute_after_commit<< block
-    end
-
-    def _after_commit_hook
-      begin
-        until @_execute_after_commit.blank?
-          @_execute_after_commit.shift.call
-        end
-      rescue => e
-        if defined?(Exceptional)
-          # Rails quietly swallows exceptions in after-commit actions; to avoid missing these
-          # exceptions, we pass them to Exceptional explicitly
-          Exceptional.context(:after_commit_entity => self.inspect)
-          Exceptional.handle(e, "execute_after_commit")
-        else
-          Rails.logger.error "Error in execute_after_commit block: #{e.inspect}"
-        end
-        raise e
-      end
-    end
+  included do
+    after_commit :_after_commit_hook
+  end
 
+  def execute_after_commit(&block)
+    @_execute_after_commit ||= []
+    @_execute_after_commit<< block
   end
 
-  if defined?(Rails) # if this is a full blown rails app, use a railtie. This avoids deprecation warnings in Rails 4.2
-    class Railtie < Rails::Railtie
-      initializer "active_record.include_plugins" do
-        ActiveSupport.on_load(:active_record) do
-          ::ActiveRecord::Base.send :include, ActiveRecord
-        end
+  def _after_commit_hook
+    begin
+      until @_execute_after_commit.blank?
+        @_execute_after_commit.shift.call
       end
+    rescue => e
+      if defined?(Exceptional)
+        # Rails quietly swallows exceptions in after-commit actions; to avoid missing these
+        # exceptions, we pass them to Exceptional explicitly
+        Exceptional.context(:after_commit_entity => self.inspect)
+        Exceptional.handle(e, "execute_after_commit")
+      else
+        Rails.logger.error "Error in execute_after_commit block: #{e.inspect}"
+      end
+      raise e
     end
-  else
-    ::ActiveRecord::Base.send :include, ActiveRecord
   end
+
 end

data/spec/models/tester.rb

@@ -1,4 +1,6 @@
 class Tester < ActiveRecord::Base
+  include AfterCommitAction
+
   after_initialize :after_initialize
 
   before_create :before_create
@@ -15,7 +17,7 @@ class Tester < ActiveRecord::Base
   def before_create
     execute_after_commit { @array<< 'before_create' }
   end
-  
+
   def after_create
     execute_after_commit { @array<< 'after_create' }
   end

data/spec/rails_app/config/application.rb

@@ -44,12 +44,6 @@ module RailsApp
     # like if you have constraints or database-specific column types
     # config.active_record.schema_format = :sql
 
-    # Enforce whitelist mode for mass assignment.
-    # This will create an empty whitelist of attributes available for mass-assignment for all models
-    # in your app. As such, your models will need to explicitly whitelist or blacklist accessible
-    # parameters by using an attr_accessible or attr_protected declaration.
-    config.active_record.whitelist_attributes = true
-
     # Enable the asset pipeline
     config.assets.enabled = true
 

data/spec/rails_app/config/environments/development.rb

@@ -22,13 +22,6 @@ RailsApp::Application.configure do
   # Only use best-standards-support built into browsers
   config.action_dispatch.best_standards_support = :builtin
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
-  # Log the query plan for queries taking more than this (works
-  # with SQLite, MySQL, and PostgreSQL)
-  config.active_record.auto_explain_threshold_in_seconds = 0.5
-
   # Do not compress assets
   config.assets.compress = false
 

data/spec/rails_app/config/environments/production.rb

@@ -60,8 +60,4 @@ RailsApp::Application.configure do
 
   # Send deprecation notices to registered listeners
   config.active_support.deprecation = :notify
-
-  # Log the query plan for queries taking more than this (works
-  # with SQLite, MySQL, and PostgreSQL)
-  # config.active_record.auto_explain_threshold_in_seconds = 0.5
 end

data/spec/rails_app/config/environments/test.rb

@@ -29,9 +29,6 @@ RailsApp::Application.configure do
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
-
   # Print deprecation notices to the stderr
   config.active_support.deprecation = :stderr
 end

data/spec/spec_helper.rb

@@ -10,9 +10,3 @@ load "#{File.dirname(__FILE__)}/schema.rb"
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
-
-RSpec.configure do |config|
-  config.before :suite do
-    ActiveRecord::Base.send :include, AfterCommitAction::ActiveRecord
-  end
-end

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: after_commit_action
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 1.0.0
 platform: ruby
 authors:
 - BestVendor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-25 00:00:00.000000000 Z
+date: 2015-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: 3.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -66,20 +80,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.0.1
-- !ruby/object:Gem::Dependency
-  name: activerecord
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.0.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.0.0
 description: Use this module to defer actions to the after-commit hook. This is useful
   if you want to trigger actions in after_create, after_destroy and after_update callbacks
   but want to execute them outside of the transaction (for example, to avoid deadlocks).
@@ -175,7 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: Easily defer blocks of code to the after-commit action of an ActiveRecord