africansms 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0037113780c55ec7c02643af02be2f0dec24c4b463be3d5c232b3cf8a7dd7fe
-  data.tar.gz: dd05389799d56be4f27ed0b142a44e61da12f8cbc7f81b1bfb98795206c614b5
+  metadata.gz: f5b35bc11b8fe1a17e77a9538de7cd819e6dc54b630b4668137963751807a58e
+  data.tar.gz: 99316ba7ec6bfa458cac519022e66e7a86d8febef68e09aa5ab9d179007a7461
 SHA512:
-  metadata.gz: 2293ed57aa78eedd2c824baf4ec6ad49754f3aba39cb084b9ec3a13530577682fc038da5949d0464f46e5296bd8c7ba433573c11a8093eccbd755d5ee65f5998
-  data.tar.gz: 265ecb3907e4e5eb7a49560ad0764e0046b25351924eccecbc5bc522409a4f344766e47e62bca60bd7e67b31a95f73de3ae4740d8e6f8b815bbfd40b8dfb74ed
+  metadata.gz: '0924a357882b883ef67b853d3b7427139560a4e771ef3a4ae5e62e39f51d3203821cfc03b1324cd779fa72fc591e7eb5cff4542ec187c7ebcbdb00e5c6d2acd6'
+  data.tar.gz: 88d1cb291535da63e93767d7eba775b52b18c43b2921c2a34207e106726082281ccc8e86e1e050bf9eb7af2503473ea6e9a064ce4393d57ffcf265b8be6c2460

data/.rubocop.yml

@@ -0,0 +1,18 @@
+AllCops:
+  TargetRubyVersion: 2.5.0
+  NewCops: enable
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Metrics/ClassLength:
+  Max: 300
+
+Layout/LineLength:
+  Max: 120
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false

data/Gemfile

@@ -1,4 +1,6 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in africansms.gemspec
 gemspec
+
+gem 'rubocop', require: false

data/Gemfile.lock

@@ -1,12 +1,13 @@
 PATH
   remote: .
   specs:
-    africansms (0.1.5)
+    africansms (0.1.7)
       rest-client (~> 2.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.4.2)
     domain_name (0.5.20190701)
       unf (>= 0.0.5, < 1.0.0)
     http-accept (1.7.0)
@@ -16,15 +17,34 @@ GEM
       mime-types-data (~> 3.2015)
     mime-types-data (3.2021.0704)
     netrc (0.11.0)
+    parallel (1.20.1)
+    parser (3.0.2.0)
+      ast (~> 2.4.1)
+    rainbow (3.0.0)
     rake (13.0.6)
+    regexp_parser (2.1.1)
     rest-client (2.1.0)
       http-accept (>= 1.7.0, < 2.0)
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
+    rexml (3.2.5)
+    rubocop (1.18.3)
+      parallel (~> 1.10)
+      parser (>= 3.0.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.7.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.8.0)
+      parser (>= 3.0.1.1)
+    ruby-progressbar (1.11.0)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.7.7)
+    unicode-display_width (2.0.0)
 
 PLATFORMS
   x86_64-linux
@@ -33,6 +53,7 @@ DEPENDENCIES
   africansms!
   bundler (~> 2.2.23)
   rake (~> 13.0)
+  rubocop
 
 BUNDLED WITH
    2.2.23

data/README.md

@@ -22,7 +22,8 @@ Or install it yourself as:
 
 ### Overview
 
-Africansms is a gem which is an integration of Africastalking SMS service. Before using the gem please take a look on Africastalking SMS service documentation "https://developers.africastalking.com/docs/sms/overview" to get the required configration credentials (api_key, username & shortcode)
+Africansms is an integration of Africastalking SMS service. Before using the gem you should have a knowledge Africastalking SMS service. Documentation URL: https://developers.africastalking.com/docs/sms/overview 
+You have to create an account on AfricasTalking to get the required configration credentials (api_key, username & shortcode).
 
 ### Configuration
 

data/africansms.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
   spec.description            = 'Integration of Africastalking SMS service for sending SMS in African regions'
   spec.homepage               = 'https://github.com/ayushagrawal134/africansms'
   spec.license                = 'MIT'
-  spec.required_ruby_version  = '>= 2.3.0'
+  spec.required_ruby_version  = '>= 2.5.0'
   spec.files                  = `git ls-files`.split("\n")
 
   spec.add_dependency 'rest-client', '~> 2.1'

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "africansms"
+require 'bundler/setup'
+require 'africansms'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "africansms"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/lib/africansms.rb

@@ -3,7 +3,7 @@ require 'africansms/client'
 
 module Africansms
   class AfricansmsError < StandardError; end
-  
+
   class << self
     def configure
       yield configuration

data/lib/africansms/client.rb

@@ -10,10 +10,11 @@ module Africansms
 
     def send_message
       raise(AfricansmsError, 'The message to send should not be empty') unless valid_message?
+
       response = RestClient.post(base_url, request_params, request_header)
       response.body
-    rescue StandardError => error
-      error
+    rescue StandardError => e
+      e
     end
 
     private
@@ -21,7 +22,7 @@ module Africansms
     def request_params
       params.merge(
         username: Africansms.configuration.username!,
-        from: Africansms.configuration.shortcode!,
+        from: Africansms.configuration.shortcode!
       )
     end
 
@@ -33,13 +34,15 @@ module Africansms
     end
 
     def base_url
-      params.dig(:mode).eql?('live') ?
-       'https://api.africastalking.com/version1/messaging' :
+      if params[:mode].eql?('live')
+        'https://api.africastalking.com/version1/messaging'
+      else
         'https://api.sandbox.africastalking.com/version1/messaging'
+      end
     end
 
-   def valid_message?
-     params[:message] && !params[:message].empty? 
-   end
+    def valid_message?
+      params[:message] && !params[:message].empty?
+    end
   end
 end

data/lib/africansms/configuration.rb

@@ -15,7 +15,7 @@ module Africansms
     def username!
       username || raise(AfricansmsError, 'No username specified.')
     end
-    
+
     def shortcode!
       shortcode || raise(AfricansmsError, 'No shortcode specified.')
     end

data/lib/africansms/version.rb

@@ -1,3 +1,3 @@
 module Africansms
-  VERSION = "0.1.6"
+  VERSION = '0.1.7'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: africansms
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Ayush Agrawal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-16 00:00:00.000000000 Z
+date: 2021-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -61,6 +61,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
@@ -86,14 +87,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubyforge_project: 
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: AfricasTalking SMS service integration