ae_page_objects 0.3.0 → 0.4.0

data/lib/ae_page_objects.rb

@@ -2,10 +2,12 @@ require 'capybara'
 require 'capybara/dsl'
 
 require 'ae_page_objects/version'
+require 'ae_page_objects/exceptions'
 
 module AePageObjects
   autoload :Universe,             'ae_page_objects/core/universe'
-  autoload :Application,          'ae_page_objects/core/application'
+  autoload :Site,                 'ae_page_objects/core/site'
+  autoload :BasicRouter,          'ae_page_objects/core/basic_router'
   autoload :ApplicationRouter,    'ae_page_objects/core/application_router'
   autoload :RakeRouter,           'ae_page_objects/core/rake_router'
   autoload :Dsl,                  'ae_page_objects/core/dsl'

data/lib/ae_page_objects/concerns/load_ensuring.rb

@@ -1,7 +1,4 @@
 module AePageObjects
-  class LoadingFailed < StandardError
-  end
-  
   module Concerns
     module LoadEnsuring
 

data/lib/ae_page_objects/concerns/staleable.rb

@@ -1,12 +1,9 @@
 module AePageObjects
-  class StalePageObject < StandardError
-  end
-
-  module Concerns  
+  module Concerns
     module Staleable
 
       def stale?
-        @stale
+        !!@stale
       end
 
       def node

data/lib/ae_page_objects/concerns/visitable.rb

@@ -1,7 +1,4 @@
 module AePageObjects
-  class PathNotResolvable < StandardError
-  end
-  
   module Concerns
     module Visitable
 
@@ -23,7 +20,7 @@ module AePageObjects
         def visit(*args)
           raise ArgumentError, "Cannot pass block to visit()" if block_given?
 
-          full_path = application.generate_path(paths.first, *args)
+          full_path = site.generate_path(paths.first, *args)
           raise PathNotResolvable, "#{self.name} not visitable via #{paths.first}(#{args.inspect})" unless full_path
 
           Capybara.current_session.visit(full_path)
@@ -39,7 +36,7 @@ module AePageObjects
           url = current_url_without_params
 
           paths.any? do |path|
-            application.path_recognizes_url?(path, url)
+            site.path_recognizes_url?(path, url)
           end
         end
       
@@ -59,4 +56,4 @@ module AePageObjects
       end
     end
   end
-end
+end

data/lib/ae_page_objects/core/application_router.rb

@@ -1,60 +1,130 @@
 module AePageObjects
-  class ApplicationRouter
-    def path_recognizes_url?(path, url)
-      if path.is_a?(String)
-        path.sub(/\/$/, '') == url.sub(/\/$/, '')
-      elsif path.is_a?(Symbol)
-        url, router = url_and_router(url)
-
-        ["GET", "PUT", "POST", "DELETE", "PATCH"].each do |method|
-          router.recognize(request_for(url, method)) do |route, matches, params|
-            return true if route.name.to_s == path.to_s
+  class ApplicationRouter < BasicRouter
+
+    # This whole file is a kludge and probably belongs in an ae_page_objects-rails extension
+
+    module Recognizer
+
+      class Base
+        def generate_path(named_route, *args)
+          if routes.respond_to?("#{named_route}_path")
+            routes.send("#{named_route}_path", *args)
           end
         end
-        false
       end
-    end
 
-    def generate_path(named_route, *args)
-      return named_route if named_route.is_a?(String)
+      class Rails23 < Base
+        def recognizes?(path, url)
+          ["GET", "PUT", "POST", "DELETE", "PATCH"].map(&:downcase).map(&:to_sym).each do |method|
+            route = ActionController::Routing::Routes.named_routes[path]
+            route.recognize(url, {:method => method})
 
-      if routes.respond_to?("#{named_route}_path")
-        routes.send("#{named_route}_path", *args)
+            return true if route && route.recognize(url, {:method => method})
+          end
+
+          false
+        end
+
+      private
+
+        def routes
+          @routes ||= begin
+            routes_class = Class.new do
+              include ActionController::UrlWriter
+            end
+            ActionController::Routing::Routes.install_helpers(routes_class)
+            routes_class.new
+          end
+        end
       end
-    end
 
-  private
-  
-    def request_for(url, method)
-      Rails.application.routes.request_class.new(env_for(url, method))
+      class Rails3 < Base
+        def recognizes?(path, url)
+          url, router = url_and_router(url)
+
+          ["GET", "PUT", "POST", "DELETE", "PATCH"].each do |method|
+            router.recognize(request_for(url, method)) do |route, matches, params|
+              return true if route.name.to_s == path.to_s
+            end
+          end
+
+          false
+        end
+
+
+      private
+
+        def request_for(url, method)
+          Rails.application.routes.request_class.new(env_for(url, method))
+        end
+
+        def env_for(url, method)
+          begin
+            Rack::MockRequest.env_for(url, {:method => method})
+          rescue URI::InvalidURIError => e
+            raise ActionController::RoutingError, e.message
+          end
+        end
+
+        def url_and_router(url)
+          url = Rack::Mount::Utils.normalize_path(url) unless url =~ %r{://}
+          router = Rails.application.routes.set
+
+          [url, router]
+        end
+
+        def routes
+          @routes ||= begin
+            routes_class = Class.new do
+              include Rails.application.routes.url_helpers
+            end
+            routes_class.new
+          end
+        end
+      end
+
+      class Rails32 < Rails3
+
+      private
+        def url_and_router(url)
+          url = Journey::Router::Utils.normalize_path(url) unless url =~ %r{://}
+          router = Rails.application.routes.router
+
+          [url, router]
+        end
+      end
     end
-  
-    def env_for(url, method)
-      begin
-        Rack::MockRequest.env_for(url, {:method => method})
-      rescue URI::InvalidURIError => e
-        raise ActionController::RoutingError, e.message
+
+    def path_recognizes_url?(path, url)
+      if path.is_a?(Symbol)
+        recognizer.recognizes?(path, url)
+      else
+        super
       end
     end
-  
-    def url_and_router(url)
-      if Rails.version =~ /^3.[01]/ 
-        url = Rack::Mount::Utils.normalize_path(url) unless url =~ %r{://}
-        router = Rails.application.routes.set
+
+    def generate_path(named_route, *args)
+      if named_route.is_a?(Symbol)
+        recognizer.generate_path(named_route, *args)
       else
-        url = Journey::Router::Utils.normalize_path(url) unless url =~ %r{://}
-        router = Rails.application.routes.router
+        super
       end
-      
-      [url, router]
     end
 
-    def routes
-      @routes ||= begin
-        routes_class = Class.new do
-          include Rails.application.routes.url_helpers
+  private
+
+    def recognizer
+      @recognizer ||= begin
+        if Rails.version =~ /\A2\.3/
+          Recognizer::Rails23.new
+        elsif Rails.version =~ /\A3\.[01]/
+          Recognizer::Rails3.new
+        elsif Rails.version =~ /\A3\.2/
+          Recognizer::Rails32.new
+        else
+          warn "[WARNING]: AePageObjects is not tested against Rails #{Rails.version} and may behave in an undefined manner."
+          Recognizer::Rails32.new
         end
-        routes_class.new
       end
     end
   end

data/lib/ae_page_objects/core/basic_router.rb

@@ -0,0 +1,11 @@
+module AePageObjects
+  class BasicRouter
+    def path_recognizes_url?(path, url)
+      path.sub(/\/$/, '') == url.sub(/\/$/, '')
+    end
+
+    def generate_path(named_route, *args)
+      named_route
+    end
+  end
+end

data/lib/ae_page_objects/core/rake_router.rb

@@ -1,5 +1,5 @@
 module AePageObjects
-  class RakeRouter
+  class RakeRouter < BasicRouter
     
     attr_reader :routes
     
@@ -18,11 +18,11 @@ module AePageObjects
     end
     
     def path_recognizes_url?(path, url)
-      if path.is_a?(String)
-        path.sub(/\/$/, '') == url.sub(/\/$/, '')
-      elsif path.is_a?(Symbol)
+      if path.is_a?(Symbol)
         route = @routes[path]
         route && route.matches?(url)
+      else
+        super
       end
     end
 

data/lib/ae_page_objects/core/{application.rb → site.rb}

@@ -1,7 +1,7 @@
 module AePageObjects
-  class Application
+  class Site
     extend AePageObjects::Singleton
-      
+
     class << self
       private :new
 
@@ -13,11 +13,11 @@ module AePageObjects
         instance.router = router
       end
 
-      def inherited(application_class)
+      def inherited(site_class)
         super
 
-        application_class.universe.send(:include, Universe)
-        application_class.universe.page_objects_application_class = application_class
+        site_class.universe.send(:include, Universe)
+        site_class.universe.page_objects_site_class = site_class
       end
 
       def universe
@@ -27,7 +27,7 @@ module AePageObjects
       def from(from_mod)
         until from_mod == Object
           if from_mod < AePageObjects::Universe
-            return from_mod.page_objects_application_class.instance
+            return from_mod.page_objects_site_class.instance
           end
 
           from_mod = from_mod.parent

data/lib/ae_page_objects/core/universe.rb

@@ -3,7 +3,7 @@ module AePageObjects
     def self.included(target)
       target.class_eval do
         class << self
-          attr_accessor :page_objects_application_class
+          attr_accessor :page_objects_site_class
         end
       end
     end

data/lib/ae_page_objects/document.rb

@@ -2,14 +2,18 @@ module AePageObjects
   class Document < Node
     include Concerns::Visitable
     
+    def initialize
+      super(Capybara.current_session)
+    end
+
     def document
       self
     end
     
     class << self
     private
-      def application
-        @application ||= AePageObjects::Application.from(self)
+      def site
+        @site ||= AePageObjects::Site.from(self)
       end
     end
   end

data/lib/ae_page_objects/exceptions.rb

@@ -0,0 +1,10 @@
+module AePageObjects
+  class StalePageObject < StandardError
+  end
+
+  class LoadingFailed < StandardError
+  end
+
+  class PathNotResolvable < StandardError
+  end
+end

data/lib/ae_page_objects/node.rb

@@ -1,7 +1,7 @@
 module AePageObjects
   class Node
     module Methods
-      def initialize(capybara_node = Capybara.current_session)
+      def initialize(capybara_node)
         @node = capybara_node
       end
 

data/lib/ae_page_objects/version.rb

@@ -1,3 +1,3 @@
 module AePageObjects
-  VERSION = '0.3.0'.freeze
+  VERSION = '0.4.0'.freeze
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ae_page_objects
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 15
   prerelease: 
   segments: 
   - 0
-  - 3
+  - 4
   - 0
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Donnie Tognazzini
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-07-08 00:00:00 Z
+date: 2013-07-19 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   type: :runtime
@@ -32,26 +32,10 @@ dependencies:
         version: "1.1"
   requirement: *id001
   prerelease: false
-- !ruby/object:Gem::Dependency 
-  type: :runtime
-  name: nokogiri
-  version_requirements: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 17
-        segments: 
-        - 1
-        - 5
-        - 9
-        version: 1.5.9
-  requirement: *id002
-  prerelease: false
 - !ruby/object:Gem::Dependency 
   type: :development
   name: appraisal
-  version_requirements: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -62,12 +46,12 @@ dependencies:
         - 5
         - 1
         version: 0.5.1
-  requirement: *id003
+  requirement: *id002
   prerelease: false
 - !ruby/object:Gem::Dependency 
   type: :development
   name: mocha
-  version_requirements: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
@@ -78,12 +62,12 @@ dependencies:
         - 13
         - 3
         version: 0.13.3
-  requirement: *id004
+  requirement: *id003
   prerelease: false
 - !ruby/object:Gem::Dependency 
   type: :development
   name: selenium-webdriver
-  version_requirements: &id005 !ruby/object:Gem::Requirement 
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -92,7 +76,7 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  requirement: *id005
+  requirement: *id004
   prerelease: false
 description: Capybara Page Objects pattern
 email: 
@@ -108,10 +92,11 @@ files:
 - lib/ae_page_objects/concerns/load_ensuring.rb
 - lib/ae_page_objects/concerns/staleable.rb
 - lib/ae_page_objects/concerns/visitable.rb
-- lib/ae_page_objects/core/application.rb
 - lib/ae_page_objects/core/application_router.rb
+- lib/ae_page_objects/core/basic_router.rb
 - lib/ae_page_objects/core/dsl.rb
 - lib/ae_page_objects/core/rake_router.rb
+- lib/ae_page_objects/core/site.rb
 - lib/ae_page_objects/core/universe.rb
 - lib/ae_page_objects/core_ext/module.rb
 - lib/ae_page_objects/document.rb
@@ -121,6 +106,7 @@ files:
 - lib/ae_page_objects/elements/collection.rb
 - lib/ae_page_objects/elements/form.rb
 - lib/ae_page_objects/elements/select.rb
+- lib/ae_page_objects/exceptions.rb
 - lib/ae_page_objects/node.rb
 - lib/ae_page_objects/util/hash_symbolizer.rb
 - lib/ae_page_objects/util/inflector.rb