ae_fast_decimal_formatter 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bfad6f29472a1ffc004d85c66182f379905f04d968324acba49ded7c3bf277c9
-  data.tar.gz: b351216f297f3c692f42fd44e0ba917a3405e677c567fa9206d6d8f4cba936c3
+  metadata.gz: 25d8e986474fd332d72658a25693cb1147d0ff71f187b5dd39e3b1be69078bb9
+  data.tar.gz: c0faafa4e3be83109a3de7174e7055c226129e31cdfb83c443483c6c2973a86f
 SHA512:
-  metadata.gz: d3aa9e8b0438d4f4f0dd59f286685f4d2e0954ca6b50f6aed8a02c6e819e9be2abc7886468931e2e9cf2ea0bf70525decd5364468b99b30944dc74e2e40e08b2
-  data.tar.gz: 053b1593c4b4ed4ab05cbc1cc481361a65d9dac6b05ae1ec5f03ec06c931f712ababb7665e7cfefe6d129e2d4a9a3d7717772ca9b7502a28bed1db5e044f3946
+  metadata.gz: '0009ff8c75044a9caafee78662242e0de482dedf0dc9aa207b6d808b7d1ee4145fde1c071cd0b2d29b76fc2f4126f8b212c4b55621f2d5ae317a8f96dd1141f3'
+  data.tar.gz: 2cd3523e207af1a6f0cc2946bdfbc82d8d915e2e58eb488d39fb730dd92597935958f3ba628370a3ff6d426efba1d765d36116eda16b7b387f3c54b9f2a6b32e

data/lib/ae_fast_decimal_formatter/version.rb

@@ -1,3 +1,3 @@
 class AeFastDecimalFormatter
-  VERSION = '2.0.0'
+  VERSION = '2.1.0'
 end

data/lib/ae_fast_decimal_formatter.rb

@@ -5,18 +5,18 @@ class AeFastDecimalFormatter
     precision = 0 if precision < 0
     precision = 5 if precision > 5
 
-    if number.is_a?(BigDecimal)
-      # With BigDecimal, we do not need to call round twice.
-      format_long((number * 10 ** precision).round, precision)
-    else
-      # It looks like we need the two sets of rounds in order to attempt
-      # to round floating numbers. For example,
-      # (148.855 * 100).round -> 14885 seems incorrect, so we try,
-      # 148.855.round(2) * 100 -> 14886 but then,
-      # (1234567890.12.round(2) * 100).to_i -> 123456789011 which is
-      # definitely not correct. Thus the two rounds.
-      format_long((number.round(precision) * 10 ** precision).round, precision)
-    end
+    # We can call to_f on the input to convert variety of types to floats. This is
+    # faster than inspecting the type of the input and performing different logic.
+    # This is safe as we have a test that verifies we produce the same result for
+    # float as we do for BigDecimals (i.e. format_long((num * 10 ** precision).round, precision)).
+    #
+    # In order to round correct, it looks like we need the two sets of rounds. For example,
+    # (148.855 * 100).round.to_i -> 14885 seems incorrect, so we try,
+    # (148.855.round(2) * 100).to_i -> 14886 but then,
+    # (1234567890.12.round(2) * 100).to_i -> 123456789011 which is definitely not correct.
+    #
+    # Thus the two rounds.
+    format_long((number.to_f.round(precision) * 10 ** precision).round, precision)
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ae_fast_decimal_formatter
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - AppFolio
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-01 00:00:00.000000000 Z
+date: 2022-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -84,7 +84,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.0.9
 signing_key:
 specification_version: 4
 summary: Efficiently format decimal number.