ae_easy-qa 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 172e1208f37869ecc60b0baf0ddcfa31af006223f7153e944231b905499b85a5
-  data.tar.gz: 7c25f94aede5d289722740a37a23630c3b61c2864dfb56b32263c93333f7e172
+  metadata.gz: 363c9d9b41cd90e575c4f64e77c044f71ec0e9785e71a69659150ff215411e1f
+  data.tar.gz: 5e236351848333d7634534634d77b8f12068a972c20d1f9a592378570a302639
 SHA512:
-  metadata.gz: f3b0dac40f664140bd9b0d6b7a628d70a55b3775edd31aa670bfb2f20797a0debe02b50ead75071c31a39d3ab010e021999fccf2f8b012e9af70a9284e663a3f
-  data.tar.gz: 842ce7c6017d512e5334ac825fe5e98122b3ffecdccccb54f095e1f10fe9cd639bfcd441c3f96a64fc9fae6cccf10f8217bc6ea3707a530f153f59ce232ef9a9
+  metadata.gz: 3d1e88121ee00124767981264022b66271a5aaa3ccbaf74e0518d201e7c1bae5b1bf279c931cece1217f6550e369dc2fed3b57c5b3247b03f0876b2534805a16
+  data.tar.gz: 96a35e2965262a2fdbc8ea9b4412b1d3943a2f728774bd6bb6a9367148134e38953028e3ed0b6cfd7798675066b7957369d21a6686191024895c7b63e870a108

data/lib/ae_easy/qa/validate_external.rb

@@ -0,0 +1,24 @@
+module AeEasy
+  module Qa
+    class ValidateExternal
+      attr_reader :data, :errors, :config
+
+      def initialize(data, errors, config)
+        @data = data
+        @errors = errors
+        @config = config
+      end
+
+      def run
+        begin
+          ValidateGroups.new(data, errors).run
+          ValidateRules.new(data, errors, config['individual_validations']).run if config
+          return errors
+        rescue StandardError => e
+          puts "An error has occurred: #{e}"
+          return nil
+        end
+      end
+    end
+  end
+end

data/lib/ae_easy/qa/validate_groups.rb

@@ -0,0 +1,48 @@
+module AeEasy
+  module Qa
+    class ValidateGroups
+      attr_reader :data, :errors
+
+      def initialize(data, errors)
+        @data = data
+        @errors = errors
+      end
+
+      def run
+        if group_validations_present?
+          load_module
+          include_module
+          call_validation_methods
+        end
+      end
+
+      private
+
+      def fail_validation(name)
+        errors[name.to_sym] = 'fail'
+      end
+
+      def load_module
+        load group_validations_path
+      end
+
+      def include_module
+        self.class.send(:include, GroupValidations)
+      end
+
+      def call_validation_methods
+        GroupValidations.public_instance_methods.each do |method|
+          self.send(method)
+        end
+      end
+
+      def group_validations_present?
+        File.exists?(group_validations_path)
+      end
+
+      def group_validations_path
+        @group_validations_path ||= File.expand_path('group_validations.rb', Dir.pwd)
+      end
+    end
+  end
+end

data/lib/ae_easy/qa/validate_internal.rb

@@ -0,0 +1,92 @@
+module AeEasy
+  module Qa
+    class ValidateInternal
+      attr_reader :scrapers, :rules
+
+      def initialize(config)
+        @scrapers = config['scrapers']
+        @rules = config['individual_validations']
+      end
+
+      def run
+        begin
+          scrapers.each do |scraper_name, collections|
+            ValidateScraper.new(scraper_name, collections, rules).run
+          end
+        rescue StandardError => e
+          puts "An error has occurred: #{e}"
+          return nil
+        end
+      end
+    end
+
+    class ValidateScraper
+      attr_reader :scraper_name, :collections, :rules
+
+      def initialize(scraper_name, collections, rules)
+        @scraper_name = scraper_name
+        @collections = collections
+        @rules = rules
+      end
+
+      def run
+        collections.each do |collection_name|
+          ValidateCollection.new(scraper_name, collection_name, total_records(collection_name), rules).run
+        end
+      end
+
+      private
+
+      def total_records(collection_name)
+        collection_counts.find{|collection_hash| collection_hash['collection'] == collection_name }['count']
+      end
+
+      def collection_counts
+        @collection_counts ||= AnswersEngine::Client::ScraperJobOutput.new.collections(scraper_name)
+      end
+    end
+
+    class ValidateCollection
+      attr_reader :scraper_name, :collection_name, :total_records, :rules, :errors
+
+      def initialize(scraper_name, collection_name, total_records, rules)
+        @scraper_name = scraper_name
+        @collection_name = collection_name
+        @total_records = total_records
+        @rules = rules
+        @errors = { errored_items: [] }
+      end
+
+      def run
+        ValidateGroups.new(data, errors).run
+        #could create the errors hash inside ValidateRules?
+        #errors = ValidateRules.new(data, config).run
+        ValidateRules.new(data, errors, rules).run
+        #should have a class that saves the output and the summary output
+        #SaveOutput.new(errors, output_collection_name).run
+      end
+
+      private
+
+      def output_collection_name
+        @output_collection_name ||= "#{scraper_name}_#{collection_name}"
+      end
+
+      def data
+        @data ||= begin
+                    data = []
+                    page = 1
+                    while data.count < total_records
+                      records = AnswersEngine::Client::ScraperJobOutput.new(per_page:500, page: page).all(scraper_name, collection_name).parsed_response
+                      records.each do |record|
+                        data << record
+                      end
+                      page += 1
+                    end
+                    data
+                  end
+      end
+
+    end
+  end
+end

data/lib/ae_easy/qa/validate_rules.rb

@@ -9,7 +9,7 @@ module AeEasy
       def initialize(data, errors, rules)
         @data = data
         @errors = errors
-        @rules = rules['individual_validations']
+        @rules = rules
       end
 
       def run
@@ -22,31 +22,40 @@ module AeEasy
         data.each do |data_hash|
           reset_errored_item
           rules.each{|field_to_validate, options|
-            options.each{|validation, value|
-              case validation
-              when 'required'
-                required_check(data_hash, field_to_validate) if value == true
-              when 'type'
-                ValidateType.new(data_hash, field_to_validate, value, rules, errored_item).run if options['required']
-              when 'value'
-                ValidateValue.new(data_hash, field_to_validate, value, errored_item).run if options['required']
-              when 'length'
-                validate_length(data_hash, field_to_validate, value) if options['required']
-              else
-                unknown_validation_error(validation) if validation !~ /format/
-              end
-            }
+            if passes_required_check?(options, data_hash, field_to_validate)
+              options.each{|validation, value|
+                case validation
+                when 'type'
+                  ValidateType.new(data_hash, field_to_validate, value, rules, errored_item).run if options['required']
+                when 'value'
+                  ValidateValue.new(data_hash, field_to_validate, value, errored_item).run if options['required']
+                when 'length'
+                  validate_length(data_hash, field_to_validate, value) if options['required']
+                when 'required'
+                  nil
+                else
+                  unknown_validation_error(validation) if validation !~ /format/
+                end
+              }
+            end
           }
           errors[:errored_items].push(errored_item) if errored_item && !errored_item[:failures].empty?
         end
       end
 
-      def required_check(data_hash, field_to_validate)
-        if data_hash[field_to_validate].nil? || (data_hash[field_to_validate].class == String && data_hash[field_to_validate].empty?)
+      def passes_required_check?(options, data_hash, field_to_validate)
+        if options['required'] == true && fails_required_check?(data_hash, field_to_validate)
           add_errored_item(data_hash, field_to_validate, 'required')
+          false
+        else
+          true
         end
       end
 
+      def fails_required_check?(data_hash, field_to_validate)
+        data_hash[field_to_validate].nil? || (data_hash[field_to_validate].class == String && data_hash[field_to_validate].empty?)
+      end
+
       def validate_length(data_hash, field_to_validate, length)
         add_errored_item(data_hash, field_to_validate, 'length') if data_hash[field_to_validate].to_s.length != length
       end

data/lib/ae_easy/qa/validate_type.rb

@@ -24,9 +24,9 @@ module AeEasy
         when 'String'
           add_errored_item(data_hash, field_to_validate, 'type') if data_hash[field_to_validate].class != String
         when 'Integer'
-          add_errored_item(data_hash, field_to_validate, 'type') unless data_hash[field_to_validate].class == Fixnum || data_hash[field_to_validate].to_s.strip =~ /\A\d+(\.\d+)?\z/
+          add_errored_item(data_hash, field_to_validate, 'type') unless data_hash[field_to_validate].class == Fixnum || data_hash[field_to_validate].to_s.strip =~ /\A\d+(\,\d+)?(\.\d+)?\z/
         when 'Float'
-          add_errored_item(data_hash, field_to_validate, 'type') unless data_hash[field_to_validate].class == Float || data_hash[field_to_validate].to_s.strip =~ /\A\d+(\.\d+)?\z/
+          add_errored_item(data_hash, field_to_validate, 'type') unless data_hash[field_to_validate].class == Float || data_hash[field_to_validate].to_s.strip =~ /\A\d+(\,\d+)?(\.\d+)?\z/
         when 'Date'
           validate_date_type
         when 'Url'

data/lib/ae_easy/qa/version.rb

@@ -1,5 +1,5 @@
 module AeEasy
   module Qa
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/lib/ae_easy/qa.rb

@@ -1,36 +1,38 @@
 require 'ae_easy/qa/helpers'
 require 'ae_easy/qa/version'
+require 'ae_easy/qa/validate_internal'
+require 'ae_easy/qa/validate_external'
 require 'ae_easy/qa/validate_rules'
 require 'ae_easy/qa/validate_type'
 require 'ae_easy/qa/validate_value'
+require 'ae_easy/qa/validate_groups'
+require 'answersengine'
 require 'time'
 
 module AeEasy
   module Qa
-    class Validate
-      attr_accessor :rules
+    class Validator
+      attr_accessor :config
       attr_reader :data, :errors
 
-      def initialize(data, options={})
-        load_rules
+      def initialize(data=nil, options={})
+        load_config
         @data = data
         @errors = { errored_items: [] }
       end
 
-      def run
-        begin
-          ValidateRules.new(data, errors, rules).run if rules
-          return errors
-        rescue StandardError => e
-          puts "An error has occurred: #{e}"
-          return nil
-        end
+      def validate_internal
+        ValidateInternal.new(config).run
+      end
+
+      def validate_external
+        ValidateExternal.new(data, errors, config).run
       end
 
       private
 
-      def load_rules
-        self.rules = YAML.load(File.open(config_path))['qa'] if File.exists?(config_path)
+      def load_config
+        self.config = YAML.load(File.open(config_path))['qa'] if File.exists?(config_path)
       end
 
       def config_path

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: ae_easy-qa
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - David Lynam
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-11 00:00:00.000000000 Z
+date: 2019-06-14 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: answersengine
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -64,6 +78,9 @@ files:
 - bin/setup
 - lib/ae_easy/qa.rb
 - lib/ae_easy/qa/helpers.rb
+- lib/ae_easy/qa/validate_external.rb
+- lib/ae_easy/qa/validate_groups.rb
+- lib/ae_easy/qa/validate_internal.rb
 - lib/ae_easy/qa/validate_rules.rb
 - lib/ae_easy/qa/validate_type.rb
 - lib/ae_easy/qa/validate_value.rb