adzerk 0.12 → 0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f22414a06756a78f2e6d8ee07568be6e99ba7a91
-  data.tar.gz: 1674c74ef8ce38b9e307eb51897c18c396eccea6
+  metadata.gz: 45256e26c1df6bc024eb079d454aa60403c11578
+  data.tar.gz: 3ee03c68d83208ff84b71a2331b15041ba822b56
 SHA512:
-  metadata.gz: b959885a659a94db14a5ea8e520314cc18f20bada0c7f1d005e05b974c35aeb963df396d190ea648509ddcbfc951532eaa2d56743ca15e40b806b5bf16286d5d
-  data.tar.gz: a65125e6343526b18933b7fe547a59118305472f486d73edc13643a7cb35ffab5eb1ba3c9a0e6a8d34ac1cf94a0acdd2561d5be8741f64da40b953a9f29d9717
+  metadata.gz: f3e19e1997bdfe16fa887c5834716de82fcddc76b47f86e4d7af7f3f51690ce105e95f76d7e88be4fed3446642792115e4819963d4b167cf1b4741e5f885f6e5
+  data.tar.gz: 23fe705e697ca32fc9ebc3dc1c5ef5162fd5921ae7c6c8b58c8051e2358d7fdc2b5e3f94801cc1bb93f68689980bd5e62c6f9d6fe2125393d73f5e29922e17bc

data/lib/adzerk/client.rb

@@ -85,7 +85,8 @@ module Adzerk
       response = http.request(request)
       if response.kind_of? Net::HTTPClientError
         error_response = JSON.parse(response.body)
-        raise Adzerk::ApiError.new(error_response["message"])
+        msg = error_response["message"] || error_response["Error"]
+        raise Adzerk::ApiError.new(msg)
       end
       response
     end

data/lib/adzerk/version.rb

@@ -1,3 +1,3 @@
 module Adzerk
-  VERSION = "0.12"
+  VERSION = "0.13"
 end

data/test/campaign_api_spec.rb

@@ -154,7 +154,9 @@ describe "Campaign API" do
     }
 
     expect{ @campaigns.create(new_campaign) }.to raise_error("This advertiser is not part of your network")
+  end
 
+  it "should not update a campaign with a new advertiserId" do
     updated_campaign = {
       :id => $campaign_id,
       :name => 'Test campaign ' + rand(1000000).to_s,
@@ -167,7 +169,7 @@ describe "Campaign API" do
       :is_deleted => false
     }
 
-    expect{ @campaigns.update(updated_campaign) }.to raise_error("This advertiser is not part of your network")
+    expect{ @campaigns.update(updated_campaign) }.to raise_error("This campaign belongs to advertiser #{$advertiserId}; a different advertiser cannot be specified.")
   end
 
   it "should not retrieve a campaign with a advertiserId that doesn't belong to it" do

data/test/login_api_spec.rb

@@ -1,5 +1,9 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
+def random_email
+  "test@email-#{rand(1000000)}.com"
+end
+
 describe "Login_API" do
 
   before do
@@ -7,13 +11,14 @@ describe "Login_API" do
   end
 
   it "should create a new login" do
-    email = "test@email_#{rand(1000000)}.com"
+    email = random_email()
     login = @logins.create(:email => email,
                            :password => '1234567',
                            :name => "John Doe")
     $login_id = login[:id]
     expect(login[:email]).to eq(email)
-    expect(login[:password]).to eq("1234567")
+    # Password is redacted in the response.
+    expect(login[:password]).to eq("")
     expect(login[:name]).to eq("John Doe")
   end
 
@@ -28,9 +33,12 @@ describe "Login_API" do
   end
 
   it "should update a login" do
+    new_email = random_email()
     login = @logins.update(:id => $login_id,
-                           :name => "New Name")
+                           :name => "New Name",
+                           :email => new_email)
     expect(login[:name]).to eq("New Name")
+    expect(login[:email]).to eq(new_email)
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adzerk
 version: !ruby/object:Gem::Version
-  version: '0.12'
+  version: '0.13'
 platform: ruby
 authors:
 - Kacy Fortner
@@ -17,7 +17,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-14 00:00:00.000000000 Z
+date: 2017-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -81,14 +81,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '5.1'
 description: Ruby library for the Adzerk API
 email: engineering@adzerk.com
 executables: []