adyen_jpiqueras 2.4.0 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 05bd483db66cada29259292de71f385a2c54345a
-  data.tar.gz: ac777c6f970f2b311ce3bd4d3798eace00b0d357
+  metadata.gz: b5139ac00936797e1f84aefb6a162168a81e310a
+  data.tar.gz: 0f8eb991c5e19cd5e5b76997ccd476fe0b788041
 SHA512:
-  metadata.gz: c118178acf9a176f816c06fb831ba622656d0f99f611a62ada157422a76fcac23e2e16c6a6d5b78ebf0c0ebc737b450a4cf46076d2b1aa45903c1f055ce44b21
-  data.tar.gz: 5131df70714f73087622423e4cc206412e5ab49abc53e5f61f060b1df9462ea796c84d60c72a0d3d15282889c52c0bf9b5a8ac90e0cde522b4cf31214fe1b811
+  metadata.gz: 9276098701eee8a3f7d17fea9c9a0232aa123a320bb830fc0b757d1b0e2910d2217e59b428666567c0ddc6ff8103a95d6d48c5f37f7b2106f7b14c3d235ac011
+  data.tar.gz: 116b47ff94bb0b875d816d1b738dfca7ea993bc2f1d98634dfa64400d590925fc334f748af396d7951c74d74a195ff1e88c65feab0edce6bb96e4e64505f2932

data/CHANGELOG.md

@@ -6,6 +6,18 @@ The following changes have been made to the library over the years. Pleae add an
 
 Nothing yet!
 
+#### Version 2.5.0
+
+- Add ThirdParty methods for Payout API
+
+#### Version 2.4.0
+
+- Fix error handling
+
+#### Version 2.3.0
+
+- Add Payouts API support
+
 #### Version 2.2.0
 
 - Add `Adyen::HPP` to integrate with Adyen's Hosted Payment Pages. `Adyen::HPP` supports the new HMAC-256 signing mechanism. `Adyen::Form` should be considered deprecated and will be removed from a future release.

data/adyen_jpiqueras.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
   EOS
 
   s.authors  = ['Willem van Bergen', 'Michel Barbosa', 'Stefan Borsje', 'Eloy Durán', 'Jordi Piqueras']
-  s.email    = ['willem@vanbergen.org', 'cicaboo@gmail.com', 'mail@sborsje.nl', 'eloy.de.enige@gmail.com', 'jordi.piqueras@helpling.net']
+  s.email    = ['willem@vanbergen.org', 'cicaboo@gmail.com', 'mail@sborsje.nl', 'eloy.de.enige@gmail.com', 'jordi.piqueras@helpling.com']
   s.homepage = 'http://github.com/wvanbergen/adyen/wiki'
   s.license  = 'MIT'
 

data/lib/adyen/rest/client.rb

@@ -109,7 +109,7 @@ module Adyen
         when Net::HTTPUnauthorized
           raise Adyen::REST::Error.new("Webservice credentials are incorrect")
         else
-          raise Adyen::REST::Error.new("Unexpected HTTP response code: #{response.code} | response body: #{response.body}")
+          raise Adyen::REST::Error.new("Unexpected HTTP response code: #{response.code} | request path: #{request.path} | response body: #{response.body}")
         end
       end
 

data/lib/adyen/rest/payout.rb

@@ -5,6 +5,11 @@ module Adyen
     # https://docs.adyen.com/developers/payout-manual
     module Payout
       class Request < Adyen::REST::Request
+        protected
+
+        def base_path
+          '/pal/servlet/%s/v25/%s'
+        end
       end
 
       class Response < Adyen::REST::Response
@@ -60,16 +65,36 @@ module Adyen
         execute_request(request)
       end
 
+      def submit_payout_third_party(attributes = {})
+        request = store_request('Payout.submitThirdParty', attributes)
+        execute_request(request)
+      end
+
+      def submit_and_store_payout_third_party(attributes = {})
+        request = store_request('Payout.storeDetailAndSubmitThirdParty', attributes)
+        execute_request(request)
+      end
+
       def confirm_payout(attributes = {})
         request = review_request('Payout.confirm', attributes)
         execute_request(request)
       end
 
+      def confirm_payout_third_party(attributes = {})
+        request = review_request('Payout.confirmThirdParty', attributes)
+        execute_request(request)
+      end
+
       def decline_payout(attributes = {})
         request = review_request('Payout.decline', attributes)
         execute_request(request)
       end
 
+      def decline_payout_third_party(attributes = {})
+        request = review_request('Payout.declineThirdParty', attributes)
+        execute_request(request)
+      end
+
       private
       # Require you to use a client initialize with payout_store
       def store_request(action, attributes)

data/lib/adyen/rest/request.rb

@@ -93,12 +93,12 @@ module Adyen
       end
 
       def generate_path(action)
-        PATH % action.split('.')
+        base_path % action.split('.')
       end
 
-      # @see Adyen::REST::Request#set_path
-      PATH = '/pal/servlet/%s/v12/%s'
-      private_constant :PATH
+      def base_path
+        '/pal/servlet/%s/v12/%s'
+      end
     end
   end
 end

data/lib/adyen/version.rb

@@ -1,5 +1,5 @@
 module Adyen
   # Version constant for the Adyen plugin.
   # Set it & commit the change before running rake release.
-  VERSION = "2.4.0"
+  VERSION = '2.5.0'
 end

data/test/functional/payout_api_test.rb

@@ -8,6 +8,7 @@ class PayoutAPITest < Minitest::Test
       'storePayout@Company.VanBergen',
       'xxWWcc'
     )
+    @merchant_account = 'VanBergenORG'
   end
 
   def teardown
@@ -16,7 +17,7 @@ class PayoutAPITest < Minitest::Test
 
   def test_submit_and_store_request
     response = @client.submit_and_store_payout(
-      merchantAccount: 'VanBergenORG',
+      merchantAccount: @merchant_account,
       amount: { currency: 'EUR', value: 20},
       bank: { iban: 'NL48RABO0132394782', bankName: 'Rabobank', countryCode: 'NL', ownerName: 'Test shopper' },
       recurring: { contract: 'PAYOUT' },
@@ -29,9 +30,32 @@ class PayoutAPITest < Minitest::Test
     assert response.psp_reference
   end
 
+  def test_submit_and_store_third_party_request
+    response = @client.submit_and_store_payout_third_party(
+      merchantAccount: @merchant_account,
+      amount: { currency: 'EUR', value: 20},
+      bank: { iban: 'NL48RABO0132394782', bankName: 'Rabobank', countryCode: 'NL', ownerName: 'Test shopper' },
+      recurring: { contract: 'PAYOUT' },
+      reference: 'PayoutPayment-0001',
+      shopperEmail: 'shopper@example.com',
+      shopperReference: 'ShopperFoo',
+      entityType: 'NaturalPerson',
+      shoppername: {
+        firstname: 'John',
+        gender: 'MALE',
+        lastname: 'Doe',
+      },
+      nationality: 'NL',
+      dateOfBirth: '1980-01-01',
+    )
+
+    assert response.received?
+    assert response.psp_reference
+  end
+
   def test_store_request
     response = @client.store_payout(
-      merchantAccount: 'VanBergenORG',
+      merchantAccount: @merchant_account,
       bank: { iban: 'NL48RABO0132394782', bankName: 'Rabobank', countryCode: 'NL', ownerName: 'Test shopper' },
       recurring: { contract: 'PAYOUT' },
       shopperEmail: 'shopper@example.com',
@@ -44,7 +68,7 @@ class PayoutAPITest < Minitest::Test
 
   def test_submit_request
     response = @client.submit_payout(
-      merchantAccount: 'VanBergenORG',
+      merchantAccount: @merchant_account,
       amount: { currency: 'EUR', value: 20 },
       recurring: { contract: 'PAYOUT' },
       reference: 'PayoutPayment-0001',
@@ -56,6 +80,29 @@ class PayoutAPITest < Minitest::Test
     assert response.received?
     assert response.psp_reference
   end
+
+  def test_submit_third_party_request
+    response = @client.submit_payout_third_party(
+      merchantAccount: @merchant_account,
+      amount: { currency: 'EUR', value: 20 },
+      recurring: { contract: 'PAYOUT' },
+      reference: 'PayoutPayment-0001',
+      shopperEmail: 'shopper@example.com',
+      shopperReference: 'ShopperFoo',
+      selectedRecurringDetailReference: 'LATEST',
+      entityType: 'NaturalPerson',
+      shoppername: {
+        firstname: 'John',
+        gender: 'MALE',
+        lastname: 'Doe',
+      },
+      nationality: 'NL',
+      dateOfBirth: '1980-01-01',
+    )
+
+    assert response.received?
+    assert response.psp_reference
+  end
 end
 
 class PayoutReviewTest < Minitest::Test
@@ -65,6 +112,7 @@ class PayoutReviewTest < Minitest::Test
       'reviewPayout@Company.VanBergen',
       'ssWWcc'
     )
+    @merchant_account = 'VanBergenORG'
   end
 
   def teardown
@@ -73,7 +121,17 @@ class PayoutReviewTest < Minitest::Test
 
   def test_confirm_payout
     response = @client.confirm_payout(
-      merchantAccount: 'VanBergenORG',
+      merchantAccount: @merchant_account,
+      originalReference: '1234'
+    )
+
+    assert response.confirmed?
+    assert response.psp_reference
+  end
+
+  def test_confirm_payout_third_party
+    response = @client.confirm_payout_third_party(
+      merchantAccount: @merchant_account,
       originalReference: '1234'
     )
 
@@ -83,7 +141,17 @@ class PayoutReviewTest < Minitest::Test
 
   def test_decline_payout
     response = @client.decline_payout(
-      merchantAccount: 'VanBergenORG',
+      merchantAccount: @merchant_account,
+      originalReference: '1234'
+    )
+
+    assert response.declined?
+    assert response.psp_reference
+  end
+
+  def test_decline_payout_third_party
+    response = @client.decline_payout_third_party(
+      merchantAccount: @merchant_account,
       originalReference: '1234'
     )
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adyen_jpiqueras
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.0
 platform: ruby
 authors:
 - Willem van Bergen
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-05 00:00:00.000000000 Z
+date: 2017-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -143,7 +143,7 @@ email:
 - cicaboo@gmail.com
 - mail@sborsje.nl
 - eloy.de.enige@gmail.com
-- jordi.piqueras@helpling.net
+- jordi.piqueras@helpling.com
 executables: []
 extensions: []
 extra_rdoc_files:
@@ -264,7 +264,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Having Nokogiri installed will speed up XML handling when using the SOAP API.
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Integrate Adyen payment services in your Ruby on Rails application.