adyen-cse-ruby 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 782ff730d1ac1d0476cba0dbefc6be067b728b1b
-  data.tar.gz: 7bbce7b21d58a8036efae5332882cdd4ccf4a6ae
+  metadata.gz: ea59b9c101cd2d69299eb6b7168322331278de2f
+  data.tar.gz: e4eb587d6b0f8a22ac149856bf992edea4e9208e
 SHA512:
-  metadata.gz: e191247e97b161da4d1eef3cc24c319a10118d6ec38b8b1bca29634d5957120447f47944dcdd13417390b93bd230fc81896d0434f84a2c0c058d3acb701a2c2f
-  data.tar.gz: 08aab6a28c4aa756ae744af7a3493e469a5461c8aa0535a22603bb15b1a2e66743dff1313e49cebf7484b830fbfc99267211bcf114c5120d02d9a037ebe4c4f7
+  metadata.gz: b26b614a9a9489605a62700a02e5e821998cbf1fca20bc028fa77b46bb4edc3fffe85e9e7f2aaaf9a520609112479777762517f4f6938b7c44991a68e84085fd
+  data.tar.gz: 15957fd799f9c946a7d76d8a88f6b03f41a7911fa3e19ca0951ff7503366579dac9c449cc4317da320c48bb895dc915631b53aad764e9a22277da33608c723c2

data/Gemfile

@@ -3,7 +3,7 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in adyen_cse_ruby.gemspec
 gemspec
 
-gem "openssl-ccm"
+gem "openssl-ccm", git: "https://github.com/jooeycheng/openssl-ccm", branch: "update-cipher-validation"
 
 group :development do
   gem "pry"

data/README.md

@@ -1,4 +1,6 @@
+[![Gem Version](https://badge.fury.io/rb/adyen-cse-ruby.svg)](https://badge.fury.io/rb/adyen-cse-ruby)
 [![Build Status](https://travis-ci.org/jooeycheng/adyen-cse-ruby.svg?branch=master)](https://travis-ci.org/jooeycheng/adyen-cse-ruby)
+[![](https://api.codeclimate.com/v1/badges/ac46c6f16792ed094d7f/maintainability)](https://codeclimate.com/github/jooeycheng/adyen-cse-ruby/maintainability)
 
 # Adyen CSE for Ruby
 
@@ -24,6 +26,10 @@ Or install it yourself as:
 
     $ gem install adyen-cse-ruby
 
+## Known issue
+
+If you are facing error `OpenSSL::CCMError: unsupported cipher algorithm (AES)`, refer to [issue #11](https://github.com/jooeycheng/adyen-cse-ruby/issues/11).
+
 ## Usage
 
 ```ruby
@@ -58,7 +64,9 @@ Example of an `:adyen_test_card` factory with [factory_bot](https://github.com/t
 require 'adyen_cse'
 
 class AdyenTestCard
-  attr_reader :holder_name, :number, :expiry_month, :expiry_year, :cvc, :nonce
+  attr_reader :holder_name, :number, :expiry_month, :expiry_year, :cvc
+
+  PUBLIC_KEY = "your_public_key_here"
 
   def initialize(params = {})
     @holder_name  = params[:holder_name]
@@ -66,30 +74,30 @@ class AdyenTestCard
     @expiry_month = params[:expiry_month]
     @expiry_year  = params[:expiry_year]
     @cvc          = params[:cvc]
-    @nonce        = params[:nonce]
   end
 
-  def self.public_key
-    "your_public_key_here"
+  def nonce
+    AdyenCse::Encrypter.new(PUBLIC_KEY).encrypt!(
+      holder_name: holder_name,
+      number: number,
+      expiry_month: expiry_month,
+      expiry_year: expiry_year,
+      cvc: cvc
+    )
   end
 end
 
 FactoryBot.define do
   factory :adyen_test_card do
     sequence(:holder_name) { |n| "Shopper #{n}" }
-    number { 4111_1111_1111_1111.to_s }
     expiry_month { '08' }
     expiry_year { '2018' }
     cvc { '737' }
 
-    nonce do
-      AdyenCse::Encrypter.new(AdyenTestCard.public_key).encrypt!(
-        holder_name: holder_name,
-        number: number,
-        expiry_month: expiry_month,
-        expiry_year: expiry_year,
-        cvc: cvc
-      )
+    visa
+
+    trait :visa do
+      number { 4111_1111_1111_1111.to_s }
     end
 
     trait :mastercard do

data/adyen-cse-ruby.gemspec

@@ -21,7 +21,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "openssl-ccm", "~> 1.2.1"
+  # Temporary disabled until https://github.com/SmallLars/openssl-ccm/pull/4 is patched.
+  # spec.add_runtime_dependency "openssl-ccm"
 
   spec.add_development_dependency "bundler", "~> 1.14"
   spec.add_development_dependency "rake", "~> 10.0"

data/lib/adyen_cse/version.rb

@@ -1,3 +1,3 @@
 module AdyenCse
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: adyen-cse-ruby
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Joey Cheng
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-06-22 00:00:00.000000000 Z
+date: 2019-01-03 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: openssl-ccm
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.2.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.2.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement