advisor 0.2.1 → 0.3.0.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd0bff4c56325afe9169e9a9e6846f39a5b5050d
-  data.tar.gz: 7ed6cd9a3a9e940ae3c62b216da94c333b7910be
+  metadata.gz: d2470ec31f434a00b661314a334584b9749007f7
+  data.tar.gz: d3943ae3457133660cec580e15d5244e563dcaab
 SHA512:
-  metadata.gz: d2d760a6c6ee40363b916cb8233b488a0bfae01a021836695a6801e736751fcfd34106b93f49afdcc5f1dfc8e06fcb2402372a15f0182cb3b5e397c44a2e92dd
-  data.tar.gz: 1d33b22f3299bc1176a536771bcdcec3f756c4b389cc7bbdba6513c8519daeab17fb28758de33c861d9816b69305251d376cedb5ca91a210ada34e99e55b2e86
+  metadata.gz: 133f2ee3eb5042bbc0ddf0448e7b9389ec1af136dd4fb680cf2a940235739890cd28bf648cfc26b9428da389ce18de5a3714056599f695e1e4ae67132bab543c
+  data.tar.gz: 93960c7d757c8179afcbd2997682a10fe9c43e57e184b9719b8ee0a5631d6007e3226c014e1d432926eaa681f7eeaa0e5d0038071931e0bf1dd857b1fd1e499b

data/lib/advisor/advices/metriks.rb

@@ -4,23 +4,17 @@ require 'metriks'
 module Advisor
   module Advices
     class Metriks
-      class << self
-        attr_accessor :default_logger
-      end
-      self.default_logger = Logger.new(STDOUT)
-
       def initialize(object, method, _call_args, **opts)
         @object = object
         @method = method
 
         @instruments = Array(opts.fetch(:with)).uniq
-        @logger = opts[:logger] || Metriks.default_logger
 
         fail 'No instruments defined' if instruments.empty?
         fail 'Unknown Instrument' unless instruments.all?(&known_instrument?)
       end
 
-      attr_reader :object, :method, :logger, :instruments
+      attr_reader :object, :method, :instruments
 
       INSTRUMENTS = [
         :counter, :timer, :gauge, :call_meter, :result_meter
@@ -32,10 +26,8 @@ module Advisor
 
       def call
         result = timed? ? timer.time { yield } : yield
-        result.tap { instruments.each(&measure(result)) }
-      rescue => e
-        logger.warn(e)
-        raise
+      ensure
+        instruments.each(&measure(result))
       end
 
       private

data/lib/advisor/version.rb

@@ -1,3 +1,3 @@
 module Advisor
-  VERSION = '0.2.1'
+  VERSION = '0.3.0.pre'
 end

data/spec/advisor/advices/metriks_spec.rb

@@ -170,6 +170,46 @@ module Advisor
 
           it_behaves_like 'instruments && measuring'
         end
+
+        context 'when the block throws an exception' do
+          let(:block) { -> { fail 'i be error' } }
+
+          let(:instruments) { %i(gauge timer counter) }
+
+          it 'raises the error raised when yielding the block' do
+            expect { call }.to raise_error(RuntimeError, 'i be error')
+          end
+
+          it 'times the method call' do
+            expect(::Metriks).to receive(:timer)
+              .with('OpenStruct#the_force_awakens_timer')
+              .and_call_original
+
+            expect { call }.to raise_error
+          end
+
+          it 'does measure the execution with a nil result' do
+            expect(advice).to receive(:measure)
+              .with(nil)
+              .once
+
+            expect { call }.to raise_error
+          end
+
+          it 'does not measure with a gauge' do
+            expect(::Metriks).not_to receive(:gauge)
+
+            expect { call }.to raise_error
+          end
+
+          it 'does increment the counter' do
+            expect(::Metriks).to receive(:counter)
+              .with('OpenStruct#the_force_awakens_counter')
+              .and_call_original
+
+            expect { call }.to raise_error
+          end
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: advisor
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0.pre
 platform: ruby
 authors:
 - Renan Ranelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-05 00:00:00.000000000 Z
+date: 2015-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: metriks
@@ -152,9 +152,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2