advisor 0.3.0.pre → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d2470ec31f434a00b661314a334584b9749007f7
-  data.tar.gz: d3943ae3457133660cec580e15d5244e563dcaab
+  metadata.gz: 07274c88a6cc965df236304e2cadec348a89b609
+  data.tar.gz: 7008dc31d29852a09368e9f3add2e84e1dc6c61a
 SHA512:
-  metadata.gz: 133f2ee3eb5042bbc0ddf0448e7b9389ec1af136dd4fb680cf2a940235739890cd28bf648cfc26b9428da389ce18de5a3714056599f695e1e4ae67132bab543c
-  data.tar.gz: 93960c7d757c8179afcbd2997682a10fe9c43e57e184b9719b8ee0a5631d6007e3226c014e1d432926eaa681f7eeaa0e5d0038071931e0bf1dd857b1fd1e499b
+  metadata.gz: 1c3de77e3ba71106ce800367fedf8a49665425b09dc607d243438bd7e3b1e93f1ebd2924f95596567f47d60a5919d327810bcb49527a50d03f0c00de5db9b932
+  data.tar.gz: bddee9a5ae3777933c009f6c8d911ad188142e2132720174a937072151a39e3708e8f2b8680ae620a7dbc60f4c1878163652545a0b9ccb941e170b0d21679dd4

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    advisor (0.2.1)
+    advisor (0.3.0)
       metriks
 
 GEM

data/lib/advisor/advices/call_logger.rb

@@ -5,8 +5,10 @@ module Advisor
     class CallLogger
       class << self
         attr_accessor :default_logger
+        attr_accessor :catch_exception
       end
       self.default_logger = Logger.new(STDOUT)
+      self.catch_exception = false
 
       def initialize(object, method, call_args, **opts)
         @object = object
@@ -24,7 +26,7 @@ module Advisor
       def call
         logger.info(success_message)
         yield
-      rescue => e
+      rescue exception_class => e
         logger.warn(failure_message(e))
         raise
       end
@@ -36,7 +38,8 @@ module Advisor
       end
 
       def failure_message(ex)
-        call_message('Failed: ', "\n#{ex}")
+        backtrace = ["\n", ex.to_s] + ex.backtrace
+        call_message('Failed: ', backtrace.join("\n"))
       end
 
       def call_message(prefix, suffix = '')
@@ -64,6 +67,10 @@ module Advisor
       def id
         "[id=#{object.id}]" if object.respond_to?(:id)
       end
+
+      def exception_class
+        CallLogger.catch_exception ? Exception : StandardError
+      end
     end
   end
 end

data/lib/advisor/version.rb

@@ -1,3 +1,3 @@
 module Advisor
-  VERSION = '0.3.0.pre'
+  VERSION = '0.3.0'
 end

data/spec/advisor/advices/call_logger_spec.rb

@@ -35,24 +35,61 @@ Called: OpenStruct#the_meaning_of_life(\"the universe\", \"and everything\")"
           call
         end
 
-        context 'when yielding the block raises an exception' do
+        context 'when yielding the block raises an error' do
           let(:block) { -> () { fail 'deu ruim!' } }
 
           let(:log_message) do
-            "[Time=#{Time.now}][Thread=#{Thread.current.object_id}][id=42]\
-Failed: OpenStruct#the_meaning_of_life(\"the universe\", \"and everything\")
-deu ruim!"
+            /\[Time=#{Time.now}\]\[Thread=#{Thread.current.object_id}\]\
+\[id=42\]Failed: OpenStruct#the_meaning_of_life\(\"the universe\", \"and\
+ everything\"\).*/
           end
 
-          before { allow(logger).to receive(:warn) }
+          let(:error_message) { /deu ruim!/ }
+
+          let(:catch_exception) { false }
+
+          before do
+            allow(logger).to receive(:warn)
+            allow(CallLogger).to receive(:catch_exception)
+              .and_return(catch_exception)
+          end
 
           it { expect { call }.to raise_error(StandardError, 'deu ruim!') }
 
           it do
             expect(logger).to receive(:warn).with(log_message)
+            expect { call }.to raise_error
+          end
 
+          it do
+            expect(logger).to receive(:warn).with(error_message)
             expect { call }.to raise_error
           end
+
+          context 'when the error is not a StandardError' do
+            let(:block) { -> { fail Exception, 'deu muito ruim!' } }
+
+            let(:error_message) { /deu muito ruim!/ }
+
+            it do
+              expect(logger).not_to receive(:warn).with(log_message)
+              expect { call }.to raise_error(Exception, 'deu muito ruim!')
+            end
+
+            context 'when catching exceptions' do
+              let(:catch_exception) { true }
+
+              it do
+                expect(logger).to receive(:warn).with(log_message)
+                expect { call }.to raise_error(Exception, 'deu muito ruim!')
+              end
+
+              it do
+                expect(logger).to receive(:warn).with(error_message)
+                expect { call }.to raise_error(Exception, 'deu muito ruim!')
+              end
+            end
+          end
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: advisor
 version: !ruby/object:Gem::Version
-  version: 0.3.0.pre
+  version: 0.3.0
 platform: ruby
 authors:
 - Renan Ranelli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-14 00:00:00.000000000 Z
+date: 2015-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: metriks
@@ -152,9 +152,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2