adtech-api-client 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1fcb912aa7ee4606234d686b8617dd57173e790b
-  data.tar.gz: 9c1ecb037ecb94e5f5e077b474f1d9ec7b77d7a6
+  metadata.gz: 803699c7eb36fee26897f2e0eb0b252db5b9a26d
+  data.tar.gz: 47ec42cc91e6ff145aaa45fa6b0c85bb778e5a62
 SHA512:
-  metadata.gz: e964260571d27fe60664ee5729405ebe1cb1663da6f470fcd59b31351ad074907115864a1dde0ac1a013bb666f0d886d902e2f352cb26b106e36486de96dc4b3
-  data.tar.gz: 84067f7591418137a3e54a5b822a47726c715da39f4118468fa9e4c2c70256562b329895c49f9241dde445e3298a99e701ac831294a9b6a2a0ea4362385216fc
+  metadata.gz: 75ab90fad38132ad1acc574929c509a6933d708bedad890d4a0daaed8bc3440eecde4110d9ddd04571dd3523055a1a9fd669e00abcac3ee558f1d33a619f873f
+  data.tar.gz: 9a70715cc124cee805b42554315a0417054ec120c177264468afdef4daa37526cce9a6e4e719a4b244ff3c49bc768b57dba11f7d7e3b05c0ef64d86355e723b1

data/adtech-api-client.gemspec

@@ -2,7 +2,7 @@ $: << File.expand_path('../lib', __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = 'adtech-api-client'
-  s.version     = '0.0.3'
+  s.version     = '0.0.4'
   s.platform    = Gem::Platform::RUBY
   s.authors     = ['minsikzzang', 'ericescalante']
   s.email       = ['min.kim@factorymedia.com', 'eric.escalante@factorymedia.com', 'developers@factorymedia.com']

data/lib/adtech/api/report.rb

@@ -12,18 +12,15 @@ module ADTech
 
         start_cal = gregorian_calendar(start_date.year,
                                        start_date.month - 1,
-                                       start_date.day,
-                                       0, 0, 0)
+                                       start_date.day)
         ADTech.logger.info "Report start date set to: #{start_cal.getTime}";
 
         end_cal = gregorian_calendar(end_date.year,
                                      end_date.month - 1,
-                                     end_date.day,
-                                     23, 59, 59)
+                                     end_date.day)
         ADTech.logger.info "Report end date set to: #{end_cal.getTime}";
 
         entities = default_entities(report.getReportCategory) if !entities || entities.empty?
-
         if entities
           report_queue_entry = report_service.requestReportByEntities(
             report_type_id,
@@ -100,14 +97,14 @@ module ADTech
         end
       end
 
-      def gregorian_calendar(year, month, day, hour, minute, second)
+      def gregorian_calendar(year, month, day)
         cal = GregorianCalendar.getInstance()
         cal.set(Calendar::DAY_OF_MONTH, day)
 		    cal.set(Calendar::MONTH, month)
 		    cal.set(Calendar::YEAR, year)
-		    cal.set(Calendar::HOUR_OF_DAY, hour)
-		    cal.set(Calendar::MINUTE, minute)
-		    cal.set(Calendar::SECOND, second)
+		    cal.set(Calendar::HOUR_OF_DAY, 0)
+		    cal.set(Calendar::MINUTE, 0)
+		    cal.set(Calendar::SECOND, 0)
         cal
       end
 

data/spec/report_spec.rb

@@ -147,16 +147,9 @@ describe ADTech::API::Report do
   end
 
   describe '.gregorian_calendar' do
-    context 'when given time is end of day' do
+    context 'when given time is beginning of day' do
       it 'should return relevant gregorian_calendar object' do
-        cal = @report.send(:gregorian_calendar, 2016, 5, 12, 23, 59, 59)
-        expect(cal.getTime.to_s). to eq('Sun Jun 12 23:59:59 BST 2016')
-      end
-    end
-
-    context 'when given time is beginnig of day' do
-      it 'should return relevant gregorian_calendar object' do
-        cal = @report.send(:gregorian_calendar, 2016, 5, 12, 0, 0, 0)
+        cal = @report.send(:gregorian_calendar, 2016, 5, 12)
         expect(cal.getTime.to_s). to eq('Sun Jun 12 00:00:00 BST 2016')
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adtech-api-client
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - minsikzzang
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-06-23 00:00:00.000000000 Z
+date: 2016-07-06 00:00:00.000000000 Z
 dependencies: []
 description: ADTech Classic API ruby client
 email: