adressevaelger 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39ce3fca5b50b066546e6325522fb11677182fc4cf9a766a6baa138c937e0860
-  data.tar.gz: d01d7d4289c3a52997c744bade5d6c094f398b52547a7135964c06d87774dcc8
+  metadata.gz: 6f38d1dc804e9e0f9f1a8644bbc9acf97b47a7844750d2fed638b507311a3724
+  data.tar.gz: 488b30cba10f238ea3a34b8260da78d1c287a3856a890543bf14a8ba317b673f
 SHA512:
-  metadata.gz: 362d1a947156be0ecf9f8914596388136382e30748fd62289e13eaf05a836584092a9abd70bc86f9bb37a065451699e4ca310c8a0441f7fddcfdefc8d4528226
-  data.tar.gz: 875591926ea41fcfb4ada343652cd567c47a4d43e668f994e853318278a6641196daaececc21921c585fc23dbff357732139d98f6ff44d5d27931acb0c79975f
+  metadata.gz: e84e2680b65699a9f15432d39f40f3296da598133c5a71180a9879c276b24fafecf368c4540daf6207c7af625cb9185612d1e2d1024bdd35bc05448042cb932a
+  data.tar.gz: bd3449f9a7aca184f5d59ed06380e66d68aa41a150f2eb95f0e69f495cd7ee4ec9ddb1a74fd01b825c26b4220e060abef7183b81c0bb71d70079b389a7d35ad9

data/.rubocop.yml

@@ -0,0 +1,55 @@
+plugins:
+  - rubocop-minitest
+  - rubocop-rake
+
+AllCops:
+  NewCops: enable
+  TargetRubyVersion: 3.3
+  SuggestExtensions: false
+  Exclude:
+    - "vendor/**/*"
+    - "tmp/**/*"
+    - "pkg/**/*"
+
+Style/Documentation:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Layout/LineLength:
+  Max: 120
+
+Metrics/MethodLength:
+  Max: 35
+  Exclude:
+    - "test/**/*"
+
+Metrics/ClassLength:
+  Max: 200
+  Exclude:
+    - "test/**/*"
+
+Metrics/AbcSize:
+  Max: 50
+  Exclude:
+    - "test/**/*"
+
+Metrics/CyclomaticComplexity:
+  Max: 25
+  Exclude:
+    - "test/**/*"
+
+Metrics/PerceivedComplexity:
+  Max: 25
+  Exclude:
+    - "test/**/*"
+
+Metrics/BlockLength:
+  Exclude:
+    - "test/**/*"
+    - "*.gemspec"
+    - "Rakefile"
+
+Minitest/MultipleAssertions:
+  Max: 10

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.1.1
+
+- Add RuboCop lint job and shared style config in CI. No public API changes.
+
 ## 0.1.0
 
 - Initial public release: Adressevælger client (`autocomplete` / `search`),

data/README.md

@@ -1,8 +1,7 @@
 # Adressevaelger
 
 Ruby client for Klimadatastyrelsen **Adressevælger** and **Adressevask**
-(Danmarks Adresseregister / DAR). Denmark only — no multi-country router,
-manual entry adapter, or commercial geocoder fallback.
+(Danmarks Adresseregister / DAR).
 
 ## Install
 
@@ -76,6 +75,7 @@ production**. Obtain a proper token via [Dataforsyningen](https://dataforsyninge
 
 ```sh
 bundle exec rake test
+bundle exec rake rubocop
 ```
 
 HTTP integration tests use [VCR](https://github.com/vcr/vcr) cassettes recorded
@@ -88,14 +88,6 @@ VCR_RECORD=all bundle exec rake test TEST=test/client_vcr_test.rb
 
 Never hand-write cassette response bodies.
 
-## Scope
-
-**In:** Adressevælger search/autocomplete, resolve by husnummer/adresse id,
-Adressevask validate, optional PROJ transform.
-
-**Out:** Multi-country routing, Manual adapters, commercial fallback geocoders,
-Rails controllers/Stimulus, CRM persistence helpers.
-
 ## Attribution
 
 Address data via [Dataforsyningen](https://dataforsyningen.dk/) /
@@ -104,8 +96,6 @@ open-source client and is not affiliated with or endorsed by Klimadatastyrelsen.
 
 ## Releasing
 
-Version bumps are intentional — CI does not auto-bump on every `main` push.
-
 1. Bump `Adressevaelger::VERSION` in `lib/adressevaelger/version.rb` (gemspec reads it).
 2. Update `CHANGELOG.md` for that version.
 3. Commit and push to `main`.
@@ -116,27 +106,6 @@ Version bumps are intentional — CI does not auto-bump on every `main` push.
    publishes via [RubyGems Trusted Publishing](https://guides.rubygems.org/trusted-publishing/)
    (`rubygems/release-gem`, OIDC — no `RUBYGEMS_API_KEY` secret).
 
-### One-time RubyGems Trusted Publisher setup
-
-The gem is not on RubyGems yet, so use a **pending** trusted publisher
-(Rasmus must click through the UI; no credentials belong in this repo):
-
-1. Sign in at [rubygems.org](https://rubygems.org/) (MFA on).
-2. Open [Pending trusted publishers](https://rubygems.org/profile/oidc/pending_trusted_publishers).
-3. Click **Create**.
-4. Fill in:
-   - **Gem name:** `adressevaelger`
-   - **Repository owner:** `bergholdt`
-   - **Repository name:** `adressevaelger`
-   - **Workflow filename:** `push_gem.yml`
-   - **Environment name:** `release`
-5. Click **Create Pending trusted publisher**.
-6. In GitHub → repo **Settings → Environments**, create an environment named
-   `release` (no required reviewers needed for a solo maintainer).
-
-After the first successful tag-triggered publish, the pending publisher becomes
-a normal trusted publisher and you own the gem on RubyGems.org.
-
 ## License
 
 MIT. See [LICENSE.txt](LICENSE.txt).

data/adressevaelger.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
 
   spec.files = Dir.chdir(__dir__) do
     `git ls-files -z`.split("\x0").reject do |f|
-      f.start_with?(*%w[bin/ test/ .git .github Gemfile Rakefile])
+      f.start_with?(*%w[bin/ test/ .git .github Gemfile Rakefile AGENTS.md])
     end
   end
   spec.require_paths = ["lib"]

data/lib/adressevaelger/client.rb

@@ -16,13 +16,14 @@ module Adressevaelger
     # this shared demo token for exploration — replace it in production.
     DEFAULT_TOKEN = "adressevaelger123"
     DEFAULT_BASE_URL = "https://adressevaelger.dk"
-    EPSG = 25832
+    EPSG = 25_832
 
     attr_reader :base_url, :token
 
     def initialize(token: nil, base_url: nil, http: nil)
-      @token = present_string(token) || present_string(ENV["ADRESSEVAELGER_TOKEN"]) || DEFAULT_TOKEN
-      @base_url = present_string(base_url) || present_string(ENV["ADRESSEVAELGER_BASE_URL"]) || DEFAULT_BASE_URL
+      @token = present_string(token) || present_string(ENV.fetch("ADRESSEVAELGER_TOKEN", nil)) || DEFAULT_TOKEN
+      @base_url = present_string(base_url) || present_string(ENV.fetch("ADRESSEVAELGER_BASE_URL",
+                                                                       nil)) || DEFAULT_BASE_URL
       @http = http
     end
 
@@ -44,9 +45,9 @@ module Adressevaelger
     # Resolve a husnummer or adresse by DAR id.
     def resolve(id:, type: "husnummer")
       path = case type.to_s
-      when "adresse" then "/adresser/#{id}"
-      else "/husnumre/#{id}"
-      end
+             when "adresse" then "/adresser/#{id}"
+             else "/husnumre/#{id}"
+             end
 
       payload = get_json(path)
       build_resolved(payload, type: type.to_s)
@@ -77,147 +78,147 @@ module Adressevaelger
 
     private
 
-      attr_reader :http
-
-      def build_resolved(payload, type:)
-        data = nested_entity(payload)
-        vejnavn = scalar(pick(data, "vejnavn")) || dig_hash(data, "vejstykke", "navn") || dig_hash(data, "navngivenvej", "vejnavn")
-        husnr = scalar(pick(data, "husnr", "husnummertekst", "husnummer"))
-        postal = scalar(pick(data, "postnr")) || dig_hash(data, "postnummer", "postnr") || dig_hash(data, "postnummer", "nr")
-        city = scalar(pick(data, "postnrnavn", "bynavn")) || dig_hash(data, "postnummer", "navn")
-        etage = scalar(pick(data, "etagebetegnelse", "etage"))
-        doer = scalar(pick(data, "doerbetegnelse", "dør", "doer"))
-
-        point = data["adgangspunkt"] || dig_hash(data, "adgangsadresse", "adgangspunkt") || data["position"]
-        easting, northing = extract_etrs89(point)
-        latitude, longitude = transform_etrs89(easting, northing)
-
-        id = pick(data, "id", "id_lokalid")
-        husnummer_id = pick(data, "husnummer_id", "adgangsadresseid") || (type == "husnummer" ? id : nil)
-        adresse_id = type == "adresse" ? id : pick(data, "adresse_id")
-
-        ResolvedAddress.new(
-          line1: [vejnavn, husnr].compact.reject { |part| blank?(part) }.join(" "),
-          line2: nil,
-          postal_code: postal.to_s,
-          city: city.to_s,
-          country: "DK",
-          etage: etage,
-          doer: doer,
-          address_provider: Adressevaelger::PROVIDER,
-          external_address_id: adresse_id || husnummer_id,
-          external_building_id: husnummer_id,
-          latitude: latitude,
-          longitude: longitude,
-          coord_easting: easting,
-          coord_northing: northing,
-          coord_epsg: easting ? EPSG : nil
-        )
-      end
+    attr_reader :http
+
+    def build_resolved(payload, type:)
+      data = nested_entity(payload)
+      vejnavn = scalar(pick(data,
+                            "vejnavn")) || dig_hash(data, "vejstykke",
+                                                    "navn") || dig_hash(data, "navngivenvej", "vejnavn")
+      husnr = scalar(pick(data, "husnr", "husnummertekst", "husnummer"))
+      postal = scalar(pick(data,
+                           "postnr")) || dig_hash(data, "postnummer", "postnr") || dig_hash(data, "postnummer", "nr")
+      city = scalar(pick(data, "postnrnavn", "bynavn")) || dig_hash(data, "postnummer", "navn")
+      etage = scalar(pick(data, "etagebetegnelse", "etage"))
+      doer = scalar(pick(data, "doerbetegnelse", "dør", "doer"))
+
+      point = data["adgangspunkt"] || dig_hash(data, "adgangsadresse", "adgangspunkt") || data["position"]
+      easting, northing = extract_etrs89(point)
+      latitude, longitude = transform_etrs89(easting, northing)
+
+      id = pick(data, "id", "id_lokalid")
+      husnummer_id = pick(data, "husnummer_id", "adgangsadresseid") || (type == "husnummer" ? id : nil)
+      adresse_id = type == "adresse" ? id : pick(data, "adresse_id")
+
+      ResolvedAddress.new(
+        line1: [vejnavn, husnr].compact.reject { |part| blank?(part) }.join(" "),
+        line2: nil,
+        postal_code: postal.to_s,
+        city: city.to_s,
+        country: "DK",
+        etage: etage,
+        doer: doer,
+        address_provider: Adressevaelger::PROVIDER,
+        external_address_id: adresse_id || husnummer_id,
+        external_building_id: husnummer_id,
+        latitude: latitude,
+        longitude: longitude,
+        coord_easting: easting,
+        coord_northing: northing,
+        coord_epsg: easting ? EPSG : nil
+      )
+    end
 
-      def nested_entity(payload)
-        %w[data husnummer adresse].each do |key|
-          value = payload[key]
-          return value if value.is_a?(Hash)
-        end
-        payload
+    def nested_entity(payload)
+      %w[data husnummer adresse].each do |key|
+        value = payload[key]
+        return value if value.is_a?(Hash)
       end
+      payload
+    end
 
-      def pick(hash, *keys)
-        keys.each do |key|
-          value = hash[key]
-          return value if present?(value)
-        end
-        nil
+    def pick(hash, *keys)
+      keys.each do |key|
+        value = hash[key]
+        return value if present?(value)
       end
+      nil
+    end
 
-      def dig_hash(hash, *keys)
-        return nil unless hash.is_a?(Hash)
-
-        hash.dig(*keys)
-      end
+    def dig_hash(hash, *keys)
+      return nil unless hash.is_a?(Hash)
 
-      def scalar(value)
-        return nil if blank?(value) || value.is_a?(Hash) || value.is_a?(Array)
+      hash.dig(*keys)
+    end
 
-        value
-      end
+    def scalar(value)
+      return nil if blank?(value) || value.is_a?(Hash) || value.is_a?(Array)
 
-      def extract_etrs89(point)
-        return [nil, nil] if blank?(point)
+      value
+    end
 
-        if point.is_a?(Array) && point.size >= 2
-          return [point[0].to_f, point[1].to_f]
-        end
+    def extract_etrs89(point)
+      return [nil, nil] if blank?(point)
 
-        coords = point["koordinater"] || point["coordinates"] || point["position"] || dig_hash(point, "geometri", "coordinates")
-        if coords.is_a?(Array) && coords.size >= 2
-          return [coords[0].to_f, coords[1].to_f]
-        end
-        if coords.is_a?(Hash)
-          easting = coords["x"] || coords["øst"] || coords["oest"] || coords["easting"]
-          northing = coords["y"] || coords["nord"] || coords["northing"]
-          return [easting.to_f, northing.to_f] if present?(easting) && present?(northing)
-        end
+      return [point[0].to_f, point[1].to_f] if point.is_a?(Array) && point.size >= 2
 
-        easting = point["øst"] || point["oest"] || point["easting"] || point["x"]
-        northing = point["nord"] || point["northing"] || point["y"]
-        return [nil, nil] if blank?(easting) || blank?(northing)
+      coords = point["koordinater"] || point["coordinates"] || point["position"] || dig_hash(point, "geometri",
+                                                                                             "coordinates")
+      return [coords[0].to_f, coords[1].to_f] if coords.is_a?(Array) && coords.size >= 2
 
-        [easting.to_f, northing.to_f]
+      if coords.is_a?(Hash)
+        easting = coords["x"] || coords["øst"] || coords["oest"] || coords["easting"]
+        northing = coords["y"] || coords["nord"] || coords["northing"]
+        return [easting.to_f, northing.to_f] if present?(easting) && present?(northing)
       end
 
-      # Wired when optional rgeo-proj4 / PROJ is available; otherwise leave WGS84 nil.
-      def transform_etrs89(easting, northing)
-        return [nil, nil] if easting.nil? || northing.nil?
+      easting = point["øst"] || point["oest"] || point["easting"] || point["x"]
+      northing = point["nord"] || point["northing"] || point["y"]
+      return [nil, nil] if blank?(easting) || blank?(northing)
 
-        Adressevaelger::Etrs89ToWgs84.call(easting: easting, northing: northing) || [nil, nil]
-      end
+      [easting.to_f, northing.to_f]
+    end
+
+    # Wired when optional rgeo-proj4 / PROJ is available; otherwise leave WGS84 nil.
+    def transform_etrs89(easting, northing)
+      return [nil, nil] if easting.nil? || northing.nil?
+
+      Adressevaelger::Etrs89ToWgs84.call(easting: easting, northing: northing) || [nil, nil]
+    end
 
-      def get_json(path, params = {})
-        uri = URI.join("#{base_url}/", path.delete_prefix("/"))
-        query = params.merge(token: token).compact
-        uri.query = URI.encode_www_form(query)
+    def get_json(path, params = {})
+      uri = URI.join("#{base_url}/", path.delete_prefix("/"))
+      query = params.merge(token: token).compact
+      uri.query = URI.encode_www_form(query)
 
-        request = Net::HTTP::Get.new(uri)
-        request["Accept"] = "application/json"
-        request["User-Agent"] = "Adressevaelger/#{VERSION}"
+      request = Net::HTTP::Get.new(uri)
+      request["Accept"] = "application/json"
+      request["User-Agent"] = "Adressevaelger/#{VERSION}"
 
-        response = perform(uri, request)
-        unless response.is_a?(Net::HTTPSuccess)
-          raise ProviderError, "Adressevælger error (#{response.code})"
-        end
+      response = perform(uri, request)
+      raise ProviderError, "Adressevælger error (#{response.code})" unless response.is_a?(Net::HTTPSuccess)
 
+      begin
         JSON.parse(response.body)
       rescue JSON::ParserError
         raise ProviderError, "Adressevælger returned invalid JSON"
       end
+    end
 
-      def perform(uri, request)
-        if http
-          return http.call(uri, request)
-        end
+    def perform(uri, request)
+      return http.call(uri, request) if http
 
-        Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == "https", open_timeout: 5, read_timeout: 10) do |client|
-          client.request(request)
-        end
-      rescue Net::OpenTimeout, Net::ReadTimeout, Errno::ECONNREFUSED, SocketError, Socket::ResolutionError => e
-        raise ProviderError, "Adressevælger unreachable (#{e.class})"
+      Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == "https", open_timeout: 5,
+                                          read_timeout: 10) do |client|
+        client.request(request)
       end
+    rescue Net::OpenTimeout, Net::ReadTimeout, Errno::ECONNREFUSED, SocketError => e
+      raise ProviderError, "Adressevælger unreachable (#{e.class})"
+    end
 
-      def blank?(value)
-        value.nil? || (value.respond_to?(:empty?) && value.empty?) ||
-          (value.is_a?(String) && value.strip.empty?)
-      end
+    def blank?(value)
+      value.nil? || (value.respond_to?(:empty?) && value.empty?) ||
+        (value.is_a?(String) && value.strip.empty?)
+    end
 
-      def present?(value)
-        !blank?(value)
-      end
+    def present?(value)
+      !blank?(value)
+    end
 
-      def present_string(value)
-        return nil if blank?(value)
+    def present_string(value)
+      return nil if blank?(value)
 
-        value.to_s
-      end
+      value.to_s
+    end
   end
 end

data/lib/adressevaelger/error.rb

@@ -1,7 +1,10 @@
 # frozen_string_literal: true
 
 module Adressevaelger
-  Error = Class.new(StandardError)
+  class Error < StandardError
+  end
+
   # Raised when the Adressevælger HTTP API fails, returns invalid JSON, or is unreachable.
-  ProviderError = Class.new(Error)
+  class ProviderError < Error
+  end
 end

data/lib/adressevaelger/etrs89_to_wgs84.rb

@@ -13,7 +13,7 @@ module Adressevaelger
 
       begin
         require "rgeo/proj4"
-        @source = RGeo::CoordSys::Proj4.create(25832)
+        @source = RGeo::CoordSys::Proj4.create(25_832)
         @target = RGeo::CoordSys::Proj4.create(4326)
         @available = true
       rescue LoadError, StandardError

data/lib/adressevaelger/resolved_address.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Adressevaelger
-  # Provider-shaped resolved Danish address (no host-app persistence helpers).
+  # Resolved Danish address from Adressevælger.
   ResolvedAddress = Data.define(
     :line1,
     :line2,

data/lib/adressevaelger/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Adressevaelger
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/adressevaelger.rb

@@ -8,8 +8,5 @@ require_relative "adressevaelger/etrs89_to_wgs84"
 require_relative "adressevaelger/client"
 
 # Ruby client for Klimadatastyrelsen Adressevælger + Adressevask (DAR).
-#
-# Denmark only. Country routing, manual entry, and commercial geocoders belong
-# in the host application.
 module Adressevaelger
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adressevaelger
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Rasmus Bergholdt
@@ -19,6 +19,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".rubocop.yml"
 - CHANGELOG.md
 - LICENSE.txt
 - README.md
@@ -35,8 +36,8 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/bergholdt/adressevaelger
-  source_code_uri: https://github.com/bergholdt/adressevaelger/tree/v0.1.0
-  changelog_uri: https://github.com/bergholdt/adressevaelger/blob/v0.1.0/CHANGELOG.md
+  source_code_uri: https://github.com/bergholdt/adressevaelger/tree/v0.1.1
+  changelog_uri: https://github.com/bergholdt/adressevaelger/blob/v0.1.1/CHANGELOG.md
   bug_tracker_uri: https://github.com/bergholdt/adressevaelger/issues
   rubygems_mfa_required: 'true'
 rdoc_options: []