adp_client 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8a6ecd5572e30c5feaa7651120f6d63fea35a7b5
-  data.tar.gz: b2a37a1d06a87df81eb8af9ca6be6c08fb03efb0
+  metadata.gz: 2d7bed256d54040400945655a49aaf64560eb4df
+  data.tar.gz: 4110d42f1b38e0be2a161cb811c98fe2e18bbcf2
 SHA512:
-  metadata.gz: d223d0315b28890253f319d09c61e135a30ba1b2cb5e35d27f83ddbe22e0ad317f5091605a177b501dc55d49eb6979a6a30a79e9852e8afbf49fd191e6c8efa5
-  data.tar.gz: 7a91c9e7a13c7ec4eab45c62ea5e74428e7970234dc311b08a44467fd7e652ed445cba87ac57017b49ad8ff4e92f2b1235126647f012f9d75d7bcf64f743baab
+  metadata.gz: 20468b2b84388fd2e91b291a5b061abd2f8e60867755c724c5810f68a4ebe140559852cad87364fb0ecb25cfb0ab068711e80f7b53d7293a6d81e2d059e3401d
+  data.tar.gz: c7ef1a0917a05e35085525266c4acf4e77b6946ed7dbd7d66c5c0122c3a30d93f95d63e57ea727dc78db530fbcd01bc7210b855200b8c6fe3e692b9b3b3b3cbf

data/.hound-rubocop.yml

@@ -55,7 +55,6 @@ Style/IfUnlessModifier:
   Description: Favor modifier if/unless usage when you have a single-line body.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier
   Enabled: false
-  MaxLineLength: 80
 Style/OptionHash:
   Description: Don't use option hashes when you can use keyword arguments.
   Enabled: false
@@ -127,8 +126,13 @@ Style/TrailingCommaInArguments:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
   Enabled: true
   EnforcedStyleForMultiline: no_comma
-Style/TrailingCommaInLiteral:
-  Description: 'Checks for trailing comma in array and hash literals.'
+Style/TrailingCommaInArrayLiteral:
+  Description: 'Checks for trailing comma in array literals.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  Enabled: true
+  EnforcedStyleForMultiline: no_comma
+Style/TrailingCommaInHashLiteral:
+  Description: 'Checks for trailing comma in hash literals.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
   Enabled: true
   EnforcedStyleForMultiline: no_comma

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    adp_client (0.1.0)
+    adp_client (1.0.0)
       httparty
 
 GEM
@@ -10,22 +10,26 @@ GEM
     addressable (2.5.2)
       public_suffix (>= 2.0.2, < 4.0)
     ast (2.4.0)
+    concurrent-ruby (1.0.5)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
     docile (1.1.5)
+    faker (1.8.7)
+      i18n (>= 0.7)
     hashdiff (0.3.7)
-    httparty (0.15.6)
+    httparty (0.16.2)
       multi_xml (>= 0.5.2)
+    i18n (1.0.1)
+      concurrent-ruby (~> 1.0)
     json (2.1.0)
     multi_xml (0.6.0)
     parallel (1.12.1)
-    parser (2.4.0.2)
-      ast (~> 2.3)
+    parser (2.5.1.0)
+      ast (~> 2.4.0)
     powerpack (0.1.1)
     public_suffix (3.0.1)
-    rainbow (2.2.2)
-      rake
+    rainbow (3.0.0)
     rake (10.5.0)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)
@@ -42,11 +46,11 @@ GEM
     rspec-support (3.7.1)
     rspec_junit_formatter (0.3.0)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (0.51.0)
+    rubocop (0.54.0)
       parallel (~> 1.10)
-      parser (>= 2.3.3.1, < 3.0)
+      parser (>= 2.5)
       powerpack (~> 0.1)
-      rainbow (>= 2.2.2, < 3.0)
+      rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
     ruby-progressbar (1.9.0)
@@ -56,7 +60,7 @@ GEM
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
-    unicode-display_width (1.3.0)
+    unicode-display_width (1.3.2)
     webmock (3.2.1)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
@@ -68,10 +72,11 @@ PLATFORMS
 DEPENDENCIES
   adp_client!
   bundler (~> 1.16)
+  faker
   rake (~> 10.0)
   rspec (~> 3.0)
   rspec_junit_formatter
-  rubocop (= 0.51.0)
+  rubocop (= 0.54.0)
   simplecov
   webmock
 

data/adp_client.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'adp_client/version'
 
@@ -20,10 +20,11 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
   spec.add_runtime_dependency 'httparty'
   spec.add_development_dependency 'bundler', '~> 1.16'
+  spec.add_development_dependency 'faker'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec_junit_formatter'
-  spec.add_development_dependency 'rubocop', '0.51.0'
+  spec.add_development_dependency 'rubocop', '0.54.0'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'webmock'
 end

data/lib/adp_client.rb

@@ -120,21 +120,48 @@ class AdpClient
   end
 
   ##
-  # Get a resource
-  # Makes a request for a resource from ADP and returns the response as a
-  # raw {Hash}.
+  # Make a delete request.
+  # Makes a request to delete an existing resource from ADP.
   #
   # @param [String] the resource endpoint
-  # @return [Hash] response data
+  # @return [HTTParty::Response] the response
+  def delete(resource)
+    headers = base_headers.merge('Content-Type' => 'application/json')
+    url = "#{@base_url}/#{resource}"
+
+    @logger.debug("DELETE request Url: #{url}")
+    @logger.debug("-- Headers: #{headers}")
+
+    x = HTTParty.delete(url, headers: headers)
+    puts x.inspect
+    x
+  end
+
+  ##
+  # Make a get request
+  # Makes a request for a resource from ADP and returns the full response.
+  #
+  # @param [String] the resource endpoint
+  # @return [HTTParty::Response] the response
   def get(resource)
     url = "#{@base_url}/#{resource}"
 
     @logger.debug("GET request Url: #{url}")
     @logger.debug("-- Headers: #{base_headers}")
 
+    HTTParty.get(url, headers: base_headers)
+  end
+
+  ##
+  # Get a resource
+  # Makes a request for a resource from ADP and returns the response as a
+  # raw {Hash}.
+  #
+  # @param [String] the resource endpoint
+  # @return [Hash] response data
+  def get_resource(resource)
     raises_unless_success do
-      HTTParty
-        .get(url, headers: base_headers)
+      get(resource)
     end.parsed_response
   end
 
@@ -146,7 +173,7 @@ class AdpClient
   # @param [String] the resource endpoint
   # @param [Hash] the resource data
   # @return [Hash] response data
-  def post(resource, data)
+  def post_resource(resource, data)
     headers = base_headers
               .merge('Content-Type' => 'application/json')
     url = "#{@base_url}/#{resource}"
@@ -232,9 +259,9 @@ class AdpClient
   class InvalidRequestHandler < BaseErrorHandler
     def error
       InvalidRequest.new(
-        format('%s: %s',
-               @httparty.parsed_response['error'],
-               @httparty.parsed_response['error_description'])
+        format('%<error>s: %<description>s',
+               error: @httparty.parsed_response['error'],
+               description: @httparty.parsed_response['error_description'])
       )
     end
 
@@ -265,9 +292,9 @@ class AdpClient
   class UnauthorizedHandler < BaseErrorHandler
     def error
       Unauthorized.new(
-        format('%s: %s',
-               @httparty.parsed_response['error'],
-               @httparty.parsed_response['error_description'])
+        format('%<error>s: %<description>s',
+               error: @httparty.parsed_response['error'],
+               description: @httparty.parsed_response['error_description'])
       )
     end
 

data/lib/adp_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class AdpClient
-  VERSION = '0.1.0'
+  VERSION = '1.0.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: adp_client
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Joseph Bridgwater-Rowe
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-01 00:00:00.000000000 Z
+date: 2018-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.16'
+- !ruby/object:Gem::Dependency
+  name: faker
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +100,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.51.0
+        version: 0.54.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.51.0
+        version: 0.54.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement