adomain 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5f6a4fcd3fc144bade4ae7c9c6203282f2bb60263e52b1dbb512e3e2f4aafbdc
-  data.tar.gz: 78f75f9287faa5f86db07e8de720bf2acdc291e7c77a6dca00a980da6d27b691
+  metadata.gz: f12152322fbc0b75e36dcfc4dcc05497cdd16e1f47082949f42ee2af9bebae12
+  data.tar.gz: 2f267c665cb5ec0084a9d4752e57763a95f169b34719b4a478622f39ba5c7ece
 SHA512:
-  metadata.gz: 8e3df07bd32de3879be644a9b2fc82982d0d8bb942f87f0c1c1391384063024675dd8564fe74dcacaaf0c59dd301ecd3cc2b825579136ddf66fa520033b1a326
-  data.tar.gz: 21ff7155943997118c937ae08f7cc4727acafc12024b92c9866f205913210aee6480ad7663cc8df9a0f3c5407171d2ab3e8754083b1b87b057034ad855b89158
+  metadata.gz: c5ad2bed3658959228d70d592ebf9e6d34d3d14a3b928f945e1dfd916ea1f751a32a3c60fb342bff1e1a4385a9b034a97dd877a0e8ea5a3ecc2e6acf6e725d80
+  data.tar.gz: 5a8c239d1972737ecb21d6b15d7e64f4c806933d505f75d289aa42ccd3b34b65ea338d8995ecf65202ff70b9345f8c12be02d3880455f6fdf83857ebfff1169f

data/Gemfile.lock

@@ -1,30 +1,32 @@
 PATH
   remote: .
   specs:
-    adomain (0.1.0)
+    adomain (0.1.1)
       addressable (~> 2.5)
+      logger
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.2)
-      public_suffix (>= 2.0.2, < 4.0)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
     diff-lcs (1.3)
-    public_suffix (3.0.1)
+    logger (1.4.1)
+    public_suffix (4.0.1)
     rake (10.5.0)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
+    rspec (3.8.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+    rspec-core (3.8.2)
+      rspec-support (~> 3.8.0)
+    rspec-expectations (3.8.4)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
+      rspec-support (~> 3.8.0)
+    rspec-mocks (3.8.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.1)
+      rspec-support (~> 3.8.0)
+    rspec-support (3.8.2)
 
 PLATFORMS
   ruby
@@ -36,4 +38,4 @@ DEPENDENCIES
   rspec (~> 3.0)
 
 BUNDLED WITH
-   1.16.1
+   1.16.6

data/README.md

@@ -57,6 +57,20 @@ Adomain["hola"]     # => nil
 Adomain["::::::::"] # => nil
 Adomain[""]         # => Addressable::URI::InvalidURIError
 Adomain["{}"]       # => Addressable::URI::InvalidURIError
+Gem::Version.new(Adomain::VERSION) >= Gem::Version.new(0.2) # => false
+```
+
+#### WARNING: All InvalidURIError will be caught in >= version 0.2
+
+When 0.2 is released, `Addressable::URI::InvalidURIError`s will be caught
+and ignored. Nil will be returned.
+
+```ruby
+Gem::Version.new(Adomain::VERSION) >= Gem::Version.new(0.2) # => true
+Adomain["hola"]     # => nil
+Adomain["::::::::"] # => nil
+Adomain[""]         # => nil
+Adomain["{}"]       # => nil
 ```
 
 ## Installation

data/adomain.gemspec

@@ -25,4 +25,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.0"
 
   spec.add_dependency "addressable", "~> 2.5"
+  spec.add_dependency "logger"
 end

data/lib/adomain.rb

@@ -1,8 +1,17 @@
 require "adomain/version"
 require "addressable/uri"
+require "logger"
 
 class Adomain
   class << self
+
+    ADDRESSABLE_WARNING = %{
+      WARNING: breaking change planned:
+        Adomain will catch Addressable::URI::InvalidURIError.
+        This error will be caught in version 0.2.
+        Any code relying on the error will break.
+    }.gsub(/\s+/, ' ').strip
+
     # [] is a convenience method to subdomain the URL,
     # or optionally domain or subdomain_www.
     #   Adomain["http://abc.xyz.com"]               # => "abc.xyz.com"
@@ -75,6 +84,14 @@ class Adomain
         domain ||= uri.host
 
         return domain
+      rescue Addressable::URI::InvalidURIError => e
+        logger.warn ADDRESSABLE_WARNING
+
+        raise e
       end
+
+      def logger
+        @logger ||= defined?(Rails) ? Rails.logger : Logger.new(STDOUT)
+      end # https://stackoverflow.com/a/30623846/1651458
   end
 end

data/lib/adomain/version.rb

@@ -1,3 +1,3 @@
 class Adomain
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: adomain
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Sam Nissen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-15 00:00:00.000000000 Z
+date: 2019-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.5'
+- !ruby/object:Gem::Dependency
+  name: logger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - scnissen@gmail.com
@@ -107,7 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 2.7.10
 signing_key: 
 specification_version: 4
 summary: Simple, uncomplicated, schemed domain parsing using Addressable