adlint 1.8.2 → 1.8.10

data/ChangeLog

@@ -1,3 +1,195 @@
+Fri May 18 22:04:23 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.ga : 1.8.10
+	  - Fix bad narrowing logic of undefined value domain in order to
+	    detect W9001 correctly.
+	  - Fix W0635 detection not to warn when the expected type of the
+	    conversion specifier is a pointer type and the corresponding
+	    argument's type is a pointer type whose base type is cv-qualified.
+	  - Fix W0583 detection not to warn when the argument type is a
+	    cv-qualified one of the corresponding parameter's type.
+	  - Fix W0112 detection not to warn about floating point
+	    relational-expressions.
+	  - Fix W0117 and W0118 detection not to misunderstand linkage of
+	    object definitions.
+	  - Fix W0101, W0102, W0103 and W0107 detections not to warn when an
+	    address of the parameter array variable (an alias of the caller's
+	    array) is going to be saved.
+	  - Fix W0828 detection not to warn when the member variable is a type
+	    of char array and the corresponding initializer is a
+	    string-literal-specifier.
+	  - Fix W0635 detection not to warn when the `void *' argument passed
+	    as the `%p' conversion specifier.
+	  - Fix degraded W0118 detection not to warn when the object
+	    declaration is in the header file and the same declaration is in
+	    the source file, too.
+	  - Fix bad value domain multiplication logic in order to correctly
+	    detect W0723 about multiplicative-expressions.
+	  - Fix W0771 detection not to warn when declarations of the same
+	    object are in a source file.
+	  - Fix W0080 detection to warn when the file local static variable is
+	    defined without initializer.
+	  - Fix bad value domain multiplication logic in order to correctly
+	    detect W0608 about multiplicative-expressions.
+	  - Fix degraded W0771 detection not to warn when declarations of the
+	    same object are in two or more files.
+	  - Fix degraded W0118 detection to warn when all declarations of an
+	    object are in the source file.
+
+Fri May 18 21:38:59 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 1.8.9
+	  - Fix degraded W0771 detection not to warn when declarations of the
+	    same object are in two or more files.
+	  - Fix degraded W0118 detection to warn when all declarations of an
+	    object are in the source file.
+
+Fri May 18 21:21:29 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/message.rb : Fix degraded W0118 detection to warn when
+	  all declarations of an object are in the source file.
+
+Fri May 18 21:12:15 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/message.rb : Fix degraded W0771 detection not to warn
+	  when declarations of the same object are in two or more files.
+
+Fri May 18 20:46:33 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 1.8.7
+	  - Fix bad value domain multiplication logic in order to correctly
+	    detect W0608 about multiplicative-expressions.
+
+Fri May 18 20:38:30 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/domain.rb : Fix bad value domain multiplication logic in
+	  order to correctly detect W0608 about multiplicative-expressions.
+
+Fri May 18 19:50:35 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 1.8.5
+	  - Fix W0828 detection not to warn when the member variable is a type
+	    of char array and the corresponding initializer is a
+	    string-literal-specifier.
+	  - Fix W0635 detection not to warn when the `void *' argument passed
+	    as the `%p' conversion specifier.
+	  - Fix degraded W0118 detection not to warn when the object
+	    declaration is in the header file and the same declaration is in
+	    the source file, too.
+	  - Fix bad value domain multiplication logic in order to correctly
+	    detect W0723 about multiplicative-expressions.
+	  - Fix W0771 detection not to warn when declarations of the same
+	    object are in a source file.
+	  - Fix W0080 detection to warn when the file local static variable is
+	    defined without initializer.
+
+Fri May 18 19:10:56 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/message.rb : Fix W0080 detection to warn when the file
+	  local static variable is defined without initializer.
+
+Fri May 18 18:42:02 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/message.rb : Fix W0771 detection not to warn when
+	  declarations of the same object are in a source file.
+
+Fri May 18 18:25:04 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/domain.rb : Fix bad value domain multiplication logic in
+	  order to correctly detect W0723 about multiplicative-expressions.
+
+Fri May 18 15:58:57 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/message.rb : Fix degraded W0118 detection not to warn
+	  when the object declaration is in the header file and the same
+	  declaration is in the source file, too.
+
+Fri May 18 15:30:29 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/type.rb : Fix and refactor bad type similarity check not
+	  to misunderstand that the `void *' is not same as `void *'.
+
+Fri May 18 13:22:41 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/message.rb : Fix W0828 detection not to warn when the
+	  member variable is a type of char array and the corresponding
+	  initializer is a string-literal-specifier.
+
+Thu May 17 18:32:49 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* release.rc : 1.8.3
+	  - This is RC for the 2nd patch release of the 1.8 series.
+	  - Fix bad narrowing logic of undefined value domain in order to
+	    detect W9001 correctly.
+	  - Fix W0635 detection not to warn when the expected type of the
+	    conversion specifier is a pointer type and the corresponding
+	    argument's type is a pointer type whose base type is cv-qualified.
+	  - Fix W0583 detection not to warn when the argument type is a
+	    cv-qualified one of the corresponding parameter's type.
+	  - Fix W0112 detection not to warn about floating point
+	    relational-expressions.
+	  - Fix W0117 and W0118 detection not to misunderstand linkage of
+	    object definitions.
+	  - Fix W0101, W0102, W0103 and W0107 detections not to warn when an
+	    address of the parameter array variable (an alias of the caller's
+	    array) is going to be saved.
+
+Thu May 17 16:08:47 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/type.rb : Add query interface tells whether the
+	  receiver type is a type of function parameters or not.
+
+	* lib/adlint/c/message.rb : Fix W0101, W0102, W0103 and W0107
+	  detections not to warn when an address of the parameter array
+	  variable (an alias of the caller's array) is going to be saved.
+
+Thu May 17 15:24:49 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/message.rb : Fix scattered object linkage determination
+	  logic to use new Object#declared_as_*? method.
+	* lib/adlint/c/code.rb : Ditto.
+
+Wed May 16 11:57:18 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/object.rb : Fix bad linkage determination of variables
+	  in order not to misunderstand that function local variables have
+	  external linkages.
+
+	* lib/adlint/c/message.rb : Fix W0117 and W0118 detection not to
+	  misunderstand linkage of object definitions.
+
+Wed May 16 11:33:03 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/ctrlexpr.rb : Fix bad expression evaluation
+	  notification not to notify that an equality-expression evaluated
+	  when a relational-expression is evaluated.
+
+Wed May 16 10:53:56 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/type.rb : Fix bad type similarity check not to
+	  misunderstand that the pointer or array of non cv-qualified type is
+	  not similar to the pointer or array of cv-qualified type.
+
+Wed May 16 02:25:04 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* share/demo/Makefile : Add `integer_promotion' demo.
+	* share/demo/integer_promotion/integer_promotion.c : Ditto.
+	* MANIFEST : Ditto.
+
+Tue May 15 18:05:48 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/domain.rb : Fix bad value domain multiplication logic in
+	  order not to result NaN when the rhs domain contains 0.
+
+Tue May 15 15:19:31 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
+
+	* lib/adlint/c/domain.rb : Fix bad narrowing logic of undefined value
+	  domain in order not to mishandle controlling expressions of
+	  uninitialized variables.
+
+	* lib/adlint/c/ctrlexpr.rb : Remove redundant ValueDomainManipulator
+	  registration.
+
 Mon May  7 22:56:02 2012  Yutaka Yanoh  <yanoh@users.sourceforge.net>
 
 	* release.ga : 1.8.2

data/MANIFEST

@@ -148,6 +148,7 @@ share/demo/indirect_recur/indirect_recur_3.c
 share/demo/indirect_recur/indirect_recur_3.h
 share/demo/indirect_recur/indirect_recur_4.c
 share/demo/inline_asm/inline_asm.c
+share/demo/integer_promotion/integer_promotion.c
 share/demo/intro_demo/intro_demo.c
 share/demo/intro_demo/intro_demo.h
 share/demo/intro_demo/useless_header.h

data/NEWS

@@ -21,6 +21,46 @@
 
 ++
 
+=== \AdLint 1.8.10 is released (2012-05-18)
+
+==== Changes since the 1.8.2 release
+
+* Fix bad narrowing logic of undefined value domain in order to detect W9001
+  correctly
+* Fix W0635 detection not to warn when the expected type of the conversion
+  specifier is a pointer type and the corresponding argument's type is a
+  pointer type whose base type is cv-qualified
+* Fix W0583 detection not to warn when the argument type is a cv-qualified one
+  of the corresponding parameter's type
+* Fix W0112 detection not to warn about floating point relational-expressions.
+* Fix W0117 and W0118 detection not to misunderstand linkage of object
+  definitions
+* Fix W0101, W0102, W0103 and W0107 detections not to warn when an address of
+  the parameter array variable (an alias of the caller's array) is going to be
+  saved
+* Fix W0828 detection not to warn when the member variable is a type of char
+  array and the corresponding initializer is a string-literal-specifier
+* Fix W0635 detection not to warn when the `void *' argument passed as the `%p'
+  conversion specifier
+* Fix degraded W0118 detection not to warn when the object declaration is in
+  the header file and the same declaration is in the source file, too
+* Fix bad value domain multiplication logic in order to correctly detect W0723
+  about multiplicative-expressions
+* Fix W0771 detection not to warn when declarations of the same object are in a
+  source file
+* Fix W0080 detection to warn when the file local static variable is defined
+  without initializer
+* Fix bad value domain multiplication logic in order to correctly detect W0608
+  about multiplicative-expressions
+* Fix degraded W0771 detection not to warn when declarations of the same object
+  are in two or more files
+* Fix degraded W0118 detection to warn when all declarations of an object are
+  in the source file
+
+See the file
+{ChangeLog}[http://adlint.sourceforge.net/pmwiki/upload.d/Main/ChangeLog]
+for more details.
+
 === \AdLint 1.8.2 is released (2012-05-08)
 
 ==== Changes since the 1.8.0 release
@@ -29,10 +69,6 @@
   object into a pointer in order to resolve a type of the nested
   array-subscript-expression correctly
 
-See the file
-{ChangeLog}[http://adlint.sourceforge.net/pmwiki/upload.d/Main/ChangeLog]
-for more details.
-
 === \AdLint 1.8.0 is released (2012-04-27)
 
 ==== Changes since the 1.6.0 release

data/etc/mesg.d/en_US/messages.yml

@@ -36,7 +36,7 @@
 #     X9999: "Your custom message for the fatal error of #9999."
 #     E9999: "Your custom message for the error of #9999."
 
-version: "1.8.2"
+version: "1.8.10"
 
 message_definition:
   X0001: "An unknown exception `%s' is found."

data/etc/mesg.d/ja_JP/messages.yml

@@ -36,7 +36,7 @@
 #     X9999: "Your custom message for the fatal error of #9999."
 #     E9999: "Your custom message for the error of #9999."
 
-version: "1.8.2"
+version: "1.8.10"
 
 message_definition:
   X0001: "不明な例外条件 `%s' を検出しました。"

data/lib/adlint/c/code.rb

@@ -76,17 +76,16 @@ module C #:nodoc:
   class GVarDeclExtraction < CodeExtraction
     def initialize(context)
       super
-      visitor = context[:c_visitor]
-      visitor.enter_variable_declaration += method(:extract)
+      interp = context[:c_interpreter]
+      interp.on_variable_declared += method(:extract)
     end
 
     private
     def do_prepare(context) end
     def do_execute(context) end
 
-    def extract(variable_declaration)
-      if variable_declaration.storage_class_specifier &&
-          variable_declaration.storage_class_specifier.type == :EXTERN
+    def extract(variable_declaration, variable)
+      if variable.declared_as_extern?
         GVARDCL(variable_declaration.identifier.location,
                 variable_declaration.identifier.value,
                 variable_declaration.type.brief_image)
@@ -97,10 +96,10 @@ module C #:nodoc:
   class FuncDeclExtraction < CodeExtraction
     def initialize(context)
       super
-      visitor = context[:c_visitor]
-      visitor.enter_function_declaration += method(:extract)
-      visitor.enter_compound_statement += method(:enter_compound_statement)
-      visitor.leave_compound_statement += method(:leave_compound_statement)
+      interp = context[:c_interpreter]
+      interp.on_function_declared += method(:extract)
+      interp.on_block_started += method(:enter_block)
+      interp.on_block_ended += method(:leave_block)
       @block_level = 0
     end
 
@@ -108,33 +107,25 @@ module C #:nodoc:
     def do_prepare(context) end
     def do_execute(context) end
 
-    def extract(function_declaration)
-      if function_declaration.storage_class_specifier
-        case function_declaration.storage_class_specifier.type
-        when :EXTERN
-          FUNCDCL(function_declaration.identifier.location, "X",
-                  @block_level == 0 ? "F" : "B",
-                  FunctionIdentifier.new(function_declaration.identifier.value,
-                                         function_declaration.signature.to_s))
-        when :STATIC
-          FUNCDCL(function_declaration.identifier.location, "I",
-                  @block_level == 0 ? "F" : "B",
-                  FunctionIdentifier.new(function_declaration.identifier.value,
-                                         function_declaration.signature.to_s))
-        end
-      else
+    def extract(function_declaration, function)
+      if function.declared_as_extern?
         FUNCDCL(function_declaration.identifier.location, "X",
                 @block_level == 0 ? "F" : "B",
                 FunctionIdentifier.new(function_declaration.identifier.value,
                                        function_declaration.signature.to_s))
+      else
+        FUNCDCL(function_declaration.identifier.location, "I",
+                @block_level == 0 ? "F" : "B",
+                FunctionIdentifier.new(function_declaration.identifier.value,
+                                       function_declaration.signature.to_s))
       end
     end
 
-    def enter_compound_statement(node)
+    def enter_block(*)
       @block_level += 1
     end
 
-    def leave_compound_statement(node)
+    def leave_block(*)
       @block_level -= 1
     end
   end
@@ -142,11 +133,11 @@ module C #:nodoc:
   class VarDefExtraction < CodeExtraction
     def initialize(context)
       super
-      visitor = context[:c_visitor]
-      visitor.enter_variable_definition += method(:extract_variable)
-      visitor.enter_parameter_definition += method(:extract_parameter)
-      visitor.enter_compound_statement += method(:enter_compound_statement)
-      visitor.leave_compound_statement += method(:leave_compound_statement)
+      interp = context[:c_interpreter]
+      interp.on_variable_defined += method(:extract_variable)
+      interp.on_parameter_defined += method(:extract_parameter)
+      interp.on_block_started += method(:enter_block)
+      interp.on_block_ended += method(:leave_block)
       @block_level = 0
     end
 
@@ -154,90 +145,77 @@ module C #:nodoc:
     def do_prepare(context) end
     def do_execute(context) end
 
-    def extract_variable(variable_definition)
-      if variable_definition.storage_class_specifier
-        case variable_definition.storage_class_specifier.type
-        when :EXTERN
-          VARDEF(variable_definition.identifier.location, "X",
-                 @block_level == 0 ? "F" : "B",
-                 storage_class_type(
-                   variable_definition.storage_class_specifier),
-                 variable_definition.identifier.value,
-                 variable_definition.type.brief_image)
-        when :STATIC
-          VARDEF(variable_definition.identifier.location, "I",
-                 @block_level == 0 ? "F" : "B",
-                 storage_class_type(
-                   variable_definition.storage_class_specifier),
-                 variable_definition.identifier.value,
-                 variable_definition.type.brief_image)
-        when :AUTO, :REGISTER
-          VARDEF(variable_definition.identifier.location, "I", "B",
-                 storage_class_type(
-                   variable_definition.storage_class_specifier),
-                 variable_definition.identifier.value,
-                 variable_definition.type.brief_image)
-        end
-      else
-        if @block_level == 0
-          VARDEF(variable_definition.identifier.location, "X",
-                 @block_level == 0 ? "F" : "B",
-                 storage_class_type(
-                   variable_definition.storage_class_specifier),
-                 variable_definition.identifier.value,
-                 variable_definition.type.brief_image)
-        else
-          VARDEF(variable_definition.identifier.location, "I", "B",
-                 storage_class_type(
-                   variable_definition.storage_class_specifier),
-                 variable_definition.identifier.value,
-                 variable_definition.type.brief_image)
-        end
+    def extract_variable(variable_definition, variable)
+      case
+      when variable.declared_as_extern?
+        VARDEF(variable_definition.identifier.location, "X",
+               @block_level == 0 ? "F" : "B",
+               storage_class_type(variable_definition.storage_class_specifier),
+               variable_definition.identifier.value,
+               variable_definition.type.brief_image)
+      when variable.declared_as_static?
+        VARDEF(variable_definition.identifier.location, "I",
+               @block_level == 0 ? "F" : "B",
+               storage_class_type(variable_definition.storage_class_specifier),
+               variable_definition.identifier.value,
+               variable_definition.type.brief_image)
+      when variable.declared_as_auto?
+        VARDEF(variable_definition.identifier.location, "I",
+               @block_level == 0 ? "F" : "B",
+               storage_class_type(variable_definition.storage_class_specifier),
+               variable_definition.identifier.value,
+               variable_definition.type.brief_image)
+      when variable.declared_as_register?
+        VARDEF(variable_definition.identifier.location, "I",
+               @block_level == 0 ? "F" : "B",
+               storage_class_type(variable_definition.storage_class_specifier),
+               variable_definition.identifier.value,
+               variable_definition.type.brief_image)
       end
     end
 
-    def extract_parameter(parameter_definition)
-      if parameter_definition.identifier
-        VARDEF(parameter_definition.identifier.location, "I", "P",
-               storage_class_type(
-                 parameter_definition.storage_class_specifier),
-               parameter_definition.identifier.value,
-               parameter_definition.type.brief_image)
-      end
+    def extract_parameter(parameter_definition, variable)
+      return unless variable.named?
+
+      VARDEF(parameter_definition.identifier.location, "I", "P",
+             storage_class_type(parameter_definition.storage_class_specifier),
+             parameter_definition.identifier.value,
+             parameter_definition.type.brief_image)
     end
 
-    def enter_compound_statement(node)
+    def enter_block(*)
       @block_level += 1
     end
 
-    def leave_compound_statement(node)
+    def leave_block(*)
       @block_level -= 1
     end
 
     def storage_class_type(storage_class_specifier)
-      result = "N"
-      if storage_class_specifier
-        case storage_class_specifier.type
-        when :AUTO
-          result = "A"
-        when :REGISTER
-          result = "R"
-        when :STATIC
-          result = "S"
-        end
+      return "N" unless storage_class_specifier
+
+      case storage_class_specifier.type
+      when :AUTO
+        "A"
+      when :REGISTER
+        "R"
+      when :STATIC
+        "S"
+      when :EXTERN
+        "E"
+      else
+        "N"
       end
-      result
     end
   end
 
   class FuncDefExtraction < CodeExtraction
     def initialize(context)
       super
-      visitor = context[:c_visitor]
-      visitor.enter_ansi_function_definition += method(:extract_function)
-      visitor.enter_kandr_function_definition += method(:extract_function)
-      visitor.enter_compound_statement += method(:enter_compound_statement)
-      visitor.leave_compound_statement += method(:leave_compound_statement)
+      interp = context[:c_interpreter]
+      interp.on_function_started += method(:extract_function)
+      interp.on_block_started += method(:enter_block)
+      interp.on_block_ended += method(:leave_block)
       @block_level = 0
     end
 
@@ -245,40 +223,26 @@ module C #:nodoc:
     def do_prepare(context) end
     def do_execute(context) end
 
-    def extract_function(function_definition)
-      if function_definition.storage_class_specifier
-        case function_definition.storage_class_specifier.type
-        when :EXTERN
-          FUNCDEF(function_definition.identifier.location, "X", "F",
-                  FunctionIdentifier.new(function_definition.identifier.value,
-                                         function_definition.signature.to_s),
-                  function_definition.lines)
-        when :STATIC
-          FUNCDEF(function_definition.identifier.location, "I", "F",
-                  FunctionIdentifier.new(function_definition.identifier.value,
-                                         function_definition.signature.to_s),
-                  function_definition.lines)
-        end
-      else
-        if @block_level == 0
-          FUNCDEF(function_definition.identifier.location, "X", "F",
-                  FunctionIdentifier.new(function_definition.identifier.value,
-                                         function_definition.signature.to_s),
-                  function_definition.lines)
-        else
-          FUNCDEF(function_definition.identifier.location, "I", "B",
-                  FunctionIdentifier.new(function_definition.identifier.value,
-                                         function_definition.signature.to_s),
-                  function_definition.lines)
-        end
+    def extract_function(function_definition, function)
+      case
+      when function.declared_as_extern?
+        FUNCDEF(function_definition.identifier.location, "X", "F",
+                FunctionIdentifier.new(function_definition.identifier.value,
+                                       function_definition.signature.to_s),
+                function_definition.lines)
+      when function.declared_as_static?
+        FUNCDEF(function_definition.identifier.location, "I", "F",
+                FunctionIdentifier.new(function_definition.identifier.value,
+                                       function_definition.signature.to_s),
+                function_definition.lines)
       end
     end
 
-    def enter_compound_statement(node)
+    def enter_block(*)
       @block_level += 1
     end
 
-    def leave_compound_statement(node)
+    def leave_block(*)
       @block_level -= 1
     end
   end