adjust 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 394b43447458b304090b06fbc93ebf860f94949f
-  data.tar.gz: 3176c978c5b815e5e92db9be77b3b2717e733e72
+  metadata.gz: b6006d97a274628f7f36570ac0a1c7471a7810d1
+  data.tar.gz: b0cc4a2260d946f0eb12839ae3979f6c7a5d6058
 SHA512:
-  metadata.gz: d3a95181c80beb4fe83913ee6b2adb472b1733eecefe8b69a76d2b234dbb072f94a00319e55191613d8334a1483cc669d1b8bc4e164a1f32ce2684b044f543ec
-  data.tar.gz: 4230cf55d66d62c0066cb7393a2f9fa8f5d4e8d6a7416041c24f5bae70cdb6c5d0b54a3758f3700ac3b3688a43a5167fb40aeb90040bf2ac4b25eacd976207ed
+  metadata.gz: 4d9ac213976e887ae202856a9857f53310640cec97c82a55783113d068acebc9507a8d46a8b1b99da3dce6d9aaee93112c82dd4ff363affb0edc848012b8573f
+  data.tar.gz: d83860afe9461d421db46380110cc76abc0daf50d13207564959d6665aae21b76671540073990505844e308fdb0e89fc07eaba9d401e10d6d2f0926ab62802fe

data/lib/adjust.rb

@@ -1,10 +1,11 @@
+require 'faraday'
 require 'adjust/version'
-require 'adjust/transport/faraday'
 
 module Adjust
   autoload :Core, 'adjust/core'
   autoload :Clients, 'adjust/clients'
   autoload :Representers, 'adjust/representers'
+  autoload :Transport, 'adjust/transport'
 
   class << self
     include Core::Configurable

data/lib/adjust/transport.rb

@@ -0,0 +1,2 @@
+require 'adjust/transport/fail_hard'
+require 'adjust/transport/faraday'

data/lib/adjust/transport/fail_hard.rb

@@ -0,0 +1,23 @@
+module Adjust
+  module Transport
+    class Error < StandardError; end
+
+    class FailHard < ::Faraday::Response::Middleware
+      SUCCESS_STATUSES = 200...300
+
+      def on_complete(env)
+        fail Error, error_from_json(env[:body]) if failed?(env)
+      end
+
+      def failed?(env)
+        !SUCCESS_STATUSES.include?(env[:status])
+      end
+
+      def error_from_json(body)
+        MultiJson.load(body)['error']
+      end
+
+      Faraday::Response.register_middleware fail_hard: FailHard
+    end
+  end
+end

data/lib/adjust/transport/faraday.rb

@@ -1,4 +1,3 @@
-require 'roar/http_verbs'
 require 'roar/transport/faraday'
 
 module Adjust
@@ -9,7 +8,7 @@ module Adjust
       def build_connection(uri, _)
         ::Faraday.new(url: uri) do |connection|
           connection.request :url_encoded
-          connection.use ::Faraday::Response::RaiseError
+          connection.response :fail_hard
           connection.adapter ::Faraday.default_adapter
         end
       end

data/lib/adjust/version.rb

@@ -1,3 +1,3 @@
 module Adjust
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/spec/fixtures/responses/event_unknown_device.yml

@@ -0,0 +1,35 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://s2s.adjust.com/event
+    body:
+      encoding: UTF-8
+      string: app_token=<ADJUST_APP_TOKEN>&created_at=2015-05-13T15%3A34%3A02Z&environment=sandbox&event_token=tawmb9&idfa=D2CADB5F-410F-4963-AC0C-2A78534BDF1E&s2s=1
+    headers:
+      User-Agent:
+      - Faraday v0.9.1
+      Content-Type:
+      - application/x-www-form-urlencoded
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 500
+      message: Internal Server Error
+    headers:
+      Content-Type:
+      - text/plain; charset=utf-8
+      Date:
+      - Wed, 13 May 2015 15:34:02 GMT
+      Content-Length:
+      - '138'
+    body:
+      encoding: UTF-8
+      string: |
+        {"error":"Event failed (Device not found, contact support@adjust.com) (app_token: <ADJUST_APP_TOKEN>, adid: dc4920c26bcc478fbdd2e5bfd0dbe551)"}
+    http_version: 
+  recorded_at: Wed, 13 May 2015 15:34:02 GMT
+recorded_with: VCR 2.9.3

data/spec/fixtures/responses/revenue_unknown_device.yml

@@ -0,0 +1,35 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://s2s.adjust.com/revenue
+    body:
+      encoding: UTF-8
+      string: app_token=<ADJUST_APP_TOKEN>&created_at=2015-05-13T14%3A28%3A41Z&currency=CAD&environment=sandbox&event_token=fbv8to&idfa=D2CADB5F-410F-4963-AC0C-2A78534BDF1E&revenue=2.0&s2s=1
+    headers:
+      User-Agent:
+      - Faraday v0.9.1
+      Content-Type:
+      - application/x-www-form-urlencoded
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 500
+      message: Internal Server Error
+    headers:
+      Content-Type:
+      - text/plain; charset=utf-8
+      Date:
+      - Wed, 13 May 2015 14:28:42 GMT
+      Content-Length:
+      - '138'
+    body:
+      encoding: UTF-8
+      string: |
+        {"error":"Event failed (Device not found, contact support@adjust.com) (app_token: <ADJUST_APP_TOKEN>, adid: dc4920c26bcc478fbdd2e5bfd0dbe551)"}
+    http_version: 
+  recorded_at: Wed, 13 May 2015 14:28:41 GMT
+recorded_with: VCR 2.9.3

data/spec/integration/sending_a_revenue_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe 'Sending a revenue' do
-  context 'with success', vcr: { cassette_name: :revenue_success }  do
+  context 'with success', vcr: named(:revenue_success)  do
     subject do
       Adjust.revenue \
         app: :test_app,
@@ -15,4 +15,20 @@ describe 'Sending a revenue' do
       expect(subject.track!).to be_success
     end
   end
+
+  context 'with unknown device', vcr: named(:revenue_unknown_device) do
+    subject do
+      Adjust.revenue \
+        app: :test_app,
+        event: :event2,
+        revenue: 2.0,
+        currency: 'CAD',
+        idfa: 'D2CADB5F-410F-4963-AC0C-2A78534BDF1E'
+    end
+
+    it 'raises an error' do
+      expect { subject.track! }.to raise_error \
+        Adjust::Transport::Error, /Device not found/
+    end
+  end
 end

data/spec/integration/sending_an_event_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe 'Sending an event' do
-  context 'with success', vcr: { cassette_name: :event_success }  do
+  context 'with success', vcr: named(:event_success)  do
     subject do
       Adjust.event \
         app: :test_app,
@@ -13,4 +13,18 @@ describe 'Sending an event' do
       expect(subject.track!).to be_success
     end
   end
+
+  context 'with unknown device', vcr: named(:event_unknown_device) do
+    subject do
+      Adjust.event \
+        app: :test_app,
+        event: :event1,
+        idfa: 'D2CADB5F-410F-4963-AC0C-2A78534BDF1E'
+    end
+
+    it 'raises an error' do
+      expect { subject.track! }.to raise_error \
+        Adjust::Transport::Error, /Device not found/
+    end
+  end
 end

data/spec/support/vcr.rb

@@ -40,4 +40,8 @@ RSpec.configure do |config|
   config.after(:each) do
     Timecop.return
   end
+
+  def named(name)
+    { cassette_name: name }
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: adjust
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Hugo Bastien
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-07 00:00:00.000000000 Z
+date: 2015-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -192,6 +192,8 @@ files:
 - lib/adjust/core/tokens.rb
 - lib/adjust/representers.rb
 - lib/adjust/representers/event_representer.rb
+- lib/adjust/transport.rb
+- lib/adjust/transport/fail_hard.rb
 - lib/adjust/transport/faraday.rb
 - lib/adjust/version.rb
 - spec/clients/event_spec.rb
@@ -199,7 +201,9 @@ files:
 - spec/core/configuration_spec.rb
 - spec/fixtures/config/adjust.yml
 - spec/fixtures/responses/event_success.yml
+- spec/fixtures/responses/event_unknown_device.yml
 - spec/fixtures/responses/revenue_success.yml
+- spec/fixtures/responses/revenue_unknown_device.yml
 - spec/integration/sending_a_revenue_spec.rb
 - spec/integration/sending_an_event_spec.rb
 - spec/spec_helper.rb
@@ -234,7 +238,9 @@ test_files:
 - spec/core/configuration_spec.rb
 - spec/fixtures/config/adjust.yml
 - spec/fixtures/responses/event_success.yml
+- spec/fixtures/responses/event_unknown_device.yml
 - spec/fixtures/responses/revenue_success.yml
+- spec/fixtures/responses/revenue_unknown_device.yml
 - spec/integration/sending_a_revenue_spec.rb
 - spec/integration/sending_an_event_spec.rb
 - spec/spec_helper.rb