adiwg-mdtranslator 2.20.0.pre.beta.5 → 2.20.0.pre.beta.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8d8a5f731fb5ada7138ee650206ed3a6f81d36ffcbbb52fece5f13befb9bcce
-  data.tar.gz: a2023846f039cdfe3dde6f851f13ad463afd36644e9a5a460c2d6416e644c450
+  metadata.gz: ba2ee5421220695d7a92cabc649801ce6e8f045dbd8bbfa0ee5a740728b3bbf7
+  data.tar.gz: 4d1d59bb9d77ab17ebc44b0c9027731191ab6e206160d1ca3bc0c49b891fd112
 SHA512:
-  metadata.gz: d297c28d28dc4f19840b476ba86fb6e89b36d106019a20f7ceedd58b9f36f27e8006eb8c49dcc0de935b060557e25466f7d3deeef8f3de6d05bc7ea981f189d0
-  data.tar.gz: 8093a1f20c10929bb69aa9635a6b7f1e2532300f8db5f6761e025651fde5a0ea1ca9b89d8e2111eb8d5da1b98db995f6ca66e50e49fbbfc95ec3d6cfd72027e5
+  metadata.gz: 4f086f201b9845b35c5e4d4edd2bd4bb19c76841df0b0ddb049f9c47d49c10e57c4c8af7dd24aca6a531ebdb6a2adccccdb78ed20eeeb63292bb70ae880e8e64
+  data.tar.gz: 9dc353b3095a5bd31dbe0dd00ded7f94a879204f1bdf93daf03f188060924466cd88d2bdee5c2bcf5418360d149e2e12259cc4003a7f38180f579043c76e34ab

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    adiwg-mdtranslator (2.20.0.pre.beta.0)
-      adiwg-mdcodes (= 2.10.0)
-      adiwg-mdjson_schemas (= 2.9.5)
+    adiwg-mdtranslator (2.20.0.pre.beta.7)
+      adiwg-mdcodes (= 2.10.1)
+      adiwg-mdjson_schemas (= 2.9.6)
       builder (~> 3.2)
       coderay (~> 1.1)
       jbuilder (~> 2.5)
@@ -35,9 +35,9 @@ GEM
       tzinfo (~> 2.0)
     addressable (2.8.6)
       public_suffix (>= 2.0.2, < 6.0)
-    adiwg-mdcodes (2.10.0)
+    adiwg-mdcodes (2.10.1)
       json (~> 2.0)
-    adiwg-mdjson_schemas (2.9.5)
+    adiwg-mdjson_schemas (2.9.6)
     base64 (0.2.0)
     bigdecimal (3.1.8)
     builder (3.2.4)

data/adiwg-mdtranslator.gemspec

@@ -34,8 +34,8 @@ Gem::Specification.new do |spec|
    spec.add_runtime_dependency "thor", "~> 0.19"
    spec.add_runtime_dependency "uuidtools", "~> 2.1"
    spec.add_runtime_dependency "json-schema", "~> 2.7"
-   spec.add_runtime_dependency "adiwg-mdjson_schemas", "2.9.5"
-   spec.add_runtime_dependency "adiwg-mdcodes", "2.10.0"
+   spec.add_runtime_dependency "adiwg-mdjson_schemas", "2.9.6"
+   spec.add_runtime_dependency "adiwg-mdcodes", "2.10.1"
    spec.add_runtime_dependency "jbuilder", "~> 2.5"
    spec.add_runtime_dependency "kramdown", ">= 1.13", "< 3.0"
    spec.add_runtime_dependency "coderay", "~> 1.1"

data/lib/adiwg/mdtranslator/readers/fgdc/modules/module_dataQuality.rb

@@ -56,8 +56,10 @@ module ADIWG
                         # data quality 2.1.2.2 (attracce) - Attribute Accuracy Explanation
                         xEvaluationMethod = xQuantitativeAccuracy.xpath('./attracce')
                         unless xEvaluationMethod.empty?
-                           report[:evaluationMethod] = intMetadataClass.newEvaluationMethod
-                           report[:evaluationMethod][:methodDescription] = xEvaluationMethod.text
+                           evaluationMethod = intMetadataClass.newEvaluationMethod
+                           evaluationMethod[:name] = 'Attribute Accuracy Explanation'
+                           evaluationMethod[:methodDescription] = xEvaluationMethod.text
+                           report[:evaluationMethod] << evaluationMethod
                         end
                         hDataQuality[:report] << report unless report[:quantitativeResult].empty? && report[:evaluationMethod].empty?
                      end
@@ -101,35 +103,29 @@ module ADIWG
                      unless xHorizontalAccuracy.empty?
                         report = intMetadataClass.newDataQualityReport
                         report[:type] = 'DQ_AbsoluteExternalPositionalAccuracy'
-                        # data quality 2.4.1.1 (horizpar) - Horizontal Positional Accuracy Report
+                        # Combine Horizontal Positional Accuracy Report and Explanation
+                        descriptive_result_text = ''
                         xHorizontalAccuracyReport = xHorizontalAccuracy.xpath('./horizpar')
                         unless xHorizontalAccuracyReport.empty?
-                           descriptiveResult = intMetadataClass.newDescriptiveResult
-                           descriptiveResult[:name] = 'Horizontal Positional Accuracy Report'
-                           descriptiveResult[:statement] = xHorizontalAccuracyReport.text
-                           report[:descriptiveResult] << descriptiveResult
+                           descriptive_result_text += xHorizontalAccuracyReport.text
                         end
-                        # data quality 2.4.1.2 (qhorizpa) - Quantitative Horizontal Positional Accuracy Assessment
                         xQuantitativeHorizontalAccuracy = xHorizontalAccuracy.xpath('./qhorizpa')
                         unless xQuantitativeHorizontalAccuracy.empty?
-                           # data quality 2.4.1.2.1 (horizpav) - Horizontal Positional Accuracy Value
                            xHorizontalAccuracyValue = xQuantitativeHorizontalAccuracy.xpath('horizpav')
                            unless xHorizontalAccuracyValue.empty?
-                              quantitativeResult = intMetadataClass.newQuantitativeResult
-                              value = xHorizontalAccuracyValue.text
-                              quantitativeResult[:name] = 'Horizontal Positional Accuracy Value'
-                              quantitativeResult[:values] << value
-                              report[:quantitativeResult] << quantitativeResult
+                              descriptive_result_text += " Value: #{xHorizontalAccuracyValue.text}"
                            end
-                           # data quality 2.4.1.2.2 (horizpae) - Horizontal Positional Accuracy Explanation
                            xHorizontalAccuracyExplanation = xQuantitativeHorizontalAccuracy.xpath('horizpae')
                            unless xHorizontalAccuracyExplanation.empty?
-                              descriptiveResult = intMetadataClass.newDescriptiveResult
-                              descriptiveResult[:name] = 'Horizontal Positional Accuracy Explanation'
-                              descriptiveResult[:statement] = xHorizontalAccuracyExplanation.text
-                              report[:descriptiveResult] << descriptiveResult
+                              descriptive_result_text += " Explanation: #{xHorizontalAccuracyExplanation.text}"
                            end
                         end
+                        unless descriptive_result_text.empty?
+                           descriptiveResult = intMetadataClass.newDescriptiveResult
+                           descriptiveResult[:name] = 'Horizontal Positional Accuracy Report'
+                           descriptiveResult[:statement] = descriptive_result_text
+                           report[:descriptiveResult] << descriptiveResult
+                        end
                         hDataQuality[:report] << report
                      end
                      # data quality 2.4.2 (vertacc) - Vertical Positional Accuracy
@@ -137,35 +133,29 @@ module ADIWG
                      unless xVerticalAccuracy.empty?
                         report = intMetadataClass.newDataQualityReport
                         report[:type] = 'DQ_AbsoluteExternalPositionalAccuracy'
-                        # data quality 2.4.2.1 (vertaccr) - Vertical Positional Accuracy Report
+                        # Combine Vertical Positional Accuracy Report and Explanation
+                        descriptive_result_text = ''
                         xVerticalAccuracyReport = xVerticalAccuracy.xpath('./vertaccr')
                         unless xVerticalAccuracyReport.empty?
-                           descriptiveResult = intMetadataClass.newDescriptiveResult
-                           descriptiveResult[:name] = 'Vertical Positional Accuracy Report'
-                           descriptiveResult[:statement] = xVerticalAccuracyReport.text
-                           report[:descriptiveResult] << descriptiveResult
+                           descriptive_result_text += xVerticalAccuracyReport.text
                         end
-                        # data quality 2.4.2.2 (qvertpa) - Quantitative Vertical Positional Accuracy Assessment
                         xVerticalAccuracyAssessment = xVerticalAccuracy.xpath('./qvertpa')
                         unless xVerticalAccuracyAssessment.empty?
-                           # data quality 2.4.2.2.1 (vertaccv) - Vertical Positional Accuracy Value
                            xVerticalAccuracyValue = xVerticalAccuracyAssessment.xpath('vertaccv')
                            unless xVerticalAccuracyValue.empty?
-                              quantitativeResult = intMetadataClass.newQuantitativeResult
-                              value = xVerticalAccuracyValue.text
-                              quantitativeResult[:name] = 'Vertical Positional Accuracy Value'
-                              quantitativeResult[:values] << value
-                              report[:quantitativeResult] << quantitativeResult
+                              descriptive_result_text += " Value: #{xVerticalAccuracyValue.text}"
                            end
-                           # data quality 2.4.2.2.2 (vertacce) - Vertical Positional Accuracy Explanation
                            xVerticalAccuracyExplanation = xVerticalAccuracyAssessment.xpath('vertacce')
                            unless xVerticalAccuracyExplanation.empty?
-                              descriptiveResult = intMetadataClass.newDescriptiveResult
-                              descriptiveResult[:name] = 'Vertical Positional Accuracy Explanation'
-                              descriptiveResult[:statement] = xVerticalAccuracyExplanation.text
-                              report[:descriptiveResult] << descriptiveResult
+                              descriptive_result_text += " Explanation: #{xVerticalAccuracyExplanation.text}"
                            end
                         end
+                        unless descriptive_result_text.empty?
+                           descriptiveResult = intMetadataClass.newDescriptiveResult
+                           descriptiveResult[:name] = 'Vertical Positional Accuracy Report'
+                           descriptiveResult[:statement] = descriptive_result_text
+                           report[:descriptiveResult] << descriptiveResult
+                        end
                         hDataQuality[:report] << report
                      end
                   end
@@ -190,4 +180,4 @@ module ADIWG
          end
       end
    end
-end
+end

data/lib/adiwg/mdtranslator/readers/mdJson/modules/module_dataDictionary.rb

@@ -38,6 +38,14 @@ module ADIWG
                   intMetadataClass = InternalMetadata.new
                   intDictionary = intMetadataClass.newDataDictionary
 
+                  # dictionary - id 
+                  if hDictionary.has_key?('dictionaryId')
+                     s = hDictionary['dictionaryId']
+                     if s != ''
+                        intDictionary[:dictionaryId] = s
+                     end
+                  end
+
                   # dictionary - description
                   if hDictionary.has_key?('description')
                      s = hDictionary['description']

data/lib/adiwg/mdtranslator/version.rb

@@ -109,7 +109,7 @@
 module ADIWG
    module Mdtranslator
       # current mdtranslator version
-      VERSION = "2.20.0-beta.5"
+      VERSION = "2.20.0-beta.8"
    end
 end
 

data/lib/adiwg/mdtranslator/writers/fgdc/classes/class_dataQuality.rb

@@ -8,194 +8,142 @@
 require_relative 'class_lineage'
 
 module ADIWG
-   module Mdtranslator
-      module Writers
-         module Fgdc
-
-            class DataQuality
-
-               def initialize(xml, hResponseObj)
-                  @xml = xml
-                  @hResponseObj = hResponseObj
-                  @NameSpace = ADIWG::Mdtranslator::Writers::Fgdc
-               end
-
-               def writeXML(intObj)
-
-                  # classes used
-                  lineageClass = Lineage.new(@xml, @hResponseObj)
-
-                  hDataQuality = intObj.dig(:metadata, :dataQuality, 0)
-
-                  if hDataQuality && hDataQuality[:report]
-                     # data quality 2.1 (attracc) - Attribute Accuracy
-                     attribute_accuracy_report = hDataQuality[:report].find do |report|
-                        report[:type] == 'DQ_NonQuantitativeAttributeCorrectness' &&
-                        !report.dig(:descriptiveResult, 0, :statement).nil?
-                     end
-                     attribute_accuracy_value = hDataQuality[:report].find do |report|
-                        report[:type] == 'DQ_QuantitativeAttributeAccuracy' &&
-                        !report.dig(:quantitativeResult, 0, :values).nil?
-                     end
-                     attribute_evaluation_method = hDataQuality[:report].find do |report|
-                        report[:type] == 'DQ_QuantitativeAttributeAccuracy' &&
-                        !report.dig(:evaluationMethod, :methodDescription).nil?
-                     end
-                     if attribute_accuracy_report || attribute_accuracy_value || attribute_evaluation_method
-                        # data quality 2.1 (attracc) - Attribute Accuracy
-                        @xml.tag!('attracc') do
-                           if attribute_accuracy_report
-                              # data quality 2.1.1 (attraccr) - Attribute Accuracy Report
-                              @xml.tag!('attraccr', attribute_accuracy_report[:descriptiveResult][0][:statement])
-                           end
-                           if attribute_accuracy_value || attribute_evaluation_method
-                              # data quality 2.1.2 (qattracc) - Quantitative Attribute Accuracy Assessment
-                              @xml.tag!('qattracc') do
-                                 if attribute_accuracy_value
-                                    # data quality 2.1.2.1 (attraccv) - Attribute Accuracy Value
-                                    @xml.tag!('attraccv', attribute_accuracy_value[:quantitativeResult][0][:values][0])
-                                 end
-                                 if attribute_evaluation_method
-                                    # data quality 2.1.2.2 (attracce) - Attribute Accuracy Explanation
-                                    @xml.tag!('attracce', attribute_evaluation_method[:evaluationMethod][:methodDescription])
-                                 end
-                              end
-                           end
-                        end
-                     elsif @hResponseObj[:writerShowTags]
-                        @xml.tag!('attracc', 'Not Reported')
-                     end
-
-                     # data quality 2.2 (logic) - logical consistency (required)
-                     logic_report = hDataQuality[:report].find do |report|
-                        report[:type] == 'DQ_ConceptualConsistency' &&
-                        !report.dig(:descriptiveResult, 0, :statement).nil?
-                     end
-                     if logic = logic_report&.dig(:descriptiveResult, 0, :statement)
-                        @xml.tag!('logic', logic)
-                     else
-                        @xml.tag!('logic', 'Not Reported')
-                     end
-
-                     # data quality 2.3 (complete) - completion report (required)
-                     omission_report = hDataQuality[:report].find do |report|
-                        report[:type] == 'DQ_CompletenessOmission' &&
-                        !report.dig(:descriptiveResult, 0, :statement).nil?
-                     end
-                     omission = omission_report&.dig(:descriptiveResult, 0, :statement)
-                     commission_report = hDataQuality[:report].find do |report|
-                        report[:type] == 'DQ_CompletenessCommission' &&
-                        !report.dig(:descriptiveResult, 0, :statement).nil?
-                     end
-                     commission = commission_report&.dig(:descriptiveResult, 0, :statement)
-                     complete = ''
-                     if omission
-                        complete = omission
-                     end
-                     if commission
-                        if complete != ''
-                           complete = complete + ' ' + commission
-                        else
-                           complete = commission
-                        end
-                     end
-                     if complete != ''
-                        @xml.tag!('complete', complete)
-                     else
-                        @xml.tag!('complete', 'Not Reported')
-                     end
-
-                     # data quality 2.4 (position) - Positional Accuracy
-
-                     # data quality 2.4.1 (horizpa) - Horizontal Positional Accuracy
-                     horizontal_positional_accuracy_report = hDataQuality[:report].find do |report|
-                        report[:type] == 'DQ_AbsoluteExternalPositionalAccuracy' &&
-                        report.dig(:descriptiveResult, 0, :name) == 'Horizontal Positional Accuracy Report' &&
-                        !report.dig(:descriptiveResult, 0, :statement).nil? 
-                     end
-                     horizpar = horizontal_positional_accuracy_report&.dig(:descriptiveResult, 0, :statement)
-                     horizpav = horizontal_positional_accuracy_report&.dig(:quantitativeResult, 0, :values, 0)
-                     horizpae = horizontal_positional_accuracy_report&.dig(:descriptiveResult, 1, :statement)
-
-                     # data quality 2.4.2 (vertacc) - Vertical Positional Accuracy
-                     vertical_positional_accuracy_report = hDataQuality[:report].find do |report|
-                        report[:type] == 'DQ_AbsoluteExternalPositionalAccuracy' &&
-                        report.dig(:descriptiveResult, 0, :name) == 'Vertical Positional Accuracy Report' &&
-                        !report.dig(:descriptiveResult, 0, :statement).nil?
-                     end
-                     vertaccr = vertical_positional_accuracy_report&.dig(:descriptiveResult, 0, :statement)
-                     vertaccv = vertical_positional_accuracy_report&.dig(:quantitativeResult, 0, :values, 0)
-                     vertacce = vertical_positional_accuracy_report&.dig(:descriptiveResult, 1, :statement)
-
-                     if horizpar || vertaccr
-                        # data quality 2.4 (posacc) - Positional Accuracy
-                        @xml.tag!('posacc') do
-                           if horizpar
-                              # data quality 2.4.1 (horizpa) - Horizontal Positional Accuracy
-                              @xml.tag!('horizpa') do
-                                 # data quality 2.4.1.1 (horizpar) - Horizontal Positional Accuracy Report
-                                 @xml.tag!('horizpar', horizpar)
-                                 if horizpav || horizpae
-                                    # data quality 2.4.1.2 (qhorizpa) - Quantitative Horizontal Positional Accuracy
-                                    @xml.tag!('qhorizpa') do
-                                       if horizpav
-                                          # data quality 2.4.1.2.1 (horizpav) - Horizontal Positional Accuracy Value
-                                          @xml.tag!('horizpav', horizpav)
-                                       end
-                                       if horizpae
-                                          # data quality 2.4.1.2.2 (horizpae) - Horizontal Positional Accuracy Explanation
-                                          @xml.tag!('horizpae', horizpae)
-                                       end
-                                    end
-                                 end
-                              end
-                           end
-
-                           if vertaccr
-                              # data quality 2.4.2 (vertacc) - Vertical Positional Accuracy
-                              @xml.tag!('vertacc') do
-                                 # data quality 2.4.2.1 (vertaccr) - Vertical Positional Accuracy Report
-                                 @xml.tag!('vertaccr', vertaccr)
-                                 if vertaccv || vertacce
-                                    # data quality 2.4.2.2 (qvertpa) - Quantitative Vertical Positional Accuracy
-                                    @xml.tag!('qvertpa') do
-                                       if vertaccv
-                                          # data quality 2.4.2.2.1 (vertaccv) - Vertical Positional Accuracy Value
-                                          @xml.tag!('vertaccv', vertaccv)
-                                       end
-                                       if vertacce
-                                          # data quality 2.4.2.2.2 (vertacce) - Vertical Positional Accuracy Explanation
-                                          @xml.tag!('vertacce', vertacce)
-                                       end
-                                    end
-                                 end
-                              end
-                           end
-                        end
-                     elsif @hResponseObj[:writerShowTags]
-                        @xml.tag!('position', 'Not Reported')
-                     end
+  module Mdtranslator
+    module Writers
+      module Fgdc
+
+        class DataQuality
+
+          def initialize(xml, hResponseObj)
+            @xml = xml
+            @hResponseObj = hResponseObj
+            @NameSpace = ADIWG::Mdtranslator::Writers::Fgdc
+          end
+
+          def writeXML(intObj)
+
+            # classes used
+            lineageClass = Lineage.new(@xml, @hResponseObj)
+
+            hDataQuality = intObj.dig(:metadata, :dataQuality, 0)
+
+            if hDataQuality && hDataQuality[:report]
+              # data quality 2.1 (attracc) - Attribute Accuracy
+              attribute_accuracy_report_text = hDataQuality[:report].select do |report|
+                [
+                  'DQ_NonQuantitativeAttributeCorrectness',
+                  'DQ_ThematicClassificationCorrectness'
+                ].include?(report[:type]) && !report.dig(:descriptiveResult, 0, :statement).nil?
+              end.map { |report| report.dig(:descriptiveResult, 0, :statement) }.compact.join(' ')
+
+              quantitative_attribute_accuracy = hDataQuality[:report].find { |report| report[:type] == 'DQ_QuantitativeAttributeAccuracy' }
+              attribute_accuracy_value = quantitative_attribute_accuracy.dig(:quantitativeResult, 0, :values, 0) if quantitative_attribute_accuracy
+              attribute_evaluation_method = quantitative_attribute_accuracy.dig(:evaluationMethod, :methodDescription) if quantitative_attribute_accuracy
+
+              if attribute_accuracy_report_text != '' || attribute_accuracy_value || attribute_evaluation_method
+                @xml.tag!('attracc') do
+                  @xml.tag!('attraccr', attribute_accuracy_report_text) unless attribute_accuracy_report_text.empty?
+                  if attribute_accuracy_value || attribute_evaluation_method
+                    @xml.tag!('qattracc') do
+                      @xml.tag!('attraccv', attribute_accuracy_value) if attribute_accuracy_value
+                      @xml.tag!('attracce', attribute_evaluation_method) if attribute_evaluation_method
+                    end
                   end
-
-                  # data quality 2.5 (lineage) - lineage (required)
-                  unless intObj[:metadata][:lineageInfo].empty?
-                     @xml.tag!('lineage') do
-                        lineageClass.writeXML(intObj[:metadata][:lineageInfo])
-                     end
-                  end
-                  if intObj[:metadata][:lineageInfo].empty?
-                     @NameSpace.issueWarning(350, nil, 'data quality section')
+                end
+              elsif @hResponseObj[:writerShowTags]
+                @xml.tag!('attracc', 'Not Reported')
+              end
+
+              # data quality 2.2 (logic) - logical consistency (required)
+              logic_reports = hDataQuality[:report].select do |report|
+                [
+                  'DQ_ConceptualConsistency',
+                  'DQ_DomainConsistency',
+                  'DQ_FormatConsistency',
+                  'DQ_TopologicalConsistency'
+                ].include?(report[:type]) && !report.dig(:descriptiveResult, 0, :statement).nil?
+              end
+
+              logic = logic_reports.map { |report| report.dig(:descriptiveResult, 0, :statement) }.compact.join(' ')
+
+              if logic != ''
+                @xml.tag!('logic', logic)
+              else
+                @xml.tag!('logic', 'Not Reported')
+              end
+
+              # data quality 2.3 (complete) - completion report (required)
+              omission = hDataQuality[:report].find { |report| report[:type] == 'DQ_CompletenessOmission' }&.dig(:descriptiveResult, 0, :statement)
+              commission = hDataQuality[:report].find { |report| report[:type] == 'DQ_CompletenessCommission' }&.dig(:descriptiveResult, 0, :statement)
+              complete = [omission, commission].compact.join(' ')
+              if complete != ''
+                @xml.tag!('complete', complete)
+              else
+                @xml.tag!('complete', 'Not Reported')
+              end
+
+              # data quality 2.4 (posacc) - Positional Accuracy
+              reports = hDataQuality[:report].select do |report|
+                [
+                  'DQ_AbsoluteExternalPositionalAccuracy',
+                  'DQ_RelativeInternalPositionalAccuracy',
+                  'DQ_GriddedDataPositionalAccuracy'
+                ].include?(report[:type]) && !report.dig(:descriptiveResult, 0, :statement).nil?
+              end
+
+              horizpar = ''
+              vertaccr = ''
+
+              reports.each do |report|
+                descriptive_result = report.dig(:descriptiveResult, 0)
+                next unless descriptive_result
+
+                if descriptive_result[:name] == 'Vertical Positional Accuracy Report'
+                  vertaccr = descriptive_result[:statement]
+                else
+                  horizpar = descriptive_result[:statement]
+                end
+              end
+
+              if !horizpar.empty? || !vertaccr.empty?
+                @xml.tag!('posacc') do
+                  if !horizpar.empty?
+                    @xml.tag!('horizpa') do
+                      @xml.tag!('horizpar', horizpar)
+                    end
                   end
 
-                  # data quality 2.6 (cloud) - cloud cover (not implemented)
-                  if @hResponseObj[:writerShowTags]
-                     @xml.tag!('cloud', 'Not Reported')
+                  if !vertaccr.empty?
+                    @xml.tag!('vertacc') do
+                      @xml.tag!('vertaccr', vertaccr)
+                    end
                   end
+                end
+              elsif @hResponseObj[:writerShowTags]
+                @xml.tag!('position', 'Not Reported')
+              end
+
+              # data quality 2.5 (lineage) - lineage (required)
+              unless intObj[:metadata][:lineageInfo].empty?
+                @xml.tag!('lineage') do
+                  lineageClass.writeXML(intObj[:metadata][:lineageInfo])
+                end
+              end
+              if intObj[:metadata][:lineageInfo].empty?
+                @NameSpace.issueWarning(350, nil, 'data quality section')
+              end
+
+              # data quality 2.6 (cloud) - cloud cover (not implemented)
+              if @hResponseObj[:writerShowTags]
+                @xml.tag!('cloud', 'Not Reported')
+              end
+
+            end # writeXML
+          end # DataQuality
+
+        end # Quality
 
-               end # writeXML
-            end # Quality
-
-         end
       end
-   end
-end
+    end
+  end
+end

data/lib/adiwg/mdtranslator/writers/fgdc/classes/class_spatialDomain.rb

@@ -127,7 +127,7 @@ module ADIWG
 
                                     # altitude bounding (altmax) - maximum altitude (required)
                                     unless hBBox[:maximumAltitude].nil?
-                                       @xml.tag!('altmax', hBBox[:minimumAltitude])
+                                       @xml.tag!('altmax', hBBox[:maximumAltitude])
                                     end
                                     if hBBox[:maximumAltitude].nil?
                                        @NameSpace.issueWarning(372, 'altmax')

data/lib/adiwg/mdtranslator/writers/iso19115_3/classes/class_enumerationList.rb

@@ -0,0 +1,52 @@
+# ISO <<CodeLists>> Enumerations
+# 19115-2 writer output in XML
+
+# History:
+#  Stan Smith 2016-12-12 refactored for mdTranslator/mdJson 2.0
+#  Stan Smith 2015-07-14 refactored to eliminate namespace globals $WriterNS and $IsoNS
+#  Stan Smith 2015-07-14 refactored to make iso19110 independent of iso19115_2 classes
+#  Stan Smith 2015-06-22 replace global ($response) with passed in object (responseObj)
+#  Stan Smith 2015-06-12 refactored to use mdCodes gem for codelist contents
+#  Stan Smith 2014-12-15 replaced NOAA CT_CodelistCatalogue with mdTranslator CT_CodelistCatalogue
+#  Stan Smith 2014-12-12 refactored to handle namespacing readers and writers
+#  Stan Smith 2014-10-15 allow non-ISO codesNames to be rendered
+# 	Stan Smith 2013-08-09 original script
+
+require 'adiwg-mdcodes'
+
+module ADIWG
+   module Mdtranslator
+      module Writers
+         module Iso19115_3
+
+            class MD_EnumerationList
+
+               def initialize(xml, responseObj)
+                  @xml = xml
+                  @hResponseObj = responseObj
+               end
+
+               def writeXML(codeList, codeName)
+
+                  # get requested codelist from the adiwg-mdcodes gem
+                  mdCodelist = ADIWG::Mdcodes.getCodelistDetail(codeList)
+
+                  sourceName = mdCodelist['sourceName']
+                  codelist = mdCodelist['codelist']
+
+                  # search the codelist for a matching codeName
+                  # only valid enumeration values can be written in ISO
+                  codelist.each do |code|
+                     if code['codeName'] == codeName
+                        @xml.tag!('gmd:' + "#{sourceName}", codeName)
+                        break
+                     end
+                  end
+
+               end # writeXML
+            end # MD_EnumerationList class
+
+         end
+      end
+   end
+end