adhearsion 1.0.2 → 1.0.3

data/CHANGELOG

@@ -1,9 +1,12 @@
+1.0.3
+ - Fix the play() command regression when passing an array of strings. This was breaking the SimonGame
+ - Deprecate ManagerInterface#send_action_asynchronously
+
 1.0.2
  - Fix rcov Rake task
  - Add Ben Langfeld as an author (Thanks, Ben!)
  - Add "rake" as a runtime dependency
  - Remove usage of BEGIN blocks (for Rubinius; CS)
- - Improve component testing generators
 
 1.0.1
  NOTE for Ruby 1.9 users: The behavior of Ruby 1.9 and case statements has changed

data/lib/adhearsion/initializer.rb

@@ -91,7 +91,7 @@ module Adhearsion
       end
 
       def ahn_root=(path)
-        if Object.constants.include?("AHN_ROOT")
+        if Object.constants.map(&:to_sym).include?(:AHN_ROOT)
           Object.const_get(:AHN_ROOT).base_path = File.expand_path(path)
         else
           Object.const_set(:AHN_ROOT, PathString.new(File.expand_path(path)))

data/lib/adhearsion/version.rb

@@ -2,7 +2,7 @@ module Adhearsion #:nodoc:
   module VERSION #:nodoc:
     MAJOR = 1 unless defined? MAJOR
     MINOR = 0 unless defined? MINOR
-    TINY  = 2 unless defined? TINY
+    TINY  = 3 unless defined? TINY
 
     STRING = [MAJOR, MINOR, TINY].join('.') unless defined? STRING
   end

data/lib/adhearsion/voip/asterisk/commands.rb

@@ -175,7 +175,7 @@ module Adhearsion
         # Fixnums (e.g. 1000), Strings which are valid Fixnums (e.g "123"), and direct sound files. When playing
         # numbers, Adhearsion assumes you're saying the number, not the digits. For example, play("100")
         # is pronounced as "one hundred" instead of "one zero zero". To specify how the Date/Time objects are said
-        # pass in as an array with the first parameter as the Date/Time/DateTime object along with a hash with the 
+        # pass in as an array with the first parameter as the Date/Time/DateTime object along with a hash with the
         # additional options.  See play_time for more information.
         #
         # Note: it is not necessary to supply a sound file extension; Asterisk will try to find a sound
@@ -196,8 +196,10 @@ module Adhearsion
         #   play "you-sound-cute", "what-are-you-wearing"
         #
         def play(*arguments)
-          arguments.each do |argument|
-            play_time(argument) || play_numeric(argument) || play_string(argument)
+          unless play_time(arguments)
+            arguments.flatten.each do |argument|
+              play_numeric(argument) || play_string(argument)
+            end
           end
         end
 
@@ -347,14 +349,14 @@ module Adhearsion
         # It's important to understand the differences between these and how they affect the overall outcome:
         #
         #   |---------------|-------------------|------------------------------------------------------|
-        #   | exact matches |	potential matches	| result                                               |
+        #   | exact matches | potential matches | result                                               |
         #   |---------------|-------------------|------------------------------------------------------|
-        #   |  0	          |  0	               | Fail and start over                                  |
-        #   |  1	          |  0	               | Match found!                                         |
-        #   |  0	          | >0	               | Get another digit                                    |
-        #   | >1	          |  0	               | Go with the first exact match                        |
-        #   |  1	          | >0	               | Get another digit. If timeout, use exact match       |
-        #   | >1	          | >0	               | Get another digit. If timeout, use first exact match |
+        #   |  0            |  0                 | Fail and start over                                  |
+        #   |  1            |  0                 | Match found!                                         |
+        #   |  0            | >0                 | Get another digit                                    |
+        #   | >1            |  0                 | Go with the first exact match                        |
+        #   |  1            | >0                 | Get another digit. If timeout, use exact match       |
+        #   | >1            | >0                 | Get another digit. If timeout, use first exact match |
         #   |---------------|-------------------|------------------------------------------------------|
         #
         # == Database integration
@@ -450,30 +452,30 @@ module Adhearsion
         #  1. The number of digits you specify as the first argument is collected
         #  2. The timeout you specify with the :timeout option elapses.
         #  3. The "#" key (or the key you specify with :accept_key) is pressed
-      	#
-      	# Usage examples
-      	#
-      	#   input   # Receives digits until the caller presses the "#" key
-      	#   input 3 # Receives three digits. Can be 0-9, * or #
-      	#   input 5, :accept_key => "*"   # Receive at most 5 digits, stopping if '*' is pressed
-      	#   input 1, :timeout => 1.minute # Receive a single digit, returning an empty
-      	#                                   string if the timeout is encountered
-      	#   input 9, :timeout => 7, :accept_key => "0" # Receives nine digits, returning
-      	#                                              # when the timeout is encountered
-      	#                                              # or when the "0" key is pressed.
-      	#   input 3, :play => "you-sound-cute"
-      	#   input :play => ["if-this-is-correct-press", 1, "otherwise-press", 2]
-      	#
-      	# When specifying files to play, the playback of the sequence of files will stop
-      	# immediately when the user presses the first digit.
-      	#
-      	# The :timeout option works like a digit timeout, therefore each digit pressed
-      	# causes the timer to reset. This is a much more user-friendly approach than an
+        #
+        # Usage examples
+        #
+        #   input   # Receives digits until the caller presses the "#" key
+        #   input 3 # Receives three digits. Can be 0-9, * or #
+        #   input 5, :accept_key => "*"   # Receive at most 5 digits, stopping if '*' is pressed
+        #   input 1, :timeout => 1.minute # Receive a single digit, returning an empty
+        #                                   string if the timeout is encountered
+        #   input 9, :timeout => 7, :accept_key => "0" # Receives nine digits, returning
+        #                                              # when the timeout is encountered
+        #                                              # or when the "0" key is pressed.
+        #   input 3, :play => "you-sound-cute"
+        #   input :play => ["if-this-is-correct-press", 1, "otherwise-press", 2]
+        #
+        # When specifying files to play, the playback of the sequence of files will stop
+        # immediately when the user presses the first digit.
+        #
+        # The :timeout option works like a digit timeout, therefore each digit pressed
+        # causes the timer to reset. This is a much more user-friendly approach than an
         # absolute timeout.
-      	#
+        #
         # Note that when the digit limit is not specified the :accept_key becomes "#".
         # Otherwise there would be no way to end the collection of digits. You can
-      	# obviously override this by passing in a new key with :accept_key.
+        # obviously override this by passing in a new key with :accept_key.
         def input(*args)
           options = args.last.kind_of?(Hash) ? args.pop : {}
           number_of_digits = args.shift
@@ -510,7 +512,7 @@ module Adhearsion
             end
             key = wait_for_digit(timeout || -1)
           end
-      	end
+        end
 
         # Jumps to a context. An alternative to DialplanContextProc#+@. When jumping to a context, it will *not* resume executing
         # the former context when the jumped-to context has finished executing. Make sure you don't have any
@@ -545,36 +547,36 @@ module Adhearsion
           raise Adhearsion::VoIP::DSL::Dialplan::ControlPassingException.new(context)
         end
 
-      	# Place a call in a queue to be answered by a registered agent. You must then call join!()
-      	#
-      	# @param [String] queue_name the queue name to place the caller in
-      	# @return [Adhearsion::VoIP::Asterisk::Commands::QueueProxy] a queue proxy object
+        # Place a call in a queue to be answered by a registered agent. You must then call join!()
+        #
+        # @param [String] queue_name the queue name to place the caller in
+        # @return [Adhearsion::VoIP::Asterisk::Commands::QueueProxy] a queue proxy object
         #
         # @see http://www.voip-info.org/wiki-Asterisk+cmd+Queue Full information on the Asterisk Queue
         # @see Adhearsion::VoIP::Asterisk::Commands::QueueProxy#join! join!() for further details
-      	def queue(queue_name)
-      	  queue_name = queue_name.to_s
-
-      	  @queue_proxy_hash_lock = Mutex.new unless defined? @queue_proxy_hash_lock
-      	  @queue_proxy_hash_lock.synchronize do
-      	    @queue_proxy_hash ||= {}
-      	    if @queue_proxy_hash.has_key? queue_name
-        	    return @queue_proxy_hash[queue_name]
-      	    else
-      	      proxy = @queue_proxy_hash[queue_name] = QueueProxy.new(queue_name, self)
-      	      return proxy
-    	      end
-      	  end
-    	  end
-
-      	# Get the status of the last dial(). Possible dial statuses include :answer,
+        def queue(queue_name)
+          queue_name = queue_name.to_s
+
+          @queue_proxy_hash_lock = Mutex.new unless defined? @queue_proxy_hash_lock
+          @queue_proxy_hash_lock.synchronize do
+            @queue_proxy_hash ||= {}
+            if @queue_proxy_hash.has_key? queue_name
+              return @queue_proxy_hash[queue_name]
+            else
+              proxy = @queue_proxy_hash[queue_name] = QueueProxy.new(queue_name, self)
+              return proxy
+            end
+          end
+        end
+
+        # Get the status of the last dial(). Possible dial statuses include :answer,
         # :busy, :no_answer, :cancelled, :congested, and :channel_unavailable.
         # If :cancel is returned, the caller hung up before the callee picked up.
         # If :congestion is returned, the dialed extension probably doesn't exist.
         # If :channel_unavailable, the callee phone may not be registered.
-      	def last_dial_status
-      	  DIAL_STATUSES[get_dial_status]
-      	end
+        def last_dial_status
+          DIAL_STATUSES[get_dial_status]
+        end
 
         # @return [Boolean] true if your last call to dial() finished with the ANSWER state,
         # as reported by Asterisk. false otherwise
@@ -663,49 +665,49 @@ module Adhearsion
         # @param [String] variable_name
         #
         # @see: http://www.voip-info.org/wiki/view/get+variable Asterisk Get Variable
-      	def get_variable(variable_name)
-      	  result = response("GET VARIABLE", variable_name)
-      	  case result
-      	    when "200 result=0"
-      	      return nil
-    	    when /^200 result=1 \((.*)\)$/
-    	      return $LAST_PAREN_MATCH
-    	    end
-    	  end
-
-    	  # Pass information back to the asterisk dial plan.
-    	  #
-    	  # Keep in mind that the variables are not global variables. These variables only exist for the channel
-    	  # related to the call that is being serviced by the particular instance of your adhearsion application.
-    	  # You will not be able to pass information back to the asterisk dialplan for other instances of your adhearsion
-    	  # application to share. Once the channel is "hungup" then the variables are cleared and their information is gone.
-    	  #
-    	  # @param [String] variable_name
-    	  # @param [String] value
-    	  #
-    	  # @see http://www.voip-info.org/wiki/view/set+variable Asterisk Set Variable
-    	  def set_variable(variable_name, value)
-    	    response("SET VARIABLE", variable_name, value) == "200 result=1"
-  	    end
-        
+        def get_variable(variable_name)
+          result = response("GET VARIABLE", variable_name)
+          case result
+            when "200 result=0"
+              return nil
+          when /^200 result=1 \((.*)\)$/
+            return $LAST_PAREN_MATCH
+          end
+        end
+
+        # Pass information back to the asterisk dial plan.
+        #
+        # Keep in mind that the variables are not global variables. These variables only exist for the channel
+        # related to the call that is being serviced by the particular instance of your adhearsion application.
+        # You will not be able to pass information back to the asterisk dialplan for other instances of your adhearsion
+        # application to share. Once the channel is "hungup" then the variables are cleared and their information is gone.
+        #
+        # @param [String] variable_name
+        # @param [String] value
+        #
+        # @see http://www.voip-info.org/wiki/view/set+variable Asterisk Set Variable
+        def set_variable(variable_name, value)
+          response("SET VARIABLE", variable_name, value) == "200 result=1"
+        end
+
         # Issue the command to add a custom SIP header to the current call channel
         # example use: sip_add_header("x-ahn-test", "rubyrox")
         #
         # @param[String] the name of the SIP header
         # @param[String] the value of the SIP header
-        # 
+        #
         # @return [String] the Asterisk response
         #
         # @see http://www.voip-info.org/wiki/index.php?page=Asterisk+cmd+SIPAddHeader Asterisk SIPAddHeader
         def sip_add_header(header, value)
           execute("SIPAddHeader", "#{header}: #{value}") == "200 result=1"
         end
-        
+
         # Issue the command to fetch a SIP header from the current call channel
         # example use: sip_get_header("x-ahn-test")
         #
         # @param[String] the name of the SIP header to get
-        # 
+        #
         # @return [String] the Asterisk response
         #
         # @see http://www.voip-info.org/wiki/index.php?page=Asterisk+cmd+SIPGetHeader Asterisk SIPGetHeader
@@ -713,32 +715,32 @@ module Adhearsion
           get_variable("SIP_HEADER(#{header})")
         end
         alias :sip_header :sip_get_header
-        
-    	  # Allows you to either set or get a channel variable from Asterisk.
-    	  # The method takes a hash key/value pair if you would like to set a variable
-    	  # Or a single string with the variable to get from Asterisk
-    	  def variable(*args)
-    	    if args.last.kind_of? Hash
-      	    assignments = args.pop
-      	    raise ArgumentError, "Can't mix variable setting and fetching!" if args.any?
-      	    assignments.each_pair do |key, value|
-      	      set_variable(key, value)
-    	      end
-    	    else
-    	      if args.size == 1
-    	        get_variable args.first
-  	        else
-      	      args.map { |var| get_variable(var) }
-    	      end
-    	    end
-  	    end
-
-    	  # Send a caller to a voicemail box to leave a message.
-    	  #
-    	  # The method takes the mailbox_number of the user to leave a message for and a
-    	  # greeting_option that will determine which message gets played to the caller.
-    	  #
-    	  # @see http://www.voip-info.org/tiki-index.php?page=Asterisk+cmd+VoiceMail Asterisk Voicemail
+
+        # Allows you to either set or get a channel variable from Asterisk.
+        # The method takes a hash key/value pair if you would like to set a variable
+        # Or a single string with the variable to get from Asterisk
+        def variable(*args)
+          if args.last.kind_of? Hash
+            assignments = args.pop
+            raise ArgumentError, "Can't mix variable setting and fetching!" if args.any?
+            assignments.each_pair do |key, value|
+              set_variable(key, value)
+            end
+          else
+            if args.size == 1
+              get_variable args.first
+            else
+              args.map { |var| get_variable(var) }
+            end
+          end
+        end
+
+        # Send a caller to a voicemail box to leave a message.
+        #
+        # The method takes the mailbox_number of the user to leave a message for and a
+        # greeting_option that will determine which message gets played to the caller.
+        #
+        # @see http://www.voip-info.org/tiki-index.php?page=Asterisk+cmd+VoiceMail Asterisk Voicemail
         def voicemail(*args)
           options_hash    = args.last.kind_of?(Hash) ? args.pop : {}
           mailbox_number  = args.shift
@@ -884,20 +886,20 @@ module Adhearsion
         # end
 
 
-      	# Speaks the digits given as an argument. For example, "123" is spoken as "one two three".
-      	#
-      	# @param [String] digits
-      	def say_digits(digits)
-      	  execute "saydigits", validate_digits(digits)
-      	end
-
-      	# Get the number of seconds the given block takes to execute. This
-      	# is particularly useful in dialplans for tracking billable time. Note that
-      	# if the call is hung up during the block, you will need to rescue the
-      	# exception if you have some mission-critical logic after it with which
-      	# you're recording this return-value.
-      	#
-      	# @return [Float] number of seconds taken for block to execute
+        # Speaks the digits given as an argument. For example, "123" is spoken as "one two three".
+        #
+        # @param [String] digits
+        def say_digits(digits)
+          execute "saydigits", validate_digits(digits)
+        end
+
+        # Get the number of seconds the given block takes to execute. This
+        # is particularly useful in dialplans for tracking billable time. Note that
+        # if the call is hung up during the block, you will need to rescue the
+        # exception if you have some mission-critical logic after it with which
+        # you're recording this return-value.
+        #
+        # @return [Float] number of seconds taken for block to execute
         def duration_of
           start_time = Time.now
           yield
@@ -918,7 +920,7 @@ module Adhearsion
         end
 
         ##
-        # Executes the SayPhonetic command. This command will read the text passed in 
+        # Executes the SayPhonetic command. This command will read the text passed in
         # out load using the NATO phonetic alphabet.
         #
         # @param [String] Passed in as the text to read aloud
@@ -956,21 +958,21 @@ module Adhearsion
           argument, options = args.flatten
           options ||= {}
 
+          return false unless options.is_a? Hash
+
           timezone = options.delete(:timezone) || ''
           format   = options.delete(:format)   || ''
-          epoch    = case argument.class.to_s
-                     when 'Time'      then argument.to_i
-                     when 'DateTime'  then argument.to_i
-                     when 'Date'
+          epoch    = case argument
+                     when Time || DateTime
+                       argument.to_i
+                     when Date
                        format = 'BdY' unless format.present?
                        argument.to_time.to_i
-                     else
-                       nil
                      end
 
           return false if epoch.nil?
 
-          execute(:sayunixtime, epoch, timezone, format)
+          execute :sayunixtime, epoch, timezone, format
         end
 
         protected
@@ -1251,7 +1253,7 @@ module Adhearsion
             #    queue('sales').join! :allow_transfer => :agent, :timeout => 30.seconds,
             def join!(options={})
               environment.execute("queue", name, *self.class.format_join_hash_key_arguments(options))
-          	  normalize_queue_status_variable environment.variable("QUEUESTATUS")
+              normalize_queue_status_variable environment.variable("QUEUESTATUS")
             end
 
             # Get the agents associated with a queue
@@ -1310,7 +1312,7 @@ module Adhearsion
             # LEAVEUNAVAIL => :leaveunavail
             # CONTINUE     => :continue
             #
-            # If the QUEUESTATUS variable is not set the call was successfully connected, 
+            # If the QUEUESTATUS variable is not set the call was successfully connected,
             # and Adhearsion will return :completed.
             #
             # @param [String] QUEUESTATUS variable from Asterisk

data/lib/adhearsion/voip/asterisk/manager_interface.rb

@@ -285,16 +285,20 @@ module Adhearsion
           # @param [String, Symbol] action_name The name of the action (e.g. Originate)
           # @param [Hash] headers Other key/value pairs to send in this action. Note: don't provide an ActionID
           # @return [FutureResource] Call resource() on this object if you wish to access the response (optional). Note: if the response has not come in yet, your Thread will wait until it does.
+          # @deprecated Async AMI is deprecated
           #
           def send_action_asynchronously(action_name, headers={})
-            check_action_name action_name
-            action = ManagerInterfaceAction.new(action_name, headers)
-            if action.replies_with_action_id?
-              @write_queue << action
-              action
-            else
-              raise NotImplementedError
-            end
+            ahn_log.ami.deprecation.warn  <<WARN
+\n
+  Asterisk only supports one outstanding action ID at a time, making the
+  asynchronous AMI interface dangerous to use.  This interface is now
+  deprecated and will disappear in future versions of Adhearsion.  If you need
+  to do background processing while Asterisk processes a long-running action
+  (such as a synchronous Originate) then you will need to handle this manually
+  with Ruby threads.  Note that Originate specifically has an :Async header
+  which tells Asterisk to process the Originate event asynchronously.
+WARN
+            _send_action_asynchronously(action_name, headers)
           end
 
           ##
@@ -307,35 +311,20 @@ module Adhearsion
           # @return [ManagerInterfaceResponse, ImmediateResponse] Contains the response from Asterisk and all headers
           #
           def send_action_synchronously(*args)
-            send_action_asynchronously(*args).response.tap do |response|
+            _send_action_asynchronously(*args).response.tap do |response|
               raise response if response.kind_of?(ManagerInterfaceError)
             end
           end
 
           alias send_action send_action_synchronously
 
-
-          #######                                              #######
-          ###########                                      ###########
-          ################# SOON-DEPRECATED COMMANDS #################
-          ###########                                      ###########
-          #######                                              #######
-
           # ping sends an action to the Asterisk Manager Interface that returns a pong
           # more details here: http://www.voip-info.org/wiki/index.php?page=Asterisk+Manager+API+Action+Ping
           def ping
-            #deprecation_warning
             send_action "Ping"
             true
           end
 
-          def deprecation_warning
-            ahn_log.ami.deprecation.warn "The implementation of the ping, originate, introduce, hangup, call_into_context " +
-                "and call_and_exec methods will soon be moved from this class to SuperManager. At the moment, the " +
-                "SuperManager abstractions are not completed. Don't worry. The migration to SuperManager will be very easy."+
-                " See http://docs.adhearsion.com/AMI for more information."
-          end
-
           # The originate method launches a call to Asterisk, full details here:
           # http://www.voip-info.org/tiki-index.php?page=Asterisk+Manager+API+Action+Originate
           # Takes these arguments as a hash:
@@ -360,7 +349,6 @@ module Adhearsion
           #             :exten    => 's',
           #             :priority => '1' }
           def originate(options={})
-            #deprecation_warning
             options = options.clone
             options[:callerid] = options.delete :caller_id if options.has_key? :caller_id
             options[:exten] = options.delete :extension if options.has_key? :extension
@@ -382,7 +370,6 @@ module Adhearsion
           # TODO: Provide an example when this works.
           #
           def introduce(caller, callee, opts={})
-            #deprecation_warning
             dial_args  = callee
             dial_args += "|#{opts[:options]}" if opts[:options]
             call_and_exec caller, "Dial", :args => dial_args, :caller_id => opts[:caller_id]
@@ -391,14 +378,12 @@ module Adhearsion
           # hangup terminates a call accepts a channel as the argument
           # full details here: http://www.voip-info.org/wiki/index.php?page=Asterisk+Manager+API+Action+Hangup
           def hangup(channel)
-            #deprecation_warning
             send_action "Hangup", :channel => channel
           end
 
           # call_and_exec allows you to make a call to a channel and then execute an Astersik application
           # on that call
           def call_and_exec(channel, app, opts={})
-            #deprecation_warning
             args = { :channel => channel, :application => app }
             args[:caller_id] = opts[:caller_id] if opts[:caller_id]
             args[:data] = opts[:args] if opts[:args]
@@ -411,7 +396,6 @@ module Adhearsion
           #
           # call_into_context('SIP/1000@sipnetworks.com', 'my_context', { :variables => { :session_guid => new_guid }})
           def call_into_context(channel, context, options={})
-            #deprecation_warning
             args = {:channel => channel, :context => context}
             args[:priority] = options[:priority] || 1
             args[:exten] = options[:extension] if options[:extension]
@@ -420,11 +404,18 @@ module Adhearsion
             originate args
           end
 
-          #######                                                  #######
-          ###########                                          ###########
-          ################# END SOON-DEPRECATED COMMANDS #################
-          ###########                                          ###########
-          #######                                                  #######
+          private
+          def _send_action_asynchronously(action_name, headers={})
+            check_action_name action_name
+            action = ManagerInterfaceAction.new(action_name, headers)
+            if action.replies_with_action_id?
+              @write_queue << action
+              action
+            else
+              raise NotImplementedError
+            end
+          end
+
 
 
           protected
@@ -582,25 +573,22 @@ module Adhearsion
             retry
           end
 
-          def login_actions
-            action = send_action_asynchronously "Login", "Username" => @username, "Secret" => @password, "Events" => "Off"
-            response = action.response
-            if response.kind_of? ManagerInterfaceError
-              raise AuthenticationFailedException, "Incorrect username and password! #{response.message}"
+          def login_actions        
+            response = send_action "Login", "Username" => @username, "Secret" => @password, "Events" => "Off"
+            ahn_log.ami "Successful AMI actions-only connection into #{@username}@#{@host}"
+            if @actions_lexer.ami_version < 1.1
+              @coreSettings = Hash.new
+              @coreSettings["AsteriskVersion"] = "1.4.0"
+              @coreSettings["AMIversion"] = "1.0"
+              @coreSettings["ArgumentDelimiter"] = "|"
             else
-              ahn_log.ami "Successful AMI actions-only connection into #{@username}@#{@host}"
-              if @actions_lexer.ami_version < 1.1
-                @coreSettings = Hash.new
-                @coreSettings["AsteriskVersion"] = "1.4.0"
-                @coreSettings["AMIversion"] = "1.0"
-                @coreSettings["ArgumentDelimiter"] = "|"
-              else
-                @coreSettings = send_action_synchronously("CoreSettings").headers
-                @coreSettings["ArgumentDelimiter"] = ","
-              end
-              UnsupportedActionName::preinitialize(@coreSettings["AsteriskVersion"].to_f)
-              response
+              @coreSettings = send_action_synchronously("CoreSettings").headers
+              @coreSettings["ArgumentDelimiter"] = ","
             end
+            UnsupportedActionName::preinitialize(@coreSettings["AsteriskVersion"].to_f)
+            response
+          rescue ManagerInterfaceError => e
+            raise AuthenticationFailedException, "Incorrect username and password! #{e.message}"
           end
 
           def disconnect_events_connection