adequate_serialization 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a78d88a2501cf72c9d7b2752de13d260fbe6e2b3aae542dded2e7f7a8f61f037
-  data.tar.gz: 5242b799a239f6224461bc00ffdd60f2d182edf9f28e405228321bf382871672
+  metadata.gz: 5c44c471509c73b1edc5a18d3ccfdf9e05643ce234b10be8a5a2e3eadaa89ab4
+  data.tar.gz: 290271ba291a48c85f7e4cc5691d32056f2c3215cf6a5af069f26a5b63a7e4ad
 SHA512:
-  metadata.gz: d5d4071ea9064f3f54ae6f375f767d61f7417e4da907422526cfa83a7e6af572ae4b2963277f2dfb497a57e408343c6f4c0a0a265c0cfa6064dfd318beecba68
-  data.tar.gz: c16e33d20c2b7000d3a0601b9f1fd353b1149314ce2f238d74e3515482b0330a12ac89aaa0e983bb0c08ba975e00ecf1409d3a81f099a94518ea8be78c243434
+  metadata.gz: 81aaf4709e2f4d6e0546f8212ee01ebf3fcf0b55d66d8f54c2f16e763eb4853d36154fada8e2f1f311a49cf15aa8cae6f094e2f90861e5aeb3ffc4fe7fff12ad
+  data.tar.gz: 9e510a610e415d090c0ee430d3add1b3ddd4d08a8e762d35f5f8d8bd8f6580a3039eba0bd7bfd3d766b4680e5bb3e2261701ae3dbbc3637ef3da936a6c71e9a5

data/.travis.yml

@@ -7,6 +7,4 @@ branches:
 before_install:
 - gem update --system
 - gem install bundler
-script:
-- bundle exec rake
-- bundle exec rubocop --parallel
+script: bundle exec rake && bundle exec rubocop --parallel

data/CHANGELOG.md

@@ -0,0 +1,14 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+## [0.1.1] - 2018-08-30
+### Changed
+- No longer trigger another query when the `ActiveRecord` relation being serialized isn't loaded.
+
+[Unreleased]: https://github.com/CultureHQ/client/compare/v0.1.1...HEAD
+[0.1.1]: https://github.com/CultureHQ/client/compare/v0.1.0...v0.1.1

data/Gemfile.lock

@@ -1,48 +1,48 @@
 PATH
   remote: .
   specs:
-    adequate_serialization (0.1.0)
+    adequate_serialization (0.1.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (5.2.0)
-      actionpack (= 5.2.0)
+    actioncable (5.2.1)
+      actionpack (= 5.2.1)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
-    actionmailer (5.2.0)
-      actionpack (= 5.2.0)
-      actionview (= 5.2.0)
-      activejob (= 5.2.0)
+    actionmailer (5.2.1)
+      actionpack (= 5.2.1)
+      actionview (= 5.2.1)
+      activejob (= 5.2.1)
       mail (~> 2.5, >= 2.5.4)
       rails-dom-testing (~> 2.0)
-    actionpack (5.2.0)
-      actionview (= 5.2.0)
-      activesupport (= 5.2.0)
+    actionpack (5.2.1)
+      actionview (= 5.2.1)
+      activesupport (= 5.2.1)
       rack (~> 2.0)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.2.0)
-      activesupport (= 5.2.0)
+    actionview (5.2.1)
+      activesupport (= 5.2.1)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activejob (5.2.0)
-      activesupport (= 5.2.0)
+    activejob (5.2.1)
+      activesupport (= 5.2.1)
       globalid (>= 0.3.6)
-    activemodel (5.2.0)
-      activesupport (= 5.2.0)
-    activerecord (5.2.0)
-      activemodel (= 5.2.0)
-      activesupport (= 5.2.0)
+    activemodel (5.2.1)
+      activesupport (= 5.2.1)
+    activerecord (5.2.1)
+      activemodel (= 5.2.1)
+      activesupport (= 5.2.1)
       arel (>= 9.0)
-    activestorage (5.2.0)
-      actionpack (= 5.2.0)
-      activerecord (= 5.2.0)
+    activestorage (5.2.1)
+      actionpack (= 5.2.1)
+      activerecord (= 5.2.1)
       marcel (~> 0.3.1)
-    activesupport (5.2.0)
+    activesupport (5.2.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
@@ -52,12 +52,13 @@ GEM
     builder (3.2.3)
     concurrent-ruby (1.0.5)
     crass (1.0.4)
-    docile (1.3.0)
+    docile (1.3.1)
     erubi (1.7.1)
     globalid (0.4.1)
       activesupport (>= 4.2.0)
-    i18n (1.0.1)
+    i18n (1.1.0)
       concurrent-ruby (~> 1.0)
+    jaro_winkler (1.5.1)
     json (2.1.0)
     loofah (2.2.2)
       crass (~> 1.0.2)
@@ -68,59 +69,60 @@ GEM
       mimemagic (~> 0.3.2)
     method_source (0.9.0)
     mimemagic (0.3.2)
-    mini_mime (1.0.0)
+    mini_mime (1.0.1)
     mini_portile2 (2.3.0)
     minitest (5.11.3)
     nio4r (2.3.1)
-    nokogiri (1.8.2)
+    nokogiri (1.8.4)
       mini_portile2 (~> 2.3.0)
     parallel (1.12.1)
-    parser (2.5.1.0)
+    parser (2.5.1.2)
       ast (~> 2.4.0)
-    powerpack (0.1.1)
+    powerpack (0.1.2)
     rack (2.0.5)
-    rack-test (1.0.0)
+    rack-test (1.1.0)
       rack (>= 1.0, < 3)
-    rails (5.2.0)
-      actioncable (= 5.2.0)
-      actionmailer (= 5.2.0)
-      actionpack (= 5.2.0)
-      actionview (= 5.2.0)
-      activejob (= 5.2.0)
-      activemodel (= 5.2.0)
-      activerecord (= 5.2.0)
-      activestorage (= 5.2.0)
-      activesupport (= 5.2.0)
+    rails (5.2.1)
+      actioncable (= 5.2.1)
+      actionmailer (= 5.2.1)
+      actionpack (= 5.2.1)
+      actionview (= 5.2.1)
+      activejob (= 5.2.1)
+      activemodel (= 5.2.1)
+      activerecord (= 5.2.1)
+      activestorage (= 5.2.1)
+      activesupport (= 5.2.1)
       bundler (>= 1.3.0)
-      railties (= 5.2.0)
+      railties (= 5.2.1)
       sprockets-rails (>= 2.0.0)
     rails-dom-testing (2.0.3)
       activesupport (>= 4.2.0)
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.0.4)
       loofah (~> 2.2, >= 2.2.2)
-    railties (5.2.0)
-      actionpack (= 5.2.0)
-      activesupport (= 5.2.0)
+    railties (5.2.1)
+      actionpack (= 5.2.1)
+      activesupport (= 5.2.1)
       method_source
       rake (>= 0.8.7)
-      thor (>= 0.18.1, < 2.0)
+      thor (>= 0.19.0, < 2.0)
     rainbow (3.0.0)
     rake (12.3.1)
-    rubocop (0.56.0)
+    rubocop (0.58.2)
+      jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.5)
+      parser (>= 2.5, != 2.5.1.1)
       powerpack (~> 0.1)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.9.0)
+    ruby-progressbar (1.10.0)
     simplecov (0.16.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
-    sprockets (3.7.1)
+    sprockets (3.7.2)
       concurrent-ruby (~> 1.0)
       rack (> 1, < 3)
     sprockets-rails (3.2.1)
@@ -132,7 +134,7 @@ GEM
     thread_safe (0.3.6)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
-    unicode-display_width (1.3.2)
+    unicode-display_width (1.4.0)
     websocket-driver (0.7.0)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.3)
@@ -146,7 +148,7 @@ DEPENDENCIES
   minitest (~> 5)
   rails (~> 5, >= 5.2)
   rake (~> 12)
-  rubocop (~> 0.52)
+  rubocop (~> 0.58)
   simplecov (~> 0.16)
   sqlite3
 

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2018 Kevin Deisz
+Copyright (c) 2018 CultureHQ
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -1,6 +1,7 @@
 # AdequateSerialization
 
-[![Build Status](https://travis-ci.org/kddeisz/adequate_serialization.svg?branch=master)](https://travis-ci.org/kddeisz/adequate_serialization)
+[![Build Status](https://travis-ci.org/CultureHQ/adequate_serialization.svg?branch=master)](https://travis-ci.org/CultureHQ/adequate_serialization)
+[![Gem Version](https://img.shields.io/gem/v/adequate_serialization.svg)](https://github.com/CultureHQ/adeqaute_serialization)
 
 Serializes objects adequately. `AdequateSerialization` allows you to define serializers that will convert your objects into simple hashes that are suitable for variable purposes such as caching or using in an HTTP response. It stems from the simple idea of giving slightly more control over the `as_json` method that gets called when objects are serialized using Rails' default controller serialization.
 
@@ -183,7 +184,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/kddeisz/adequate_serialization.
+Bug reports and pull requests are welcome on GitHub at https://github.com/CultureHQ/adequate_serialization.
 
 ## License
 

data/adequate_serialization.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
   spec.email         = ['kevin.deisz@gmail.com']
 
   spec.summary       = 'Serializes objects adequately'
-  spec.homepage      = 'https://github.com/kddeisz/adequate_serialization'
+  spec.homepage      = 'https://github.com/CultureHQ/adequate_serialization'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
@@ -24,6 +24,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1'
   spec.add_development_dependency 'minitest', '~> 5'
   spec.add_development_dependency 'rake', '~> 12'
-  spec.add_development_dependency 'rubocop', '~> 0.52'
+  spec.add_development_dependency 'rubocop', '~> 0.58'
   spec.add_development_dependency 'simplecov', '~> 0.16'
 end

data/lib/adequate_serialization/rails/relation_serializer.rb

@@ -10,7 +10,12 @@ module AdequateSerialization
       end
 
       def as_json(*options)
-        return [] if relation.empty?
+        # Very purposefully using #length here. If you use #empty? or #count and
+        # the relation isn't yet loaded, it's going to trigger another query.
+        # Since we're going to need to map over each of the results in order to
+        # serialize it anyway, it's better just to load it now and avoid the
+        # extra query.
+        return [] if relation.length.zero?
 
         opts = Options.from(*options, multi_caching: true)
         decorator = Decorator.from(opts.attachments)

data/lib/adequate_serialization/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AdequateSerialization
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: adequate_serialization
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Kevin Deisz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-05-30 00:00:00.000000000 Z
+date: 2018-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.52'
+        version: '0.58'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.52'
+        version: '0.58'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -90,6 +90,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -112,7 +113,7 @@ files:
 - lib/adequate_serialization/steps/passthrough_step.rb
 - lib/adequate_serialization/steps/serialize_step.rb
 - lib/adequate_serialization/version.rb
-homepage: https://github.com/kddeisz/adequate_serialization
+homepage: https://github.com/CultureHQ/adequate_serialization
 licenses:
 - MIT
 metadata: {}