adequate_exposure 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 626c4da5b880bf6134c02ee44d83f44df6f57b75
-  data.tar.gz: 1ec2a29a65c9e16811bea76d76ac33a3b149715a
+  metadata.gz: 08518a93835d972d60b024e436f478f894b811c4
+  data.tar.gz: 7d0c3042b2d662a44e1d22ec6415fc46c1957078
 SHA512:
-  metadata.gz: e3ceb0f0b2246cacb2dee1ee1e3fb6d89e94b034566c5a60233bff3324255b2d484079d68e6aebe62ad797fea0d4016ab5f377600fc7720579728e2748d0813e
-  data.tar.gz: df20c7691859271f41aaed077b00f3d4a12e589213919a8bf774ccc1e7a962044267b253054682fcf41f3992f7b62fa5bfc43332081e66c3c29215edaec29125
+  metadata.gz: 3925a14260bd04bf95bba1e8785595ccb2771526b056f42bcc63e88978ab218520bc911462a61b124cef4df0c8103f08e1a2314c63e5623007552387d5786f8a
+  data.tar.gz: 027d750fbafb02bcee26be876daa877e04c033d5656a035c8df117f0289b8ffa5cc3f4becb93563e952f8b1a40ed95c5ac57efd797136eaebaa204af7389ccdd

data/lib/adequate_exposure/exposure.rb

@@ -17,6 +17,7 @@ module AdequateExposure
       assert_singleton_option :from
       assert_incompatible_options_pair :parent, :model
       assert_incompatible_options_pair :parent, :scope
+      assert_incompatible_options_pair :find_by, :find
 
       normalize_options
     end
@@ -70,6 +71,10 @@ module AdequateExposure
       if from = options.delete(:from)
         merge_lambda_option :fetch, ->{ send(from).send(exposure_name) }
       end
+
+      if find_by = options.delete(:find_by)
+        merge_lambda_option :find, ->(id, scope){ scope.find_by!(find_by => id) }
+      end
     end
 
     def normalize_non_proc_option(name)

data/lib/adequate_exposure/flow.rb

@@ -23,7 +23,8 @@ module AdequateExposure
 
     def default_fetch
       computed_scope = scope(model)
-      id ? decorate(find(id, computed_scope)) : decorate(build(computed_scope))
+      instance = id ? find(id, computed_scope) : build(computed_scope)
+      decorate(instance)
     end
 
     def default_id

data/lib/adequate_exposure/version.rb

@@ -1,3 +1,3 @@
 module AdequateExposure
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/controller_spec.rb

@@ -104,7 +104,6 @@ describe AdequateExposure::Controller do
   end
 
   context "default behaviour" do
-
     context "build" do
       let(:thing){ double("Thing") }
 
@@ -138,6 +137,12 @@ describe AdequateExposure::Controller do
           expect(Thing).to receive(:new).with(foo: :bar).and_return(thing)
           expect(controller).to receive(:custom_params_method_name).and_return(foo: :bar)
         end
+
+        it "can use custom build params" do
+          expose :thing, build_params: ->{ foobar }
+          expect(controller).to receive(:foobar).and_return(42)
+          expect(Thing).to receive(:new).with(42).and_return(thing)
+        end
       end
     end
 
@@ -163,6 +168,20 @@ describe AdequateExposure::Controller do
     end
   end
 
+  context "find_by" do
+    it "throws and error when using with :find" do
+      action = ->{ expose :thing, find: :foo, find_by: :bar }
+      expect(&action).to raise_error(ArgumentError, "Using :find_by option with :find doesn't make sense")
+    end
+
+    it "allows to specify what attribute to use for find" do
+      expect(Thing).to receive(:find_by!).with(foo: 10).and_return(42)
+      expose :thing, find_by: :foo
+      controller.params.merge! id: 10
+      expect(controller.thing).to eq(42)
+    end
+  end
+
   context "parent option" do
     context "with scope/model options" do
       it "throws an error when used with scope option" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: adequate_exposure
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Pavel Pravosud