adequack 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 19d707b457e7ae1fd0ad7067027fa90a39697869
-  data.tar.gz: 90d10cb4dd9d948e98c4c688ea75e9521c0888ac
+  metadata.gz: cb0c0c9b3407f1c1dae6c369e477b99d01dca4d2
+  data.tar.gz: 2ff4f234e3298d02d5315aa2127ace31024bf60d
 SHA512:
-  metadata.gz: f3e5594e0a8d0b60a1a0dbb4b630bd498f6666d7903c3dd8a8d3a3512696da715858487594a12dbfef3c39fa9ea39c1ce294da7cf2b1554f6de8f997629df66f
-  data.tar.gz: 7476ef90343baf2a48f5ffed1989644cd4ccc472b9197d89bd5d7d6758db1729c34fe5681c9b666382c9cabba2132e9877be00712e20c5554d2b8569d0251077
+  metadata.gz: 4fbada0961dff547e86707db6be7de200fb23aa69f48ee0e75cc782b25e51605e4e4a7910673fa5a462778537a32c3538b040413d4f8fa3954f657210f3d05e3
+  data.tar.gz: e9a43c8b583c386929e6c64221ad2f5ad33343f12d82a63182b6bf8806e3ca8b40c2d0a7a97811783a3766fc7905619ffa973a5f534881287ff546921ac9b869

data/.travis.yml

@@ -0,0 +1,4 @@
+rvm:
+  - "2.0.0"
+  - "1.9.3"
+  - "1.9.2"

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# Version 0.0.4 (unreleased)
+
+* `behavioral_double` now supports multiple interfaces
+
+# Version 0.0.3
+
+* Ruby 2.0 key arguments support
+
+* New descriptive helper names: `behave_like` and `behavioral_double`
+
 # Version 0.0.2
 
 * Class methods now counted too when trying to stub them

data/README.md

@@ -1,12 +1,12 @@
 # Adequack
 
 [![Gem Version](https://badge.fury.io/rb/adequack.png)](http://badge.fury.io/rb/adequack)
-[![Build Status](https://travis-ci.org/Somebody32/adequack.png?branch=master)](https://travis-ci.org/Somebody32/adequack)
+[![Build Status](https://travis-ci.org/somebody32/adequack.png?branch=master)](https://travis-ci.org/Somebody32/adequack)
 [![Dependency Status](https://gemnasium.com/Somebody32/adequack.png)](https://gemnasium.com/Somebody32/adequack)
 
-Everyone likes isolation testing. And when you do it then you stubbing and mocking a lot.  
-But the main concern when you use this approach is that you stubs will be out of sync with the
-real objects.   
+Everyone likes isolation testing. And when you do it, you are stubbing and mocking a lot.  
+But the main concern when you use this approach is that your stubs will be out of sync with the
+real objects.
 Adequack addresses this issue.
 
 ## Problem 1. Missing methods
@@ -85,11 +85,11 @@ end
 
 describe Dog do
   subject { described_class }
-  it { should be_adequack_to DogInterface }
+  it { should behave_like DogInterface }
 end
 
 describe Owner do
-  let(:dog) { adequack_double double, DogInterface }
+  let(:dog) { behavioral_double double, DogInterface }
   subject { described_class.new dog }
   
   it "feeds animal" do
@@ -109,9 +109,9 @@ Finished in 0.00128 seconds
 ```
 
 We should validate not only our mocks, but also that our core object really responds to the interface.  
-Use `be_adequack_to` matcher with a core class as an argument.
+Use `behave_like` matcher with a core class as an argument.
 
-And to create doubles and stubs use `adequack_double` helper. This will return a proxy object that  
+And to create doubles and stubs use `behavioral_double` helper. This will return a proxy object that  
 will translate all calls to the object that you'll pass first (plain `double` at the example).  
 
 Let's replay our changes again:
@@ -130,7 +130,7 @@ F.
 Failures:
 
   1) Dog 
-     Failure/Error: it { should be_adequack_to DogInterface }
+     Failure/Error: it { should behave_like DogInterface }
      Adequack::InterfaceImplementationError:
        object does not respond to 'eat_food' method
 
@@ -203,7 +203,7 @@ gem install adequack
 
 and require it when you need it: `require 'adequack'`
 
-After that your rspec tests will have `be_adequack_to` matcher and `adequack_double` helper.
+After that your rspec tests will have `behave_like` matcher and `behavioral_double` helper.
 
 ## Usage
 

data/adequack.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["somebody32@gmail.com"]
   spec.description   = %q{Be sure that your mocks are adequate}
   spec.summary       = %q{Be sure that your mocks are adequate}
-  spec.homepage      = "https://github.com/Somebody32/adequack"
+  spec.homepage      = "https://github.com/somebody32/adequack"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files`.split($/)
@@ -18,8 +18,10 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rspec", "~> 2.13"
+  spec.add_dependency "rspec", "~> 2.11"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec", "~> 2.14"
+  spec.add_development_dependency "pry"
 end

data/lib/adequack.rb

@@ -1,7 +1,10 @@
 require "adequack/version"
 require "adequack/core"
 require "adequack/proxy"
+
+require "adequack/integration/rspec_proxy"
 require "adequack/integration/rspec_setup"
+require "adequack/integration/expect_syntax_support"
 
 module Adequack
   InterfaceImplementationError = Class.new(::StandardError)
@@ -10,7 +13,7 @@ module Adequack
     Core.implements duck, interface
   end
 
-  def self.double(core, interface)
-    Proxy.new core, interface
+  def self.double(core, interfaces)
+    RspecProxy.new core, interfaces
   end
 end

data/lib/adequack/integration/expect_syntax_support.rb

@@ -0,0 +1,38 @@
+module RSpec
+  module Expectations
+    class ExpectationTarget
+
+      def to(matcher = nil, message = nil, &block)
+        matcher_message = get_affected_message(matcher)
+
+        if matcher.kind_of?(RSpec::Mocks::Matchers::HaveReceived) && @target.kind_of?(Adequack::RspecProxy)
+          @target = @target.instance_variable_get(:"@target")
+        end
+
+        if @target.kind_of?(Adequack::RspecProxy) && matcher_message
+          @target.send(
+            :check_method_existence,
+            matcher.instance_variable_get(:"@#{matcher_message}"))
+
+        end
+
+        prevent_operator_matchers(:to, matcher)
+        RSpec::Expectations::PositiveExpectationHandler
+          .handle_matcher(
+            @target,
+            matcher,
+            message,
+            &block
+          )
+      end
+
+      private
+
+      def get_affected_message(matcher)
+        if matcher.kind_of? RSpec::Mocks::Matchers::Receive
+          "message"
+        end
+      end
+    end
+  end
+end

data/lib/adequack/integration/rspec_proxy.rb

@@ -0,0 +1,37 @@
+module Adequack
+  class RspecProxy < Proxy
+
+    def stub(message_or_hash, opts = {}, &block)
+      methods =
+        Hash === message_or_hash ? message_or_hash.keys : [message_or_hash]
+
+      methods.each { |m| check_method_existence m }
+
+      target.stub(message_or_hash, opts, &block)
+    end
+
+    alias_method :stub!, :stub
+
+    def stub_chain(*chain, &blk)
+      method =
+        String === chain.first ? chain.first.split(".").first : chain.first
+
+      check_method_existence method
+
+      target.stub_chain(*chain, &blk)
+    end
+
+    def should_receive(message, opts = {}, &block)
+      check_method_existence message
+
+      target.should_receive(message, opts, &block)
+    end
+
+    def receive(method_name, &block)
+      binding.pry
+      check_method_existence method_name
+
+      target.receive method_name, &block
+    end
+  end
+end

data/lib/adequack/integration/rspec_setup.rb

@@ -1,7 +1,9 @@
+require "rspec/matchers" unless RSpec::Matchers.respond_to? :define
+
 module Adequack
   module Integration
     module RSpecHelpers
-      def behavioral_double(object, interface)
+      def behavioral_double(object, *interface)
         Adequack.double object, interface
       end
 

data/lib/adequack/proxy.rb

@@ -1,40 +1,14 @@
 module Adequack
   class Proxy
 
-    def initialize(target, interface)
+    def initialize(target, interfaces)
       self.target = target
-      self.interface = interface
-    end
-
-    def stub(message_or_hash, opts = {}, &block)
-      methods =
-        Hash === message_or_hash ? message_or_hash.keys : [message_or_hash]
-
-      methods.each { |m| check_method_existence m }
-
-      target.stub(message_or_hash, opts, &block)
-    end
-
-    alias_method :stub!, :stub
-
-    def stub_chain(*chain, &blk)
-      method =
-        String === chain.first ? chain.first.split(".").first : chain.first
-
-      check_method_existence method
-
-      target.stub_chain(*chain, &blk)
-    end
-
-    def should_receive(message, opts = {}, &block)
-      check_method_existence message
-
-      target.should_receive(message, opts, &block)
+      self.interfaces = interfaces
     end
 
     private
 
-    attr_accessor :target, :interface
+    attr_accessor :target, :interfaces
 
     def method_missing(name, *args, &block)
       check_interface_implementation name, args
@@ -81,12 +55,11 @@ module Adequack
     end
 
     def get_methods
-      cm = interface.methods.map do |m|
-        interface.public_method(m)
-      end
+      cm, im = [], []
 
-      im = interface.instance_methods.map do |m|
-        interface.public_instance_method(m)
+      interfaces.each do |interface|
+        cm += interface.methods.map { |m| interface.public_method(m) }
+        im += interface.instance_methods.map { |m| interface.public_instance_method(m) }
       end
 
       cm + im

data/lib/adequack/version.rb

@@ -1,3 +1,3 @@
 module Adequack
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/adequack_spec.rb

@@ -28,7 +28,7 @@ describe Adequack do
       end
 
       expect { described_class.check_implementation(Animal, interface) }.
-        not_to raise_error Adequack::InterfaceImplementationError
+        not_to raise_error
     end
 
     it "fails when no class method" do
@@ -68,7 +68,7 @@ describe Adequack do
       end
 
       expect { described_class.check_implementation(Animal, bad_interface) }.
-        not_to raise_error Adequack::InterfaceImplementationError
+        not_to raise_error
     end
 
   end
@@ -76,7 +76,7 @@ describe Adequack do
   context "when stubbing and mocking" do
 
     let(:core) { double }
-    let(:subject) { Adequack.double core, interface }
+    let(:subject) { Adequack.double core, [interface] }
 
     it "let you stub methods that exists and return actual object" do
       core.should_receive(:stub).with({ bark: "woof" }, {})
@@ -127,7 +127,7 @@ describe Adequack do
     end
 
     it "works with class method defs too" do
-      d = Adequack.double Class.new, interface
+      d = Adequack.double Class.new, [interface]
       d.should_receive(:evolutionize)
       d.evolutionize
     end

data/spec/integration/fixtures/animal.rb

@@ -0,0 +1,24 @@
+class Animal
+  def initialize(name)
+    @name = name
+  end
+
+  def identify
+    self.class.name
+  end
+
+  def self.evolutionize(from_what)
+    new("next step from #{from_what}")
+  end
+
+  def bark(what)
+    puts what
+  end
+
+  def feed(what, many = false)
+    emotion = "So yammy #{what}"
+    emotion = [emotion, "I'm full up"].join(", ") if many
+
+    bark emotion
+  end
+end

data/spec/integration/fixtures/interfaces/animal.rb

@@ -0,0 +1,7 @@
+module Interface
+  module AnimalInterface
+    def self.evolutionize(from_what); end
+    def bark(what); end
+    def feed(what, many = false); end
+  end
+end

data/spec/integration/fixtures/interfaces/identificationable.rb

@@ -0,0 +1,5 @@
+module Interface
+  module Identificationable
+    def identify; end
+  end
+end

data/spec/integration/fixtures/owner.rb

@@ -0,0 +1,15 @@
+class Owner
+
+  def initialize(animal)
+    @animal = animal
+  end
+
+  def trick_animal
+    @animal.bark("woof")
+  end
+
+  def enormously_feed_animal
+    @animal.feed("chappy", true)
+  end
+
+end

data/spec/integration/rspec/integration_spec.rb

@@ -0,0 +1,57 @@
+require "spec_helper"
+require_relative "../fixtures/interfaces/animal"
+require_relative "../fixtures/interfaces/identificationable"
+require_relative "../fixtures/animal"
+require_relative "../fixtures/owner"
+
+describe Animal do
+  it do
+    described_class.should behave_like Interface::AnimalInterface,
+      Interface::Identificationable
+    expect(described_class).to behave_like Interface::AnimalInterface,
+      Interface::Identificationable
+  end
+end
+
+describe Owner do
+  let(:animal) do
+    behavioral_double double,
+      Interface::AnimalInterface, Interface::Identificationable
+  end
+
+  subject { described_class.new animal }
+
+  context "when using should syntax" do
+    it "tricks animal" do
+      animal.should_receive(:bark).and_return("barked")
+      subject.trick_animal.should eql "barked"
+    end
+
+    it "feeds animal the right way" do
+      -> {
+        animal.should_receive(:not_right_feed).and_return("barked")
+      }.should raise_error Adequack::InterfaceImplementationError
+    end
+  end
+
+  context "when using expect syntax" do
+    it "tricks animal" do
+      expect(animal).to receive(:bark).and_return("barked")
+      expect(subject.trick_animal).to eql "barked"
+    end
+
+    context "works with spies" do
+      it "works when all is ok" do
+        animal.stub(:bark)
+        subject.trick_animal
+        expect(animal).to have_received(:bark)
+      end
+    end
+
+    it "feeds animal" do
+      expect {
+        expect(animal).to receive(:not_right_feed).and_return("barked")
+      }.to raise_error Adequack::InterfaceImplementationError
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1 +1 @@
-require "adequack"
+require "adequack"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: adequack
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Ilya Zayats
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-19 00:00:00.000000000 Z
+date: 2013-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.13'
+        version: '2.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.13'
+        version: '2.11'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,34 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Be sure that your mocks are adequate
 email:
 - somebody32@gmail.com
@@ -61,6 +89,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .travis.yml
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -69,13 +98,19 @@ files:
 - adequack.gemspec
 - lib/adequack.rb
 - lib/adequack/core.rb
+- lib/adequack/integration/expect_syntax_support.rb
+- lib/adequack/integration/rspec_proxy.rb
 - lib/adequack/integration/rspec_setup.rb
 - lib/adequack/proxy.rb
 - lib/adequack/version.rb
 - spec/adequack_spec.rb
-- spec/integration_spec.rb
+- spec/integration/fixtures/animal.rb
+- spec/integration/fixtures/interfaces/animal.rb
+- spec/integration/fixtures/interfaces/identificationable.rb
+- spec/integration/fixtures/owner.rb
+- spec/integration/rspec/integration_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/Somebody32/adequack
+homepage: https://github.com/somebody32/adequack
 licenses:
 - MIT
 metadata: {}
@@ -101,5 +136,9 @@ specification_version: 4
 summary: Be sure that your mocks are adequate
 test_files:
 - spec/adequack_spec.rb
-- spec/integration_spec.rb
+- spec/integration/fixtures/animal.rb
+- spec/integration/fixtures/interfaces/animal.rb
+- spec/integration/fixtures/interfaces/identificationable.rb
+- spec/integration/fixtures/owner.rb
+- spec/integration/rspec/integration_spec.rb
 - spec/spec_helper.rb

data/spec/integration_spec.rb

@@ -1,64 +0,0 @@
-require "spec_helper"
-
-module AnimalInterface
-  def self.evolutionize(from_what); end
-  def bark(what); end
-  def feed(what, many = false); end
-end
-
-class Animal
-  def initialize(name)
-    @name = name
-  end
-
-  def self.evolutionize(from_what)
-    new("next step from #{from_what}")
-  end
-
-  def bark(what)
-    puts what
-  end
-
-  def feed(what, many = false)
-    emotion = "So yammy #{what}"
-    emotion = [emotion, "I'm full up"].join(", ") if many
-
-    bark emotion
-  end
-end
-
-describe Animal do
-  subject { described_class }
-  it { should behave_like AnimalInterface }
-end
-
-class Owner
-
-  def initialize(animal)
-    @animal = animal
-  end
-
-  def trick_animal
-    @animal.bark("woof")
-  end
-
-  def enormously_feed_animal
-    @animal.feed("chappy", true)
-  end
-
-end
-
-describe Owner do
-  let(:animal) { behavioral_double double, AnimalInterface }
-  subject { described_class.new animal }
-
-  it "tricks animal" do
-    animal.should_receive(:bark).and_return("barked")
-    expect(subject.trick_animal).to eql "barked"
-  end
-
-  it "feeds animal" do
-    animal.should_receive(:feed).and_return("barked")
-    expect(subject.enormously_feed_animal).to eql "barked"
-  end
-end