address_line_divider 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 35c739931b4af196ad0a5dc9181106b9484c849e6a27a907f75afb407647a9f8
-  data.tar.gz: 90db5541183059ea3a59a99b76f9bb9eb4aae261af4c07a7de3add6c560c1418
+  metadata.gz: 678fdc52d5f68e75e97ff2f67d260c325747273287c4e0fe7054dbca7258277c
+  data.tar.gz: 1c5b3ffda58132cafcf8632d06a1b77243cccd096b680a634f3b0b7ca070164c
 SHA512:
-  metadata.gz: 1b7ef4b0b5261404a42c9c72e58128e4f229ba99442e49fd5edf4369e4ce41e6f54006280e7fb2dda672f13e87ba3ede8d8f25ff18c53077a20f432288cf787a
-  data.tar.gz: a4aede3d31b69bac9e7ea051cac8f235b27fc8a083b96eccfdcdbe6ea687003fd6e38473ee63c2d0baeec99ee3c99cb07d892737c03c462628bf167342e4a19a
+  metadata.gz: b02307bdbad519d388d2f3c97d1849b61404c1629174c90f2b43026371fdaeeb387013d0528e51687b65ad99c0c52ec8b62de19b1aa90d3e9b1cab06fcaf8d68
+  data.tar.gz: 66a5ddc6ed60ec17c49683e9e017ae114ebb65130c3b21bb885152923e3e0cd02649003157e5e125d7cc2f1a64f633fffa264cd113f1b77e8a923510ef44b1d8

data/.gitignore

@@ -9,3 +9,5 @@
 
 # rspec failure tracking
 .rspec_status
+
+.byebug_history

data/CHANGELOG.md

@@ -1,4 +1,6 @@
 # Changelog
+## v1.0.6
+  *  Improve verifying results.
 ## v1.0.5
   *  Verify results and return nil if it's invalid.
 ## v1.0.4

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    address_line_divider (1.0.5)
+    address_line_divider (1.0.6)
 
 GEM
   remote: https://rubygems.org/

data/lib/address_line_divider/address_parser.rb

@@ -8,10 +8,12 @@ module AddressLineDivider
 
     def parse(address_line)
       street = search_street_on_file(address_line)
-      return [street, street_no(address_line, street)] if street
+      result = [street, street_no(address_line, street)] if street
+      result ||= parse_using_regex(address_line)
 
-      result = parse_using_regex(address_line)
-      result unless result.nil? || result.any?(:nil?)
+      return if invalid_result(address_line, result)
+
+      result
     end
 
     private
@@ -24,13 +26,13 @@ module AddressLineDivider
       street_name = address_line[0..last_number_index - 1].strip
       street_no = address_line[last_number_index..-1].strip
 
-      return if invalid_result(address_line, [street_name, street_no])
-
       [street_name, street_no]
     end
 
     def invalid_result(address_line, result)
-      squish(result.join(" ")) != squish(address_line)
+      result.nil? ||
+        result.any? { |r| r.nil? || r.strip.empty? } ||
+        squish(result.join(" ")) != squish(address_line)
     end
 
     def last_number(address_line)

data/lib/address_line_divider/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AddressLineDivider
-  VERSION = "1.0.5"
+  VERSION = "1.0.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: address_line_divider
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Matias Albarello