additional_tags 3.2.0 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8ed778f6643bfc7ef2e38f292fa92d0dab319705968e9791bb820b0e284124b
-  data.tar.gz: 29db0db1b7c774c387fe46b7294d5be48dc71ab0857cd8fca9eebea610e17e6b
+  metadata.gz: 941c8111797b91a7678dc2a387b792699a95f98e129c34348974980171c8913d
+  data.tar.gz: 88af7551ac94803ed51804a266606125fc9fd870922426718560b23546e9477b
 SHA512:
-  metadata.gz: c76cb8da0ffab5ef74651cc450150fc1c057e4bfff58633cc4a8aa17fdd0ff91134537bf5cacb9f85783a624b628e21d0705b30b656819583ccc7d62f4fd2f5d
-  data.tar.gz: b12dc1e15cf91fc1514ecda011fd3e7f8186b64be0046fe7df894853b52db7045f2713aa00ae67101e1a42d7b44947256a129c21553021a3892bea0612eab34c
+  metadata.gz: 2bcad3378a0309df1df4a967a6e6877959310c8d6577470f504ad8d3f66257531a1d78166284b46a6d9769928f23464fd60d7777e24fe87b3b324a45dc5ec382
+  data.tar.gz: 01a32c8d39b97fbaa2d4fbfc01b00441e1bfda74eaa552e2eebbbe869637d97bfb5ec04138f1a3b86d236b35dc509d4ef92b88a5bfc5c841b6419289e41fe54f

data/README.md

@@ -5,11 +5,11 @@
 ## Features
 
 - Tags for issues. To use them you need to:
-  -  *Activate issue tags* in the plugin configuration
-  -  and update your role permissions in the Redmine administration *Roles & permissions / Issue tracking*.
+  - *Activate issue tags* in the plugin configuration
+  - and update your role permissions in the Redmine administration *Roles & permissions / Issue tracking*.
 - Tags for wiki pages. To use them  you need to:
   - *Activate wiki tags* in the plugin configuration
-  -  and update your role permissions in the Redmine administration *Roles & permissions / Wiki*
+  - and update your role permissions in the Redmine administration *Roles & permissions / Wiki*
 - Available role permissions for issue tags (section *Issue tracking*):
   - Add issue tags
   - Edit issue tags
@@ -59,7 +59,7 @@ Start using it, too. The example image shows the centralized tag management in t
 ## Requirements
 
 - Redmine `>= 5.0`
-- Ruby `>= 3.0`
+- Ruby `>= 3.1`
 - Redmine plugins: [additionals](https://www.redmine.org/plugins/additionals)
 
 ## Installing
@@ -94,6 +94,7 @@ git clone https://github.com/alphanodes/additional_tags.git plugins/additional_t
 ### 2. Install dependencies and migrate database
 
 ```shell
+bundle config set --local without 'development test'
 bundle install
 bundle exec rake redmine:plugins:migrate RAILS_ENV=production
 ```
@@ -136,13 +137,39 @@ rm -rf plugins/additional_tags
 ## License
 
 This plugin is licensed under the terms of GNU/GPL v2.
-See LICENSE for details.
+See [LICENSE](LICENSE) for details.
+
+## Redmine Copyright
+
+The additional_tags is a plugin extension for Redmine Project Management Software, whose Copyright follows.
+Copyright (C) 2006-  Jean-Philippe Lang
+
+Redmine is a flexible project management web application written using Ruby on Rails framework.
+More details can be found in the doc directory or on the official website <http://www.redmine.org>
+
+This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.
+
+This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 
 ## Credits
 
+### Code
+
 The source code is a (almost) rewrite of
 
 - [redmine_tags](https://github.com/ixti/redmine_tags)
 - [redmineup_tags](https://www.redmine.org/plugins/redmineup_tags)
 
 Special thanks to the original author and contributors for making this awesome hook for Redmine.
+
+### Icons
+
+Thanks to:
+
+- Font Awesome Free Icons (<https://fontawesome.com/license/free>) licenced under - Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License.
+  Copyright (c) 2018- Fonticons, Inc.
+- Tabler Icons - Free and open source icons (<https://tabler.io/icons>) licensed under MIT License.
+  Copyright (c) 2020- Paweł Kuna

data/app/controllers/additional_tags_controller.rb

@@ -36,7 +36,7 @@ class AdditionalTagsController < ApplicationController
   def update
     @tag.name = params[:tag][:name] if params[:tag]
     if @tag.save
-      flash[:notice] = l :notice_successful_update
+      flash[:notice] = flash_msg :update
       respond_to do |format|
         format.html do
           redirect_to @tag_list_path

data/app/helpers/additional_tags_helper.rb

@@ -32,7 +32,7 @@ module AdditionalTagsHelper
                          counts: WikiPage.available_tags.to_h { |tag| [tag.id, tag.count] } }
     end
 
-    call_hook :helper_additional_manageable_tag_columns, columns: columns
+    call_hook(:helper_additional_manageable_tag_columns, columns:)
 
     @manageable_tag_columns = columns
   end
@@ -127,9 +127,9 @@ module AdditionalTagsHelper
     use_colors = AdditionalTags.use_colors? if use_colors.nil?
     color_theme = AdditionalTags.setting :tags_color_theme if color_theme.nil?
 
-    tag_info = AdditionalTag.new name: name.nil? ? tag_object.name : name,
+    tag_info = AdditionalTag.new(name: name.nil? ? tag_object.name : name,
                                  disable_grouping: !use_colors,
-                                 color_theme: color_theme
+                                 color_theme:)
     tag_name = [tag_info.tag_name]
 
     tag_style = "background-color: #{tag_info.tag_bg_color}; color: #{tag_info.tag_fg_color}" if use_colors
@@ -206,7 +206,7 @@ module AdditionalTagsHelper
     sum = if entries.blank? || entries.empty?
             0
           else
-            query = IssueQuery.new project: project, name: '_'
+            query = IssueQuery.new project:, name: '_'
             query.add_filter 'tags', '*'
             query.filters['status_id'][:operator] = '*' if !open_issues_only && query.filters.key?('status_id')
 
@@ -221,36 +221,44 @@ module AdditionalTagsHelper
 
   def issue_tag_status_filter(operator: nil, open_issues_only: false)
     if operator
-      { field: :status_id, operator: operator }
+      { field: :status_id, operator: }
     elsif open_issues_only
       { field: :status_id, operator: 'o' }
     end
   end
 
+  def wiki_tags_on_show?
+    options = { enabled: AdditionalTags.setting?(:active_wiki_tags) }
+
+    call_hook(:helper_wiki_tags_on_show, options:)
+
+    options[:enabled]
+  end
+
   private
 
   def tag_url(tag_name, filter: nil, tag_action: nil, tag_controller: nil, project: nil, display_type: nil)
     action = tag_action.presence || (controller_name == 'hrm_user_resources' ? 'show' : 'index')
 
-    fields = [:tags]
-    values = { tags: [tag_name] }
-    operators = { tags: '=' }
+    f = [:tags]
+    v = { tags: [tag_name] }
+    op = { tags: '=' }
 
     if filter.present?
       field = filter[:field]
-      fields << field
-      operators[field] = filter[:operator]
-      values[field] = filter[:value] if filter.key? :value
+      f << field
+      op[field] = filter[:operator]
+      v[field] = filter[:value] if filter.key? :value
     end
 
     { controller: tag_controller.presence || controller_name,
-      action: action,
+      action:,
       set_filter: 1,
-      display_type: display_type,
+      display_type:,
       project_id: project,
-      f: fields,
-      v: values,
-      op: operators }
+      f:,
+      v:,
+      op: }
   end
 
   def add_tags(style, tags, content, item_el, options)

data/app/helpers/additional_tags_wiki_helper.rb

@@ -16,26 +16,24 @@ module AdditionalTagsWikiHelper
     render_tags_list sidebar_tags, **options
   end
 
-  def render_wiki_index_title(project: nil, name: nil, tag: nil, title: :label_wiki)
+  def render_wiki_index_title(title, project: nil, name: nil, tag: nil)
+    title = l title unless is_a? Symbol
+
     if tag.present?
       tag_object = ActsAsTaggableOn::Tag.new name: tag
 
       if project
         safe_join [l(:label_wiki_index_for_tag), additional_tag_link(tag_object, link: '#')], ' '
       else
-        title = [link_to(l(title), wiki_index_path)]
-        title << Additionals::LIST_SEPARATOR
-        title << l(:label_wiki_index_for_tag)
-        title << additional_tag_link(tag_object, link: '#')
-        safe_join title, ' '
+        items = [link_to(title, wiki_index_path)]
+        items << safe_join([l(:label_wiki_index_for_tag), additional_tag_link(tag_object, link: '#')], ' ')
+        render_breadcrumb items
       end
     elsif name.present?
-      title = [link_to(l(title), wiki_index_path)]
-      title << Additionals::LIST_SEPARATOR
-      title << name
-      safe_join title, ' '
+      render_breadcrumb [link_to(title, wiki_index_path),
+                         name]
     else
-      l title
+      title
     end
   end
 end

data/app/models/migrate_tag.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class MigrateTag < Rails.version < '7.1' ? ActiveRecord::Base : ApplicationRecord
+class MigrateTag < AdditionalsApplicationRecord
   self.table_name = 'tags'
   has_many :migrate_taggings, dependent: :destroy, foreign_key: :tag_id, inverse_of: :migrate_tag
 end

data/app/models/migrate_tagging.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class MigrateTagging < Rails.version < '7.1' ? ActiveRecord::Base : ApplicationRecord
+class MigrateTagging < AdditionalsApplicationRecord
   self.table_name = 'taggings'
   belongs_to :migrate_tag, foreign_key: :tag_id, inverse_of: :migrate_taggings
   belongs_to :taggable, polymorphic: true

data/app/models/query_tags_column.rb

@@ -2,6 +2,6 @@
 
 class QueryTagsColumn < QueryRelationsColumn
   def initialize(name = :tags, **options)
-    super name, **options
+    super
   end
 end

data/app/views/additional_tags/settings/_general.html.slim

@@ -30,15 +30,15 @@ fieldset.settings
                                                                          [l(:label_tag_color_theme, value: 5), 'd']],
                                                                         @settings['tags_color_theme'])
 
+  p
+    = additionals_settings_checkbox :show_tags_after_queries
+
 fieldset.settings
   legend = l :label_issue_plural
 
   p
     = additionals_settings_checkbox :active_issue_tags
 
-  p
-    = additionals_settings_checkbox :show_tags_after_queries
-
   p
     = additionals_settings_checkbox :open_issues_only
 

data/app/views/additional_tags/settings/_manage_tags.html.slim

@@ -20,10 +20,10 @@
             td.checkbox.hide-when-print
               = check_box_tag 'ids[]', tag.id, false, id: nil
             td
-              = additional_tag_link tag,
+              = additional_tag_link(tag,
                                     link: edit_additional_tag_path(tag),
-                                    use_colors: use_colors,
-                                    color_theme: color_theme
+                                    use_colors:,
+                                    color_theme:)
 
             - manageable_tag_column_values(tag).each do |column|
               td = column

data/app/views/common/_tag_summary_block.html.slim

@@ -1,4 +1,4 @@
-ul.reporting-list.tag-summary
+ul.dashboard-list.tag-summary
   li.amount-tags
     = l :label_amount_tags
     ' :

data/app/views/dashboards/blocks/_issue_tags.html.slim

@@ -1,18 +1,18 @@
 h3 = block_definition[:label]
 
 - open_issues_only = RedminePluginKit.true? settings[:open_issues_only]
-- tags = Issue.available_tags project: @project, open_issues_only: open_issues_only
-- counts = AdditionalTags::Tags.entity_group_by scope: Issue.group_by_status_with_tags(@project),
-                                                tags: tags,
+- tags = Issue.available_tags(project: @project, open_issues_only:)
+- counts = AdditionalTags::Tags.entity_group_by(scope: Issue.group_by_status_with_tags(@project),
+                                                tags:,
                                                 statuses: { true => :closed, false => :open },
-                                                group_id_is_bool: true
+                                                group_id_is_bool: true)
 
 = render 'common/tag_summary_block',
-         tags: tags,
+         tags:,
          entities_label: l(:label_issue_plural),
          totals_link: link_to_issue_tags_totals(entries: counts,
                                                 project: @project,
-                                                open_issues_only: open_issues_only)
+                                                open_issues_only:)
 
 - if RedminePluginKit.true? settings[:with_table_of_values]
   - if tags.present?
@@ -31,30 +31,30 @@ h3 = block_definition[:label]
         - color_theme = AdditionalTags.setting :tags_color_theme
         - tags.each do |tag|
           tr
-            td.name = additional_tag_link tag,
+            td.name = additional_tag_link(tag,
                                           tag_action: 'index',
                                           tag_controller: 'issues',
-                                          filter: issue_tag_status_filter(open_issues_only: open_issues_only),
+                                          filter: issue_tag_status_filter(open_issues_only:),
                                           use_colors: RedminePluginKit.true?(settings[:use_colors]),
-                                          color_theme: color_theme
+                                          color_theme:)
             - unless open_issues_only
-              td.value = additional_tag_link tag,
+              td.value = additional_tag_link(tag,
                                              tag_action: 'index',
                                              tag_controller: 'issues',
                                              filter: issue_tag_status_filter(operator: 'o'),
                                              use_colors: false,
-                                             name: counts[tag.name][:open]
-              td.value = additional_tag_link tag,
+                                             name: counts[tag.name][:open])
+              td.value = additional_tag_link(tag,
                                              tag_action: 'index',
                                              tag_controller: 'issues',
                                              filter: issue_tag_status_filter(operator: 'c'),
                                              use_colors: false,
-                                             name: counts[tag.name][:closed]
-            td.value = additional_tag_link tag,
+                                             name: counts[tag.name][:closed])
+            td.value = additional_tag_link(tag,
                                            tag_action: 'index',
                                            tag_controller: 'issues',
-                                           filter: issue_tag_status_filter(open_issues_only: open_issues_only),
+                                           filter: issue_tag_status_filter(open_issues_only:),
                                            use_colors: false,
-                                           name: open_issues_only ? counts[tag.name][:open] : counts[tag.name][:total]
+                                           name: open_issues_only ? counts[tag.name][:open] : counts[tag.name][:total])
   - else
     p.nodata = l :label_no_data

data/app/views/issues/_tags_form_details.html.slim

@@ -3,4 +3,4 @@
   div
     p#issue_tags
       = label_tag l(:field_tag_list)
-      = render tags_form, project: project
+      = render tags_form, project:

data/app/views/wiki/_tags_form_bottom.html.slim

@@ -1,4 +1,4 @@
 - if AdditionalTags.setting?(:active_wiki_tags) && User.current.allowed_to?(:add_wiki_tags, @project)
   p#wiki_tags
     = label_tag l(:field_tag_list)
-    = render 'wiki/tags_form', project: project, page: page
+    = render 'wiki/tags_form', project:, page:

data/app/views/wiki/_tags_show.html.slim

@@ -1,4 +1,4 @@
-- if AdditionalTags.setting? :active_wiki_tags
+- if wiki_tags_on_show?
   .wiki-attributes
     = render 'additional_tags/tag_list',
              entry: page,

data/app/views/wiki/tag_index.html.slim

@@ -2,7 +2,7 @@
   - if User.current.allowed_to? :edit_wiki_pages, @project
     = link_to l(:label_wiki_page_new), new_project_wiki_page_path(@project), remote: true, class: 'icon icon-add'
 
-h2 = render_wiki_index_title project: @project, tag: @tag
+h2 = render_wiki_index_title :label_wiki, project: @project, tag: @tag
 
 - if @pages.empty?
   p.nodata = l :label_no_data

data/db/migrate/20201123093214_migrate_existing_tags.rb

@@ -17,16 +17,16 @@ class MigrateExistingTags < ActiveRecord::Migration[5.2]
           context = tagging.respond_to?(:context) && tagging.context.present? ? tagging.context : 'tags'
 
           # old data can include dups
-          next if ActsAsTaggableOn::Tagging.exists? tag_id: tag.id,
+          next if ActsAsTaggableOn::Tagging.exists?(tag_id: tag.id,
                                                     taggable_id: tagging.taggable_id,
                                                     taggable_type: tagging.taggable_type,
-                                                    context: context
+                                                    context:)
 
-          ActsAsTaggableOn::Tagging.create! tag_id: tag.id,
+          ActsAsTaggableOn::Tagging.create!(tag_id: tag.id,
                                             taggable_id: tagging.taggable_id,
                                             taggable_type: tagging.taggable_type,
-                                            context: context,
-                                            created_at: tagging.created_at
+                                            context:,
+                                            created_at: tagging.created_at)
           cnt += 1
         end
 

data/lib/additional_tags/patches/agile_query_patch.rb

@@ -6,7 +6,7 @@ module AdditionalTags
       extend ActiveSupport::Concern
 
       included do
-        include AdditionalsQuery
+        include Additionals::Concerns::Query
         include InstanceMethods
 
         alias_method :initialize_available_filters_without_tags, :initialize_available_filters

data/lib/additional_tags/patches/issue_patch.rb

@@ -35,7 +35,7 @@ module AdditionalTags
           scope = if project && Setting.display_subprojects_issues?
                     visible(user).where(AdditionalTags::Tags.subproject_sql(project))
                   else
-                    visible user, project: project
+                    visible user, project:
                   end
 
           scope.joins(:status)

data/lib/additional_tags/patches/issue_query_patch.rb

@@ -6,7 +6,7 @@ module AdditionalTags
       extend ActiveSupport::Concern
 
       included do
-        include AdditionalsQuery
+        include Additionals::Concerns::Query
         prepend InstanceOverwriteMethods
         include InstanceMethods
 
@@ -36,7 +36,7 @@ module AdditionalTags
         def sql_for_tags_field(field, _operator, values)
           build_sql_for_tags_field_with_permission klass: queried_class,
                                                    operator: operator_for(field),
-                                                   values: values,
+                                                   values:,
                                                    permission: :view_issue_tags
         end
       end

data/lib/additional_tags/patches/query_patch.rb

@@ -13,12 +13,11 @@ module AdditionalTags
         def sql_for_tags_field(field, _operator, values)
           build_sql_for_tags_field klass: queried_class,
                                    operator: operator_for(field),
-                                   values: values
+                                   values:
         end
 
-        def initialize_tags_filter(position: nil)
-          add_available_filter 'tags', order: position,
-                                       type: :list_optional,
+        def initialize_tags_filter
+          add_available_filter 'tags', type: :list_optional,
                                        values: -> { available_tag_values queried_class }
         end
 
@@ -32,7 +31,7 @@ module AdditionalTags
         end
 
         def available_tag_values(klass)
-          klass.available_tags(project: project)
+          klass.available_tags(project:)
                .pluck(:name)
                .map { |name| [name, name] }
         end
@@ -69,7 +68,7 @@ module AdditionalTags
           when '=', '!'
             ids_list = klass.tagged_with(values, any: true).ids
             # special case: filter with deleted tag
-            return AdditionalsQuery::NO_RESULT_CONDITION if ids_list.blank? && values.present? && operator == '='
+            return Additionals::SQL_NO_RESULT_CONDITION if ids_list.blank? && values.present? && operator == '='
           else
             allowed_projects = Project.where(Project.allowed_to_condition(User.current, permission))
                                       .select(:id)
@@ -90,7 +89,7 @@ module AdditionalTags
               "(#{klass.table_name}.id #{compare} (#{ids_list.join ','}))"
             elsif values.present? && operator == '='
               # special case: filter with deleted tag
-              AdditionalsQuery::NO_RESULT_CONDITION
+              Additionals::SQL_NO_RESULT_CONDITION
             end
           else
             entries = ActsAsTaggableOn::Tagging.where taggable_type: klass.name

data/lib/additional_tags/patches/time_entry_query_patch.rb

@@ -36,7 +36,7 @@ module AdditionalTags
         end
 
         def sql_for_issue_tags_field(_field, operator, values)
-          build_sql_for_tags_field klass: Issue, operator: operator, values: values
+          build_sql_for_tags_field klass: Issue, operator:, values:
         end
       end
     end

data/lib/additional_tags/patches/wiki_controller_patch.rb

@@ -20,7 +20,7 @@ module AdditionalTags
           @page.safe_attributes = [:tag_list]
           @page.tag_list = params[:wiki_page][:tag_list].to_a.reject(&:empty?)
           flash[:notice] = if @page.save
-                             l :notice_successful_update
+                             flash_msg :update
                            else
                              t :notice_failed_to_add_tags
                            end

data/lib/additional_tags/patches/wiki_page_patch.rb

@@ -45,7 +45,7 @@ module AdditionalTags
         def with_tags(tag, project: nil, order: 'title_asc', max_entries: nil, exclude_page: nil)
           wiki = project&.wiki
 
-          scope = with_tags_scope wiki: wiki, project: project
+          scope = with_tags_scope(wiki:, project:)
           scope = scope.where.not id: exclude_page.id if exclude_page
           scope = scope.limit max_entries if max_entries
 

data/lib/additional_tags/plugin_version.rb

@@ -2,6 +2,6 @@
 
 module AdditionalTags
   module PluginVersion
-    VERSION = '3.2.0' unless defined? AdditionalTags::PluginVersion::VERSION
+    VERSION = '3.3.1' unless defined? AdditionalTags::PluginVersion::VERSION
   end
 end

data/lib/additional_tags/tags.rb

@@ -7,7 +7,7 @@ module AdditionalTags
         permission = options[:permission] || :view_issue_tags
         skip_pre_condition = options[:skip_pre_condition] || true
 
-        tag_access permission, user, skip_pre_condition: skip_pre_condition
+        tag_access permission, user, skip_pre_condition:
       end
 
       def available_tags(klass, **options)
@@ -48,7 +48,7 @@ module AdditionalTags
       end
 
       def all_type_tags(klass, without_projects: false)
-        ActsAsTaggableOn::Tag.joins(tag_for_joins(klass, without_projects: without_projects))
+        ActsAsTaggableOn::Tag.joins(tag_for_joins(klass, without_projects:))
                              .distinct
                              .order(:name)
       end
@@ -74,7 +74,8 @@ module AdditionalTags
         ActsAsTaggableOn::Tagging.transaction do
           tag = ActsAsTaggableOn::Tag.find_by(name: tag_name) || ActsAsTaggableOn::Tag.create(name: tag_name)
           # Update old tagging with new tag
-          ActsAsTaggableOn::Tagging.where(tag_id: tags_to_merge.map(&:id)).update_all tag_id: tag.id
+          ActsAsTaggableOn::Tagging.where(tag_id: tags_to_merge.map(&:id))
+                                   .update_all tag_id: tag.id
           # remove old (merged) tags
           tags_to_merge.reject { |t| t.id == tag.id }.each(&:destroy)
           # remove duplicate taggings
@@ -114,22 +115,22 @@ module AdditionalTags
       def entity_group_by(scope:, tags:, statuses: nil, sub_groups: nil, group_id_is_bool: false)
         counts = {}
         tags.each do |tag|
-          values = { tag: tag, total: 0, total_sub_groups: 0, groups: [] }
+          values = { tag:, total: 0, total_sub_groups: 0, groups: [] }
 
           if statuses
             statuses.each do |status|
               group_id = status.first
               group = status.second
-              values[group] = status_for_tag_value scope: scope,
+              values[group] = status_for_tag_value(scope:,
                                                    tag_id: tag.id,
-                                                   group_id: group_id,
-                                                   group_id_is_bool: group_id_is_bool
-              values[:groups] << { id: group_id, group: group, count: values[group] }
+                                                   group_id:,
+                                                   group_id_is_bool:)
+              values[:groups] << { id: group_id, group:, count: values[group] }
               values[:total] += values[group]
               values[:total_sub_groups] += values[group] if sub_groups&.include? group_id
             end
           else
-            values[:total] += status_for_tag_value scope: scope, tag_id: tag.id
+            values[:total] += status_for_tag_value scope:, tag_id: tag.id
           end
 
           values[:total_without_sub_groups] = values[:total] - values[:total_sub_groups]
@@ -210,13 +211,13 @@ module AdditionalTags
         projects_allowed = if permission.nil?
                              Project.visible.ids
                            else
-                             Project.where(Project.allowed_to_condition(user, permission, skip_pre_condition: skip_pre_condition)).ids
+                             Project.where(Project.allowed_to_condition(user, permission, skip_pre_condition:)).ids
                            end
 
         if projects_allowed.present?
           "#{Project.table_name}.id IN (#{projects_allowed.join ','})" unless projects_allowed.empty?
         else
-          AdditionalsQuery::NO_RESULT_CONDITION
+          Additionals::SQL_NO_RESULT_CONDITION
         end
       end
     end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: additional_tags
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.1
 platform: ruby
 authors:
 - AlphaNodes
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-27 00:00:00.000000000 Z
+date: 2024-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: acts-as-taggable-on
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: redmine_plugin_kit
   requirement: !ruby/object:Gem::Requirement
@@ -151,7 +151,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.0'
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="