addic7ed 0.3.4 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dbf867829f89e180c8a9ea1ecaba686e5955f364
-  data.tar.gz: d6584fb960b5ac97fb12f9b7997c542bc74334dd
+  metadata.gz: f7ec6d7d5e15148f20ab37ecd8c1fa41de36bbf3
+  data.tar.gz: 1f676080c6d49804e7607b952a62cb3a8e412b31
 SHA512:
-  metadata.gz: 97bbcc17a3723d49f2cd9b42e7212018c41181aa8f1024dc73540576d0d98f64f3f8b2216e1d0ae3808e10839e1b46af2283da692db041faeeac5c6bd6c9b986
-  data.tar.gz: d008f13a53e310a43fdc0bc3af5fe3643dfc424d660b587ddb18f911b7a581781c7bbedcff73d133e72ea9057bb5606ced8fdfd2fec9d26e2bf06515ab5f65b2
+  metadata.gz: 0d7613da70d67bbca0e9fc10698ce6856b8c5bf121e092614f4308141fdc324014d2d4977ca3dc83786a01eab1adb5088e42bf35bb8ea4ab65aece13cb58ffe6
+  data.tar.gz: 0d27c90a45c3d3c5beb71cf3da12e57a01139e14bc893f488b6a2ed589e6fda1d0f80b5f94b811e05f7410614581102be6a1defcb40cc36481343004fe9d8876

data/bin/addic7ed

@@ -33,6 +33,10 @@ OptionParser.new do |opts|
     options[:force] = f
   end
 
+  opts.on("-u", "--untagged", "Do not include language code in subtitle filename") do |u|
+    options[:untagged] = u
+  end
+
   opts.on("-v", "--[no-]verbose", "Run verbosely") do |v|
     options[:verbose] = v
   end
@@ -77,7 +81,7 @@ options[:filenames].each do |filename|
   end
 
   begin
-    ep = Addic7ed::Episode.new(filename)
+    ep = Addic7ed::Episode.new(filename, options[:untagged])
     puts "Searching subtitles for #{ep.filename.basename}" if options[:verbose]
     if File.file?(filename.gsub(/\.\w{3}$/, '.srt')) and not options[:force]
       puts "A subtitle already exists (#{filename.gsub(/\.\w{3}$/, '.srt')}). Skipping.".gsub(/^/, options[:verbose] ? '  ' : '') unless options[:quiet]
@@ -98,7 +102,7 @@ options[:filenames].each do |filename|
       puts "    #{ep.best_subtitle(options[:language])}"
     end
     unless options[:nodownload]
-      ep.download_best_subtitle!(options[:language])
+      ep.download_best_subtitle!(options[:language], options[:untagged])
       puts "New subtitle downloaded for #{filename}.\nEnjoy your show :-)".gsub(/^/, options[:verbose] ? '  ' : '') unless options[:quiet]
     end
   rescue Addic7ed::InvalidFilename

data/lib/addic7ed.rb

@@ -1,7 +1,7 @@
 require 'addic7ed/version'
 require 'addic7ed/common'
 require 'addic7ed/errors'
-require 'addic7ed/filename'
+require 'addic7ed/video_file'
 require 'addic7ed/episode'
 require 'addic7ed/subtitle'
 require 'addic7ed/parser'

data/lib/addic7ed/episode.rb

@@ -4,16 +4,17 @@ require 'open-uri'
 module Addic7ed
   class Episode
 
-    attr_reader :filename
+    attr_reader :file, :untagged
 
-    def initialize(filename)
-      @filename = Addic7ed::Filename.new(filename)
+    def initialize(filename, untagged = false)
+      @file  = Addic7ed::VideoFile.new(filename)
+      @untagged = untagged
     end
 
     def url(lang = 'fr')
       check_language_availability(lang)
       @localized_urls ||= {}
-      @localized_urls[lang] ||= "http://www.addic7ed.com/serie/#{@filename.encoded_showname}/#{@filename.season}/#{@filename.episode}/#{LANGUAGES[lang][:id]}"
+      @localized_urls[lang] ||= "http://www.addic7ed.com/serie/#{file.encoded_showname}/#{file.season}/#{file.episode}/#{LANGUAGES[lang][:id]}"
     end
 
     def subtitles(lang = 'fr')
@@ -35,11 +36,11 @@ module Addic7ed
       if response.kind_of?(Net::HTTPRedirection)
         follow_redirection(lang, response['location'], http_redirect_limit)
       else
-        save_subtitle response.body
+        save_subtitle(response.body, lang)
       end
     end
 
-    protected
+  protected
 
     def find_subtitles(lang)
       initialize_language(lang)
@@ -50,7 +51,7 @@ module Addic7ed
     def find_best_subtitle(lang)
       @best_subtitle ||= {}
       subtitles(lang).each do |sub|
-        @best_subtitle[lang] = sub if sub.works_for? @filename.group and sub.can_replace? @best_subtitle[lang]
+        @best_subtitle[lang] = sub if sub.works_for? file.group and sub.can_replace? @best_subtitle[lang]
       end
       raise NoSubtitleFound unless @best_subtitle[lang]
     end
@@ -83,8 +84,8 @@ module Addic7ed
       download_best_subtitle!(lang, http_redirect_limit - 1)
     end
 
-    def save_subtitle(content)
-      Kernel.open "#{filename}".gsub(/\.\w{3}$/, '.srt'), 'w' do |f|
+    def save_subtitle(content, lang)
+      Kernel.open "#{file}".gsub(/\.\w{3}$/, untagged ? ".srt" : ".#{lang}.srt"), 'w' do |f|
         f << content
       end
     rescue

data/lib/addic7ed/parser.rb

@@ -17,7 +17,7 @@ module Addic7ed
       @subtitles
     end
 
-    protected
+  protected
 
     def subtitles_page_dom
       response = Net::HTTP.get_response(URI(@episode.url(@lang)))
@@ -38,13 +38,14 @@ module Addic7ed
     end
 
     def parse_subtitle_node(sub_node)
-      version   = extract_version(sub_node)
-      language  = extract_language(sub_node)
-      status    = extract_status(sub_node)
-      url       = extract_url(sub_node)
-      source    = extract_source(sub_node)
-      downloads = extract_downloads(sub_node)
-      Addic7ed::Subtitle.new(version, language, status, url, source, downloads)
+      Addic7ed::Subtitle.new(
+        version:   extract_version(sub_node),
+        language:  extract_language(sub_node),
+        status:    extract_status(sub_node),
+        url:       extract_url(sub_node),
+        source:    extract_source(sub_node),
+        downloads: extract_downloads(sub_node)
+      )
     end
 
     def extract_version(sub_node)

data/lib/addic7ed/subtitle.rb

@@ -4,60 +4,65 @@ module Addic7ed
     attr_reader :version, :language, :status, :via, :downloads
     attr_accessor :url
 
-    def initialize(version, language, status, url, via, downloads)
-      @version   = normalized_version(version)
-      @language  = language
-      @status    = status
-      @url       = url
-      @via       = via
-      @downloads = downloads.to_i
+    def initialize(options = {})
+      @version   = options[:version]
+      @language  = options[:language]
+      @status    = options[:status]
+      @url       = options[:url]
+      @via       = options[:via]
+      @downloads = options[:downloads].to_i || 0
+      normalize_version!
     end
 
     def to_s
-      "#{url}\t->\t#{@version} (#{language}, #{status}) [#{@downloads} downloads]#{" (via #{via})" if @via}"
+      "#{url}\t->\t#{version} (#{language}, #{status}) [#{downloads} downloads]#{" (via #{via})" if via}"
     end
 
     def works_for?(version = '')
       is_completed? and is_compatible_with? version
     end
 
-    def can_replace?(other_sub)
+    def can_replace?(other_subtitle)
       return false unless is_completed?
-      return true if other_sub.nil?
-      language == other_sub.language and
-      is_compatible_with? other_sub.version and
-      is_more_popular_than? other_sub
+      return true if other_subtitle.nil?
+      language == other_subtitle.language &&
+      is_compatible_with?(other_subtitle.version) &&
+      is_more_popular_than?(other_subtitle)
     end
 
-    protected
-
-    def normalized_version(version)
-      version.
-        gsub(/^Version */i, '').
-        gsub(/720p/i, '').
-        gsub(/hdtv/i, '').
-        gsub(/proper/i, '').
-        gsub(/rerip/i, '').
-        gsub(/x\.?264/i, '').
-        gsub(/^[- \.]*/, '').
-        gsub(/[- \.]*$/, '').
-        upcase
+    def is_featured?
+      via == "http://addic7ed.com"
     end
 
     def is_completed?
       status == 'Completed'
     end
 
+  protected
+
+    def normalize_version!
+      @version ||= ""
+      @version.gsub!(/^Version */i, '')
+      @version.gsub!(/720p/i,       '')
+      @version.gsub!(/hdtv/i,       '')
+      @version.gsub!(/proper/i,     '')
+      @version.gsub!(/rerip/i,      '')
+      @version.gsub!(/x\.?264/i,    '')
+      @version.gsub!(/^[- \.]*/,    '')
+      @version.gsub!(/[- \.]*$/,    '')
+      @version.upcase!
+    end
+
     def is_compatible_with?(other_version)
-      version == other_version or
-      COMPATIBILITY_720P[version] == other_version or
-      COMPATIBILITY_720P[other_version] == version
+      self.version == other_version ||
+      COMPATIBILITY_720P[self.version] == other_version ||
+      COMPATIBILITY_720P[other_version] == self.version
     end
 
-    def is_more_popular_than?(other_sub)
-      return true   if other_sub.nil?
-      return false  if other_sub.via == 'http://addic7ed.com'
-      return downloads > other_sub.downloads
+    def is_more_popular_than?(other_subtitle)
+      return true  if other_subtitle.nil?
+      return false if other_subtitle.is_featured?
+      return self.downloads > other_subtitle.downloads
     end
 
   end

data/lib/addic7ed/version.rb

@@ -1,3 +1,3 @@
 module Addic7ed
-  VERSION = '0.3.4'
+  VERSION = '0.4.0'
 end

data/lib/addic7ed/{filename.rb → video_file.rb}

@@ -1,5 +1,5 @@
 module Addic7ed
-  class Filename
+  class VideoFile
 
     TVSHOW_REGEX = /\A(?<showname>.*\w)[\[\. ]+S?(?<season>\d{1,2})[-\. ]?[EX]?(?<episode>\d{2})([-\. ]?[EX]?\d{2})*[\]\. ]+(?<tags>.*)-(?<group>\w*)(\.\w{3})?\z/i
 
@@ -32,15 +32,15 @@ module Addic7ed
     # Lazy getters
 
     def basename
-      @basename ||= File.basename(@filename)
+      @basename ||= ::File.basename(@filename)
     end
 
     def dirname
-      @dirname ||= File.dirname(@filename)
+      @dirname ||= ::File.dirname(@filename)
     end
 
     def extname
-      @extname ||= File.extname(@filename)
+      @extname ||= ::File.extname(@filename)
     end
 
     def to_s

data/spec/{addic7ed-episode_spec.rb → lib/addic7ed/episode_spec.rb}

@@ -94,53 +94,64 @@ describe Addic7ed::Episode do
   end
 
   describe '#download_best_subtitle!' do
-    before :each do
+    let(:episode) { Addic7ed::Episode.new(@filename) }
+
+    before do
       WebMock.reset!
       @page_stub = stub_request(:get, 'http://www.addic7ed.com/serie/The_Walking_Dead/3/2/8')
         .to_return File.new('spec/responses/walking-dead-3-2-8.http')
       @sub_stub = stub_request(:get, 'http://www.addic7ed.com/original/68018/4')
         .to_return File.new('spec/responses/walking-dead-3-2-8_best_subtitle.http')
-      # The Episode object must be re-created between every test, since redirection may modify its URI
-      @reset_episode = Addic7ed::Episode.new(@filename)
       # Prevent actual disk writing
       allow(Kernel).to receive(:open)
     end
 
     it 'gets the best subtitle candidate with a network request' do
-      expect(@reset_episode).to receive(:best_subtitle).once.and_call_original
-      @reset_episode.download_best_subtitle!('fr')
+      expect(episode).to receive(:best_subtitle).once.and_call_original
+      episode.download_best_subtitle!('fr')
       expect(@page_stub).to have_been_requested
       expect(@sub_stub).to have_been_requested
     end
 
     it 'raises DownloadError when a network error happens' do
       stub_request(:get, 'http://www.addic7ed.com/original/68018/4').to_timeout
-      expect{ @reset_episode.download_best_subtitle!('fr') }.to raise_error Addic7ed::DownloadError
+      expect{ episode.download_best_subtitle!('fr') }.to raise_error Addic7ed::DownloadError
     end
 
     it 'is called recursively' do
       stub_request(:get, 'http://www.addic7ed.com/original/68018/4').to_return File.new('spec/responses/basic_redirection.http')
       stub_request(:get, 'http://www.addic7ed.com/original/68018/4.redirected').to_return File.new('spec/responses/walking-dead-3-2-8_best_subtitle.http')
-      expect(@reset_episode).to receive(:download_best_subtitle!).twice.and_call_original
-      @reset_episode.download_best_subtitle!('fr')
+      expect(episode).to receive(:download_best_subtitle!).twice.and_call_original
+      episode.download_best_subtitle!('fr')
     end
 
     it 'raises HTTPError when stuck in a HTTP redirections loop' do
       stub_request(:get, 'http://www.addic7ed.com/original/68018/4')
         .to_return File.new('spec/responses/redirection_loop.http')
-      expect{ @reset_episode.download_best_subtitle!('fr') }.to raise_error Addic7ed::HTTPError
+      expect{ episode.download_best_subtitle!('fr') }.to raise_error Addic7ed::HTTPError
     end
 
     it 'creates a new file on disk' do
       file = double('file')
-      expect(Kernel).to receive(:open).with('The.Walking.Dead.S03E02.720p.HDTV.x264-EVOLVE.srt', 'w').and_yield(file)
+      expect(Kernel).to receive(:open).with('The.Walking.Dead.S03E02.720p.HDTV.x264-EVOLVE.fr.srt', 'w').and_yield(file)
       expect(file).to receive(:<<)
-      @reset_episode.download_best_subtitle!('fr')
+      episode.download_best_subtitle!('fr')
+    end
+
+    context "when untagged option is set" do
+      let(:episode) { Addic7ed::Episode.new(@filename, true) }
+
+      it "does not include language code in subtitle filename" do
+        file = double('file')
+        expect(Kernel).to receive(:open).with('The.Walking.Dead.S03E02.720p.HDTV.x264-EVOLVE.srt', 'w').and_yield(file)
+        expect(file).to receive(:<<)
+        episode.download_best_subtitle!('fr')
+      end
     end
 
     it 'raises SubtitleCannotBeSaved when a disk error happens' do
-      expect(Kernel).to receive(:open).with('The.Walking.Dead.S03E02.720p.HDTV.x264-EVOLVE.srt', 'w').and_raise('Persmission denied')
-      expect{ @reset_episode.download_best_subtitle!('fr') }.to raise_error Addic7ed::SubtitleCannotBeSaved
+      expect(Kernel).to receive(:open).with('The.Walking.Dead.S03E02.720p.HDTV.x264-EVOLVE.fr.srt', 'w').and_raise('Persmission denied')
+      expect{ episode.download_best_subtitle!('fr') }.to raise_error Addic7ed::SubtitleCannotBeSaved
     end
   end
 end

data/spec/lib/addic7ed/subtitle_spec.rb

@@ -0,0 +1,167 @@
+require "spec_helper"
+require "./lib/addic7ed"
+
+describe Addic7ed::Subtitle, "#normalize_version!" do
+  def normalized_version(version)
+    Addic7ed::Subtitle.new(version: version).version
+  end
+
+  it "upcases everything" do
+    expect(normalized_version("DiMENSiON")).to eq 'DIMENSION'
+  end
+
+  it "removes heading or trailing dots" do
+    expect(normalized_version(".DIMENSION.")).to eq 'DIMENSION'
+  end
+
+  it "removes heading or trailing whitespaces" do
+    expect(normalized_version(" DIMENSION ")).to eq 'DIMENSION'
+  end
+
+  it "removes heading or trailing dashes" do
+    expect(normalized_version("-DIMENSION-")).to eq 'DIMENSION'
+  end
+
+  it "removes '720p' tag" do
+    expect(normalized_version("720P DIMENSION")).to eq 'DIMENSION'
+  end
+
+  it "removes 'HDTV' tag" do
+    expect(normalized_version("HDTV DIMENSION")).to eq 'DIMENSION'
+  end
+
+  it "removes 'x264' tag" do
+    expect(normalized_version("X264 DIMENSION")).to eq 'DIMENSION'
+    expect(normalized_version("X.264 DIMENSION")).to eq 'DIMENSION'
+  end
+
+  it "removes 'PROPER' tag" do
+    expect(normalized_version("PROPER DIMENSION")).to eq 'DIMENSION'
+  end
+
+  it "removes 'RERIP' tag" do
+    expect(normalized_version("RERIP DIMENSION")).to eq 'DIMENSION'
+  end
+
+  it "removes the 'Version' prefix" do
+    expect(normalized_version("Version DIMENSION")).to eq 'DIMENSION'
+  end
+end
+
+describe Addic7ed::Subtitle, "#to_s" do
+  let(:subtitle) { Addic7ed::Subtitle.new(version: "DIMENSION", language: "fr", status: "Completed", url: "http://some.fancy.url", via: "http://addic7ed.com", downloads: "42") }
+
+  it "prints a human readable version" do
+    expect(subtitle.to_s).to eq "http://some.fancy.url\t->\tDIMENSION (fr, Completed) [42 downloads] (via http://addic7ed.com)"
+  end
+end
+
+describe Addic7ed::Subtitle, "#works_for?" do
+  let(:subtitle) { Addic7ed::Subtitle.new(version: "DIMENSION") }
+
+  context "when it is incomplete" do
+    before { allow(subtitle).to receive(:is_completed?).and_return(false) }
+
+    it "returns false" do
+      expect(subtitle.works_for? "DIMENSION").to be false
+    end
+  end
+
+  context "when it is completed" do
+    before { allow(subtitle).to receive(:is_completed?).and_return(true) }
+
+    it "returns true given the exact same version" do
+      expect(subtitle.works_for? "DIMENSION").to be true
+    end
+
+    it "returns true given a compatible version" do
+      expect(subtitle.works_for? "LOL").to be true
+    end
+
+    it "returns false given an incompatible version" do
+      expect(subtitle.works_for? "EVOLVE").to be false
+    end
+  end
+end
+
+describe Addic7ed::Subtitle, "#can_replace?" do
+  let(:defaults)       { {version: "DIMENSION", language: "fr", status: "Completed", downloads: "10"} }
+  let(:subtitle)       { Addic7ed::Subtitle.new(defaults) }
+  let(:other_subtitle) { Addic7ed::Subtitle.new(defaults) }
+
+  context "when it is incomplete" do
+    before { allow(subtitle).to receive(:is_completed?).and_return(false) }
+
+    it "returns false" do
+      expect(subtitle.can_replace? other_subtitle).to be false
+    end
+  end
+
+  context "when it is completed" do
+    before { allow(subtitle).to receive(:is_completed?).and_return(true) }
+
+    it "returns true given no other_subtitle" do
+      expect(subtitle.can_replace? nil).to be true
+    end
+
+    context "when other_subtitle has a different language" do
+      before { allow(other_subtitle).to receive(:language).and_return("en") }
+
+      it "returns false" do
+        expect(subtitle.can_replace? other_subtitle).to be false
+      end
+    end
+
+    context "when other_subtitle has an incompatible version" do
+      before { allow(subtitle).to receive(:is_compatible_with?).with(other_subtitle.version).and_return(false) }
+
+      it "returns false" do
+        expect(subtitle.can_replace? other_subtitle).to be false
+      end
+    end
+
+    context "when other_subtitle is featured by Addic7ed" do
+      before { allow(other_subtitle).to receive(:is_featured?).and_return(true) }
+
+      it "returns false" do
+        expect(subtitle.can_replace? other_subtitle).to be false
+      end
+    end
+
+    context "when other_subtitle has more downloads" do
+      before { allow(other_subtitle).to receive(:downloads).and_return(subtitle.downloads + 1) }
+
+      it "returns false" do
+        expect(subtitle.can_replace? other_subtitle).to be false
+      end
+    end
+
+    context "when other_subtitle has less downloads" do
+      before { allow(other_subtitle).to receive(:downloads).and_return(subtitle.downloads - 1) }
+
+      it "returns true" do
+        expect(subtitle.can_replace? other_subtitle).to be true
+      end
+    end
+  end
+end
+
+describe Addic7ed::Subtitle, "#is_featured?" do
+  it "returns true when 'via' is 'http://addic7ed.com'" do
+    expect(Addic7ed::Subtitle.new(via: 'http://addic7ed.com').is_featured?).to be true
+  end
+
+  it "returns false otherwise" do
+    expect(Addic7ed::Subtitle.new(via: 'anything else').is_featured?).to be false
+  end
+end
+
+describe Addic7ed::Subtitle, "#is_completed?" do
+  it "returns true when 'status' is 'Completed'" do
+    expect(Addic7ed::Subtitle.new(status: 'Completed').is_completed?).to be true
+  end
+
+  it "returns false otherwise" do
+    expect(Addic7ed::Subtitle.new(status: '80%').is_completed?).to be false
+  end
+end

data/spec/lib/addic7ed/video_file_spec.rb

@@ -0,0 +1,189 @@
+require 'spec_helper'
+require './lib/addic7ed'
+
+describe Addic7ed::VideoFile do
+  let(:file) { Addic7ed::VideoFile.new(filename) }
+
+  shared_examples "a media file" do |filename, expected_show_name|
+    let(:filename) { filename }
+
+    it "it detects successfully" do
+      expect(file.showname).to eq (expected_show_name || 'Showname')
+      expect(file.season  ).to eq 2
+      expect(file.episode ).to eq 1
+      expect(file.tags    ).to eq ['720P', 'HDTV', 'X264']
+      expect(file.group   ).to eq 'GROUP'
+    end
+  end
+
+  shared_examples "an unknown file" do |filename|
+    let(:filename) { filename }
+
+    it "raises an error" do
+      expect{file}.to raise_error Addic7ed::InvalidFilename
+    end
+  end
+
+  describe "#initialize" do
+    context "with regular notation" do
+      it_behaves_like "a media file", "Showname.S02E01.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context "with x notation" do
+      it_behaves_like "a media file", "Showname.02x01.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context 'with 3-digits notation' do
+      it_behaves_like "a media file", "Showname.201.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context 'with brackets notation' do
+      it_behaves_like "a media file", "Showname.[S02E01].720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context 'with brackets and x notation' do
+      it_behaves_like "a media file", "Showname.[2x01].720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context 'with brackets and 3-digits notation' do
+      it_behaves_like "a media file", "Showname.[201].720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context 'with brackets and x notation and space separator' do
+      it_behaves_like "a media file", "Showname [2x01] 720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context 'with brackets and 3-digits notation and space separator' do
+      it_behaves_like "a media file", "Showname [201] 720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context 'with lowercase filename' do
+      it_behaves_like "a media file", "showname.s02e01.720p.HDTV.x264-group.mkv", "showname"
+    end
+
+    context 'with multiple words in show name' do
+      it_behaves_like "a media file", "Show.Name.S02E01.720p.HDTV.x264-GROUP.mkv", "Show Name"
+    end
+
+    context 'with multiple words in show name separated by spaces' do
+      it_behaves_like "a media file", "Show Name.S02E01.720p.HDTV.x264-GROUP.mkv", "Show Name"
+    end
+
+    context 'with only numbers in show name' do
+      it_behaves_like "a media file", "42.S02E01.720p.HDTV.x264-GROUP.mkv", "42"
+    end
+
+    context "with production year" do
+      it_behaves_like "a media file", "Showname.2014.S02E01.720p.HDTV.x264-GROUP.mkv", "Showname 2014"
+    end
+
+    context "with a full path" do
+      it_behaves_like "a media file", "/full/path/to/Showname.S02E01.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context "with a relative path" do
+      it_behaves_like "a media file", "../path/to/Showname.S02E01.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context "without extension" do
+      it_behaves_like "a media file", "Showname.S02E01.720p.HDTV.x264-GROUP"
+    end
+
+    context "with a double episode" do
+      it_behaves_like "a media file", "Showname.S02E0102.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context "with a double episode" do
+      it_behaves_like "a media file", "Showname.S02E01E02.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context "with a double episode with dash separator" do
+      it_behaves_like "a media file", "Showname.S02E01-02.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context "with no showname" do
+      it_behaves_like "an unknown file", ".S02E01.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context "with no season number" do
+      it_behaves_like "an unknown file", "Showname.E01.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context "with no episode number" do
+      it_behaves_like "an unknown file", "Showname.S02.720p.HDTV.x264-GROUP.mkv"
+    end
+
+    context "with no tag" do
+      it_behaves_like "an unknown file", "Showname.S02E01-GROUP.mkv"
+    end
+
+    context "with no group" do
+      it_behaves_like "an unknown file", "Showname.S02E01.720p.HDTV.x264.mkv"
+    end
+  end
+
+  describe '#encoded_filename' do
+    it 'changes all spaces to underscores' do
+      expect(Addic7ed::VideoFile.new("Show Name.S02E01.720p.HDTV.x264-GROUP.mkv").encoded_showname).to eq 'Show_Name'
+    end
+
+    it 'wraps country code with parenthesis' do
+      expect(Addic7ed::VideoFile.new("Showname.US.S02E01.720p.HDTV.x264-GROUP.mkv").encoded_showname).to eq 'Showname_(US)'
+    end
+
+    it 'detects country code even in lowercase' do
+      expect(Addic7ed::VideoFile.new("showname.us.S02E01.720p.HDTV.x264-GROUP.mkv").encoded_showname).to eq 'showname_(us)'
+    end
+
+    it "removes country code for the original show when it's UK" do
+      expect(Addic7ed::VideoFile.new("Showname.UK.S02E01.720p.HDTV.x264-GROUP.mkv").encoded_showname).to eq 'Showname'
+    end
+
+    it 'removes production year' do
+      expect(Addic7ed::VideoFile.new("Showname.2014.S02E01.720p.HDTV.x264-GROUP.mkv").encoded_showname).to eq 'Showname'
+    end
+
+    it 'handles when both country code and production year are present' do
+      expect(Addic7ed::VideoFile.new("Showname.2014.UK.S02E01.720p.HDTV.x264-GROUP.mkv").encoded_showname).to eq 'Showname'
+      expect(Addic7ed::VideoFile.new("Showname.UK.2014.S02E01.720p.HDTV.x264-GROUP.mkv").encoded_showname).to eq 'Showname'
+      expect(Addic7ed::VideoFile.new("Showname.2014.US.S02E01.720p.HDTV.x264-GROUP.mkv").encoded_showname).to eq 'Showname_(US)'
+      expect(Addic7ed::VideoFile.new("Showname.US.2014.S02E01.720p.HDTV.x264-GROUP.mkv").encoded_showname).to eq 'Showname_(US)'
+    end
+  end
+
+  describe '#basename' do
+    it 'returns only file name given a full path' do
+      expect(Addic7ed::VideoFile.new("/full/path/to/Showname.S02E01.720p.HDTV.x264-GROUP.mkv").basename).to eq "Showname.S02E01.720p.HDTV.x264-GROUP.mkv"
+    end
+  end
+
+  describe '#dirname' do
+    it 'returns only path given a full path' do
+      expect(Addic7ed::VideoFile.new("/full/path/to/Showname.S02E01.720p.HDTV.x264-GROUP.mkv").dirname).to eq '/full/path/to'
+    end
+  end
+
+  describe '#extname' do
+    it 'returns only file extension given a full path' do
+      expect(Addic7ed::VideoFile.new("/full/path/to/Showname.S02E01.720p.HDTV.x264-GROUP.mkv").extname).to eq '.mkv'
+    end
+  end
+
+  describe '#to_s' do
+    it 'returns file name as a string' do
+      expect(Addic7ed::VideoFile.new("/full/path/to/Showname.S02E01.720p.HDTV.x264-GROUP.mkv").to_s).to eq "/full/path/to/Showname.S02E01.720p.HDTV.x264-GROUP.mkv"
+    end
+  end
+
+  describe '#inspect' do
+    it 'prints a human-readable detailed version' do
+      expect(Addic7ed::VideoFile.new("Showname.S02E01.720p.HDTV.x264-GROUP.mkv").inspect).to eq(
+'Guesses for Showname.S02E01.720p.HDTV.x264-GROUP.mkv:
+  show:    Showname
+  season:  2
+  episode: 1
+  tags:    ["720P", "HDTV", "X264"]
+  group:   GROUP')
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -4,6 +4,8 @@ unless RUBY_ENGINE == 'rbx'
 end
 
 require 'webmock/rspec'
+require 'pry'
+
 WebMock.disable_net_connect!(allow_localhost: true)
 
 RSpec.configure do |config|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: addic7ed
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.4.0
 platform: ruby
 authors:
 - Michael Baudino
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-09 00:00:00.000000000 Z
+date: 2015-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -79,14 +93,14 @@ files:
 - lib/addic7ed/common.rb
 - lib/addic7ed/episode.rb
 - lib/addic7ed/errors.rb
-- lib/addic7ed/filename.rb
 - lib/addic7ed/parser.rb
 - lib/addic7ed/subtitle.rb
 - lib/addic7ed/version.rb
-- spec/addic7ed-common_spec.rb
-- spec/addic7ed-episode_spec.rb
-- spec/addic7ed-filename_spec.rb
-- spec/addic7ed-subtitle_spec.rb
+- lib/addic7ed/video_file.rb
+- spec/lib/addic7ed/common_spec.rb
+- spec/lib/addic7ed/episode_spec.rb
+- spec/lib/addic7ed/subtitle_spec.rb
+- spec/lib/addic7ed/video_file_spec.rb
 - spec/responses/basic_redirection.http
 - spec/responses/redirection_loop.http
 - spec/responses/walking-dead-3-2-1.http
@@ -117,15 +131,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Addic7ed auto-downloader
 test_files:
-- spec/addic7ed-common_spec.rb
-- spec/addic7ed-episode_spec.rb
-- spec/addic7ed-filename_spec.rb
-- spec/addic7ed-subtitle_spec.rb
+- spec/lib/addic7ed/common_spec.rb
+- spec/lib/addic7ed/episode_spec.rb
+- spec/lib/addic7ed/subtitle_spec.rb
+- spec/lib/addic7ed/video_file_spec.rb
 - spec/responses/basic_redirection.http
 - spec/responses/redirection_loop.http
 - spec/responses/walking-dead-3-2-1.http

data/spec/addic7ed-filename_spec.rb

@@ -1,309 +0,0 @@
-require 'spec_helper'
-require './lib/addic7ed'
-
-describe Addic7ed::Filename do
-  before :all do
-    # Valid filenames
-    @filename = 'Californication.S06E07.720p.HDTV.x264-2HD.mkv'
-    @filename_x = 'Californication.06x07.720p.HDTV.x264-2HD.mkv'
-    @filename_3digits = 'Californication.607.720p.HDTV.x264-2HD.mkv'
-    @filename_brackets = 'Californication.[S06E07].720p.HDTV.x264-2HD.mkv'
-    @filename_x_brackets = 'Californication.[6x07].720p.HDTV.x264-2HD.mkv'
-    @filename_3digits_brackets = 'Californication.[607].720p.HDTV.x264-2HD.mkv'
-    @filename_brackets_spaces = 'Californication [607] 720p.HDTV.x264-2HD.mkv'
-    @filename_x_brackets_spaces = 'Californication [6x07] 720p.HDTV.x264-2HD.mkv'
-    @filename_3digits_brackets_spaces = 'Californication [607] 720p.HDTV.x264-2HD.mkv'
-    @filename_lowercase = 'californication.s06e07.720p.hdtv.x264-2hd.mkv'
-    @filename_lowercase_x = 'californication.6x07.720p.hdtv.x264-2hd.mkv'
-    @filename_multiple_words = 'The.Walking.Dead.S03E11.720p.HDTV.x264-EVOLVE.mkv'
-    @filename_multiple_words_spaces = 'The Walking Dead S03E11 720p.HDTV.x264-EVOLVE.mkv'
-    @filename_numbers_only = '90210.S05E12.720p.HDTV.X264-DIMENSION.mkv'
-    @filename_showname_year = 'The.Americans.2013.S01E04.720p.HDTV.X264-DIMENSION.mkv'
-    @filename_full_path = '/data/public/Series/Californication/Saison 06/Californication.S06E07.720p.HDTV.x264-2HD.mkv'
-    @filename_relative_path = '../Saison 06/Californication.S06E07.720p.HDTV.x264-2HD.mkv'
-    @filename_no_extension = 'Californication.S06E07.720p.HDTV.x264-2HD'
-    @filename_double_episode = 'Revenge.S02E21E22.720p.HDTV.X264-DIMENSION.mkv'
-    @filename_double_episode_with_dash = 'Revenge.S02E21-22.720p.HDTV.X264-DIMENSION.mkv'
-    # Invalid filenames
-    @filename_no_showname = '.S06E07.720p.HDTV.x264-2HD.mkv'
-    @filename_no_season = 'Californication.E07.720p.HDTV.x264-2HD.mkv'
-    @filename_no_episode = 'Californication.S06.720p.HDTV.x264-2HD.mkv'
-    @filename_no_tags = 'Californication.S06E07.2HD.mkv'
-    @filename_no_group = 'Californication.S06E07.720p.HDTV.x264.mkv'
-    # Filename with special tags
-    @filename_showname_US = 'Shameless.US.S03E06.720p.HDTV.x264-IMMERSE.mkv'
-    @filename_showname_UK = 'Shameless.UK.S09E11.720p.HDTV.x264-TLA.mkv'
-    @filename_showname_US_lowercase = 'shameless.us.s04e01.720p.hdtv.x264-2hd.mkv'
-    @filename_showname_UK_year = 'The.Hour.UK.2011.S01E03.REPACK.HDTV.XviD-FoV.avi'
-    @filename_showname_year_UK = 'The.Hour.2011.UK.S01E03.REPACK.HDTV.XviD-FoV.avi'
-    @filename_showname_US_year = 'The.Hour.US.2011.S01E03.REPACK.HDTV.XviD-FoV.avi'
-    @filename_showname_year_US = 'The.Hour.2011.US.S01E03.REPACK.HDTV.XviD-FoV.avi'
-  end
-
-  describe '#initialize' do
-    it 'succeeds given valid argument' do
-      expect{ @file = Addic7ed::Filename.new(@filename) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename with x notation' do
-      expect{ @file = Addic7ed::Filename.new(@filename_x) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename with 3-digits notation' do
-      expect{ @file = Addic7ed::Filename.new(@filename_3digits) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename with brackets notation' do
-      expect{ @file = Addic7ed::Filename.new(@filename_brackets) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename with brackets and x notation' do
-      expect{ @file = Addic7ed::Filename.new(@filename_x_brackets) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename with brackets and 3-digits notation' do
-      expect{ @file = Addic7ed::Filename.new(@filename_3digits_brackets) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename with brackets notation and space separator' do
-      expect{ @file = Addic7ed::Filename.new(@filename_brackets_spaces) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename with brackets and x notation and space separator' do
-      expect{ @file = Addic7ed::Filename.new(@filename_x_brackets_spaces) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename with brackets and 3-digits notation and space separator' do
-      expect{ @file = Addic7ed::Filename.new(@filename_3digits_brackets_spaces) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given lowercase filename' do
-      expect{ @file = Addic7ed::Filename.new(@filename_lowercase) }.to_not raise_error
-      expect(@file.showname).to eq 'californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given lowercase filename with x notation' do
-      expect{ @file = Addic7ed::Filename.new(@filename_lowercase_x) }.to_not raise_error
-      expect(@file.showname).to eq 'californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename with showname containing multiple words' do
-      expect{ @file = Addic7ed::Filename.new(@filename_multiple_words) }.to_not raise_error
-      expect(@file.showname).to eq 'The Walking Dead'
-      expect(@file.season  ).to eq 3
-      expect(@file.episode ).to eq 11
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq 'EVOLVE'
-    end
-
-    it 'succeeds given filename with showname containing multiple words with space separator' do
-      expect{ @file = Addic7ed::Filename.new(@filename_multiple_words_spaces) }.to_not raise_error
-      expect(@file.showname).to eq 'The Walking Dead'
-      expect(@file.season  ).to eq 3
-      expect(@file.episode ).to eq 11
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq 'EVOLVE'
-    end
-
-    it 'succeeds given filename with showname containing only numbers' do
-      expect{ @file = Addic7ed::Filename.new(@filename_numbers_only) }.to_not raise_error
-      expect(@file.showname).to eq '90210'
-      expect(@file.season  ).to eq 5
-      expect(@file.episode ).to eq 12
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq 'DIMENSION'
-    end
-
-    it 'succeeds given filename with showname containing production year' do
-      expect{ @file = Addic7ed::Filename.new(@filename_showname_year) }.to_not raise_error
-      expect(@file.showname).to eq 'The Americans 2013'
-      expect(@file.season  ).to eq 1
-      expect(@file.episode ).to eq 4
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq 'DIMENSION'
-    end
-
-    it 'succeeds given filename containing full path' do
-      expect{ @file = Addic7ed::Filename.new(@filename_full_path) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename containing relative path' do
-      expect{ @file = Addic7ed::Filename.new(@filename_relative_path) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename containing no extension' do
-      expect{ @file = Addic7ed::Filename.new(@filename_no_extension) }.to_not raise_error
-      expect(@file.showname).to eq 'Californication'
-      expect(@file.season  ).to eq 6
-      expect(@file.episode ).to eq 7
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq '2HD'
-    end
-
-    it 'succeeds given filename which is a double episode' do
-      expect{ @file = Addic7ed::Filename.new(@filename_double_episode) }.to_not raise_error
-      expect(@file.showname).to eq 'Revenge'
-      expect(@file.season  ).to eq 2
-      expect(@file.episode ).to eq 21
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq 'DIMENSION'
-    end
-
-    it 'succeeds given filename which is a double episode (with a dash)' do
-      expect{ @file = Addic7ed::Filename.new(@filename_double_episode_with_dash) }.to_not raise_error
-      expect(@file.showname).to eq 'Revenge'
-      expect(@file.season  ).to eq 2
-      expect(@file.episode ).to eq 21
-      expect(@file.tags    ).to eq ['720P', 'HDTV', 'X264']
-      expect(@file.group   ).to eq 'DIMENSION'
-    end
-
-    it 'fails given filename with no showname' do
-      expect{ Addic7ed::Filename.new(@filename_no_showname) }.to raise_error Addic7ed::InvalidFilename
-    end
-
-    it 'fails given filename with no season number' do
-      expect{ Addic7ed::Filename.new(@filename_no_season) }.to raise_error Addic7ed::InvalidFilename
-    end
-
-    it 'raises InvalidFilename given filename with no episode number' do
-      expect{ Addic7ed::Filename.new(@filename_no_episode) }.to raise_error Addic7ed::InvalidFilename
-    end
-
-    it 'raises InvalidFilename given filename with no tags' do
-      expect{ Addic7ed::Filename.new(@filename_no_tags) }.to raise_error Addic7ed::InvalidFilename
-    end
-
-    it 'raises InvalidFilename given filename with no group' do
-      expect{ Addic7ed::Filename.new(@filename_no_group) }.to raise_error Addic7ed::InvalidFilename
-    end
-  end
-
-  describe '#encoded_filename' do
-    it 'changes all spaces to underscores' do
-      expect(Addic7ed::Filename.new(@filename_multiple_words).encoded_showname).to eq 'The_Walking_Dead'
-    end
-
-    it 'wraps country code with parenthesis' do
-      expect(Addic7ed::Filename.new(@filename_showname_US).encoded_showname).to eq 'Shameless_(US)'
-    end
-
-    it 'detects country code even in lowercase' do
-      expect(Addic7ed::Filename.new(@filename_showname_US_lowercase).encoded_showname).to eq 'shameless_(us)'
-    end
-
-    it 'removes country code for the original show (usually UK)' do
-      expect(Addic7ed::Filename.new(@filename_showname_UK).encoded_showname).to eq 'Shameless'
-    end
-
-    it 'removes production year' do
-      expect(Addic7ed::Filename.new(@filename_showname_year).encoded_showname).to eq 'The_Americans'
-    end
-
-    it 'handles when both country code and production year are present' do
-      expect(Addic7ed::Filename.new(@filename_showname_UK_year).encoded_showname).to eq 'The_Hour'
-      expect(Addic7ed::Filename.new(@filename_showname_year_UK).encoded_showname).to eq 'The_Hour'
-      expect(Addic7ed::Filename.new(@filename_showname_US_year).encoded_showname).to eq 'The_Hour_(US)'
-      expect(Addic7ed::Filename.new(@filename_showname_year_US).encoded_showname).to eq 'The_Hour_(US)'
-    end
-  end
-
-  describe '#basename' do
-    it 'returns only file name given a full path' do
-      expect(Addic7ed::Filename.new(@filename_full_path).basename).to eq 'Californication.S06E07.720p.HDTV.x264-2HD.mkv'
-    end
-  end
-
-  describe '#dirname' do
-    it 'returns only path given a full path' do
-      expect(Addic7ed::Filename.new(@filename_full_path).dirname).to eq '/data/public/Series/Californication/Saison 06'
-    end
-  end
-
-  describe '#extname' do
-    it 'returns only file extension given a full path' do
-      expect(Addic7ed::Filename.new(@filename_full_path).extname).to eq '.mkv'
-    end
-  end
-
-  describe '#to_s' do
-    it 'returns file name as a string' do
-      expect(Addic7ed::Filename.new(@filename_full_path).to_s).to eq '/data/public/Series/Californication/Saison 06/Californication.S06E07.720p.HDTV.x264-2HD.mkv'
-    end
-  end
-
-  describe '#inspect' do
-    it 'prints a human-readable detailed version' do
-      expect(Addic7ed::Filename.new(@filename).inspect).to eq(
-'Guesses for Californication.S06E07.720p.HDTV.x264-2HD.mkv:
-  show:    Californication
-  season:  6
-  episode: 7
-  tags:    ["720P", "HDTV", "X264"]
-  group:   2HD')
-    end
-  end
-end

data/spec/addic7ed-subtitle_spec.rb

@@ -1,155 +0,0 @@
-require 'spec_helper'
-require './lib/addic7ed'
-
-describe Addic7ed::Subtitle do
-  describe '#normalized_version' do
-    it 'upcases the version string' do
-      expect(Addic7ed::Subtitle.new('DiMENSiON', '', '', '', '', '0').version).to eq 'DIMENSION'
-    end
-
-    it 'removes heading and trailing dots' do
-      expect(Addic7ed::Subtitle.new('.DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION.', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('.DIMENSION.', '', '', '', '', '0').version).to eq 'DIMENSION'
-    end
-
-    it 'removes heading and trailing whitespaces' do
-      expect(Addic7ed::Subtitle.new(' DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION ', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new(' DIMENSION ', '', '', '', '', '0').version).to eq 'DIMENSION'
-    end
-
-    it 'removes heading and trailing dashes' do
-      expect(Addic7ed::Subtitle.new('-DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION-', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('-DIMENSION-', '', '', '', '', '0').version).to eq 'DIMENSION'
-    end
-
-    it 'automatically removes "720p" in version string' do
-      expect(Addic7ed::Subtitle.new('720p DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('720P DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION 720p', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION 720P', '', '', '', '', '0').version).to eq 'DIMENSION'
-    end
-
-    it 'automatically removes "HDTV" in version string' do
-      expect(Addic7ed::Subtitle.new('hdtv DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('HDTV DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION hdtv', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION HDTV', '', '', '', '', '0').version).to eq 'DIMENSION'
-    end
-
-    it 'automatically removes "x264" in version string' do
-      expect(Addic7ed::Subtitle.new('x264 DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('X264 DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('x.264 DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('X.264 DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION x264', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION X264', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION x.264', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION X.264', '', '', '', '', '0').version).to eq 'DIMENSION'
-    end
-
-    it 'automatically removes "PROPER" in version string' do
-      expect(Addic7ed::Subtitle.new('PROPER DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('Proper DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION PROPER', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION Proper', '', '', '', '', '0').version).to eq 'DIMENSION'
-    end
-
-    it 'automatically removes "RERIP" in version string' do
-      expect(Addic7ed::Subtitle.new('RERIP DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('Rerip DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION RERIP', '', '', '', '', '0').version).to eq 'DIMENSION'
-      expect(Addic7ed::Subtitle.new('DIMENSION Rerip', '', '', '', '', '0').version).to eq 'DIMENSION'
-    end
-
-    it 'automatically removes "Version" prefix in version string' do
-      expect(Addic7ed::Subtitle.new('Version DIMENSION', '', '', '', '', '0').version).to eq 'DIMENSION'
-    end
-  end
-
-  describe '#to_s' do
-    it 'prints a human readable version' do
-      sub = Addic7ed::Subtitle.new('DIMENSION', 'fr', 'Completed', 'http://some.fancy.url', 'http://addic7ed.com', '42')
-      expect(sub.to_s).to eq "http://some.fancy.url\t->\tDIMENSION (fr, Completed) [42 downloads] (via http://addic7ed.com)"
-    end
-  end
-
-  describe '#works_for?' do
-    context 'when incomplete' do
-      before(:all) { @sub = Addic7ed::Subtitle.new('', '', '80%', '', '', '10') }
-
-      it 'returns false' do
-        expect(@sub.works_for?).to be false
-      end
-    end
-
-    context 'when completed' do
-      before(:all) { @sub = Addic7ed::Subtitle.new('DIMENSION', '', 'Completed', '', '', '10') }
-
-      it 'returns true given the exact same version' do
-        expect(@sub.works_for? 'DIMENSION').to be true
-      end
-
-      it 'returns true given a compatible version' do
-        expect(@sub.works_for? 'LOL').to be true
-      end
-
-      it 'returns true when the subtitle is for a PROPER version' do
-        sub = Addic7ed::Subtitle.new('PROPER DIMENSION', '', 'Completed', '', '', '10')
-        expect(sub.works_for? 'DIMENSION').to be true
-        expect(sub.works_for? 'LOL').to be true
-      end
-
-      it 'returns false given an incompatible version' do
-        expect(@sub.works_for? 'EVOLVE').to be false
-      end
-    end
-  end
-
-  describe '#can_replace?' do
-    context 'when incomplete' do
-      it 'returns false' do
-        sub = Addic7ed::Subtitle.new('', '', '80%', '', '', '10')
-        any_other_sub = Addic7ed::Subtitle.new('', '', '', '', '', '0')
-        expect(sub.can_replace? any_other_sub).to be false
-      end
-    end
-
-    context 'when completed' do
-      before(:all) { @sub = Addic7ed::Subtitle.new('DIMENSION', 'fr', 'Completed', '', '', '10') }
-
-      it 'returns true given no other_sub' do
-        expect(@sub.can_replace? nil).to be true
-      end
-
-      it 'returns false given other_sub for another language' do
-        other_sub = Addic7ed::Subtitle.new('DIMENSION', 'en', 'Completed', '', '', '10')
-        expect(@sub.can_replace? other_sub).to be false
-      end
-
-      it 'returns false given other_sub for incompatible version' do
-        other_sub = Addic7ed::Subtitle.new('EVOLVE', 'fr', 'Completed', '', '', '10')
-        expect(@sub.can_replace? other_sub).to be false
-      end
-
-      context 'given other_sub language & version compatible' do
-        it 'returns false given other_sub featured by Addic7ed' do
-          other_sub = Addic7ed::Subtitle.new('DIMENSION', 'fr', 'Completed', '', 'http://addic7ed.com', '10')
-          expect(@sub.can_replace? other_sub).to be false
-        end
-
-        it 'returns false given other_sub with more downloads' do
-          other_sub = Addic7ed::Subtitle.new('DIMENSION', 'fr', 'Completed', '', '', '20')
-          expect(@sub.can_replace? other_sub).to be false
-        end
-
-        it 'returns true given other_sub with less downloads' do
-          other_sub = Addic7ed::Subtitle.new('DIMENSION', 'fr', 'Completed', '', '', '5')
-          expect(@sub.can_replace? other_sub).to be true
-        end
-      end
-    end
-  end
-end