adamsanderson-open_gem 1.0.0 → 1.1.0

data/README.markdown

@@ -5,8 +5,16 @@ Simply opens the specified gem in your default editor.
   
   gem open rails
   
+Installation:
+------------
+
+Just install like any normal gem:
+  gem install adamsanderson-open_gem
+  
+You might need to add Github as a gem source:
+  gem sources -a http://gems.github.com
+  
 For more help: 
   gem open --help
   
-  
 Adam Sanderson, netghost@gmail.com

data/Rakefile

@@ -15,6 +15,10 @@ begin
     s.authors = ["Adam Sanderson"]
     s.has_rdoc = false
     s.files = FileList["[A-Z]*", "{bin,lib,test}/**/*"]
+    
+    # Testing
+    s.test_files = FileList["test/**/*_test.rb"]
+    s.add_development_dependency 'mocha', '~> 0.9.5'
   end
 
 rescue LoadError
@@ -27,4 +31,4 @@ Rake::TestTask.new do |t|
   t.verbose = false
 end
 
-task :default => :install
+task :default => :test

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :patch: 0
 :major: 1
-:minor: 0
+:minor: 1

data/lib/rubygems/commands/open_command.rb

@@ -7,7 +7,7 @@ class Gem::Commands::OpenCommand < Gem::Command
   include Gem::VersionOption
   
   def initialize
-    super 'open', "Opens the gem's source directory with $EDITOR", 
+    super 'open', "Opens the gem's source directory with $GEM_OPEN_EDITOR or $EDITOR", 
       :command => nil, 
       :version=>  Gem::Requirement.default,
       :latest=>   false
@@ -29,31 +29,34 @@ class Gem::Commands::OpenCommand < Gem::Command
     "GEMNAME       gem to open"
   end
 
-  def execute    
+  def execute
     name = get_one_gem_name
+    path = get_path(name)
     
+    open_gem(path) if path
+  end
+  
+  def get_path(name)
     dep = Gem::Dependency.new name, options[:version]
     specs = Gem.source_index.search dep
     
     if specs.length == 0
       say "Could not find '#{name}'"
+      return nil
       
     elsif specs.length == 1 || options[:latest]
-      path = specs.last.full_gem_path
+      return specs.last.full_gem_path
       
     else
       choices = specs.map{|s|"#{s.name} #{s.version}"}
       c,i = choose_from_list "Open which gem?", choices
-      path = specs[i].full_gem_path if i
+      return specs[i].full_gem_path if i
       
     end
-    
-    open_gem(path) if path
   end
-  
-  private
+
   def open_gem(path)
-    editor = options[:command] || ENV['EDITOR']
+    editor = options[:command] || ENV['GEM_OPEN_EDITOR'] || ENV['EDITOR']
     if !editor
       say "Either set $EDITOR, or use -c <command_name>"
     else

data/test/open_command_test.rb

@@ -0,0 +1,42 @@
+require 'test/unit'
+require 'rubygems'
+require 'mocha'
+
+require 'rubygems/commands/open_command'
+require 'rubygems/exceptions'
+
+class Test_SomethingToTest < Test::Unit::TestCase
+  def setup
+  end
+
+  def test_opening_path
+    gem_name = 'neat_gem'
+    gem_path = 'some/path'
+    command = Gem::Commands::OpenCommand.new
+    
+    command.expects(:get_path).with(gem_name).returns(gem_path)
+    command.expects(:open_gem).with(gem_path)
+    
+    command.invoke(gem_name)
+  end
+  
+  def test_opening_nonexistent_path
+    gem_name = 'neat_gem'
+    gem_path = nil
+    command = Gem::Commands::OpenCommand.new
+    
+    command.expects(:get_path).with(gem_name).returns(gem_path)
+    command.expects(:open_gem).never
+    
+    command.invoke(gem_name)
+  end
+  
+  def test_opening_with_no_gem_name
+    command = Gem::Commands::OpenCommand.new
+    
+    assert_raises Gem::CommandLineError do
+      command.invoke()
+    end
+  end
+  
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: adamsanderson-open_gem
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors: 
 - Adam Sanderson
@@ -9,10 +9,19 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-04-26 00:00:00 -07:00
+date: 2009-04-28 00:00:00 -07:00
 default_executable: 
-dependencies: []
-
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: mocha
+  type: :development
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 0.9.5
+    version: 
 description: Open a gem's source directory with either the default editor, or a specified command.
 email: netghost@gmail.com
 executables: []
@@ -27,6 +36,7 @@ files:
 - VERSION.yml
 - lib/rubygems/commands/open_command.rb
 - lib/rubygems_plugin.rb
+- test/open_command_test.rb
 has_rdoc: false
 homepage: http://github.com/adamsanderson/open_gem
 post_install_message: 
@@ -53,5 +63,5 @@ rubygems_version: 1.2.0
 signing_key: 
 specification_version: 3
 summary: Gem Command to easily open a ruby gem with the editor of your choice.
-test_files: []
-
+test_files: 
+- test/open_command_test.rb