adamantium 0.0.4 → 0.0.5

data/.travis.yml

@@ -1,6 +1,6 @@
 language: ruby
 before_install: gem install bundler
-bundler_args: --without yard guard
+bundler_args: --without yard guard metrics benchmarks
 script: "bundle exec rake spec"
 rvm:
   - 1.8.7

data/Gemfile

@@ -27,9 +27,8 @@ end
 group :metrics do
   gem 'flay',      '~> 1.4.3'
   gem 'flog',      '~> 2.5.3'
-  gem 'reek',      '~> 1.2.8', :github => 'dkubb/reek'
   gem 'roodi',     '~> 2.1.0'
-  gem 'yardstick', '~> 0.8.0'
+  gem 'yardstick', '~> 0.8.0', :git => 'https://github.com/dkubb/yardstick.git'
 
   platforms :ruby_18, :ruby_19 do
     # this indirectly depends on ffi which does not build on ruby-head

data/adamantium.gemspec

@@ -13,10 +13,10 @@ Gem::Specification.new do |gem|
 
   gem.require_paths    = %w[lib]
   gem.files            = `git ls-files`.split($/)
-  gem.test_files       = `git ls-files spec/{unit,integration}`.split($/)
+  gem.test_files       = `git ls-files -- spec/{unit,integration}`.split($/)
   gem.extra_rdoc_files = %w[LICENSE README.md TODO]
 
-  gem.add_runtime_dependency('backports', '~> 2.6.4')
+  gem.add_runtime_dependency('backports', '~> 2.7.0')
   gem.add_runtime_dependency('ice_nine',  '~> 0.6.0')
 
   gem.add_development_dependency('rake',  '~> 10.0.3')

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 9
-total_score: 61
+total_score: 66

data/config/flog.yml

@@ -1,2 +1,2 @@
 ---
-threshold: 21.1
+threshold: 21.3

data/config/roodi.yml

@@ -1,5 +1,5 @@
 ---
-AbcMetricMethodCheck:            { score: 10.3 }
+AbcMetricMethodCheck:            { score: 10.78 }
 AssignmentInConditionalCheck:    { }
 CaseMissingElseCheck:            { }
 ClassLineCountCheck:             { line_count: 293 }

data/lib/adamantium/module_methods.rb

@@ -48,24 +48,28 @@ module Adamantium
 
     # Memoize the named method
     #
-    # @param [#to_s] method
-    #   a method to memoize
+    # @param [#to_s] method_name
+    #   a method name to memoize
     # @param [#call] freezer
     #   a freezer for memoized values
     #
     # @return [undefined]
     #
     # @api private
-    def memoize_method(method, freezer)
-      visibility = method_visibility(method)
+    def memoize_method(method_name, freezer)
+      method = instance_method(method_name)
+      if method.arity.nonzero?
+        raise ArgumentError, 'Cannot memoize method with nonzero arity'
+      end
+      visibility = method_visibility(method_name)
       define_memoize_method(method, freezer)
-      send(visibility, method)
+      send(visibility, method_name)
     end
 
     # Define a memoized method that delegates to the original method
     #
-    # @param [Symbol] method
-    #   the name of the method
+    # @param [UnboundMethod] method
+    #   the method to memoize
     # @param [#call] freezer
     #   a freezer for memoized values
     #
@@ -73,13 +77,13 @@ module Adamantium
     #
     # @api private
     def define_memoize_method(method, freezer)
-      original = instance_method(method)
-      undef_method(method)
-      define_method(method) do |*args|
-        memory.fetch(method) do
-          value  = original.bind(self).call(*args)
+      method_name = method.name.to_sym
+      undef_method(method_name)
+      define_method(method_name) do |*args|
+        memory.fetch(method_name) do
+          value  = method.bind(self).call(*args)
           frozen = freezer.call(value)
-          store_memory(method, frozen)
+          store_memory(method_name, frozen)
         end
       end
     end

data/lib/adamantium/version.rb

@@ -1,3 +1,3 @@
 module Adamantium
-  VERSION = '0.0.4'.freeze
+  VERSION = '0.0.5'.freeze
 end

data/spec/unit/adamantium/fixtures/classes.rb

@@ -4,6 +4,9 @@ module AdamantiumSpecs
   class Object
     include Adamantium
 
+    def argumented(foo)
+    end
+
     def test
       'test'
     end

data/spec/unit/adamantium/module_methods/memoize_spec.rb

@@ -23,7 +23,7 @@ shared_examples_for 'memoizes method' do
     if method != :some_state
       file, line = object.new.send(method).first.split(':')[0, 2]
       File.expand_path(file).should eql(File.expand_path('../../../../../lib/adamantium/module_methods.rb', __FILE__))
-      line.to_i.should eql(80)
+      line.to_i.should eql(84)
     end
   end
 
@@ -69,6 +69,14 @@ describe Adamantium::ModuleMethods, '#memoize' do
       end
     end
   end
+  
+  context 'on method with arguments' do
+    let(:method) { :argumented }
+
+    it 'should raise error' do
+      expect { subject }.to raise_error(ArgumentError, 'Cannot memoize method with nonzero arity')
+    end
+  end
 
   context 'with :noop freezer option' do
     let(:method)  { :some_state       }

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: adamantium
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: 
   segments: 
   - 0
   - 0
-  - 4
-  version: 0.0.4
+  - 5
+  version: 0.0.5
 platform: ruby
 authors: 
 - Dan Kubb
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-12-20 00:00:00 Z
+date: 2013-01-20 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: backports
@@ -26,12 +26,12 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 31
+        hash: 19
         segments: 
         - 2
-        - 6
-        - 4
-        version: 2.6.4
+        - 7
+        - 0
+        version: 2.7.0
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency