actv 2.5.0 → 2.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4269228c84454953535d04d0d80db8626a4aa9e9
-  data.tar.gz: 7820be864d4ab4ac32e21ae8c2e5b7e4dcc4b911
+  metadata.gz: d2c960eeba970c1ae3b64b260f4e75e7d0c2d439
+  data.tar.gz: 8da74b6d45cc994aafb1f77de9088c4831dc4246
 SHA512:
-  metadata.gz: 1de425fa54d216951dfa56044e98077f0aa40be68412201f97884dcf4af70e5ba16e7db149ade31e5194c370364fe5df4bfc2a4a5cc98545151756e4713bb584
-  data.tar.gz: 44d6ba3cb4485219c8edd1357040de16f66c6f4a101ff46f4d008650dc73cd3d319e5aaa2e838d975c3a57b98eb911dda7273e388b1d4572edd93d19b717852e
+  metadata.gz: 3e6a72e9414ac777636128bd6132fca7f9628db065c3b58f7c851d45267786e34f386b773d49747bde5b2378c4ed34fea3fc6b1966ee3169bb3292533ba3c928
+  data.tar.gz: a985e4045b5053a58a56bee24e49e58cf0854a65f3c704b703387fd5c59ff73e07f13408fb40f92486f2edd875da9a55e97505abdc78d2afee972551f40dee6c

data/lib/actv/event.rb

@@ -99,13 +99,13 @@ module ACTV
     # Returns the asset's registration open date
     # in UTC.  This is pulled from the salesStartDate
     def registration_open_date
-      Time.parse "#{authoritative_reg_start_date} UTC"
+      Time.parse parse_date_with_correct_timezone_or_offset(authoritative_reg_start_date)
     end
 
     # Returns the asset's registration end date
     # in UTC.  This is pulled from the salesEndDate
     def registration_close_date
-      Time.parse "#{authoritative_reg_end_date} UTC"
+      Time.parse parse_date_with_correct_timezone_or_offset(authoritative_reg_end_date)
     end
 
     # Returns the asset's start date
@@ -161,6 +161,14 @@ module ACTV
 
     private
 
+    def parse_date_with_correct_timezone_or_offset date
+      if self.awcamps30? || self.awcamps? || self.regcenter2? || self.regcenter?
+        "#{date} #{format_timezone_offset(place.timezoneOffset)}"
+      else
+        "#{date} UTC"
+      end
+    end
+
     # EG: -7 => "-0700"
     def format_timezone_offset(offset)
       (offset < 0 ? "-" : "") << offset.abs.to_s.rjust(2,'0') << '00'

data/lib/actv/version.rb

@@ -1,3 +1,3 @@
 module ACTV
-  VERSION = "2.5.0"
+  VERSION = "2.5.1"
 end

data/spec/actv/event_spec.rb

@@ -84,36 +84,52 @@ describe ACTV::Event do
   end
 
   describe '#registration_open_date' do
-    before { subject.stub(:sales_start_date).and_return format_date 1.day.from_now }
-    it "returns the correct date in the correct timezone" do
-      subject.registration_open_date.should be_within(1.second).of Time.parse format_date_in_utc 1.day.from_now
+    before { subject.stub(:sales_start_date).and_return '2016-11-10T00:00:00' }
+      it 'returns the correct date with correct timezone offset when asset belongs to camps or regcenter' do
+        expect(subject.registration_open_date).to eq '2016-11-10T00:00:00 -0500'
+      end
+    context 'when asset not belongs to camps or regcenter' do
+      before { subject.stub(:sourceSystem).and_return :legacyGuid => 'testid' }
+      it 'returns the correct date in utc timezone' do
+        expect(subject.registration_open_date).to eq '2016-11-10T00:00:00 UTC'
+      end
     end
   end
 
   describe '#registration_close_date' do
-    before { subject.stub(:sales_end_date).and_return format_date 1.day.from_now }
-    it "returns the correct date in the correct timezone" do
-      subject.registration_close_date.should be_within(1.second).of Time.parse format_date_in_utc 1.day.from_now
+    before { subject.stub(:sales_end_date).and_return '2016-12-10T00:00:00' }
+    context 'when asset belongs to camps or regcenter' do
+      before { subject.stub(:awcamps?).and_return true }
+      it 'returns the correct date with the correct timezone offset' do
+        expect(subject.registration_close_date).to eq '2016-12-10T00:00:00 -0500'
+      end
+    end
+
+    context 'when asset not belongs to camps or regcenter' do
+      before { subject.stub(:sourceSystem).and_return :legacyGuid => 'testid' }
+      it 'returns the correct date in utc timezone' do
+        expect(subject.registration_close_date).to eq '2016-12-10T00:00:00 UTC'
+      end
     end
   end
 
   describe '#event_start_date' do
     before do
-      subject.stub(:activity_start_date).and_return("2013-05-10T00:00:00")
+      subject.stub(:activity_start_date).and_return('2013-05-10T00:00:00')
       subject.stub(:timezone_offset).and_return(-4)
     end
-    it "returns the correct date in the correct timezone" do
-      subject.event_start_date.should eq Time.parse "2013-05-10T00:00:00 -0400"
+    it 'returns the correct date in the correct timezone' do
+      subject.event_start_date.should eq Time.parse '2013-05-10T00:00:00 -0400'
     end
   end
 
   describe '#event_end_date' do
     before do
-      subject.stub(:activity_end_date).and_return("2013-05-10T00:00:00")
+      subject.stub(:activity_end_date).and_return('2013-05-10T00:00:00')
       subject.stub(:timezone_offset).and_return(-4)
     end
-    it "returns the correct date in the correct timezone" do
-      subject.event_end_date.should eq Time.parse "2013-05-10T00:00:00 -0400"
+    it 'returns the correct date in the correct timezone' do
+      subject.event_end_date.should eq Time.parse '2013-05-10T00:00:00 -0400'
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actv
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.5.1
 platform: ruby
 authors:
 - Nathaniel Barnes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-12 00:00:00.000000000 Z
+date: 2015-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -412,7 +412,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Active API