actv 1.3.11 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e07617465c15e04efc739dcc8552c06ccebc28f6
-  data.tar.gz: fe777ce6c000a0bb609b5feb84b4361738489c75
+  metadata.gz: 4b6d1154e322af7be0639d43605c20130d6ffe10
+  data.tar.gz: f1ebad5fce18ce111bf365c26f2155ddd9de8422
 SHA512:
-  metadata.gz: d425cc25a0823c46f54eac3f5998a95f570097136027e0f710eb9652c52d2f33c9c05d7dfb438cc0b812a058c962261b2e74c4e077d2d010ae5de35362869387
-  data.tar.gz: b18351861f6b85cfcc3fb401597ee42eac6a7cd344ac8a9011373434df082eaeeb363e1fb06046a72d4831755817611115d3bb5201cee6ceabd451be275c0b4b
+  metadata.gz: 931654c507096789427ba46aa67fe930689bf4f63fb7b0a6a948d062b243481861d1a0a39fc34e921a15488d642cf412878109358d6c6dec393082ca39430c97
+  data.tar.gz: 27c9e26e7b58d3b7c1ca66ce090bc6da191251883251be16b04596b7560022af57f7033fb9626fe882ee7cbba2b0ecc5518eabb3464de2a2c1d3be7b873ff4d6

data/lib/actv/article.rb

@@ -1,42 +1,14 @@
 require 'actv/asset'
 require 'nokogiri'
+require 'active_support/core_ext/module/delegation'
 
 module ACTV
-  class Article < ACTV::Asset
+  class Article < Asset
+    attr_reader :author
+    delegate :image_url, :footer, :bio, :photo, :name_from_footer, to: :author, prefix: true
 
-    def author_footer
-      @author_footer ||= description_by_type 'authorFooter'
-    end
-
-    def by_line
-      @author ||= description_by_type 'articleByLine'
-    end
-
-    def author_bio
-      @author_bio ||= begin
-        bio_node = get_from_author_footer('div.author-text')
-        bio_node.inner_html unless bio_node.nil?
-      end
-    end
-
-    def author_photo
-      @author_photo ||= begin
-        image = nil
-
-        image_node = get_from_author_footer('div.signature-block-photo img')
-        if !image_node.nil?
-          image = ACTV::AssetImage.new({imageUrlAdr: image_node.attribute('src').text}) if image_node.attribute 'src'
-        end
-
-        image
-      end
-    end
-
-    def author_name_from_footer
-      @author_name_from_footer ||= begin
-        name_node = get_from_author_footer('span.author-name')
-        name_node.text unless name_node.nil?
-      end
+    def self.valid? response
+      ACTV::ArticleValidator.new(response).valid?
     end
 
     def source
@@ -48,7 +20,7 @@ module ACTV
     end
 
     def media_gallery?
-      self.type and self.type.downcase == "mediagallery"
+      type && type.downcase == "mediagallery"
     end
 
     def image
@@ -64,30 +36,49 @@ module ACTV
     end
 
     def inline_ad
-      @inline_ad ||= begin
-        val = tag_by_description 'inlinead'
-        if val
-          val.downcase == 'true'
-        else
-          true
-        end
-      end
+      @inline_ad ||= resolve_inline_ad_tag
     end
     alias inline_ad? inline_ad
 
-    private
+    def author
+      @author ||= author_from_reference || author_from_article
+    end
 
-      def get_from_author_footer(selector)
-        node = nil
+    def by_line
+      @by_line ||= description_by_type 'articleByLine'
+    end
+
+    def is_article?
+      true
+    end
+
+    def author_name_from_by_line
+      author_name_regex = /by (.*)/i.match by_line
+      author_name_regex[1].strip if author_name_regex.present?
+    end
+
+    private
 
-        if !author_footer.nil? && !author_footer.empty?
-          doc = Nokogiri::HTML(author_footer)
-          node = doc.css(selector).first
-        end
+    def author_from_article
+      ACTV::Author.build_from_article self.to_hash
+    end
 
-        node
+    def author_from_reference
+      if author_reference
+        ACTV.asset(author_reference.id).first
       end
-  end
-end
+    rescue ACTV::Error::NotFound
+      nil
+    end
 
+    def author_reference
+      references.find { |reference| reference.type == "author" }
+    end
 
+    def resolve_inline_ad_tag
+      tag = tag_by_description 'inlinead'
+      return false if tag && tag.downcase != 'true'
+      true
+    end
+  end
+end

data/lib/actv/article_validator.rb

@@ -0,0 +1,8 @@
+require 'actv/asset_validator'
+module ACTV
+  class ArticleValidator < AssetValidator
+    def valid?
+      category_is?('articles') || taxonomy_has?('articles')
+    end
+  end
+end

data/lib/actv/asset.rb

@@ -4,6 +4,7 @@ require 'actv/asset_description'
 require 'actv/asset_image'
 require 'actv/asset_legacy_data'
 require 'actv/asset_price'
+require 'actv/asset_reference'
 require 'actv/asset_status'
 require 'actv/asset_tag'
 require 'actv/asset_topic'
@@ -14,6 +15,7 @@ require 'actv/recurrence'
 
 module ACTV
   class Asset < ACTV::Identity
+    @types = []
 
     attr_reader :assetGuid, :assetName, :assetDsc, :activityStartDate, :activityStartTime, :activityEndDate, :activityEndTime,
       :homePageUrlAdr, :isRecurring, :contactName, :contactEmailAdr, :contactPhone, :showContact, :publishDate, :createdDate, :modifiedDate,
@@ -43,6 +45,22 @@ module ACTV
     alias maximum_age regReqMaxAge
     alias required_gender regReqGenderCd
 
+    def self.inherited base
+      @types << base
+    end
+
+    def self.types
+      @types + Array(self)
+    end
+
+    def self.from_response response={}
+      AssetFactory.new(response[:body]).asset
+    end
+
+    def self.valid? response
+      AssetValidator.new(response).valid?
+    end
+
     def endurance_id
       if self.awendurance?
         query_values = Addressable::URI.parse(registrationUrlAdr.to_s).query_values
@@ -181,28 +199,11 @@ module ACTV
     end
 
     def is_event?
-      self.assetCategories.each do |category|
-        if category[:category][:categoryTaxonomy].downcase.start_with?('event')
-          return true
-        end
-      end
       false
     end
 
     def is_article?
-      is_article = false
-      if self.assetCategories.any?
-        self.assetCategories.each do |category|
-          if category[:category][:categoryName].downcase == 'articles'
-            is_article = true
-          end
-        end
-      else
-        # no categories so check the sourceSystem
-        is_article = articles_source?
-      end
-
-      is_article
+      false
     end
 
     def has_location?
@@ -249,6 +250,10 @@ module ACTV
       self.sourceSystem[:legacyGuid].upcase == "B47B0828-23ED-4D85-BDF0-B22819F53332" rescue false
     end
 
+    def acm?
+      self.sourceSystem[:legacyGuid].upcase == "CA4EA0B1-7377-470D-B20D-BF6BEA23F040" rescue false
+    end
+
     def kids?
       kids_friendly_source_system? && kids_interest?
     end
@@ -348,7 +353,7 @@ module ACTV
       image = image_without_placeholder.imageUrlAdr rescue ""
 
       if image.empty? and (logoUrlAdr && logoUrlAdr != default_image && !(logoUrlAdr =~ URI::regexp).nil?)
-          image = logoUrlAdr
+        image = logoUrlAdr
       end
 
       image
@@ -362,6 +367,12 @@ module ACTV
       image_without_placeholder
     end
 
+    def references
+      @references ||= Array(@attrs[:assetReferences]).map do |reference|
+        ACTV::AssetReference.new reference
+      end
+    end
+
     private
 
     def image_without_placeholder
@@ -395,20 +406,13 @@ module ACTV
       end
     end
 
-private
-
     def kids_interest?
       interests = meta_interests.to_a.map(&:downcase)
       ['kids', 'family'].any? { |tag| interests.include? tag }
     end
 
     def kids_friendly_source_system?
-      activenet? || awcamps30? || articles_source? || researched?
-    end
-
-    def articles_source?
-      # this guid is equal to the Active.com Articles
-      self.sourceSystem.fetch(:legacyGuid, "").upcase == "CA4EA0B1-7377-470D-B20D-BF6BEA23F040"
+      activenet? || awcamps30? || acm? || researched?
     end
 
   end

data/lib/actv/asset_factory.rb

@@ -0,0 +1,15 @@
+module ACTV
+  class AssetFactory
+    attr_reader :response
+
+    def initialize response_body
+      @response = response_body
+    end
+
+    def asset
+      types = ACTV::Asset.types
+      klass = types.find { |type| type.valid? response }
+      klass.new response
+    end
+  end
+end

data/lib/actv/asset_image.rb

@@ -1,6 +1,5 @@
 module ACTV
   class AssetImage < Base
-
     attr_reader :imageUrlAdr, :imageName, :imageCaptionTxt, :linkUrl, :linkTarget
 
     alias url     imageUrlAdr
@@ -8,6 +7,5 @@ module ACTV
     alias caption imageCaptionTxt
     alias link    linkUrl
     alias target  linkTarget
-
   end
 end

data/lib/actv/asset_reference.rb

@@ -0,0 +1,11 @@
+module ACTV
+  class AssetReference < Base
+    def id
+      @attrs[:referenceAsset][:assetGuid]
+    end
+
+    def type
+      @attrs[:referenceType][:referenceTypeName]
+    end
+  end
+end

data/lib/actv/asset_validator.rb

@@ -0,0 +1,31 @@
+module ACTV
+  class AssetValidator
+    attr_reader :response
+
+    def initialize response
+      @response = response
+    end
+
+    def valid?
+      true
+    end
+
+    private
+
+    def asset_categories
+      response[:assetCategories] || []
+    end
+
+    def taxonomy_has? name
+      asset_categories.any? do |cat|
+        cat[:category][:categoryTaxonomy].downcase.include? name.downcase
+      end
+    end
+
+    def category_is? name
+      asset_categories.any? do |cat|
+        cat[:category][:categoryName].downcase == name.downcase
+      end
+    end
+  end
+end

data/lib/actv/author.rb

@@ -0,0 +1,61 @@
+require 'actv/asset'
+require 'active_support/core_ext/object/blank'
+
+module ACTV
+  class Author < Asset
+    def self.build_from_article article_hash
+      new article_hash
+    end
+
+    def self.valid? response
+      ACTV::AuthorValidator.new(response).valid?
+    end
+
+    def name
+      name_from_footer.presence || self.author_name.presence
+    end
+
+    def footer
+      @footer ||= description_by_type 'authorFooter'
+    end
+
+    def bio
+      @bio ||= begin
+        bio_node = from_footer 'div.author-text'
+        bio_node.inner_html unless bio_node.nil?
+      end
+    end
+
+    def photo
+      @photo ||= begin
+        image_node = from_footer 'div.signature-block-photo img'
+        url = image_node.attribute('src').to_s
+        ACTV::AssetImage.new imageUrlAdr: url
+      end
+    end
+
+    def image_url
+      if photo.url && photo.url.start_with?("/")
+        "http://www.active.com#{photo.url}"
+      else
+        photo.url
+      end
+    end
+
+    def name_from_footer
+      @name_from_footer ||= begin
+        name_node = from_footer 'span.author-name'
+        name_node.text unless name_node.nil?
+      end
+    end
+
+    private
+
+    def from_footer selector
+      if footer.present?
+        doc = Nokogiri::HTML footer
+        doc.css(selector).first
+      end
+    end
+  end
+end

data/lib/actv/author_validator.rb

@@ -0,0 +1,8 @@
+require 'actv/author_validator'
+module ACTV
+  class AuthorValidator < AssetValidator
+    def valid?
+      category_is?('author') || taxonomy_has?('author')
+    end
+  end
+end

data/lib/actv/base.rb

@@ -1,13 +1,10 @@
-require 'forwardable'
 require 'actv/null_object'
 require 'uri'
 
 module ACTV
   class Base
-    extend Forwardable
     attr_reader :attrs
     alias body attrs
-    def_delegators :attrs, :delete, :update
 
     # Define methods that retrieve the value from an initialized instance variable Hash, using the attribute as a key
     #
@@ -77,14 +74,22 @@ module ACTV
       end
     end
 
-    def self.from_response(response={})
-      new(response[:body])
+    def self.from_response response={}
+      new response[:body]
     end
 
-    def initialize(attrs={})
+    def initialize attrs={}
       @attrs = attrs || {}
     end
 
+    def delete key
+      attrs.delete key
+    end
+
+    def update key
+      attrs.update key
+    end
+
     def [](method)
       send(method)
     rescue NoMethodError
@@ -145,4 +150,4 @@ module ACTV
     end
 
   end
-end
+end