actv 1.2.0 → 1.3.0

data/README.md

@@ -1,4 +1,6 @@
 [![Build Status](https://travis-ci.org/activenetwork/actv.png)](https://travis-ci.org/activenetwork/actv)
+[![Code
+Climate](https://codeclimate.com/github/activenetwork/actv/badges/gpa.svg)](https://codeclimate.com/github/activenetwork/actv)
 
 # ACTV
 

data/actv.gemspec

@@ -11,6 +11,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'pry'
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec', '~> 2.14.1'
+  gem.add_development_dependency 'rspec-core'
   gem.add_development_dependency 'simplecov'
   gem.add_development_dependency 'timecop'
   gem.add_development_dependency 'webmock'

data/lib/actv/asset.rb

@@ -132,7 +132,7 @@ module ACTV
     def topics
       @asset_topics ||= Array(@attrs[:assetTopics]).map do |topic|
         ACTV::AssetTopic.new(topic)
-      end
+      end.sort
     end
     alias asset_topics topics
     alias assetTopics topics
@@ -191,10 +191,7 @@ module ACTV
         end
       else
         # no categories so check the sourceSystem
-        # this guid is equal to the Active.com Articles
-        if self.sourceSystem.fetch(:legacyGuid, "").upcase == "CA4EA0B1-7377-470D-B20D-BF6BEA23F040"
-          is_article = true
-        end
+        is_article = articles_source?
       end
 
       is_article
@@ -242,12 +239,7 @@ module ACTV
 
     def kids?
       return false if Rails.env == 'production'
-      (activenet? || awcamps? || awcamps30?) && kidsinterest?
-    end
-
-    def kidsinterest?
-      interests = meta_interests.to_a.map(&:downcase)
-      ['kids', 'family'].any? { |tag| interests.include? tag } 
+       kids_friendly_source_system? && kids_interest?
     end
 
     def registration_status
@@ -296,6 +288,10 @@ module ACTV
       urlize first_topic
     end
 
+    def first_topic_name
+      topics.first.topic.name
+    end
+
     def sub_topic
       get_first_topic_taxonomy[1]
     end
@@ -372,7 +368,7 @@ module ACTV
     end
 
     def get_first_topic_taxonomy
-      @first_topic_taxonomy ||= assetTopics.sort_by(&:sequence).first
+      @first_topic_taxonomy ||= assetTopics.first
       if @first_topic_taxonomy
         @first_topic_taxonomy.topic.topicTaxonomy.split '/'
       else
@@ -388,5 +384,20 @@ module ACTV
       end
     end
 
+private 
+    def kids_interest?
+      interests = meta_interests.to_a.map(&:downcase)
+      ['kids', 'family'].any? { |tag| interests.include? tag } 
+    end
+  
+    def kids_friendly_source_system?
+      activenet? || awcamps? || awcamps30? || articles_source?
+    end
+
+    def articles_source?
+      # this guid is equal to the Active.com Articles
+      self.sourceSystem.fetch(:legacyGuid, "").upcase == "CA4EA0B1-7377-470D-B20D-BF6BEA23F040"
+    end
+
   end
 end

data/lib/actv/asset_topic.rb

@@ -7,5 +7,9 @@ module ACTV
     def topic
       @topic ||= ACTV::Topic.new(@attrs[:topic]) unless @attrs[:topic].nil?
     end
+
+    def <=> topic
+       sequence <=> topic.sequence
+    end
   end
 end

data/lib/actv/client.rb

@@ -74,12 +74,9 @@ module ACTV
       end
 
       if response[:body].is_a? Array
-        results = []
-        response[:body].each do |item|
-          results << ACTV::Asset.from_response({body: item})
+        response[:body].map do |item|
+          ACTV::Asset.from_response body: item
         end
-
-        results
       else
         [ACTV::Asset.from_response(response)]
       end
@@ -166,9 +163,15 @@ module ACTV
 
       response = get("#{request_string}.json", params)
 
-      event = ACTV::Event.from_response(response)
-      event = ACTV::Evergreen.new(event) if event.evergreen?
-      event.is_article? ? nil : event
+      if response[:body].is_a? Array
+        response[:body].map do |item|
+          ACTV::Event.from_response body: item
+        end
+      else
+        event = ACTV::Event.from_response(response)
+        event = ACTV::Evergreen.new(event) if event.evergreen?
+        event.is_article? ? nil : event
+      end
     end
 
     # Returns popular assets that match a specified query.

data/lib/actv/version.rb

@@ -1,3 +1,3 @@
 module ACTV
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

data/spec/actv/asset_spec.rb

@@ -82,13 +82,13 @@ describe ACTV::Asset do
     end
   end
 
-    describe "#legacy_data" do
-      it "returns a Asset Legacy Data when assetLegacyData is set" do
-        legacy_data = ACTV::Asset.new(assetGuid: 1, assetName: "Asset #1", assetLegacyData: { assetTypeId: 1, typeName: "Legacy Data", isSearchable: true }).legacy_data
-        legacy_data.should be_a ACTV::AssetLegacyData
-      end
+  describe "#legacy_data" do
+    it "returns a Asset Legacy Data when assetLegacyData is set" do
+      legacy_data = ACTV::Asset.new(assetGuid: 1, assetName: "Asset #1", assetLegacyData: { assetTypeId: 1, typeName: "Legacy Data", isSearchable: true }).legacy_data
+      legacy_data.should be_a ACTV::AssetLegacyData
+    end
 
-      it "returns nil when assetLegacyData is not set" do
+    it "returns nil when assetLegacyData is not set" do
       legacy_data = ACTV::Asset.new(assetGuid: 1, assetName: "Asset #1").legacy_data
       legacy_data.should be_nil
     end
@@ -162,11 +162,16 @@ describe ACTV::Asset do
       topics.should be_a Array
       topics.should eq []
     end
+
+    it "returns an Array of Assets that are sorted by sequence" do
+      topics = ACTV::Asset.new(assetGuid: 1, assetName: "Asset #1", assetTopics: [{ sequence: "2", topic: { topicId: "28", topicName: "Triathlon" } }, { sequence: "1", topic: { topicId: "27", topicName: "Running" } }]).topics
+      topics.first.sequence.should eq "1"
+    end
   end
 
   describe "is_article?" do
     before(:each) do
-        stub_get("/v2/assets/valid_article.json").
+        stub_post("/v2/assets.json").with(:body => {"id"=>"valid_article"}).
           to_return(body: fixture("valid_article.json"), headers: { content_type: "application/json; charset=utf-8" })
     end
 
@@ -182,7 +187,7 @@ describe ACTV::Asset do
     end
 
     it "should return false if no assetCategory of Article" do
-      stub_get("/v2/assets/valid_event.json").
+      stub_post("/v2/assets.json").with(:body => {"id"=>"valid_event"}).
         to_return(body: fixture("valid_event.json"), headers: { content_type: "application/json; charset=utf-8" })
 
       asset = ACTV.asset('valid_event')[0]
@@ -202,99 +207,105 @@ describe ACTV::Asset do
 
   describe "#kids?" do
     let(:asset) { ACTV::Asset.new assetGuid: 1 }
-    context 'when kidsinterest? is true' do
-      before do 
-        asset.stub kidsinterest?: true 
-        class Rails
-          def self.env
-            "development"
-          end
+
+    before do 
+      class Rails
+        def self.env
+          "development"
         end
       end
+    end
 
-      context "when source system is Active Net" do
-        before { asset.stub activenet?: true }
+    context "when kids_friendly_source_system? is true" do 
+      context "by stubbing kids_friendly_source_system?" do 
+        before { asset.stub kids_friendly_source_system?: true }
 
-        context 'when source system is AW Camps' do
-          before do 
-            asset.stub awcamps?: true
-            asset.stub awcamps30?: true
-          end
-          it "evaluates to true" do
+        context 'when kids_interest? is true' do
+          before { asset.stub kids_interest?: true }
+
+          it 'evaluates to true' do
             asset.kids?.should eq true
           end
         end
 
-        context 'when source system is not AW Camps' do
-          before do 
-            asset.stub awcamps?: false 
-            asset.stub awcamps30?: false
+        context 'when kids_interest? is false' do
+          before { asset.stub kids_interest?: false }
+          
+          it 'evaluates to false' do
+            asset.kids?.should eq false
           end
-          it "evaluates to true" do
+        end
+      end
+
+      context "and activenet? returns true" do 
+        let(:asset) { ACTV::Asset.new assetGuid: 1, sourceSystem: {legacyGuid: "FB27C928-54DB-4ECD-B42F-482FC3C8681F"} }
+
+        context 'and kids_interest? is true' do
+          before { asset.stub kids_interest?: true }
+
+          it 'evaluates to true' do
             asset.kids?.should eq true
           end
         end
       end
 
-      context 'when source system is not Active Net' do
-        before { asset.stub activenet?: false }
+      context "and awcamps? returns true" do 
+        let(:asset) { ACTV::Asset.new assetGuid: 1, sourceSystem: {legacyGuid: "2B22B4E6-5AA4-44D7-BF06-F7A71F9FA8A6"} }
 
-        context 'when source system is AW Camps' do
-          before do 
-            asset.stub awcamps?: true 
-            asset.stub awcamps30?: true
-          end
-          it "evaluates to true" do
+        context 'and kids_interest? is true' do
+          before { asset.stub kids_interest?: true }
+
+          it 'evaluates to true' do
             asset.kids?.should eq true
           end
         end
+      end
 
-        context 'when source system is not AW Camps' do
-          before do 
-            asset.stub awcamps?: false 
-            asset.stub awcamps30?: false
-          end
-          it "evaluates to false" do
-            asset.kids?.should eq false
+      context "and awcamps30? returns true" do 
+        let(:asset) { ACTV::Asset.new assetGuid: 1, sourceSystem: {legacyGuid: "89208DBA-F535-4950-880A-34A6888A184C"} }
+
+        context 'and kids_interest? is true' do
+          before { asset.stub kids_interest?: true }
+
+          it 'evaluates to true' do
+            asset.kids?.should eq true
           end
         end
       end
-    end
 
-    context 'when kidsinterest? is false' do
-      before { asset.stub kidsinterest?: false }
-      it 'evaluates to false' do
-        asset.kids?.should eq false
-      end
-    end
-  end
+      context "and articles_source? returns true" do 
+        let(:asset) { ACTV::Asset.new assetGuid: 1, sourceSystem: {legacyGuid: "CA4EA0B1-7377-470D-B20D-BF6BEA23F040"} }
 
-  describe "#kidsinterest?" do
-    let(:asset) { ACTV::Asset.new assetGuid: 1, assetMetaInterests: meta_interests }
-    context "when kids meta-interest" do
-      let(:meta_interests) do
-          [ { sequence: '2', metaInterest: { metaInterestName: 'Family' } },
-            { sequence: '1', metaInterest: { metaInterestName: 'Kids' } } ]
-      end
-      it "evaluates to true" do
-        asset.kidsinterest?.should eq true
+        context 'and kids_interest? is true' do
+          before { asset.stub kids_interest?: true }
+
+          it 'evaluates to true' do
+            asset.kids?.should eq true
+          end
+        end
       end
     end
 
-    context "when other meta-interest" do
-      let(:meta_interests) do
-          [ { sequence: '2', metaInterest: { metaInterestName: 'NoFamily' } },
-            { sequence: '1', metaInterest: { metaInterestName: 'NoKids' } } ]
-      end
-      it "evaluates to false" do
-        asset.kidsinterest?.should eq false
+    context "when kids_friendly_source_system? is false" do 
+      context "by stubbing kids_friendly_source_system?" do 
+        before { asset.stub kids_friendly_source_system?: false }
+
+        it 'evaluates to false' do
+          asset.kids?.should eq false
+        end
       end
-    end
 
-    context "when no meta-interest" do
-      let(:meta_interests) {[]}
-      it "evaluates to false" do
-        asset.kidsinterest?.should eq false
+      context "and all source systems return false" do 
+        before do
+          asset.stub activenet?: false
+          asset.stub awcamps?: false
+          asset.stub awcamps30?: false
+          asset.stub articles_source?: false
+        end
+        
+        it 'evaluates to false' do
+          asset.kids?.should eq false
+        end
       end
     end
   end
@@ -318,11 +329,18 @@ describe ACTV::Asset do
 
   describe "topic path methods" do
     let(:assetTopics) do
-      [ { sequence: '2', topic: { topicTaxonomy: "Forth/Fifth/Sixth" } },
-        { sequence: '1', topic: { topicTaxonomy: "First/Second/Third" } } ]
+      [ { sequence: '2', topic: { topicTaxonomy: "Forth/Fifth/Sixth", topicName: "Triathlon" } },
+        { sequence: '1', topic: { topicTaxonomy: "First/Second/Third", topicName: "Running" } } ]
     end
     let(:asset) { ACTV::Asset.new assetGuid: 1, assetTopics: assetTopics }
 
+
+    describe '#first_topic_name' do
+      it "returns the first topics name" do
+        asset.first_topic_name.should == "Running"
+      end
+    end
+
     describe "#first_topic_path" do
       it "returns the first part of the first asset topic" do
         asset.first_topic_path.should == 'first'

data/spec/actv/asset_topic_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe ACTV::AssetTopic do
+
+  let(:topic) { ACTV::AssetTopic.new sequence: '1' }
+  let(:topic_2) { ACTV::AssetTopic.new sequence: '2' }
+  
+  describe "attribute accessors and aliases" do
+    subject { topic }
+
+    its(:sequence){ should eq '1' }
+    it "sorts by sequence" do
+      [topic_2,topic].sort.first.sequence.should eq '1'
+    end
+
+  end
+
+end

data/spec/actv/client/assets_spec.rb

@@ -9,14 +9,14 @@ describe ACTV::Client do
   describe "#asset" do
     context "with a valid asset ID passed" do
       before do
-        stub_get("/v2/assets/valid_asset.json").
+        stub_post("/v2/assets.json").with(:body => {"id"=>"valid_asset"}).
           to_return(body: fixture("valid_asset.json"), headers: { content_type: "application/json; charset=utf-8" })
 
         @asset = @client.asset("valid_asset")[0]
       end
 
       it "requests the correct asset" do
-        a_get("/v2/assets/valid_asset.json").should have_been_made
+        a_post("/v2/assets.json").should have_been_made
       end
 
       it "returns the correct place" do
@@ -84,4 +84,4 @@ describe ACTV::Client do
     end
   end
 
-end
+end

data/spec/actv/client/event_results_spec.rb

@@ -23,7 +23,7 @@ describe ACTV::Client do
       before do
         stub_request(:get, "http://api.amp.active.com/api/v1/events/asdf/asdf.json").
                    with(:headers => {'Accept'=>'application/json', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3'}).
-                            to_return(:status => 200, :body => "", :headers => {})
+                            to_return(:status => 500, :body => "", :headers => {})
       end
 
       it 'returns nil' do

data/spec/actv/client_spec.rb

@@ -145,6 +145,20 @@ describe ACTV::Client do
       end
     end
 
+    context 'when mutiple event ids' do
+      before do
+        stub_request(:get, "http://api.amp.active.com/v2/assets/asset_ids.json").
+          to_return(body: fixture("valid_assets.json"), headers: { content_type: "application/json; charset=utf-8" })
+      end
+
+      it 'returns an Array of Event' do
+        client.event('asset_ids').should be_a Array
+        client.event('asset_ids').first.should be_a ACTV::Event
+        client.event('asset_ids').last.should  be_a ACTV::Event
+      end
+
+    end
+
     context 'preview event' do
       context 'when set to true' do
         before do