actual_db_schema 0.7.8 → 0.7.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d2364e9f753a0515b61cfc7598a8479af8e6819a54ce9c103b44572bd09f7a2
-  data.tar.gz: 9d0e8b6a73e4f94b9beeb73d799053be6745b17804f93acbf3f0e09c6a7142f0
+  metadata.gz: 5a0d117f27b4bd908cbc04b0d3ca0faf0297a5feed5fd4f869c5672a50fc3cd9
+  data.tar.gz: cf0f37bc743eb44c8c5f6350454cc7f84f1781c8a8bc06ef25eb878830d7b973
 SHA512:
-  metadata.gz: 32b066503c2e9aa938552be473b4f8959022d022de6c743791f885781f6a1e585c83d1a1e635d78ffa378fdd0de828c5496c7f55c43638e16319aac74b2d39ac
-  data.tar.gz: 329e032b35b735a1b5fc0a3ffd4c7be8ebb9d98aca4469012321faa562cb6f46455996ad9bcc47d271ab2dd276ca5d5abad15af9b3da77b08c2612cc9936ebb1
+  metadata.gz: 50f4a4cd52039cd29d308676028a51fd7f44e25b89084e03c2ca570361c3c556f13bc924989415d04164967b63aadf0d88709c0f58289947fd2cf6a164f7f6dc
+  data.tar.gz: bd471eb79d28d9cf124452fe6e5608eb2a092800b4c49f1299348adf7a7c2a9d6a9bcd85da3f0cc6272753f743862e84b9777bab0cf095def8b9d1180a910e49

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.7.9] - 2024-09-07
+- Don't stop if a phantom migration rollback fails
+- Improve failed rollback of phantom migrations report
+
 ## [0.7.8] - 2024-08-07
 - Make UI working without assets pipeline
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    actual_db_schema (0.7.8)
+    actual_db_schema (0.7.9)
       activerecord
       activesupport
       csv

data/README.md

@@ -122,7 +122,8 @@ To release a new version do the following in the order:
 - update the CHANGELOG;
 - `bundle install` to update `Gemfile.lock`;
 - make the commit and push;
-- run `bundle exec rake release`. This will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+- run `bundle exec rake release`. This will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org);
+- [announce the new release on GitHub](https://github.com/widefix/actual_db_schema/releases).
 
 ### Running Tests with Specific Rails Versions
 

data/lib/actual_db_schema/commands/rollback.rb

@@ -4,6 +4,12 @@ module ActualDbSchema
   module Commands
     # Rolls back all phantom migrations
     class Rollback < Base
+      UNICODE_COLORS = {
+        red: 31,
+        green: 32,
+        yellow: 33
+      }.freeze
+
       def initialize(context, manual_mode: false)
         @manual_mode = manual_mode || manual_mode_default?
         super(context)
@@ -16,16 +22,46 @@ module ActualDbSchema
 
         return if ActualDbSchema.failed.empty?
 
+        puts_preamble
+        puts_into
         puts ""
-        puts "[ActualDbSchema] Irreversible migrations were found from other branches. Roll them back or fix manually:"
+        puts failed_migrations_list
+        puts_preamble
+      end
+
+      def failed_migrations_list
+        ActualDbSchema.failed.map.with_index(1) do |failed, index|
+          filename = failed.short_filename
+          exception = failed.exception
+          <<~MSG
+            \t#{colorize("[Migration##{index}]", :yellow)}
+            \t- #{filename}
+
+            \t\t#{exception.inspect.gsub("\n", "\n\t  ")}
+          MSG
+        end
+      end
+
+      def puts_preamble
         puts ""
-        puts ActualDbSchema.failed.map { |migration| "- #{migration.filename}" }.join("\n")
+        puts %(\u2757\u2757\u2757 #{colorize("[ActualDbSchema]", :red)})
         puts ""
       end
 
+      def puts_into
+        msg = "#{ActualDbSchema.failed.count} phantom migration(s) could not be rolled back automatically."
+        msg += " Roll them back or fix manually:"
+        puts colorize(msg, :red)
+      end
+
       def manual_mode_default?
         ActualDbSchema.config[:auto_rollback_disabled]
       end
+
+      def colorize(text, color)
+        code = UNICODE_COLORS.fetch(color, 37)
+        "\e[#{code}m#{text}\e[0m"
+      end
     end
   end
 end

data/lib/actual_db_schema/failed_migration.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module ActualDbSchema
+  FailedMigration = Struct.new(:migration, :exception, keyword_init: true) do
+    def filename
+      migration.filename
+    end
+
+    def short_filename
+      migration.filename.sub(File.join(Rails.root, "/"), "")
+    end
+  end
+end

data/lib/actual_db_schema/patches/migration_context.rb

@@ -11,7 +11,7 @@ module ActualDbSchema
           show_info_for(migration) if manual_mode
           migrate(migration) if !manual_mode || user_wants_rollback?
         rescue StandardError => e
-          handle_migration_error(e, migration)
+          ActualDbSchema.failed << FailedMigration.new(migration: migration, exception: e)
         end
       end
 
@@ -71,12 +71,6 @@ module ActualDbSchema
         puts File.read(migration.filename)
       end
 
-      def handle_migration_error(error, migration)
-        raise unless error.message.include?("ActiveRecord::IrreversibleMigration")
-
-        ActualDbSchema.failed << migration
-      end
-
       def migrate(migration)
         migrator = down_migrator_for(migration)
         migrator.extend(ActualDbSchema::Patches::Migrator)

data/lib/actual_db_schema/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActualDbSchema
-  VERSION = "0.7.8"
+  VERSION = "0.7.9"
 end

data/lib/actual_db_schema.rb

@@ -7,6 +7,7 @@ require_relative "actual_db_schema/git"
 require_relative "actual_db_schema/store"
 require_relative "actual_db_schema/version"
 require_relative "actual_db_schema/migration"
+require_relative "actual_db_schema/failed_migration"
 require_relative "actual_db_schema/migration_context"
 require_relative "actual_db_schema/patches/migration_proxy"
 require_relative "actual_db_schema/patches/migrator"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: actual_db_schema
 version: !ruby/object:Gem::Version
-  version: 0.7.8
+  version: 0.7.9
 platform: ruby
 authors:
 - Andrei Kaleshka
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-08-07 00:00:00.000000000 Z
+date: 2024-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -146,6 +146,7 @@ files:
 - lib/actual_db_schema/commands/list.rb
 - lib/actual_db_schema/commands/rollback.rb
 - lib/actual_db_schema/engine.rb
+- lib/actual_db_schema/failed_migration.rb
 - lib/actual_db_schema/git.rb
 - lib/actual_db_schema/migration.rb
 - lib/actual_db_schema/migration_context.rb