acts_more_seo 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec83478368dca721770a10e86ecd5ad7b3edc435
-  data.tar.gz: 76b21902f51b84a7f75566883e4379eabf9aea67
+  metadata.gz: 6f9639f8b54d0a9ef3ee6a3fd1a77b6eec205a03
+  data.tar.gz: 5596ab3b67ee722a89c058e5a256137dd6819b9d
 SHA512:
-  metadata.gz: ba75ecff765b0cb7abeeaa5f60dd500cbe1b5d0434c3724bf6e51358d6f3ee67e12bc906dbf91c6ff428f64311643348b0787b78771bbabf3ae811fc9f791218
-  data.tar.gz: 845c40e90b86a9bc997bf6fb8364b2c062af19cf07a24f21bee58a29c06141114a7e07bfecdc73d6fd459b6945af46f9e9a8e7e5211a8fe706c9b8f2caa101d7
+  metadata.gz: 9c05ed6cda9bbcfcf3fe8231c2596b940fc95fa26d72e81ca398950b99b7b95b5fe501f1e3908679f209b6f7365aa13cffe9dc37d4eed6ed889d7b39ca0d2015
+  data.tar.gz: 2b95457cd9b6c75a6d5948d87c7eb676e48a724acce6a2cf43d2bed44b8d53a912bc710a457dbf21a4f16a05cb640c235b27cca038717afe8707b93f43616469

data/CHANGELOG.rdoc

@@ -33,3 +33,6 @@ Backward compatibility improvements
 = Version 1.0.1
 * Polish letters conversion fix
 * Removed trim and trim! methods from string
+= Version 1.1.0
+* Update for default to_param AR behaviour - if use_id set to false - to_param won't include it
+* Removed unused string methods

data/Manifest

@@ -12,6 +12,5 @@ lib/generators/acts_more_seo/templates/create_seo_history_migration.rb
 lib/seo_finder.rb
 lib/seo_formatter.rb
 lib/seo_history.rb
-lib/string_ext.rb
 spec/acts_more_seo_spec.rb
 spec/spec_helper.rb

data/Rakefile

@@ -3,7 +3,7 @@ require 'rubygems'
 require 'rake'
 require 'echoe'
 
-Echoe.new('acts_more_seo', '1.0.1') do |p|
+Echoe.new('acts_more_seo', '1.1.0') do |p|
   p.description    = "Gem makes your ActiveRecord models more SEO friendly. Changes URL to look way better"
   p.url            = "https://github.com/mensfeld/Acts-more-SEO"
   p.author         = "Maciej Mensfeld"

data/acts_more_seo.gemspec

@@ -2,17 +2,17 @@
 
 Gem::Specification.new do |s|
   s.name = "acts_more_seo"
-  s.version = "1.0.1"
+  s.version = "1.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Maciej Mensfeld"]
-  s.date = "2013-09-17"
+  s.date = "2013-11-06"
   s.description = "Gem makes your ActiveRecord models more SEO friendly. Changes URL to look way better"
   s.email = "maciej@mensfeld.pl"
-  s.extra_rdoc_files = ["CHANGELOG.rdoc", "README.md", "lib/acts_more_seo.rb", "lib/generators/acts_more_seo/install_generator.rb", "lib/generators/acts_more_seo/templates/create_seo_history_migration.rb", "lib/seo_finder.rb", "lib/seo_formatter.rb", "lib/seo_history.rb", "lib/string_ext.rb"]
-  s.files = ["CHANGELOG.rdoc", "Gemfile", "MIT-LICENSE", "Manifest", "README.md", "Rakefile", "acts_more_seo.gemspec", "init.rb", "lib/acts_more_seo.rb", "lib/generators/acts_more_seo/install_generator.rb", "lib/generators/acts_more_seo/templates/create_seo_history_migration.rb", "lib/seo_finder.rb", "lib/seo_formatter.rb", "lib/seo_history.rb", "lib/string_ext.rb", "spec/acts_more_seo_spec.rb", "spec/spec_helper.rb"]
+  s.extra_rdoc_files = ["CHANGELOG.rdoc", "README.md", "lib/acts_more_seo.rb", "lib/generators/acts_more_seo/install_generator.rb", "lib/generators/acts_more_seo/templates/create_seo_history_migration.rb", "lib/seo_finder.rb", "lib/seo_formatter.rb", "lib/seo_history.rb"]
+  s.files = ["CHANGELOG.rdoc", "Gemfile", "MIT-LICENSE", "Manifest", "README.md", "Rakefile", "acts_more_seo.gemspec", "init.rb", "lib/acts_more_seo.rb", "lib/generators/acts_more_seo/install_generator.rb", "lib/generators/acts_more_seo/templates/create_seo_history_migration.rb", "lib/seo_finder.rb", "lib/seo_formatter.rb", "lib/seo_history.rb", "spec/acts_more_seo_spec.rb", "spec/spec_helper.rb"]
   s.homepage = "https://github.com/mensfeld/Acts-more-SEO"
-  s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Acts_more_seo", "--main", "README.md"]
+  s.rdoc_options = ["--line-numbers", "--title", "Acts_more_seo", "--main", "README.md"]
   s.require_paths = ["lib"]
   s.rubyforge_project = "acts_more_seo"
   s.rubygems_version = "2.0.0"

data/lib/acts_more_seo.rb

@@ -1,8 +1,8 @@
 require "babosa"
-require "string_ext"
 require "seo_formatter"
 require "seo_finder"
 require "seo_history"
+require "string_ext"
 
 module Acts
   module MoreSeo
@@ -63,13 +63,14 @@ module Acts
 
       # Overwrite default to_param - should return nice url
       def to_param
-        self.to_url
+        self.seo_use_id ? self.to_url : self.to_seo
       end
 
       # Lets return nice and smooth url
       def to_url
         Acts::MoreSeo::SeoFormatter.new(self).to_url
       end
+
       # Alias
       def url
         to_url

data/spec/acts_more_seo_spec.rb

@@ -57,6 +57,11 @@ describe CoolElement do
       subject.find_by_seo("134534dass").should eql(nil)
       lambda { subject.find_by_seo!("134534dass") }.should raise_error(ActiveRecord::RecordNotFound)
     end
+
+    it "should have to_param with id" do
+      a = subject.create(:name => 'bla bla bla')
+      subject.find_by_seo(a.id).to_param.to_i.should eql(a.id)
+    end
   end
 
   context "when there is no name" do
@@ -180,6 +185,13 @@ describe BestElement do
         a.seo_url.should eql("#{a.id}")
       end
     end
+
+    context "when we have a class which has use_id => false" do
+      it "should not to_param with id" do
+        a = subject.create(:name => 'bla bla bla')
+        subject.find_by_seo(a.id).to_param.to_i.should eql 0
+      end
+    end
   end
 
   context "when there are all the params" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_more_seo
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Maciej Mensfeld
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-17 00:00:00.000000000 Z
+date: 2013-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: babosa
@@ -66,7 +66,6 @@ extra_rdoc_files:
 - lib/seo_finder.rb
 - lib/seo_formatter.rb
 - lib/seo_history.rb
-- lib/string_ext.rb
 files:
 - CHANGELOG.rdoc
 - Gemfile
@@ -82,7 +81,6 @@ files:
 - lib/seo_finder.rb
 - lib/seo_formatter.rb
 - lib/seo_history.rb
-- lib/string_ext.rb
 - spec/acts_more_seo_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/mensfeld/Acts-more-SEO
@@ -91,7 +89,6 @@ metadata: {}
 post_install_message: 
 rdoc_options:
 - --line-numbers
-- --inline-source
 - --title
 - Acts_more_seo
 - --main

data/lib/string_ext.rb

@@ -1,30 +0,0 @@
-# coding: utf-8
-
-# Required string extensions
-
-class String
-  # Removes any "not url friendly" stuff and returns "pure" url
-  def to_url
-    temp = self.to_slug.transliterate.to_s.downcase
-    temp.gsub!(/[^a-zA-Z 0-9]/, "")
-    temp.gsub!(/\s/,'-')
-    temp.gsub!(/\-+$/,'')
-    temp.gsub!(/^\-+/,'')
-    temp.gsub!(/\-{2,}/, '-')
-    temp
-  end
-
-  def to_url!
-    self.replace self.to_url
-  end
-
-  # Change new line to html <br/>
-  def nl2br
-    self.gsub("\n\r","<br>").gsub("\r", "").gsub("\n", "<br />")
-  end
-
-  def nl2br!
-    self.replace self.nl2br
-  end
-
-end