acts_more_seo 0.4.2 → 0.4.3

data/CHANGELOG.rdoc

@@ -26,3 +26,5 @@ Backward compatibility improvements
 * Case sensitive/insensitive support
 = Version 0.4.2
 * Multiply pauses fix
+= Version 0.4.3
+* Casting non-string types to string before creating url

data/Rakefile

@@ -3,13 +3,13 @@ require 'rubygems'
 require 'rake'
 require 'echoe'
 
-Echoe.new('acts_more_seo', '0.4.2') do |p|
+Echoe.new('acts_more_seo', '0.4.3') do |p|
   p.description    = "Gem makes your ActiveRecord models more SEO friendly. Changes URL to look way better"
   p.url            = "https://github.com/mensfeld/Css-Image-Embedder"
   p.author         = "Maciej Mensfeld"
   p.email          = "maciej@mensfeld.pl"
   p.ignore_pattern = ["tmp/*", "script/*"]
   p.dependencies = ["babosa"]
-  p.development_dependencies = ["rspec >=2.0.0", "active_record"]
+  p.development_dependencies = ["rspec >=2.0.0", "activerecord"]
 end
 

data/acts_more_seo.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = "acts_more_seo"
-  s.version = "0.4.2"
+  s.version = "0.4.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Maciej Mensfeld"]
-  s.date = "2012-03-17"
+  s.date = "2013-01-01"
   s.description = "Gem makes your ActiveRecord models more SEO friendly. Changes URL to look way better"
   s.email = "maciej@mensfeld.pl"
   s.extra_rdoc_files = ["CHANGELOG.rdoc", "README.md", "lib/acts_more_seo.rb", "lib/generators/acts_more_seo/install_generator.rb", "lib/generators/acts_more_seo/templates/create_seo_history_migration.rb", "lib/seo_finder.rb", "lib/seo_formatter.rb", "lib/seo_history.rb", "lib/string_ext.rb"]
@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
   s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Acts_more_seo", "--main", "README.md"]
   s.require_paths = ["lib"]
   s.rubyforge_project = "acts_more_seo"
-  s.rubygems_version = "1.8.15"
+  s.rubygems_version = "1.8.10"
   s.summary = "Gem makes your ActiveRecord models more SEO friendly. Changes URL to look way better"
 
   if s.respond_to? :specification_version then
@@ -24,15 +24,15 @@ Gem::Specification.new do |s|
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<babosa>, [">= 0"])
       s.add_development_dependency(%q<rspec>, [">= 2.0.0"])
-      s.add_development_dependency(%q<active_record>, [">= 0"])
+      s.add_development_dependency(%q<activerecord>, [">= 0"])
     else
       s.add_dependency(%q<babosa>, [">= 0"])
       s.add_dependency(%q<rspec>, [">= 2.0.0"])
-      s.add_dependency(%q<active_record>, [">= 0"])
+      s.add_dependency(%q<activerecord>, [">= 0"])
     end
   else
     s.add_dependency(%q<babosa>, [">= 0"])
     s.add_dependency(%q<rspec>, [">= 2.0.0"])
-    s.add_dependency(%q<active_record>, [">= 0"])
+    s.add_dependency(%q<activerecord>, [">= 0"])
   end
 end

data/lib/seo_formatter.rb

@@ -39,13 +39,13 @@ module Acts
         if @klass.seo_columns.is_a?(Array)
           seo_parts = @klass.seo_columns.collect do |field|
             el = @instance.send(field)
-            el.to_url if el
+            el.to_s.to_url if el
           end
           seo_parts.delete_if{|el| el.to_s.length == 0}
           @seo_path = seo_parts.join('-')
         else
           el = @instance.send(@klass.seo_columns)
-          @seo_path = el ? el.to_url : ''
+          @seo_path = el ? el.to_s.to_url : ''
         end
         @seo_path
       end
@@ -53,4 +53,4 @@ module Acts
     end
 
   end
-end
+end

data/spec/acts_more_seo_spec.rb

@@ -26,6 +26,10 @@ class HistorableElement < ActiveRecord::Base
       :case_sensitive => true
 end
 
+class IntegerElement < ActiveRecord::Base
+  acts_more_seo :columns => [:name]
+end
+
 describe CoolElement do
   subject { CoolElement }
   before(:each){ subject.destroy_all }
@@ -293,3 +297,14 @@ describe HistorableElement do
 
 end
 
+describe IntegerElement do
+  subject { IntegerElement }
+  before(:each){ subject.destroy_all }
+
+  context "when we have integer field" do
+    it "should cast it to string before saving" do
+      a = subject.create(:name => 1234)
+      a.name.to_s.to_url.should == '1234'
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -41,6 +41,10 @@ ActiveRecord::Schema.define do
       table.string :seo_url
     end
 
+    create_table :integer_elements do |table|
+      table.integer :name
+    end
+
     create_table :historable_elements do |table|
       table.string :name
       table.string :seo_url

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_more_seo
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-17 00:00:00.000000000Z
+date: 2013-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: babosa
-  requirement: &13159460 !ruby/object:Gem::Requirement
+  requirement: &20812460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *13159460
+  version_requirements: *20812460
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &13158660 !ruby/object:Gem::Requirement
+  requirement: &20811840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 2.0.0
   type: :development
   prerelease: false
-  version_requirements: *13158660
+  version_requirements: *20811840
 - !ruby/object:Gem::Dependency
-  name: active_record
-  requirement: &13158100 !ruby/object:Gem::Requirement
+  name: activerecord
+  requirement: &20811140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *13158100
+  version_requirements: *20811140
 description: Gem makes your ActiveRecord models more SEO friendly. Changes URL to
   look way better
 email: maciej@mensfeld.pl
@@ -103,7 +103,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '1.2'
 requirements: []
 rubyforge_project: acts_more_seo
-rubygems_version: 1.8.15
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Gem makes your ActiveRecord models more SEO friendly. Changes URL to look