acts_more_seo 0.2.5 → 0.2.6

data/CHANGELOG.rdoc

@@ -11,4 +11,6 @@
 = Version 0.2.4
 Backward compatibility improvements
 = Version 0.2.5
-* Using ID when to_url returns same string as existing (conflicts)
+* Using ID when to_url returns same string as existing (conflicts)
+= Version 0.2.6
+* find_by_seo and find_by_seo! (with raising not found exception)

data/Rakefile

@@ -3,7 +3,7 @@ require 'rubygems'
 require 'rake'
 require 'echoe'
 
-Echoe.new('acts_more_seo', '0.2.5') do |p|
+Echoe.new('acts_more_seo', '0.2.6') do |p|
   p.description    = "Gem makes your ActiveRecord models more SEO friendly. Changes URL to look way better"
   p.url            = "https://github.com/mensfeld/Css-Image-Embedder"
   p.author         = "Maciej Mensfeld"

data/acts_more_seo.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{acts_more_seo}
-  s.version = "0.2.5"
+  s.version = "0.2.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Maciej Mensfeld}]
-  s.date = %q{2011-11-07}
+  s.date = %q{2011-11-15}
   s.description = %q{Gem makes your ActiveRecord models more SEO friendly. Changes URL to look way better}
   s.email = %q{maciej@mensfeld.pl}
   s.extra_rdoc_files = [%q{CHANGELOG.rdoc}, %q{README.md}, %q{lib/acts_more_seo.rb}, %q{lib/string_ext.rb}]

data/lib/acts_more_seo.rb

@@ -91,13 +91,19 @@ module Acts
           self.column_names.include?("#{:seo_url}")
         end
 
-        def find_by_seo(id)
+        def find_by_seo!(id)
           if self.seo_use_id
             find(id)
           else
-            el = find_by_seo_url id, :first
-            raise ActiveRecord::RecordNotFound unless el
-            el
+            find_by_seo_url! id, :first
+          end
+        end
+
+        def find_by_seo(id)
+          if self.seo_use_id
+            find_by_id(id)
+          else
+            find_by_seo_url id, :first
           end
         end
 

data/spec/acts_more_seo_spec.rb

@@ -29,7 +29,8 @@ describe CoolElement do
       subject.find_by_seo(a.id).should eql(a)
       subject.find_by_seo(a.to_param).should eql(a)
       subject.find_by_seo("#{a.to_param}aaa").should eql(a)
-      lambda { subject.find_by_seo("134534dass") }.should raise_error(ActiveRecord::RecordNotFound)
+      subject.find_by_seo("134534dass").should eql(nil)
+      lambda { subject.find_by_seo!("134534dass") }.should raise_error(ActiveRecord::RecordNotFound)
     end
   end
 
@@ -72,7 +73,7 @@ describe CoolerElement do
 
     it "should raise error when there is no element" do
       a = subject.create
-     lambda { subject.find_by_seo(a.id+1) }.should raise_error(ActiveRecord::RecordNotFound)
+     lambda { subject.find_by_seo!(a.id+1) }.should raise_error(ActiveRecord::RecordNotFound)
     end
   end
 
@@ -80,7 +81,7 @@ describe CoolerElement do
     it "should return nice url" do
       a = subject.create(:title => 'bla bla bla')
       a.to_param.should eql("#{a.id}-bla-bla-bla")
-      subject.find_by_seo(a.to_param).should eql(a)
+      subject.find_by_seo!(a.to_param).should eql(a)
     end
 
     context "and there are some url-not-friendly letters" do
@@ -167,8 +168,8 @@ describe BestElement do
   context "when we have a class which has use_id => false" do
     it "should find element only when seo_url is same (or by id)" do
       a = subject.create(:name => 'bla bla bla')
-      subject.find_by_seo(a.seo_url).should eql(a)
-      lambda { subject.find_by_seo("#{a.to_param}aaa") }.should raise_error(ActiveRecord::RecordNotFound)
+      subject.find_by_seo!(a.seo_url).should eql(a)
+      lambda { subject.find_by_seo!("#{a.to_param}aaa") }.should raise_error(ActiveRecord::RecordNotFound)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_more_seo
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-07 00:00:00.000000000Z
+date: 2011-11-15 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &17432380 !ruby/object:Gem::Requirement
+  requirement: &15894980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 2.0.0
   type: :development
   prerelease: false
-  version_requirements: *17432380
+  version_requirements: *15894980
 - !ruby/object:Gem::Dependency
   name: active_record
-  requirement: &17431920 !ruby/object:Gem::Requirement
+  requirement: &15868480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +32,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *17431920
+  version_requirements: *15868480
 description: Gem makes your ActiveRecord models more SEO friendly. Changes URL to
   look way better
 email: maciej@mensfeld.pl