acts_as_textcaptcha 2.1.3 → 2.1.4

data/README.rdoc

@@ -21,7 +21,7 @@ Here's a {fully working demo on heroku}[http://textcaptcha.heroku.com]!
 What do you need?
 
 * {Rails}[http://github.com/rails/rails] >= 2.3.x  (including Rails 3)
-* {Ruby}[http://ruby-lang.org/] >= 1.8.7                                                                                                                      
+* {Ruby}[http://ruby-lang.org/] >= 1.8.7 (also tested with REE and Ruby 1.9.2)                                                                                                                      
 * {bcrypt-ruby}[http://bcrypt-ruby.rubyforge.org/] gem (to securely encrypt the spam answers in your session)
 * {Text CAPTCHA api key}[http://textcaptcha.com/register] (_optional_, since you can define your own logic questions, see below for details)             
 * {Rspec}[http://rspec.info/] (_optional_ if you want to run the tests)

data/lib/acts_as_textcaptcha/textcaptcha.rb

@@ -45,8 +45,9 @@ module ActsAsTextcaptcha
       # if returning false model.validate will always be false with errors on base
       def allowed?; true end
 
-      def validate_textcaptcha
-        if new_record?
+      def validate_textcaptcha                       
+        # if not new_record? we dont spam check on existing records (ie. no spam check on updates/edits)
+        if !respond_to?('new_record?') || new_record?     
           if allowed?
             if possible_answers && perform_spam_check? && !validate_spam_answer
               errors.add(:spam_answer, 'is incorrect, try another question instead')

data/spec/acts_as_textcaptcha_spec.rb

@@ -23,6 +23,14 @@ end
 class Note < ActiveRecord::Base
   # inline options with user defined questions only (no textcaptcha service)
   acts_as_textcaptcha('questions' => [{'question' => '1+1', 'answers' => '2,two'}])
+end  
+
+class Contact
+  # non active record object         
+  include ActiveModel::Validations
+  include ActiveModel::Conversion
+  extend ActsAsTextcaptcha::Textcaptcha 
+  acts_as_textcaptcha('questions' => [{'question' => '1+1', 'answers' => '2,two'}]) 
 end
 
 
@@ -31,7 +39,8 @@ describe 'ActsAsTextcaptcha' do
   before(:each) do
     @comment = Comment.new
     @review  = Review.new
-    @note    = Note.new
+    @note    = Note.new   
+    @contact = Contact.new 
   end
 
   describe 'validations' do
@@ -40,6 +49,17 @@ describe 'ActsAsTextcaptcha' do
       @note.generate_spam_question
       @note.validate_textcaptcha.should be_false
       @note.should_not be_valid
+    end  
+    
+    it "should validate non ActiveRecord object" do
+      @contact.generate_spam_question
+      @contact.spam_answer = 'wrong'
+      @contact.validate_textcaptcha.should be_false
+      @contact.should_not be_valid
+      
+      @contact.spam_answer = 'two'
+      @contact.validate_textcaptcha.should be_true
+      @contact.should be_valid
     end
 
     it 'should validate spam answer with possible answers' do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: acts_as_textcaptcha
 version: !ruby/object:Gem::Version 
-  hash: 13
+  hash: 3
   prerelease: false
   segments: 
   - 2
   - 1
-  - 3
-  version: 2.1.3
+  - 4
+  version: 2.1.4
 platform: ruby
 authors: 
 - Matthew Hutchinson
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-02 00:00:00 +01:00
+date: 2010-09-17 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency