acts_as_span 0.0.6 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9ed7f152ad93220467d76ca831763a2a4dbd02ba
-  data.tar.gz: eaf693675a0aa764b8d85a77464b9897787993be
+SHA256:
+  metadata.gz: d1b2bd958d53e10e1816b39bbb073c8b9d21b105ab20b7bdd1d0f11048f2adf7
+  data.tar.gz: 9f211ee95efdcbad216591259729983fbf31fc26f6ce91d39fdd03be258d0c0e
 SHA512:
-  metadata.gz: 686a48328384d0e29b0aba18af0d957cc06d0e8ab4fd051d72a33a8515c23115eca337427424f0e920edbf5970abb3605d12b582fa9df37799a0ed911624d8de
-  data.tar.gz: a35877b8ff3c5748a921fb095dd925791e1212246dc0442835a5e3e5c77cbdc30ec659a69d56cc55fbc0e4eee154f53babf7a70a26ee194674a9ad59e4cb0cdb
+  metadata.gz: aa5735e3051308f569cee93a81b13b833c33c1611feaacc0cfc2b985f1938dbaac923676bcd5e0fc75ed91f428651a3b2e10ff2a4ed48981e6191acc60494bd1
+  data.tar.gz: 2fc6f890b396e9829559aa063f6bdd6dfb21b1afc0806a83dc1114acbc736af6ce0cf6dec2c319a259ad1adfdbd52657f81c2adc439b32a3d05c4844f179b7f5

data/.travis.yml

@@ -1,6 +1,8 @@
 language: ruby
 rvm:
-  - 2.2.8
-  - 2.3.5
+  - 2.4.5
+  - 2.5.3
+  - 2.6.1
+before_install: gem install bundler
 notifications:
   email: false

data/acts_as_span.gemspec

@@ -26,10 +26,10 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_development_dependency "bundler", "~> 1.15"
+  s.add_development_dependency "bundler", "~> 2.0.1"
   s.add_development_dependency "rake", "~> 10.0"
   s.add_development_dependency "rspec", "~> 3.0"
-  s.add_development_dependency "sqlite3"
+  s.add_development_dependency "sqlite3", "~> 1.3.6"
   s.add_development_dependency "has_siblings", "~> 0.2.7"
   s.add_development_dependency "temping"
   s.add_development_dependency "pry-byebug"

data/lib/acts_as_span.rb

@@ -13,6 +13,8 @@ require 'active_record'
 module ActsAsSpan
   extend ActiveSupport::Concern
 
+  OPTIONS = %i[start_field end_field name].freeze
+
   class << self
     def options
       @options ||= {
@@ -32,8 +34,17 @@ module ActsAsSpan
       self.send(:extend, ActsAsSpan::ExtendedClassMethods)
       self.send(:include, ActsAsSpan::IncludedInstanceMethods)
 
+      # TODO: There's some refactoring that could be done here using keyword args (or the more standard old hash arg pattern)
       options = OpenStruct.new(args.last.is_a?(Hash) ? ActsAsSpan.options.merge(args.pop) : ActsAsSpan.options)
 
+      unsupported_options =
+        options.to_h.keys.reject { |opt| OPTIONS.include? opt }
+      unless unsupported_options.empty?
+        raise ArgumentError,
+          'Unsupported option(s): ' <<
+          unsupported_options.map { |o| "'#{o}'" }.join(', ')
+      end
+
       acts_as_span_definitions[options.name] = options
 
       # TODO add tests that check delegation of all methos in span

data/lib/acts_as_span/version.rb

@@ -1,8 +1,8 @@
 module ActsAsSpan
   module VERSION
-    MAJOR = 0
+    MAJOR = 1
     MINOR = 0
-    TINY  = 6
+    TINY  = 0
     PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')

data/spec/lib/acts_as_span_spec.rb

@@ -1,6 +1,27 @@
 require 'spec_helper'
 
 RSpec.describe "acts_as_span" do
+  it 'raises an ArgumentError when unsupported arguments are passed' do
+    expect do
+      SpannableModel.acts_as_span(
+        start_field: :starting_date,
+        end_field: :ending_date,
+        span_overlap_scope: [:unique_by_date_range]
+      )
+    end.to raise_error(
+      ArgumentError, "Unsupported option(s): 'span_overlap_scope'"
+    )
+  end
+
+  it "doesn't raise an ArgumentError when valid arguments are passed" do
+    expect do
+      SpannableModel.acts_as_span(
+        start_field: :starting_date,
+        end_field: :ending_date
+      )
+    end.not_to raise_error
+  end
+
   context "ClassMethods" do
     it "should have 1 acts_as_span_definition" do
       expect(SpanModel.acts_as_span_definitions.size).to eq(1)

data/spec/spec_models.rb

@@ -4,6 +4,15 @@ require 'has_siblings'
 ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
 ActiveRecord::Base.logger = Logger.new(STDOUT) if ENV["DEBUG"]
 
+Temping.create :spannable_model do
+  with_columns do |t|
+    t.date :starting_date
+    t.date :ending_date
+
+    t.integer :unique_by_date_range
+  end
+end
+
 Temping.create :span_model do
   with_columns do |t|
     t.date :start_date

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_span
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 1.0.0
 platform: ruby
 authors:
 - Eric Sullivan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-23 00:00:00.000000000 Z
+date: 2019-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: 2.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: 2.0.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -56,16 +56,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
 - !ruby/object:Gem::Dependency
   name: has_siblings
   requirement: !ruby/object:Gem::Requirement
@@ -193,20 +193,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
-summary: acts_as_span 0.0.6
-test_files:
-- spec/lib/acts_as_span_spec.rb
-- spec/lib/delegation_spec.rb
-- spec/lib/no_overlap_validator_spec.rb
-- spec/lib/span_instance/named_scopes_on_spec.rb
-- spec/lib/span_instance/named_scopes_spec.rb
-- spec/lib/span_instance/overlap_spec.rb
-- spec/lib/span_instance/status_spec.rb
-- spec/lib/span_instance/validations_spec.rb
-- spec/lib/span_instance_spec.rb
-- spec/lib/within_parent_date_span_validator_spec.rb
-- spec/spec_helper.rb
-- spec/spec_models.rb
+summary: acts_as_span 1.0.0
+test_files: []