acts_as_shopping_cart 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f4f7ed62db4ed5b247d005dcafc10eb7ebdb3773
-  data.tar.gz: 68c2a98c28d253d7077e1d0b93d1054f9c3c0820
+  metadata.gz: ad7a330566d80daae15b2607ef62db7371fbf587
+  data.tar.gz: 659618258dcadb593cf915635152735229849f57
 SHA512:
-  metadata.gz: 4d841c20dcd7cd9344422fb99b95248dd1f92bb02ab0b8335de1b97f4b4d6b43ba6329332f04d7423d0ec7123ffebb5066a9db547a8f332476ec1fecb00748b0
-  data.tar.gz: 63e9b2b8e4e2df46e1efd4db8afe96933336c51d57ee7136e251a184eff66b438080d9618f72624bbdbc869c83fbc3b922bc5c9399715cfcc6df17f03f3b4979
+  metadata.gz: 32aa00ad9d7adaca7d5a67b2bf449387f97a38ff46d4f7014d1975092310775ce30d8310e08c28825812f9c60874d646099a9d4dff0282a6e4fe59cb7c01018e
+  data.tar.gz: 77f185dcee1546399da192d341eaf84ad141c2f9bdb72dd620e811fd1a33d67d294bd8d6797a04f338cbbe72e42bae5824632e99e2691015309e02279ee58647

data/.rubocop.yml

@@ -1,5 +1,7 @@
+Rails:
+  Enabled: true
+
 AllCops:
-  RunRailsCops: true
   DisplayCopNames: true
   DisplayStyleGuide: true
   StyleGuideCopsOnly: true

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 0.4.1
+
+- Renamed the items? methods to `items?` and `no_items?`
+
 ## 0.4.0
 
 - Updated dependencies to use it on Rails 5

data/README.markdown

@@ -5,6 +5,7 @@ A simple shopping cart implementation.
 [![Build Status](https://secure.travis-ci.org/dabit/acts_as_shopping_cart.png?branch=master)](http://travis-ci.org/dabit/acts_as_shopping_cart)
 [![Code Climate](https://codeclimate.com/github/dabit/acts_as_shopping_cart/badges/gpa.svg)](https://codeclimate.com/github/dabit/acts_as_shopping_cart)
 [![Test Coverage](https://codeclimate.com/github/dabit/acts_as_shopping_cart/badges/coverage.svg)](https://codeclimate.com/github/dabit/acts_as_shopping_cart/coverage)
+[![Gem Version](https://badge.fury.io/rb/acts_as_shopping_cart.svg)](https://badge.fury.io/rb/acts_as_shopping_cart)
 
 You can find an example application [here](https://github.com/dabit/acts_as_shopping_cart_app).
 
@@ -27,7 +28,7 @@ And run bundler
 
 Just include it in your Gemfile as:
 
-    gem 'acts_as_shopping_cart', '~> 0.2.1'
+    gem 'acts_as_shopping_cart', '~> 0.4.0'
 
 And run bundle install
 
@@ -35,7 +36,7 @@ And run bundle install
 
 ## Usage
 
-You need two models, one to hold the Shopping Carts and another to hold the Items
+You need two models, one to hold the `Shopping Carts` and another to hold the `Items`
 
 You can use any name for the models, you just have to let each model know about each other.
 
@@ -54,8 +55,8 @@ For the items:
       acts_as_shopping_cart_item_for :cart
     end
 
-or, if you want to use convention over configuration, make sure your models are called *ShoppingCart* and *ShoppingCartItem*,
-then just use the shortcuts:
+or, if you want to use convention over configuration, make sure your models are
+named `ShoppingCart` and `ShoppingCartItem`, then just use the shortcuts:
 
     class ShoppingCart < ActiveRecord::Base
       acts_as_shopping_cart
@@ -75,14 +76,15 @@ In order for this to work, the Shopping Cart Item model should have the followin
 
 ### Shopping Cart Items
 
-Your ShoppingCart class will have a _shopping_cart_items_ association
-that returns all the ShoppingCartItem objects in your cart.
+Your `ShoppingCart` class will have a `shopping_cart_items` association
+that returns all the `ShoppingCartItem` objects in your cart.
 
 ### Add Items
 
-To add an item to the cart you use the add method. You have to send the object and the price of the object as parameters.
+To add an item to the cart you use the add method. You have to send the object
+and the price of the object as parameters.
 
-So, if you had a Product class, you would do something like this:
+So, if you had a `Product` class, you would do something like this:
 
     @cart = Cart.create
     @product = Product.find(1)
@@ -93,38 +95,41 @@ In the case where your product has a price field you could do something like:
 
     @cart.add(@product, @product.price)
 
-I tried to make it independent to the models in case you calculate discounts, sale prices or anything customized.
+I tried to make it independent to the models in case you calculate discounts,
+sale prices or anything customized.
 
 You can include a quantity parameter too.
 
     @cart.add(@product, 99.99, 5)
 
-In that case, you would add 5 of the same products to the shopping cart. If you don't specify the quantity 1 will be assumed.
+In that case, you would add 5 of the same products to the shopping cart. If you
+don't specify the quantity `1` will be assumed.
 
 ### Remove Items
 
-To remove an item from the cart you can use the remove method. You just have to send the object and the quantity you want to remove.
+To remove an item from the cart you can use the remove method. You just have to
+send the object and the quantity you want to remove.
 
     @cart.remove(@product, 1)
 
 ### Empty the cart
 
-To remove all the items in the cart at once, just use the _clear_ method
+To remove all the items in the cart at once, just use the `clear` method
 
     @cart.clear
 
 ### Total
 
-You can find out about the total using the _total_ method:
+You can find out about the total using the `total` method:
 
     @cart.total # => 99.99
 
 ### Taxes
 
-Taxes by default are calculated by multiplying subtotal times 8.25
+Taxes by default are calculated by multiplying subtotal times `8.25`
 
-If you want to change the way taxes are calculated, override the taxes
-method on your class that acts_as_shopping_cart.
+If you want to change the way taxes are calculated, override the `taxes`
+method on your class that `acts_as_shopping_cart`.
 
 Example:
 
@@ -136,7 +141,7 @@ Example:
       end
     end
 
-If you just want to update the percentage, just override the tax_pct
+If you just want to update the `percentage`, override the `tax_pct`
 method.
 
     class ShoppingCart < ActiveRecord::Base
@@ -163,9 +168,9 @@ class depending on your needs.
 
 ### Total unique items
 
-You can find out how many unique items you have on your cart using the _total_unique_items_ method.
+You can find out how many unique items you have on your cart using the `total_unique_items` method.
 
-So, if you had something like:
+So, if you have something like:
 
     @cart.add(@product, 99.99, 5)
 

data/lib/active_record/acts/shopping_cart/collection.rb

@@ -28,16 +28,18 @@ module ActiveRecord
         #
         # Returns true when the cart has items
         #
-        def has_items?
+        def items?
           shopping_cart_items.any?
         end
+        alias :has_items? :items?
 
         #
         # Returns true when the cart is empty
         #
-        def has_no_items?
+        def no_items?
           shopping_cart_items.empty?
         end
+        alias :has_no_items? :no_items?
 
 
         #

data/lib/acts_as_shopping_cart/version.rb

@@ -1,3 +1,3 @@
 module ActsAsShoppingCart
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

data/spec/active_record/acts/shopping_cart/collection_spec.rb

@@ -77,42 +77,42 @@ describe ActiveRecord::Acts::ShoppingCart::Collection do
 
     it "clears all the items in the cart" do
       subject.clear
-      expect(subject.has_no_items?).to be true
+      expect(subject.no_items?).to be true
     end
   end
 
-  describe "has_items?" do
+  describe "items?" do
     context "cart has items" do
       before do
         subject.shopping_cart_items << double
       end
 
       it "returns true" do
-        expect(subject.has_items?).to be true
+        expect(subject.items?).to be true
       end
     end
 
     context "cart is empty" do
       it "returns false" do
-        expect(subject.has_items?).to be false
+        expect(subject.items?).to be false
       end
     end
   end
 
-  describe "has_no_items?" do
+  describe "no_items?" do
     context "cart has items" do
       before do
         subject.shopping_cart_items << double
       end
 
       it "returns false" do
-        expect(subject.has_no_items?).to be false
+        expect(subject.no_items?).to be false
       end
     end
 
     context "cart is empty" do
       it "returns true" do
-        expect(subject.has_no_items?).to be true
+        expect(subject.no_items?).to be true
       end
     end
   end
@@ -170,7 +170,7 @@ describe ActiveRecord::Acts::ShoppingCart::Collection do
 
       it "returns the sum of the price * quantity for all items" do
         expect(subject.subtotal).to be_an_instance_of(Money)
-        expect(subject.subtotal).to eq(Money.new(11397))
+        expect(subject.subtotal).to eq(Money.new(11_397))
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_shopping_cart
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - David Padilla
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-25 00:00:00.000000000 Z
+date: 2016-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails