acts_as_shellscript_executable 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 190be56029b641566b7aad1e32156a01f482df48
-  data.tar.gz: a81c819d7d98661b72fde5ba7b39963506eabd5d
+  metadata.gz: 030e8454c0d6d951be268f756c079181261df705
+  data.tar.gz: 199e6144126b46ee7cab835d06eee8c4c9798835
 SHA512:
-  metadata.gz: 8acbe54b17e19cabb50f8aacac224bbc66cc69e70b428d090f8db334bcc3a7a8a154180a6bf480b30ee4174f557ee96ecc22891e44d14bb2cf603ced3373bd45
-  data.tar.gz: 5b0554b894a5467f6a9a3c038b61e9c7dc4a07395d61c538a097786c0486a733b7ff4405c83899990c32a854e7f9c39ddbdd3c357f847e0e87d15d5afe0fd2ef
+  metadata.gz: 12f82a5a9c37ba137bfa7cf2a8c33860fd634a4345fa2e748e21ede214a20ce4930ef69ef34414986166f6c41089e84298261305280074bc52526c17cbd2222d
+  data.tar.gz: 04fa8af167cbbbb104eb7ba321a2f91ec4afad6effa9d7eced3d4e8b2a92bad4f97e0b656ea15817e30d39e80fd431fc8d13f61d9f7d53d6826955574f7b2c57

data/README.md

@@ -33,7 +33,7 @@ script.save!
 
 ## #execute!
 
-* `#execute!(nil)`
+* `#execute!(no args)`
     * returns scripts stdout of whole of the shellscript
 
 * `#execute!(block)`
@@ -45,9 +45,6 @@ script.save!
     * if `Symbol`, the same name column's value will be evaluated as shellscript
     * if `String`, the string will be evaluated as shellscript
 
-* `parallel:` (default: `false`)
-    * if true, the script will run in parallel by using `thread`
-
 * `method:` (default: `execute!`)
     * the execute method's name
 

data/lib/acts_as_shellscript_executable/active_record/acts/shellscript_executable.rb

@@ -1,5 +1,3 @@
-require 'thread'
-
 module ActiveRecord
   module Acts
     module ShellscriptExecutable
@@ -16,15 +14,8 @@ module ActiveRecord
             def #{configuration[:method]}(&block)
               script = @@__configuration__[:script]
               answer = ''
-              if @@__configuration__[:parallel]
-                Thread.new do
-                  __execute__(script, answer, block)
-                end
-                block_given? ? nil : answer
-              else
-                __execute__(script, answer, block)
-                block_given? ? nil : answer
-              end
+              __execute__(script, answer, block)
+              block_given? ? nil : answer
             end
           EOV
 

data/lib/acts_as_shellscript_executable/version.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module Acts
     module ShellscriptExecutable
-      VERSION = '0.0.1'
+      VERSION = '0.0.2'
     end
   end
 end

data/spec/features/acts_as_shellscript_executable_spec.rb

@@ -38,40 +38,6 @@ describe ActiveRecord::Base do
       end
     end
 
-    describe 'given option parallel' do
-      context 'given option {script: :script, parallel: false}' do
-        before do
-          class Script < ActiveRecord::Base
-            acts_as_shellscript_executable script: :script, parallel: false
-          end
-        end
-
-        it do
-          script = Script.create
-          script.script = 'echo $PPID'
-          expect(script.execute!).to eq "#{Process.pid}\n"
-        end
-      end
-
-      context 'given option {script: :script, parallel: true}' do
-        before do
-          class Script < ActiveRecord::Base
-            acts_as_shellscript_executable script: :script, parallel: true
-          end
-        end
-
-        it do
-          script = Script.create
-          script.script = "sleep 1\necho $PPID"
-          result = script.execute!
-
-          expect(result).to eq('')
-          sleep 1.5
-          expect(result).to eq("#{Process.pid}\n")
-        end
-      end
-    end
-
     context 'given option { script: :script2 }' do
       before do
         class Script < ActiveRecord::Base
@@ -116,31 +82,6 @@ describe ActiveRecord::Base do
       end
     end
 
-    context 'given option {script: "echo 1\nsleep 1\necho 2" parallel: true}' do
-      before do
-        class Script < ActiveRecord::Base
-          acts_as_shellscript_executable \
-            script: "echo 1\nsleep 1\necho 2", parallel: true
-        end
-      end
-
-      describe 'block given' do
-        it do
-          script = Script.create
-          watcher = []
-
-          retval = script.execute! do |each_line_result|
-            watcher << each_line_result
-          end
-
-          sleep 2
-
-          expect(retval).to be_nil
-          expect(watcher).to eq ["1\n", '', "2\n"]
-        end
-      end
-    end
-
     context 'given option {script: "echo 1\necho 2"}' do
       before do
         class Script < ActiveRecord::Base
@@ -163,30 +104,5 @@ describe ActiveRecord::Base do
         end
       end
     end
-
-    context 'given option {method: :awesome!}' do
-      before do
-        class Script < ActiveRecord::Base
-          acts_as_shellscript_executable \
-            method: :awesome!, script: "echo 1\nsleep 1\necho 2", parallel: true
-        end
-      end
-
-      describe 'block given' do
-        it do
-          script = Script.create
-          watcher = []
-
-          retval = script.awesome! do |each_line_result|
-            watcher << each_line_result
-          end
-
-          sleep 2
-
-          expect(retval).to be_nil
-          expect(watcher).to eq ["1\n", '', "2\n"]
-        end
-      end
-    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_shellscript_executable
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - hoshinotsuyoshi