acts_as_priceable 0.2.0 → 0.2.1

data/README.md

@@ -105,8 +105,16 @@ class Product < ActiveRecord::Base
 end
 ```
 
+From version 0.2.1 you can use serialized fields to store your price information. Gem supports serialization to Hash and Hstore
 
+```ruby
+class Product
+  serialize :data, Hash
+
+  has_price :price, serialized: :data
 
+end
+```
 
 ## Contributing
 

data/acts_as_priceable.gemspec

@@ -17,5 +17,6 @@ Gem::Specification.new do |gem|
   gem.add_dependency "activerecord", ">= 3.0.0"
   gem.add_development_dependency 'rspec', "~> 2.10.0"
   gem.add_development_dependency 'rake'
-  gem.add_development_dependency 'sqlite3'
+  gem.add_development_dependency 'pg'
+  gem.add_development_dependency 'activerecord-postgres-hstore'
 end

data/lib/acts_as_priceable/base.rb

@@ -14,11 +14,12 @@ module ActsAsPriceable
       def has_price(name = :price, options = {})
         scale = options[:scale] || 2
         without_validations = options[:without_validations] || false
+        serialized = options[:serialized]
 
         ActsAsPriceable::Schema::COLUMNS.each do |column_name, column_type|
           raise AttributeError, "#{name}_#{column_name} is not defined" if columns_hash["#{name}_#{column_name}"].nil?
           raise AttributeError, "#{name}_#{column_name} has wrong column type (is #{columns_hash["#{name}_#{column_name}"].type}) should be #{column_type}" if columns_hash["#{name}_#{column_name}"].type != column_type
-        end
+        end if serialized.nil?
 
         gross = "#{name}_gross"
         net = "#{name}_net"
@@ -26,20 +27,44 @@ module ActsAsPriceable
         tax = "#{name}_tax"
         mode = "#{name}_mode"
 
+        send :define_method, "get_#{name}_attribute" do |attribute|
+          if serialized.nil?
+            self[attribute.to_sym].to_i
+          else
+            self.send(serialized)[attribute.to_s].to_i
+          end
+        end
+
+        send :define_method, "set_#{name}_attribute" do |attribute, value|
+          if serialized.nil?
+            self[attribute.to_sym] = value
+          else
+            self.send(serialized)[attribute.to_s] = value
+          end
+        end
+
         send :define_method, gross do
-          BigDecimal.new(self[gross.to_sym].to_i) / BigDecimal.new(10**scale.to_i)
+          BigDecimal.new(self.send("get_#{name}_attribute", gross)) / BigDecimal.new(10**scale.to_i)
         end
 
         send :define_method, "#{gross}=" do |value|
-          self[gross.to_sym] = (value.to_s.gsub(',', '.').to_d * (10**scale)).to_i
+          self.send "set_#{name}_attribute", gross, (value.to_s.gsub(',', '.').to_d * (10**scale)).to_i
         end
 
         send :define_method, net do
-          BigDecimal.new(self[net.to_sym].to_i) / BigDecimal.new(10**scale.to_i)
+          BigDecimal.new(self.send("get_#{name}_attribute", net)) / BigDecimal.new(10**scale.to_i)
         end
 
         send :define_method, "#{net}=" do |value|
-          self[net.to_sym] = (value.to_s.gsub(',', '.').to_d * (10**scale)).to_i
+          self.send("set_#{name}_attribute", net, (value.to_s.gsub(',', '.').to_d * (10**scale)).to_i)
+        end
+
+        send :define_method, tax do
+          self.send "get_#{name}_attribute", tax
+        end
+
+        send :define_method, "#{tax}=" do |value|
+          self.send "set_#{name}_attribute", tax, value
         end
 
         send :define_method, tax_value do

data/lib/acts_as_priceable/version.rb

@@ -1,3 +1,3 @@
 module ActsAsPriceable
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/base_spec.rb

@@ -27,7 +27,7 @@ describe Dummy do
         @dummy.should respond_to(:price=)
       end
 
-      it 'should have mode attr_accessor' do
+      it 'should have price_mode attr_accessor' do
         @dummy.should respond_to(:price_mode)
         @dummy.should respond_to(:price_mode=)
       end
@@ -42,7 +42,7 @@ describe Dummy do
 
       it 'price_net should be converted to integer' do
         @dummy.price_net = @test_value
-        @dummy[:price_net].should be(1020)
+        @dummy.get_price_attribute(:price_net).should be(1020)
       end
 
       it 'price_net should return correct value' do
@@ -52,7 +52,7 @@ describe Dummy do
 
       it 'price_gross should be converted to integer' do
         @dummy.price_gross = @test_value
-        @dummy[:price_gross].should be(1020)
+        @dummy.get_price_attribute(:price_gross).should be(1020)
       end
 
       it 'price_gross should return correct value' do
@@ -115,4 +115,229 @@ describe Dummy do
     end
   end
 
+end
+
+describe DummySerialize do
+
+  describe 'class methods' do
+    it 'should have has_price method' do
+      DummySerialize.should respond_to(:has_price)
+    end
+  end
+
+  describe 'instance' do
+
+    describe 'hstore' do
+
+      before(:all) do
+        DummySerialize.send :has_price, :price, serialized: :hstore_data
+        @test_value = '10.20'
+      end
+
+      describe 'methods' do
+
+        before(:each) do
+          @dummy = DummySerialize.new
+        end
+
+        it 'should have price attr_accessor' do
+          @dummy.should respond_to(:price)
+          @dummy.should respond_to(:price=)
+        end
+
+        it 'should have price_mode attr_accessor' do
+          @dummy.should respond_to(:price_mode)
+          @dummy.should respond_to(:price_mode=)
+        end
+
+        it 'should have price_tax_value method' do
+          @dummy.should respond_to(:price_tax_value)
+        end
+
+        it 'should have update_price method' do
+          @dummy.should respond_to(:update_price)
+        end
+
+        it 'price_net should be converted to integer' do
+          @dummy.price_net = @test_value
+          @dummy.get_price_attribute(:price_net).should be(1020)
+        end
+
+        it 'price_net should return correct value' do
+          @dummy.price_net = @test_value
+          @dummy.price_net.should == BigDecimal.new(@test_value)
+        end
+
+        it 'price_gross should be converted to integer' do
+          @dummy.price_gross = @test_value
+          @dummy.get_price_attribute(:price_gross).should be(1020)
+        end
+
+        it 'price_gross should return correct value' do
+          @dummy.price_gross = @test_value
+          @dummy.price_gross.should == BigDecimal.new(@test_value)
+        end
+
+        it 'calculates price gross from price_net' do
+          @dummy.price = '10.00'
+          @dummy.price_tax = 23
+          @dummy.price_mode = 'net'
+          @dummy.update_price
+          @dummy.price_net.should == BigDecimal.new('10.00')
+          @dummy.price_gross.should == BigDecimal.new('12.30')
+        end
+
+        it 'calculates price net from price gross' do
+          @dummy.price = '12.30'
+          @dummy.price_tax = 23
+          @dummy.price_mode = 'gross'
+          @dummy.update_price
+          @dummy.price_net.should == BigDecimal.new('10.00')
+          @dummy.price_gross.should == BigDecimal.new('12.30')
+        end
+
+        it 'calculates tax value properly' do
+          @dummy.price = '10.00'
+          @dummy.price_tax = 23
+          @dummy.price_mode = 'net'
+          @dummy.update_price
+          @dummy.price_tax_value.should == BigDecimal.new('2.30')
+        end
+
+      end
+
+      describe 'validations' do
+
+        before(:each) do
+          @dummy = DummySerialize.new price_net: '10.00', price_gross: '12.30', price_tax: 23
+        end
+
+        it 'correct should be valid' do
+          @dummy.valid?.should be(true)
+        end
+
+        it "price_net can't be negative" do
+          @dummy.price_net = -1
+          @dummy.valid?.should be(false)
+        end
+
+        it "price_gross can't be negative" do
+          @dummy.price_gross = -1
+          @dummy.valid?.should be(false)
+        end
+
+        it "price_tax can't be negative" do
+          @dummy.price_tax = -1
+          @dummy.valid?.should be(false)
+        end
+      end
+    end
+
+    describe 'hash' do
+
+      before(:all) do
+        DummySerialize.send :has_price, :price, serialized: :hash_data
+        @test_value = '10.20'
+      end
+
+      describe 'methods' do
+
+        before(:each) do
+          @dummy = DummySerialize.new
+        end
+
+        it 'should have price attr_accessor' do
+          @dummy.should respond_to(:price)
+          @dummy.should respond_to(:price=)
+        end
+
+        it 'should have price_mode attr_accessor' do
+          @dummy.should respond_to(:price_mode)
+          @dummy.should respond_to(:price_mode=)
+        end
+
+        it 'should have price_tax_value method' do
+          @dummy.should respond_to(:price_tax_value)
+        end
+
+        it 'should have update_price method' do
+          @dummy.should respond_to(:update_price)
+        end
+
+        it 'price_net should be converted to integer' do
+          @dummy.price_net = @test_value
+          @dummy.get_price_attribute(:price_net).should be(1020)
+        end
+
+        it 'price_net should return correct value' do
+          @dummy.price_net = @test_value
+          @dummy.price_net.should == BigDecimal.new(@test_value)
+        end
+
+        it 'price_gross should be converted to integer' do
+          @dummy.price_gross = @test_value
+          @dummy.get_price_attribute(:price_gross).should be(1020)
+        end
+
+        it 'price_gross should return correct value' do
+          @dummy.price_gross = @test_value
+          @dummy.price_gross.should == BigDecimal.new(@test_value)
+        end
+
+        it 'calculates price gross from price_net' do
+          @dummy.price = '10.00'
+          @dummy.price_tax = 23
+          @dummy.price_mode = 'net'
+          @dummy.update_price
+          @dummy.price_net.should == BigDecimal.new('10.00')
+          @dummy.price_gross.should == BigDecimal.new('12.30')
+        end
+
+        it 'calculates price net from price gross' do
+          @dummy.price = '12.30'
+          @dummy.price_tax = 23
+          @dummy.price_mode = 'gross'
+          @dummy.update_price
+          @dummy.price_net.should == BigDecimal.new('10.00')
+          @dummy.price_gross.should == BigDecimal.new('12.30')
+        end
+
+        it 'calculates tax value properly' do
+          @dummy.price = '10.00'
+          @dummy.price_tax = 23
+          @dummy.price_mode = 'net'
+          @dummy.update_price
+          @dummy.price_tax_value.should == BigDecimal.new('2.30')
+        end
+
+      end
+
+      describe 'validations' do
+
+        before(:each) do
+          @dummy = DummySerialize.new price_net: '10.00', price_gross: '12.30', price_tax: 23
+        end
+
+        it 'correct should be valid' do
+          @dummy.valid?.should be(true)
+        end
+
+        it "price_net can't be negative" do
+          @dummy.price_net = -1
+          @dummy.valid?.should be(false)
+        end
+
+        it "price_gross can't be negative" do
+          @dummy.price_gross = -1
+          @dummy.valid?.should be(false)
+        end
+
+        it "price_tax can't be negative" do
+          @dummy.price_tax = -1
+          @dummy.valid?.should be(false)
+        end
+      end
+    end
+  end
+
 end

data/spec/database.yml

@@ -1,3 +1,8 @@
 test:
-  adapter: sqlite3
-  database: ":memory:"
+  adapter: postgresql
+  database: acts_as_priceable_test
+  username: ruby
+  password: ruby
+  port: 5432
+  host: localhost
+  min_messages: warning

data/spec/models/dummy_serialize.rb

@@ -0,0 +1,6 @@
+class DummySerialize < ActiveRecord::Base
+
+  serialize :hash_data, Hash
+  serialize :hstore_data, ActiveRecord::Coders::Hstore
+
+end

data/spec/spec_helper.rb

@@ -4,17 +4,27 @@ require 'yaml'
 
 
 def create_tables
+  #ActiveRecord::Base.connection.execute "CREATE EXTENSION hstore;"
+
   ActiveRecord::Base.connection.create_table :dummies, force: true do |table|
     table.column :price_gross, :integer
     table.column :price_net, :integer
     table.column :price_tax, :integer
   end
+
+  ActiveRecord::Base.connection.create_table :dummy_serializes, force: true do |table|
+    table.column :hstore_data, :hstore
+    table.column :hash_data, :text
+  end
 end
 
 RSpec.configure do |config|
   ActiveRecord::Base.establish_connection YAML.load_file("#{File.dirname __FILE__}/database.yml")['test']
   create_tables
+  #require 'active_support'
+  require 'activerecord-postgres-hstore'
   require 'models/dummy'
+  require 'models/dummy_serialize'
   config.color_enabled = true
   #config.formatter = 'documentation'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_priceable
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-04 00:00:00.000000000 Z
+date: 2013-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -60,7 +60,23 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: pg
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activerecord-postgres-hstore
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
@@ -95,6 +111,7 @@ files:
 - spec/base_spec.rb
 - spec/database.yml
 - spec/models/dummy.rb
+- spec/models/dummy_serialize.rb
 - spec/schema_spec.rb
 - spec/spec_helper.rb
 homepage: ''
@@ -111,7 +128,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 415468810773993444
+      hash: -81614923785070028
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -120,7 +137,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 415468810773993444
+      hash: -81614923785070028
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25
@@ -131,5 +148,6 @@ test_files:
 - spec/base_spec.rb
 - spec/database.yml
 - spec/models/dummy.rb
+- spec/models/dummy_serialize.rb
 - spec/schema_spec.rb
 - spec/spec_helper.rb