acts_as_paranoid 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 73cbdef60cb81f9506a3763c13b0380f83169b8c68f0b914305d828b90202d25
-  data.tar.gz: 2023f4db3125ff3db3dd9dc7b0fb0142e92d6f8f54bc433557d5dd0dc40fb853
+  metadata.gz: 2a0dd97ab43e1d7a8a72327a1abf5df84ae9d3ff36c38caed38a808aacef6b01
+  data.tar.gz: a628f74884aff858620127b163b1998b5d790a0cfcbff4ad56e9851f962a3caf
 SHA512:
-  metadata.gz: 1c7b2ff7d8655621915c11630012ff946a196b46fd0a175facad75d90aa4f6ecae1ae6df1e627f9cf778faa46d26fb559b275e62101a4ba402007d545014f43d
-  data.tar.gz: ec47e5232127609e3e83b9bf22b142a821e955b55a77e082f21ceaeb5e62c390253fee6815cfc3a4a795257eb68c15f29eb5adbad8e511703718e4278d84e52c
+  metadata.gz: 1488e86f1437d179e8aef1bc8b2e6da851a29d44ef9a93d7d2a60685bae36da50d69ec74bb19f6c4751257ddce5af556994c1d38beaef037b5753c063fdf409a
+  data.tar.gz: 630cec48256d5baf5e859f138fcc74b0a3718f6283ee08d47b36fa96cca9feba16bd6a2e1e4a3eeb3ecc210238d5ac8eb4ea31374ca8b0cfa07b57bdb9392368

data/CHANGELOG.md

@@ -2,6 +2,27 @@
 
 Notable changes to this project will be documented in this file.
 
+## 0.7.3
+
+## Improvements
+
+* Fix deletion time scopes ([#212] by [Matijs van Zuijlen][mvz])
+* Reload `has_one` associations after dependent recovery ([#214],
+  by [Matijs van Zuijlen][mvz])
+* Make dependent recovery work when parent is non-optional ([#227],
+  by [Matijs van Zuijlen][mvz])
+* Avoid querying nil `belongs_to` associations when recovering ([#219],
+  by [Matijs van Zuijlen][mvz])
+* On relations, deprecate `destroy!` in favour of `destroy_fully!` ([#222],
+  by [Matijs van Zuijlen][mvz])
+* Deprecate the undocumented `:recovery_value` setting. Calculate the correct
+  value instead. ([#220], by [Matijs van Zuijlen][mvz])
+
+## Developer experience
+
+* Log ActiveRecord activity to a visible log during tests ([#218],
+  by [Matijs van Zuijlen][mvz])
+
 ## 0.7.2
 
 * Do not set boolean column to NULL on recovery if nulls are not allowed
@@ -100,6 +121,13 @@ Notable changes to this project will be documented in this file.
 
 <!-- issues & pull requests -->
 
+[#227]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/227
+[#222]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/222
+[#220]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/220
+[#219]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/219
+[#218]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/218
+[#214]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/214
+[#212]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/212
 [#209]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/209
 [#208]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/208
 [#207]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/207

data/lib/acts_as_paranoid.rb

@@ -27,15 +27,10 @@ module ActsAsParanoid
       column_type: "time",
       recover_dependent_associations: true,
       dependent_recovery_window: 2.minutes,
-      recovery_value: nil,
       double_tap_destroys_fully: true
     }
     if options[:column_type] == "string"
       paranoid_configuration.merge!(deleted_value: "deleted")
-    elsif options[:column_type] == "boolean" && !options[:allow_nulls]
-      paranoid_configuration.merge!(recovery_value: false)
-    elsif options[:column_type] == "boolean"
-      paranoid_configuration.merge!(allow_nulls: true)
     end
 
     paranoid_configuration.merge!(options) # user options

data/lib/acts_as_paranoid/core.rb

@@ -88,6 +88,19 @@ module ActsAsParanoid
         end
       end
 
+      def recovery_value
+        if paranoid_configuration.key? :recovery_value
+          ActiveSupport::Deprecation.warn \
+            "The recovery_value setting is deprecated and will be removed in" \
+            " ActsAsParanoid 0.8.0"
+          paranoid_configuration[:recovery_value]
+        elsif boolean_type_not_nullable?
+          false
+        else
+          nil
+        end
+      end
+
       protected
 
       def define_deleted_time_scopes
@@ -96,10 +109,12 @@ module ActsAsParanoid
         }
 
         scope :deleted_after_time, lambda { |time|
-          where("#{table_name}.#{paranoid_column} > ?", time)
+          only_deleted
+            .where("#{table_name}.#{paranoid_column} > ?", time)
         }
         scope :deleted_before_time, lambda { |time|
-          where("#{table_name}.#{paranoid_column} < ?", time)
+          only_deleted
+            .where("#{table_name}.#{paranoid_column} < ?", time)
         }
       end
 
@@ -185,16 +200,16 @@ module ActsAsParanoid
 
       self.class.transaction do
         run_callbacks :recover do
-          if options[:recursive]
-            recover_dependent_associations(options[:recovery_window], options)
-          end
           increment_counters_on_associations
-          self.paranoid_value = self.class.paranoid_configuration[:recovery_value]
-          if options[:raise_error]
-            save!
-          else
-            save
-          end
+          deleted_value = paranoid_value
+          self.paranoid_value = self.class.recovery_value
+          result = if options[:raise_error]
+                     save!
+                   else
+                     save
+                   end
+          recover_dependent_associations(deleted_value, options) if options[:recursive]
+          result
         end
       end
     end
@@ -205,30 +220,19 @@ module ActsAsParanoid
       recover(options)
     end
 
-    def recover_dependent_associations(window, options)
+    def recover_dependent_associations(deleted_value, options)
       self.class.dependent_associations.each do |reflection|
-        next unless (klass = get_reflection_class(reflection)).paranoid?
-
-        scope = klass.only_deleted.merge(get_association_scope(reflection: reflection))
-
-        # We can only recover by window if both parent and dependant have a
-        # paranoid column type of :time.
-        if self.class.paranoid_column_type == :time && klass.paranoid_column_type == :time
-          scope = scope.deleted_inside_time_window(paranoid_value, window)
-        end
-
-        scope.each do |object|
-          object.recover(options)
-        end
+        recover_dependent_association(reflection, deleted_value, options)
       end
     end
 
     def destroy_dependent_associations!
       self.class.dependent_associations.each do |reflection|
-        next unless (klass = get_reflection_class(reflection)).paranoid?
+        assoc = association(reflection.name)
+        next unless (klass = assoc.klass).paranoid?
 
         klass
-          .only_deleted.merge(get_association_scope(reflection: reflection))
+          .only_deleted.merge(get_association_scope(assoc))
           .each(&:destroy!)
       end
     end
@@ -255,16 +259,33 @@ module ActsAsParanoid
 
     private
 
-    def get_association_scope(reflection:)
-      ActiveRecord::Associations::AssociationScope.scope(association(reflection.name))
-    end
+    def recover_dependent_association(reflection, deleted_value, options)
+      assoc = association(reflection.name)
+      return unless (klass = assoc.klass).paranoid?
 
-    def get_reflection_class(reflection)
-      if reflection.macro == :belongs_to && reflection.options.include?(:polymorphic)
-        send(reflection.foreign_type).constantize
-      else
-        reflection.klass
+      if reflection.belongs_to? && attributes[reflection.association_foreign_key].nil?
+        return
+      end
+
+      scope = klass.only_deleted.merge(get_association_scope(assoc))
+
+      # We can only recover by window if both parent and dependant have a
+      # paranoid column type of :time.
+      if self.class.paranoid_column_type == :time && klass.paranoid_column_type == :time
+        scope = scope.deleted_inside_time_window(deleted_value, options[:recovery_window])
       end
+
+      recovered = false
+      scope.each do |object|
+        object.recover(options)
+        recovered = true
+      end
+
+      assoc.reload if recovered && reflection.has_one? && assoc.loaded?
+    end
+
+    def get_association_scope(dependent_association)
+      ActiveRecord::Associations::AssociationScope.scope(dependent_association)
     end
 
     def paranoid_value=(value)

data/lib/acts_as_paranoid/relation.rb

@@ -30,6 +30,13 @@ module ActsAsParanoid
         end
 
         def destroy!(id_or_array)
+          destroy_fully! id_or_array
+        end
+
+        deprecate :destroy!,
+                  deprecator: ActiveSupport::Deprecation.new("0.8.0", "ActsAsParanoid")
+
+        def destroy_fully!(id_or_array)
           where(primary_key => id_or_array).orig_delete_all
         end
       end

data/lib/acts_as_paranoid/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActsAsParanoid
-  VERSION = "0.7.2"
+  VERSION = "0.7.3"
 end

data/test/test_associations.rb

@@ -346,13 +346,9 @@ class AssociationsTest < ParanoidBaseTest
     assert_not_nil not_paranoid.paranoid_time
   end
 
-  def test_mass_assignment_of_paranoid_column_enabled
-    if Gem.loaded_specs["activerecord"].version >= Gem::Version.new("5.2.0")
-      skip "Creation as deleted is not supported with Rails >= 5.2"
+  def test_mass_assignment_of_paranoid_column_disabled
+    assert_raises ActiveRecord::RecordNotSaved do
+      ParanoidTime.create! name: "Foo", deleted_at: Time.now
     end
-    now = Time.now
-    record = ParanoidTime.create! name: "Foo", deleted_at: now
-    assert_equal "Foo", record.name
-    assert_equal now, record.deleted_at
   end
 end

data/test/test_core.rb

@@ -112,6 +112,34 @@ class ParanoidTest < ParanoidBaseTest
     end
   end
 
+  def test_recover_has_one_association
+    parent = ParanoidBoolean.create(name: "parent")
+    child = parent.create_paranoid_has_one_dependant(name: "child")
+
+    parent.destroy
+    assert parent.paranoid_has_one_dependant.destroyed?
+
+    parent.recover
+    refute parent.paranoid_has_one_dependant.destroyed?
+
+    child.reload
+    refute child.destroyed?
+  end
+
+  def test_recover_has_many_association
+    parent = ParanoidTime.create(name: "parent")
+    child = parent.paranoid_has_many_dependants.create(name: "child")
+
+    parent.destroy
+    assert child.destroyed?
+
+    parent.recover
+    assert_equal 1, parent.paranoid_has_many_dependants.count
+
+    child.reload
+    refute child.destroyed?
+  end
+
   # Rails does not allow saving deleted records
   def test_no_save_after_destroy
     paranoid = ParanoidString.first
@@ -124,6 +152,13 @@ class ParanoidTest < ParanoidBaseTest
     end
   end
 
+  def test_scope_chaining
+    assert_equal 3, ParanoidBoolean.unscoped.with_deleted.count
+    assert_equal 0, ParanoidBoolean.unscoped.only_deleted.count
+    assert_equal 0, ParanoidBoolean.with_deleted.only_deleted.count
+    assert_equal 3, ParanoidBoolean.with_deleted.with_deleted.count
+  end
+
   def setup_recursive_tests
     @paranoid_time_object = ParanoidTime.first
 
@@ -676,4 +711,26 @@ class ParanoidTest < ParanoidBaseTest
     assert_equal "explicit_table.deleted_at", ParanoidWithExplicitTableNameAfterMacro
       .paranoid_column_reference
   end
+
+  def test_deleted_after_time
+    ParanoidTime.first.destroy
+    assert_equal 0, ParanoidTime.deleted_after_time(1.hour.from_now).count
+    assert_equal 1, ParanoidTime.deleted_after_time(1.hour.ago).count
+  end
+
+  def test_deleted_before_time
+    ParanoidTime.first.destroy
+    assert_equal 1, ParanoidTime.deleted_before_time(1.hour.from_now).count
+    assert_equal 0, ParanoidTime.deleted_before_time(1.hour.ago).count
+  end
+
+  def test_deleted_inside_time_window
+    ParanoidTime.first.destroy
+    assert_equal 1, ParanoidTime.deleted_inside_time_window(1.minute.ago, 2.minutes).count
+    assert_equal 1,
+                 ParanoidTime.deleted_inside_time_window(1.minute.from_now, 2.minutes).count
+    assert_equal 0, ParanoidTime.deleted_inside_time_window(3.minutes.ago, 1.minute).count
+    assert_equal 0,
+                 ParanoidTime.deleted_inside_time_window(3.minutes.from_now, 1.minute).count
+  end
 end

data/test/test_default_scopes.rb

@@ -2,9 +2,16 @@
 
 require "test_helper"
 
-class MultipleDefaultScopesTest < ParanoidBaseTest
+class MultipleDefaultScopesTest < ActiveSupport::TestCase
   def setup
-    setup_db
+    ActiveRecord::Schema.define(version: 1) do
+      create_table :paranoid_polygons do |t|
+        t.integer :sides
+        t.datetime :deleted_at
+
+        timestamps t
+      end
+    end
 
     ParanoidPolygon.create! sides: 3
     ParanoidPolygon.create! sides: 3
@@ -15,6 +22,10 @@ class MultipleDefaultScopesTest < ParanoidBaseTest
     assert_equal 4, ParanoidPolygon.unscoped.count
   end
 
+  def teardown
+    teardown_db
+  end
+
   def test_fake_removal_with_multiple_default_scope
     ParanoidPolygon.first.destroy
     assert_equal 2, ParanoidPolygon.count

data/test/test_dependent_recovery.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class DependentRecoveryTest < ActiveSupport::TestCase
+  class ParanoidForest < ActiveRecord::Base
+    acts_as_paranoid
+    has_many :paranoid_trees, dependent: :destroy
+  end
+
+  class ParanoidTree < ActiveRecord::Base
+    acts_as_paranoid
+    belongs_to :paranoid_forest, optional: false
+  end
+
+  def setup
+    ActiveRecord::Schema.define(version: 1) do
+      create_table :paranoid_forests do |t|
+        t.string   :name
+        t.boolean  :rainforest
+        t.datetime :deleted_at
+
+        timestamps t
+      end
+
+      create_table :paranoid_trees do |t|
+        t.integer  :paranoid_forest_id
+        t.string   :name
+        t.datetime :deleted_at
+
+        timestamps t
+      end
+    end
+  end
+
+  def teardown
+    teardown_db
+  end
+
+  def test_recover_dependent_records_with_required_belongs_to
+    forest = ParanoidForest.create! name: "forest"
+
+    tree = ParanoidTree.new name: "tree"
+    refute tree.valid?
+    tree.paranoid_forest = forest
+    assert tree.valid?
+    tree.save!
+
+    forest.destroy
+    forest.recover
+
+    assert_equal 1, ParanoidTree.count
+  end
+end

data/test/test_deprecated_behavior.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class DeprecatedBehaviorTest < ActiveSupport::TestCase
+  class StringlyParanoid < ActiveRecord::Base
+    acts_as_paranoid column_type: "string", column: "foo", recovery_value: "alive"
+  end
+
+  def setup
+    ActiveRecord::Schema.define(version: 1) do
+      create_table :stringly_paranoids do |t|
+        t.string :foo
+
+        timestamps t
+      end
+    end
+  end
+
+  def teardown
+    teardown_db
+  end
+
+  def test_recovery_value
+    record = StringlyParanoid.create!
+    record.destroy
+    record.recover
+    assert_equal "alive", record.paranoid_value
+  end
+end

data/test/test_helper.rb

@@ -32,8 +32,12 @@ I18n.enforce_available_locales = true
 ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")
 ActiveRecord::Schema.verbose = false
 
+log_dir = File.expand_path("../log/", __dir__)
+FileUtils.mkdir_p log_dir
+file_path = File.join(log_dir, "test.log")
+ActiveRecord::Base.logger = Logger.new(file_path)
+
 # rubocop:disable Metrics/AbcSize
-# rubocop:disable Metrics/MethodLength
 def setup_db
   ActiveRecord::Schema.define(version: 1) do # rubocop:disable Metrics/BlockLength
     create_table :paranoid_times do |t|
@@ -169,22 +173,6 @@ def setup_db
       timestamps t
     end
 
-    create_table :paranoid_forests do |t|
-      t.string   :name
-      t.boolean  :rainforest
-      t.datetime :deleted_at
-
-      timestamps t
-    end
-
-    create_table :paranoid_trees do |t|
-      t.integer  :paranoid_forest_id
-      t.string   :name
-      t.datetime :deleted_at
-
-      timestamps t
-    end
-
     create_table :paranoid_polygons do |t|
       t.integer :sides
       t.datetime :deleted_at
@@ -241,11 +229,18 @@ def setup_db
 
       timestamps t
     end
+
+    create_table :paranoid_with_serialized_columns do |t|
+      t.string :name
+      t.datetime :deleted_at
+      t.string :colors
+
+      timestamps t
+    end
   end
 end
-# rubocop:enable Metrics/AbcSize
-# rubocop:enable Metrics/MethodLength
 
+# rubocop:enable Metrics/AbcSize
 def timestamps(table)
   table.column  :created_at, :timestamp, null: false
   table.column  :updated_at, :timestamp, null: false
@@ -290,6 +285,7 @@ class ParanoidString < ActiveRecord::Base
 end
 
 class NotParanoid < ActiveRecord::Base
+  has_many :paranoid_times
 end
 
 class ParanoidNoDoubleTapDestroysFully < ActiveRecord::Base
@@ -524,22 +520,6 @@ class ParanoidBaseTest < ActiveSupport::TestCase
   end
 end
 
-class ParanoidForest < ActiveRecord::Base
-  acts_as_paranoid
-
-  ActiveRecord::Base.logger = Logger.new(StringIO.new)
-
-  scope :rainforest, -> { where(rainforest: true) }
-
-  has_many :paranoid_trees, dependent: :destroy
-end
-
-class ParanoidTree < ActiveRecord::Base
-  acts_as_paranoid
-  belongs_to :paranoid_forest
-  validates_presence_of :name
-end
-
 class ParanoidPolygon < ActiveRecord::Base
   acts_as_paranoid
   default_scope { where("sides = ?", 3) }
@@ -563,3 +543,12 @@ class ParanoidWithExplicitTableNameAfterMacro < ActiveRecord::Base
   acts_as_paranoid
   self.table_name = "explicit_table"
 end
+
+class ParanoidWithSerializedColumn < ActiveRecord::Base
+  acts_as_paranoid
+  validates_as_paranoid
+
+  serialize :colors, Array
+
+  validates_uniqueness_of_without_deleted :colors
+end

data/test/test_relations.rb

@@ -2,9 +2,63 @@
 
 require "test_helper"
 
-class RelationsTest < ParanoidBaseTest
+class RelationsTest < ActiveSupport::TestCase
+  class ParanoidForest < ActiveRecord::Base
+    acts_as_paranoid
+
+    scope :rainforest, -> { where(rainforest: true) }
+
+    has_many :paranoid_trees, dependent: :destroy
+  end
+
+  class ParanoidTree < ActiveRecord::Base
+    acts_as_paranoid
+    belongs_to :paranoid_forest
+    validates_presence_of :name
+  end
+
+  class NotParanoidBowl < ActiveRecord::Base
+    has_many :paranoid_chocolates, dependent: :destroy
+  end
+
+  class ParanoidChocolate < ActiveRecord::Base
+    acts_as_paranoid
+    belongs_to :not_paranoid_bowl
+    validates_presence_of :name
+  end
+
   def setup
-    setup_db
+    ActiveRecord::Schema.define(version: 1) do
+      create_table :paranoid_forests do |t|
+        t.string   :name
+        t.boolean  :rainforest
+        t.datetime :deleted_at
+
+        timestamps t
+      end
+
+      create_table :paranoid_trees do |t|
+        t.integer  :paranoid_forest_id
+        t.string   :name
+        t.datetime :deleted_at
+
+        timestamps t
+      end
+
+      create_table :not_paranoid_bowls do |t|
+        t.string   :name
+
+        timestamps t
+      end
+
+      create_table :paranoid_chocolates do |t|
+        t.integer  :not_paranoid_bowl_id
+        t.string   :name
+        t.datetime :deleted_at
+
+        timestamps t
+      end
+    end
 
     @paranoid_forest_1 = ParanoidForest.create! name: "ParanoidForest #1"
     @paranoid_forest_2 = ParanoidForest.create! name: "ParanoidForest #2", rainforest: true
@@ -21,6 +75,10 @@ class RelationsTest < ParanoidBaseTest
     assert_equal 4, ParanoidTree.count
   end
 
+  def teardown
+    teardown_db
+  end
+
   def test_filtering_with_scopes
     assert_equal 2, ParanoidForest.rainforest.with_deleted.count
     assert_equal 2, ParanoidForest.with_deleted.rainforest.count
@@ -83,13 +141,29 @@ class RelationsTest < ParanoidBaseTest
     assert_equal 1, ParanoidForest.rainforest.only_deleted.count
 
     # destroy_all: through a relation
-    @paranoid_forest_2.paranoid_trees.order(:id).destroy_all
+    @paranoid_forest_2.paranoid_trees.destroy_all
     assert_equal 0, @paranoid_forest_2.paranoid_trees.count
     assert_equal 2, @paranoid_forest_2.paranoid_trees.with_deleted.count
   end
 
-  def test_real_removal_through_relation_with_destroy_bang
-    # Relation.destroy!: aliased to delete
+  def test_fake_removal_through_has_many_relation_of_non_paranoid_model
+    not_paranoid = NotParanoidBowl.create! name: "NotParanoid #1"
+    not_paranoid.paranoid_chocolates.create! name: "ParanoidChocolate #1"
+    not_paranoid.paranoid_chocolates.create! name: "ParanoidChocolate #2"
+
+    not_paranoid.paranoid_chocolates.destroy_all
+    assert_equal 0, not_paranoid.paranoid_chocolates.count
+    assert_equal 2, not_paranoid.paranoid_chocolates.with_deleted.count
+  end
+
+  def test_real_removal_through_relation_with_destroy_fully
+    ParanoidForest.rainforest.destroy_fully!(@paranoid_forest_3)
+    assert_equal 1, ParanoidForest.rainforest.count
+    assert_equal 1, ParanoidForest.rainforest.with_deleted.count
+    assert_equal 0, ParanoidForest.rainforest.only_deleted.count
+  end
+
+  def test_real_removal_through_relation_with_deprecated_destroy!
     ParanoidForest.rainforest.destroy!(@paranoid_forest_3)
     assert_equal 1, ParanoidForest.rainforest.count
     assert_equal 1, ParanoidForest.rainforest.with_deleted.count
@@ -99,7 +173,7 @@ class RelationsTest < ParanoidBaseTest
   def test_two_step_real_removal_through_relation_with_destroy
     # destroy: two-step through a relation
     paranoid_tree = @paranoid_forest_1.paranoid_trees.first
-    @paranoid_forest_1.paranoid_trees.order(:id).destroy(paranoid_tree.id)
+    @paranoid_forest_1.paranoid_trees.destroy(paranoid_tree.id)
     @paranoid_forest_1.paranoid_trees.only_deleted.destroy(paranoid_tree.id)
     assert_equal 1, @paranoid_forest_1.paranoid_trees.count
     assert_equal 1, @paranoid_forest_1.paranoid_trees.with_deleted.count
@@ -108,7 +182,7 @@ class RelationsTest < ParanoidBaseTest
 
   def test_two_step_real_removal_through_relation_with_destroy_all
     # destroy_all: two-step through a relation
-    @paranoid_forest_1.paranoid_trees.order(:id).destroy_all
+    @paranoid_forest_1.paranoid_trees.destroy_all
     @paranoid_forest_1.paranoid_trees.only_deleted.destroy_all
     assert_equal 0, @paranoid_forest_1.paranoid_trees.count
     assert_equal 0, @paranoid_forest_1.paranoid_trees.with_deleted.count
@@ -117,7 +191,7 @@ class RelationsTest < ParanoidBaseTest
 
   def test_real_removal_through_relation_with_delete_all_bang
     # delete_all!: through a relation
-    @paranoid_forest_2.paranoid_trees.order(:id).delete_all!
+    @paranoid_forest_2.paranoid_trees.delete_all!
     assert_equal 0, @paranoid_forest_2.paranoid_trees.count
     assert_equal 0, @paranoid_forest_2.paranoid_trees.with_deleted.count
     assert_equal 0, @paranoid_forest_2.paranoid_trees.only_deleted.count

data/test/test_table_namespace.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class TableNamespaceTest < ActiveSupport::TestCase
+  module Paranoid
+    class Blob < ActiveRecord::Base
+      acts_as_paranoid
+
+      validates_presence_of :name
+
+      def self.table_name_prefix
+        "paranoid_"
+      end
+    end
+  end
+
+  def setup
+    ActiveRecord::Schema.define(version: 1) do
+      create_table :paranoid_blobs do |t|
+        t.string   :name
+        t.datetime :deleted_at
+
+        timestamps t
+      end
+    end
+  end
+
+  def teardown
+    teardown_db
+  end
+
+  def test_correct_table_name
+    assert_equal "paranoid_blobs", Paranoid::Blob.table_name
+
+    b = Paranoid::Blob.new(name: "hello!")
+    b.save!
+    assert_equal b, Paranoid::Blob.first
+  end
+end

data/test/test_validations.rb

@@ -23,6 +23,24 @@ class ValidatesUniquenessTest < ParanoidBaseTest
     end
   end
 
+  def test_validate_serialized_attribute_without_deleted
+    ParanoidWithSerializedColumn.create!(name: "ParanoidWithSerializedColumn #1",
+                                         colors: %w[Cyan Maroon])
+    record = ParanoidWithSerializedColumn.new(name: "ParanoidWithSerializedColumn #2")
+    record.colors = %w[Cyan Maroon]
+    refute record.valid?
+
+    record.colors = %w[Beige Turquoise]
+    assert record.valid?
+  end
+
+  def test_updated_serialized_attribute_validated_without_deleted
+    record = ParanoidWithSerializedColumn.create!(name: "ParanoidWithSerializedColumn #1",
+                                                  colors: %w[Cyan Maroon])
+    record.update!(colors: %w[Beige Turquoise])
+    assert record.valid?
+  end
+
   def test_models_with_scoped_validations_can_be_multiply_deleted
     model_a = ParanoidWithScopedValidation.create(name: "Model A", category: "Category A")
     model_b = ParanoidWithScopedValidation.create(name: "Model B", category: "Category B")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_paranoid
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Zachary Scott
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-16 00:00:00.000000000 Z
+date: 2021-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -196,9 +196,12 @@ files:
 - test/test_associations.rb
 - test/test_core.rb
 - test/test_default_scopes.rb
+- test/test_dependent_recovery.rb
+- test/test_deprecated_behavior.rb
 - test/test_helper.rb
 - test/test_inheritance.rb
 - test/test_relations.rb
+- test/test_table_namespace.rb
 - test/test_validations.rb
 homepage: https://github.com/ActsAsParanoid/acts_as_paranoid
 licenses:
@@ -228,7 +231,10 @@ test_files:
 - test/test_associations.rb
 - test/test_core.rb
 - test/test_default_scopes.rb
+- test/test_dependent_recovery.rb
+- test/test_deprecated_behavior.rb
 - test/test_helper.rb
 - test/test_inheritance.rb
 - test/test_relations.rb
+- test/test_table_namespace.rb
 - test/test_validations.rb