acts_as_paranoid 0.10.0 → 0.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 992c8836d7fa518c06baf1be695fcad08a9f9332cbd25596041cdbcf7c61d525
-  data.tar.gz: 2deedb7d195a333cd869b60ada4fe9f91c3d68005a04470e5fb97115c3acb748
+  metadata.gz: 45d8ec4adf62543fc1eaba6560fde9b075ecf0fef95b8e2d2811ee08a9093d24
+  data.tar.gz: 51da12bf09c6d0aab09d835d44aa7a74e617ad5f31b0a624af32148ffb63b17c
 SHA512:
-  metadata.gz: 120588d3f6db69ca22c70d554bb82fcad1fe6471e411df9711ba111ea8b63aba93fa312b60216fd033457e6ff6f9b2d8bbc2cd5d8ca276e0c0b1d3a4b6d5a159
-  data.tar.gz: 73eee9f04521fb530034d81dcdbe41a3bf8c84f83f0dfa37db26f38d8a66d89c681d0ba0cbf6aae2f3cb3fb5c0588678ea6de506137983ab9c07a5d5e2d637b7
+  metadata.gz: d419f338d8ab828856188404eb2c1f84f31508af15cae65fee647c050ed1efbe41f69951ebf0f3e9de69a5416b0ff7157fb3ad999642eae0dc4dc804fce59634
+  data.tar.gz: 236842d046c63ac8b0efedf5937911ddca18a7232006d7459fb19027902ef38534b70a32c674916972c9b7aec08b1c6f109e6c07979b1de1afdf88a7c6a45094

data/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 Notable changes to this project will be documented in this file.
 
+## 0.10.1
+
+* Add changelog_uri to gemspec ([#332] by [fynsta])
+* Improve contribution instructions ([#338] by [mvz])
+* Make with_deleted work with paranoid join records ([#339] by [mvz])
+
+[fynsta]: https://github.com/fynsta
+
+[#332]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/332
+[#338]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/338
+[#339]: https://github.com/ActsAsParanoid/acts_as_paranoid/pull/339
+
 ## 0.10.0
 
 * Support Ruby 3.0 through 3.3, dropping support for 2.7 ([#322] by [mvz])

data/CONTRIBUTING.md

@@ -1,7 +1,7 @@
 # Contributing to ActsAsParanoid
 
-We welcome all contributions to ActsAsParanoid. Below are some guidelines to
-help the process of handling issues and pull requests go smoothly.
+We welcome contributions to ActsAsParanoid. Please follow the guidelines below to help the
+process of handling issues and pull requests go smoothly.
 
 ## Issues
 
@@ -14,30 +14,35 @@ ticket.
 - Describe what you are trying to achieve
 - Describe what you did, preferably including relevant code
 - Describe what you expected to happen
-- Describe what happened instead, possibly including relevant output
+- Describe what happened instead. Include relevant output if possible
+- State the version of ActsAsParanoid you are using
 - Use [code blocks](https://github.github.com/gfm/#fenced-code-blocks) to
   format any code and output in your ticket to make it readable.
 
-## Pull requests
+## Pull Requests
 
 If you have an idea for a particular feature, it's probably best to create a
 GitHub issue for it before trying to implement it yourself. That way, we can
 discuss the feature and whether it makes sense to include in ActsAsParanoid itself
 before putting in the work to implement it.
 
-To send pull requests or patches, please follow the instructions below.
-**If you get stuck, please make a pull request anyway and we'll try to
-help out.**
+When sending a pull request, please follow **all of** the instructions below:
 
-- Make sure `bundle exec rake` runs without reporting any failures.
-- Add tests for your feature. Otherwise, we can't see if it works or if we
-  break it later.
+- Make sure `bundle exec rake` runs without reporting any failures. See
+  *Testing your changes* below for more details.
+- Add tests for your feature. Otherwise, we can't see if it works or if
+  we break it later.
 - Create a separate branch for your feature based off of latest master.
+- Write [good commit messages](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
 - Do not include changes that are irrelevant to your feature in the same
   commit.
 - Keep an eye on the build results in GitHub Actions. If the build fails and it
   seems due to your changes, please update your pull request with a fix.
 
+If you're not sure how to test the problem, or what the best solution is, or
+get stuck on something else, please open an issue first so that we can discuss
+the best approach.
+
 ### Testing your changes
 
 You can run the test suite with the latest version of all dependencies by running the following:
@@ -62,9 +67,10 @@ documentation for details.
   that just fix a mistake in a previous commits, we will ask you to clean up
   the history.
   Again, [the git-rebase guide](https://git-rebase.io/) should help out.
-- At the end of the review process we may still choose not to merge your pull
-  request. For example, this could happen if we decide the proposed feature
+  Note that we will not squash-merge pull requests, since that results in a loss of history.
+- **At the end of the review process we may still choose not to merge your pull
+  request.** For example, this could happen if we decide the proposed feature
   should not be part of ActsAsParanoid, or if the technical implementation does not
-  match where we want to go with the architecture the project.
+  match where we want to go with the architecture of the project.
 - We will generally not merge any pull requests that make the build fail, unless
   it's very clearly not related to the changes in the pull request.

data/lib/acts_as_paranoid/associations.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 module ActsAsParanoid
+  # This module is included in ActiveRecord::Base to provide paranoid associations.
   module Associations
     def self.included(base)
       base.extend ClassMethods

data/lib/acts_as_paranoid/core.rb

@@ -118,13 +118,10 @@ module ActsAsParanoid
       def without_paranoid_default_scope
         scope = all
 
-        # unscope avoids applying the default scope when using this scope for associations
-        scope = scope.unscope(where: paranoid_column)
-
-        paranoid_where_clause =
-          ActiveRecord::Relation::WhereClause.new([paranoid_default_scope])
-
-        scope.where_clause = all.where_clause - paranoid_where_clause
+        unless scope.unscope_values.include?({ where: paranoid_column })
+          # unscope avoids applying the default scope when using this scope for associations
+          scope = scope.unscope(where: paranoid_column)
+        end
 
         scope
       end

data/lib/acts_as_paranoid/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActsAsParanoid
-  VERSION = "0.10.0"
+  VERSION = "0.10.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_paranoid
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.10.1
 platform: ruby
 authors:
 - Zachary Scott
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-05-17 00:00:00.000000000 Z
+date: 2024-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.14'
+- !ruby/object:Gem::Dependency
+  name: minitest-around
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: minitest-focus
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +108,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: minitest-stub-const
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -256,6 +284,7 @@ homepage: https://github.com/ActsAsParanoid/acts_as_paranoid
 licenses:
 - MIT
 metadata:
+  changelog_uri: https://github.com/ActsAsParanoid/acts_as_paranoid/blob/master/CHANGELOG.md
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
@@ -272,7 +301,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.10
+rubygems_version: 3.5.16
 signing_key:
 specification_version: 4
 summary: Active Record plugin which allows you to hide and restore records without