acts_as_orderable 0.1.2 → 0.1.3

data/CHANGELOG.rdoc

@@ -3,4 +3,6 @@
 = Version 0.1.1
 * table_exists? fix
 = Version 0.1.2
-* Fix for assigning same parent - should not change order
+* Fix for assigning same parent - should not change order
+= Version 0.1.3
+* Fix for casting string to int on parent comparing

data/Rakefile

@@ -3,7 +3,7 @@ require 'rubygems'
 require 'rake'
 require 'echoe'
 
-Echoe.new('acts_as_orderable', '0.1.2') do |p|
+Echoe.new('acts_as_orderable', '0.1.3') do |p|
   p.description    = "Rails gem allowing ActiveRecord models to have order and to move them up and down"
   p.url            = "https://github.com/mensfeld/Acts-as-Orderable"
   p.author         = "Maciej Mensfeld"

data/acts_as_orderable.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{acts_as_orderable}
-  s.version = "0.1.2"
+  s.version = "0.1.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Maciej Mensfeld}]
-  s.date = %q{2011-12-08}
+  s.date = %q{2011-12-11}
   s.description = %q{Rails gem allowing ActiveRecord models to have order and to move them up and down}
   s.email = %q{maciej@mensfeld.pl}
   s.extra_rdoc_files = [%q{CHANGELOG.rdoc}, %q{README.md}, %q{lib/acts_as_orderable.rb}]

data/lib/acts_as_orderable.rb

@@ -39,7 +39,7 @@ module Acts
           old_parent = self.send(:"#{parent_column}")
           super new_parent
           # If object exist (been saved and we're just changing its parent)
-          init_me! unless self.new_record? || old_parent == new_parent
+          init_me! unless self.new_record? || old_parent.to_i == new_parent.to_i
         end if parent_column
       end
     end

data/spec/acts_as_orderable_spec.rb

@@ -327,6 +327,27 @@ describe WayCoolerElement do
       aa.element_order.should == olda
       ab.element_order.should == oldb
     end
+  
+    context "and we send it as a string not as an integer" do
+      it "should not interfere with children order" do
+        a = subject.create
+        aa = a.children.create
+        ab = a.children.create
+        a.reload; aa.reload; ab.reload
+
+        olda = aa.element_order
+        oldb = ab.element_order
+
+        aa.update_attributes({:parent_id => "#{aa.parent_id}"})
+        aa.reload
+        ab.reload
+        aa.element_order.should == olda
+        ab.element_order.should == oldb
+      end
+    end
+
   end
 
+  
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_orderable
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-12-08 00:00:00.000000000Z
+date: 2011-12-11 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &10839320 !ruby/object:Gem::Requirement
+  requirement: &13061300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 2.0.0
   type: :development
   prerelease: false
-  version_requirements: *10839320
+  version_requirements: *13061300
 - !ruby/object:Gem::Dependency
   name: active_record
-  requirement: &10838660 !ruby/object:Gem::Requirement
+  requirement: &13060580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +32,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *10838660
+  version_requirements: *13060580
 description: Rails gem allowing ActiveRecord models to have order and to move them
   up and down
 email: maciej@mensfeld.pl