acts_as_orderable 0.1.1 → 0.1.2

data/CHANGELOG.rdoc

@@ -1,4 +1,6 @@
 = Version 0.1.0
 * Gem existence started
 = Version 0.1.1
-* table_exists? fix
+* table_exists? fix
+= Version 0.1.2
+* Fix for assigning same parent - should not change order

data/Rakefile

@@ -3,7 +3,7 @@ require 'rubygems'
 require 'rake'
 require 'echoe'
 
-Echoe.new('acts_as_orderable', '0.1.1') do |p|
+Echoe.new('acts_as_orderable', '0.1.2') do |p|
   p.description    = "Rails gem allowing ActiveRecord models to have order and to move them up and down"
   p.url            = "https://github.com/mensfeld/Acts-as-Orderable"
   p.author         = "Maciej Mensfeld"

data/acts_as_orderable.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{acts_as_orderable}
-  s.version = "0.1.1"
+  s.version = "0.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{Maciej Mensfeld}]
-  s.date = %q{2011-11-06}
+  s.date = %q{2011-12-08}
   s.description = %q{Rails gem allowing ActiveRecord models to have order and to move them up and down}
   s.email = %q{maciej@mensfeld.pl}
   s.extra_rdoc_files = [%q{CHANGELOG.rdoc}, %q{README.md}, %q{lib/acts_as_orderable.rb}]

data/lib/acts_as_orderable.rb

@@ -35,10 +35,11 @@ module Acts
 
         # Define methods for assigning new parent - when we change parent
         # we need to be first or last element (according to new_el_pos)
-        self.send(:define_method, "#{parent_column}=".to_sym) do |new_parent|
+        self.send(:define_method, :"#{parent_column}=") do |new_parent|
+          old_parent = self.send(:"#{parent_column}")
           super new_parent
           # If object exist (been saved and we're just changing its parent)
-          init_me! unless self.new_record?
+          init_me! unless self.new_record? || old_parent == new_parent
         end if parent_column
       end
     end
@@ -108,7 +109,7 @@ module Acts
         self.save
       end
 
-      # Builds query part used to fetch only elements from uor node (or do nothing)
+      # Builds query part used to fetch only elements from your node (or do nothing)
       def search_node_query(init_end = true)
         p_c = self.class.parent_column
         # If parent exists - fetch our parent_id and put it into query

data/spec/acts_as_orderable_spec.rb

@@ -121,7 +121,6 @@ describe CoolElement do
       a.element_order.should be < d.element_order
     end
   end
-
 end
 
 describe CoolerElement do
@@ -312,4 +311,22 @@ describe WayCoolerElement do
     end
   end
 
+  context "when sending save root element" do
+    it "should not interfere with children order" do
+      a = subject.create
+      aa = a.children.create
+      ab = a.children.create
+      a.reload; aa.reload; ab.reload
+
+      olda = aa.element_order
+      oldb = ab.element_order
+
+      aa.update_attributes({:parent_id => aa.parent_id})
+      aa.reload
+      ab.reload
+      aa.element_order.should == olda
+      ab.element_order.should == oldb
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_orderable
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-06 00:00:00.000000000Z
+date: 2011-12-08 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &26845980 !ruby/object:Gem::Requirement
+  requirement: &10839320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 2.0.0
   type: :development
   prerelease: false
-  version_requirements: *26845980
+  version_requirements: *10839320
 - !ruby/object:Gem::Dependency
   name: active_record
-  requirement: &26845540 !ruby/object:Gem::Requirement
+  requirement: &10838660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +32,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *26845540
+  version_requirements: *10838660
 description: Rails gem allowing ActiveRecord models to have order and to move them
   up and down
 email: maciej@mensfeld.pl